1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Commit graph

457 commits

Author SHA1 Message Date
Charles Duffy
d59973295d #6341: check systemd service status with show subcommand 2014-03-10 00:09:29 -05:00
Jarno Keskikangas
37ef39d0fa Recognize rule changes even if ufw is in disabled state.
See http://askubuntu.com/questions/30781/see-configured-rules-even-when-inactive
for the details.
2014-03-09 12:56:52 +02:00
Jarno Keskikangas
4d5340587e Insert rule to a specific num. 2014-03-09 12:56:51 +02:00
Jarno Keskikangas
0247708199 Fix typo: 'reseted' -> 'reset'. 2014-03-09 12:56:51 +02:00
Jarno Keskikangas
2613e6fb14 Add protocol options 'esp' and 'ah'. 2014-03-09 12:56:51 +02:00
Jarno Keskikangas
f4e8a86c87 Add functionality and reduce complexity.
* Separate 'state', 'policy' and 'rule' commands
* Support for 'logging' command
* Support for 'direction' and 'interface' attributes
* Reliable change notifications based on 'ufw status verbose' diff
* Update documentation
* Cleanup
2014-03-09 12:56:51 +02:00
Aleksey Ovcharenko
651c04a3ec New module [ufw]: this module handles Ubuntu UFW operations
* Updated documentation related to IPv6 usage.

BugFixes:
* Solved the default_policy and state mutual exclusive status.
* Fixed changed status for IPv6 addresses.

Added @otnateos patch.
2014-03-09 12:56:51 +02:00
Richard C Isaacson
aba86e3657 Cleaning up pep8 alerts. 2014-03-07 23:06:19 -06:00
Richard C Isaacson
f3c1177265 Documentation cleanup. 2014-03-07 23:04:56 -06:00
Richard C Isaacson
7686204b43 Refactored a few things to be more inline with the Ansible way. Passing testing. 2014-03-07 23:04:07 -06:00
Charles Duffy
44ebd3f4f3 systemd template services must not discard template part 2014-03-07 18:53:15 -06:00
jctanner
6a615f18c5 Merge pull request #5872 from tomdymond/add-ignoreerror-to-sysctl
Add option to enable the sysctl -e option
2014-03-05 12:58:05 -05:00
Julien DAUPHANT
16bb6c88f5 Add version_added 1.6 for the params modprobe option 2014-03-05 16:45:20 +01:00
Julien DAUPHANT
daa7416323 Add linux module parameters for the modprobe module 2014-03-05 16:42:52 +01:00
anatoly techtonik
a48f0da9d8 setup: Fix KeyError: 'ipv4_secondaries' (issue #6274) 2014-03-04 20:00:18 +02:00
James Tanner
39e368b713 Fix debconf docstring indentation 2014-03-03 13:48:44 -05:00
James Tanner
ff1ae57fbf Merge branch 'debconf' of git://github.com/bcoca/ansible into bcoca-debconf 2014-03-03 13:46:11 -05:00
Brian Coca
400a1aa49a didnt make 1.5 ... lets see 2014-03-01 22:28:51 -05:00
Brian Coca
68510ecda8 added better gentoo/funtoo support 2014-03-01 21:56:02 -05:00
Michael DeHaan
9d3a344c06 Merge pull request #6223 from lvh/patch-2
Support ssh-ed25519 keys
2014-02-28 12:59:05 -05:00
Laurens Van Houtven
80e2c597a8 Support ssh-ed25519 keys
The newest version of OpenSSH supports a new, wonderful key type. authorized_key incorrectly discards pubkeys of this type as busted because it doesn't recognize type signature.
2014-02-28 18:46:54 +01:00
James Cammarata
57486b268a Use the no-user-groups option (-N) for useradd in the user module
If no group was specified, but a group by the same name as the user
exists, an error was raised in the situation where USERGROUPS_ENAB is
enabled in /etc/login.defs (which is the case for almost every major
linux distro). In this case, the user will be put in group 100 (which
is usually the "users" group on those same distros). This is currently
only done in the base class, as the issue may not exist on other
platforms like AIX or the BSDs.

Fixes #6210
2014-02-28 11:46:27 -06:00
Dustin C. Hatch
467914e3c3 filesystem: Ignore blkid cache
Sometimes, `blkid` will incorrectly return no information about a block
device, even if it exists and has a valid filesystem. This causes the
*filesystem* module to fail if *force=no*. Instructing `blkid` to use
`/dev/null` as a cache file will force it to rescan the block device on
each run, making results more consistent.

Signed-off-by: Dustin C. Hatch <admiralnemo@gmail.com>
2014-02-25 20:16:01 -06:00
Chris Church
1d6bdd451b Fix setup module to gather facts from PowerPC Macs. 2014-02-25 18:27:36 -05:00
James Cammarata
6fe369fca0 Merge branch 'usermod_fix' of https://github.com/tknguyen79/ansible into tknguyen79-usermod_fix
Conflicts:
	library/system/user
2014-02-24 23:38:51 -06:00
Stefan J. Betz
789ae4697c Require force for LVM shrink and remove operations in lvol. Fixes #5774
Conflicts:
	library/system/lvol
2014-02-24 18:52:35 -06:00
Richard C Isaacson
bf30707670 If you try to resize a lvol to the current size return a changed=False and don't fail.
This addresses GH-5165 and adds the ability to check if a lvol exists.

The tests for this don't fit nicely into the current integration tests so they are below.

```
---

- name: remove any existing lv=one of vg=main
  lvol: lv=one vg=main state=absent

- name: remove any existing lv=two of vg=main
  lvol: lv=two vg=main state=absent

- name: check to see if lv=one of vg=main exists
  lvol: lv=one vg=main state=present
  ignore_errors: true
  register: lvol_result0

- name: Assert that we will get a "No size given."
  assert:
    that:
      - "'No size given.' in lvol_result0.msg"

- name: create lv=one of vg=main sized 30g
  lvol: lv=one size=30g vg=main state=present
  register: lvol_result1

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result1.changed == True"

- name: check to see if lv=one of vg=main exists
  lvol: lv=one vg=main state=present
  register: lvol_result2

- name: Assert that we did not make changes."
  assert:
    that:
      - "lvol_result2.changed == False"

- name: remove lv=one of vg=main
  lvol: lv=one vg=main state=absent

- name: create lv=two of vg=main sized 30G
  lvol: lv=two size=30G vg=main state=present
  register: lvol_result3

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result3.changed == True"

- name: reduce lv=two of vg=main to 15G
  lvol: lv=two size=15G vg=main state=present
  register: lvol_result4

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result4.changed == True"

- name: increase lv=two of vg=main to 30G
  lvol: lv=two size=30G vg=main state=present
  register: lvol_result5

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result5.changed == True"

- name: create lv=two of vg=main sized 30G when already exists at 30G
  lvol: lv=two size=30g vg=main state=present
  register: lvol_result6

- name: Assert that we did not make changes."
  assert:
    that:
      - "lvol_result6.changed == False"

- name: remove lv=two of vg=main
  lvol: lv=two vg=main state=absent
```
2014-02-24 16:56:08 -06:00
Matt Jeffery
8131feaade Normalise the module name when comparing against the module names in /proc/modules. 2014-02-20 16:54:33 +00:00
C. Morgan Hamill
5776c95497 Add 'vgoptions' parameter to lvg module.
Allows specifying extra flags to pass to `vgcreate`.
2014-02-18 15:20:12 -05:00
Nils Pascal Illenseer
858004984b Fix zfs create command for properties with spaces
If a property value contains one or more spaces, the zfs command will fail.
With value quoted this behavior is fixed.
2014-02-18 11:30:17 +01:00
Richard C Isaacson
7d670f8308 Merge remote-tracking branch 'berendt/fixing_permissions' into pull_4703 2014-02-17 11:46:23 -06:00
Peter Gehres
c427a829a0 Adding better failure output for chkconfig failures rather than
just saying that the service name is unknown
2014-02-13 23:05:00 -08:00
Sean Chittenden
5e0cf6663a Fix broken behavior when removing all auxiliary groups from a user
(e.g. 'groups=' in the user module).
2014-02-10 13:08:53 -08:00
Brian Coca
f475de2316 hopefully last batch of fixes
- removed previous 'typification' of input as it needs it is typed by
  module as strings and needs to be output as strings, making it
  useless.
- now checks for vtype and value against None when question is specified
- simplified set_selections as vtype and value should have a string
  value going in.
- added example of querying questions for a package
- added module requirement of question,vtype and value being required
  together.
2014-02-09 20:47:01 -05:00
Brian Coca
a1de284dba made changes as per feedback:
- field names are more consistent with debconf
- values are now 'booleanized' or accepted as list/set objects when
  pertinent
- updated docs to reflect all of the above and debconf cli tools
  required
2014-02-09 17:46:18 -05:00
Brian Coca
0233584343 fixed main() issue created in prev fix, now values are empty string if they were None
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
2014-02-06 11:59:37 -05:00
Brian Coca
de956c57fe changes names to name in example 2014-02-05 18:28:17 -05:00
Brian Coca
453d473728 fixes as per feedback 2014-02-05 18:08:01 -05:00
Tom Dymond
486d14cb2d Reworked PR to avoid repeating the command 2014-02-05 15:35:24 +00:00
jctanner
5967b463c9 Merge pull request #5554 from ttarabul/devel
Use /etc/rc.conf.local for sevice configuration on FreeBSD
2014-02-04 10:59:19 -08:00
Tom Dymond
cf80f9b68b Add option to enable the sysctl -e option 2014-02-04 18:19:28 +00:00
kustodian
a7839208c7 Updated authorized_key module documentation regarding manage_dir
Added a warning in the documentation about manage_dir when selecting an alternate directory for authorized_keys
2014-01-29 23:39:43 +01:00
Aaron Lindsay
59ac969d2b Add move_home option to user module 2014-01-29 14:10:26 -05:00
Richard C Isaacson
7a2df2733f Tested implementation adding action option for (add, delete, unique). 2014-01-28 20:29:41 -05:00
Richard C Isaacson
c198217900 Rough cut implementation based on @resmo's comments. 2014-01-28 20:29:41 -05:00
Richard C Isaacson
cd871384de Rough cut implementation based on @resmo's comments. 2014-01-28 20:29:41 -05:00
Richard C Isaacson
b00939acff Change to dynamically pick up the command from the PATH. 2014-01-28 20:29:41 -05:00
Richard C Isaacson
9650c118cf Formating and syntax fixes that were pointed out during code review. 2014-01-28 20:29:41 -05:00
Richard C Isaacson
ec04e30186 Added user option. 2014-01-28 20:29:41 -05:00
Richard C Isaacson
3a7e579bc2 First commit of the at module being very basic. 2014-01-28 20:29:41 -05:00
Brian Coca
46dfe07181 be permissive with BSD with service enabled upper/lower/mixed cases
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
2014-01-28 14:49:57 -05:00
Jakub Jirutka
8c9a63bcd0 sysctl: parse bool value as 0/1 and refactor a little bit 2014-01-27 20:26:11 +01:00
Thoai Nguyen
5c4bb5730e reorder usermod options 2014-01-22 15:27:00 -05:00
jctanner
7b76ad9e62 Merge pull request #5676 from simonz05/bugfix-sysctl-multivalue2
Correctly compare values returned by 'sysctl -e -n'
2014-01-20 06:11:29 -08:00
Augustus Kling
c3f182bc9b Fix error reporting in case locale-gen fails on non-Ubuntu systems. 2014-01-20 00:11:01 +01:00
Augustus Kling
1fb830fba6 Merge remote-tracking branch 'upstream/devel' into locale 2014-01-19 23:51:27 +01:00
Augustus Kling
6b75e75161 Handle install/uninstall of locales for Ubuntu, too. 2014-01-19 23:35:10 +01:00
Simon Zimmermann
3db808c840 correctly compare the values, better func name 2014-01-18 11:04:15 +01:00
Simon Zimmermann
055b404f13 Correctly compare values as returned from 'sysctl -e -n' 2014-01-18 10:50:24 +01:00
Simon Zimmermann
7495095496 fix str format error due to missing '%' in sysctl module 2014-01-17 22:31:12 +01:00
James Tanner
3bd99903a4 Fixes #5661 Handle null values for sysctl parameters 2014-01-17 11:30:07 -05:00
Michael DeHaan
2a46022bc7 Merge pull request #5658 from rishid/devel
Add support for Scientific Linux for hostname module
2014-01-16 17:55:24 -08:00
jctanner
450bb37c8c Merge pull request #5655 from scottgilbert/devel
Allow keystring passed to authorized_key to contain blank lines and comments
2014-01-16 14:22:57 -08:00
James Tanner
19cb22b6df Fixes #5656 quote values with multiple columns before calling
the sysctl command. Calling sysctl should also not be true by default
2014-01-16 16:30:13 -05:00
rishid
34f9349b5e Add support for Scientific Linux for hostname module
hostname module was lacking support for Scientific Linux, this commit adds it.
2014-01-16 16:08:51 -05:00
Scott Gilbert
0aedd0c0b2 Allow keystring passed to authorized_key to contain blank lines and comments 2014-01-16 12:14:37 -06:00
James Tanner
2c39576e80 Remove unused variable from authorized_key 2014-01-16 11:46:06 -05:00
James Tanner
e22af253bb Fixes #5486 Keep authorized key options in tact and ordered 2014-01-15 17:10:10 -05:00
James Tanner
c627358c37 sysctl module: append newline character to lines in the file 2014-01-15 10:25:27 -05:00
Michael DeHaan
6f49642286 All modules should be using /usr/bin/python in the shebang as ansible_python_interpreter processes this (see FAQ).
Fixing for standardization purposes.
2014-01-15 09:52:17 -05:00
jctanner
332d3d6a0e Merge pull request #5490 from rgbj/devel
user module/OpenBSD: using login_class always makes status 'changed'
2014-01-14 14:44:51 -08:00
jctanner
6e39adb89e Merge pull request #5426 from lichesser/debian_release_4565
setup module: Partial fix for #4565, reporting Debian release version. Works only for Debian 7 and later
2014-01-14 13:00:08 -08:00
James Tanner
17c50cc81e sysctl module: fail if reloading the file did not succeed 2014-01-14 10:48:57 -05:00
James Tanner
ca05584495 Fixes #5469 Refactor sysctl module into object oriented code,
and add a sysctl_set parameter to manage the values in /proc
2014-01-13 18:53:02 -05:00
Tyler
2f813f7660 keep /usr/local/etc/rc.conf for backwards compatibility 2014-01-08 14:38:49 -05:00
Tyler
1a655b2dd7 Use /etc/rc.conf.local for sevice configuration on FreeBSD
/etc/rc.conf.local is the preferred location for system-specific
startup configuration, and /usr/local/etc/rc.conf generally isn’t used.

see:
http://www.freebsd.org/doc/handbook/configtuning-core-configuration.html
2014-01-08 13:48:11 -05:00
Joshua Lund
3b4f3f8ca3 Improved the documentation for password generation 2014-01-07 18:20:39 -07:00
James Tanner
dee960716b Fixes #5353 create etc/hostname file in debian if it does not exist 2014-01-07 15:53:16 -05:00
Michael DeHaan
1e6926b9ab Merge pull request #5528 from dverhelst/devel
Adding support for detecting RHEV Hypervisor in ansible_virtualization_type
2014-01-07 15:51:21 -05:00
Paul Beattie
e96377685e Fixed typo in example documentation 2014-01-04 00:22:14 +00:00
rgbj
f2150b101e On OpenBSD, make user module status 'changed' only if necessary when using 'login_class' parameter 2014-01-03 15:41:12 +01:00
jctanner
89abc35e59 Merge pull request #5167 from jaspernbrouwer/devel
service_module: Fixed false positive on initctl as enable_cmd
2014-01-02 20:24:00 -08:00
James Tanner
86719ce77f Fixes #5040 setup module: do not add primary interface info to the secondary interface data 2014-01-02 16:17:24 -05:00
lichesser
b49cb2e540 Partial fix for #4565. Works only for Debian 7 and later 2013-12-26 17:53:17 +01:00
Michael DeHaan
aa8beadec3 Fix a documentation item. 2013-12-25 13:50:15 -05:00
Augustus Kling
6d1c2a92de Basic handling of locales. 2013-12-24 12:29:02 +01:00
Brian Coca
35980ef329 making pylint happier
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-12-23 14:09:15 -05:00
Brian Coca
c2c0d9bcd7 corrected my grammar (again Mikhail)
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-12-23 13:48:53 -05:00
Brian Coca
555f12c59a did some minor refactoring on docs and fixed spelling mistakes (thanks
Mikhail)
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-12-23 13:35:27 -05:00
Jasper N. Brouwer
a52ca73167 Swapped conditions of the changed if statements 2013-12-23 09:54:16 +01:00
Brian Coca
821aa432a6 corrected indentation and now handles non existing previous key (not
just changed existing)

Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-12-20 12:50:06 -05:00
Brian Coca
307ab1f561 and it was supposed to be a dict
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-12-19 17:22:05 -05:00
Brian Coca
fd78916a73 fixed typo for showing diff
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-12-19 17:21:00 -05:00
Brian Coca
175d6346a2 debconf package
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-12-19 16:54:02 -05:00
jctanner
91f903eabe Merge pull request #4886 from sergeyhush/devel
fix when the system does not have lsb_release script, but has /etc/lsb_release file
2013-12-13 11:25:45 -08:00
jctanner
dc41912158 Merge pull request #5213 from dalevizo/devel
Add get_dmi_facts in setup for FreeBSD systems using dmidecode
2013-12-12 15:32:59 -08:00
Dimos Alevizos
8c73aa13e4 Minor changes to simplify code 2013-12-08 09:02:50 +02:00
David Hummel
cc3678730c Fix issue #5214: hostname persistence on RedHat/CentOS 2013-12-07 21:10:42 -05:00
Dimos Alevizos
de4e4c54b9 Add get_dmi_facts in setup for FreeBSD systems using dmidecode 2013-12-07 17:16:20 +02:00
jeromew
1916e8ec90 user module: force= and remove= should not be mutually exclusive 2013-12-05 17:07:24 -05:00