ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

Correctly compare values as returned from 'sysctl -e -n'

Browse source
This commit is contained in:
Simon Zimmermann 2014-01-18 10:50:24 +01:00
parent b8676203b9
commit 055b404f13
1 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
library/system/sysctl
View file

@ -148,7 +148,7 @@ class SysctlModule(object):
if self.args['sysctl_set']:
if self.proc_value is None:
self.changed = True
elif self.proc_value != self.args['value']:
elif self._compare_values(self.proc_value, self.args['value']):
self.changed = True
self.set_proc = True
@ -161,6 +161,21 @@ class SysctlModule(object):
if self.set_proc:
self.set_token_value(self.args['name'], self.args['value'])
def _compare_values(self, a, b):
"""Expects two string values. It will split the string by whitespace
and compare each value. It will return True if both lists are the same,
contain the same elements and the same order."""
if a is None or b is None:
return False
a = a.split()
b = b.split()
if len(a) != len(b):
return False
return len([i for i, j in zip(a, b) if i == j]) != len(a)
# ==============================================================
# SYSCTL COMMAND MANAGEMENT
# ==============================================================