1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/library/system
Lorin Hochstein 8c9cceacbf authorized_key: Set manage_dir default value
This commit fixes a bug where the authorized_key module causes
the ~user/.ssh directory to be owned by root instead of the user,
when the manage_dir argument is not specified.

If the manage_dir argument was not specified, the module behaved as if
manage_dir was set to false, even though it's supposed to default to
true.

This module assumed that an optional argument, with no default
specified, will not be present in the module.params dictionary.

What actually seems to happen is that the argument does appear in
the module.params dictionary with a value of None.

The upside is that this line was evaluating to None instead of
true:

    manage_dir = params.get("manage_dir", True)

I fixed the problem in this particular module by explicitly specifying
the default value for the manage_dir arugment. But if this bug
occurred because of a change in behavior in AnsibleModule, then other
modules may be broken as well.
2013-05-30 16:16:14 -04:00
..
authorized_key authorized_key: Set manage_dir default value 2013-05-30 16:16:14 -04:00
cron Allow modules to be categorized, and also sort them when generating the documentation. 2013-04-28 15:03:45 -04:00
facter Allow modules to be categorized, and also sort them when generating the documentation. 2013-04-28 15:03:45 -04:00
filesystem Change filesystem module message. 2013-05-11 14:03:40 -04:00
group FreeBSD group operations is now supported properly. 2013-05-08 13:36:55 +04:00
lvg Allow modules to be categorized, and also sort them when generating the documentation. 2013-04-28 15:03:45 -04:00
lvol Allow modules to be categorized, and also sort them when generating the documentation. 2013-04-28 15:03:45 -04:00
mount Allow modules to be categorized, and also sort them when generating the documentation. 2013-04-28 15:03:45 -04:00
ohai Allow modules to be categorized, and also sort them when generating the documentation. 2013-04-28 15:03:45 -04:00
ping Allow modules to be categorized, and also sort them when generating the documentation. 2013-04-28 15:03:45 -04:00
seboolean Allow modules to be categorized, and also sort them when generating the documentation. 2013-04-28 15:03:45 -04:00
selinux Allow modules to be categorized, and also sort them when generating the documentation. 2013-04-28 15:03:45 -04:00
service Fixes #2991: Service module pattern argument ignored. 2013-05-23 09:39:26 -06:00
setup Merge branch 'facter-fix' of git://github.com/flyapen/ansible into devel 2013-05-29 10:00:20 -04:00
sysctl Allow modules to be categorized, and also sort them when generating the documentation. 2013-04-28 15:03:45 -04:00
user Fixes #2924: User creation always reports 'changed' 2013-05-23 13:43:23 -06:00
zfs Allow modules to be categorized, and also sort them when generating the documentation. 2013-04-28 15:03:45 -04:00