1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/library
Lorin Hochstein 8c9cceacbf authorized_key: Set manage_dir default value
This commit fixes a bug where the authorized_key module causes
the ~user/.ssh directory to be owned by root instead of the user,
when the manage_dir argument is not specified.

If the manage_dir argument was not specified, the module behaved as if
manage_dir was set to false, even though it's supposed to default to
true.

This module assumed that an optional argument, with no default
specified, will not be present in the module.params dictionary.

What actually seems to happen is that the argument does appear in
the module.params dictionary with a value of None.

The upside is that this line was evaluating to None instead of
true:

    manage_dir = params.get("manage_dir", True)

I fixed the problem in this particular module by explicitly specifying
the default value for the manage_dir arugment. But if this bug
occurred because of a change in behavior in AnsibleModule, then other
modules may be broken as well.
2013-05-30 16:16:14 -04:00
..
cloud Fixup fetch doc formatting. 2013-05-29 10:45:31 -04:00
commands Allow modules to be categorized, and also sort them when generating the documentation. 2013-04-28 15:03:45 -04:00
database Now can specify amount of time to wait_for_handoffs or ring ready instead of booleans. 2013-05-27 17:24:10 -04:00
files Fixup fetch doc formatting. 2013-05-29 10:45:31 -04:00
internal Allow modules to be categorized, and also sort them when generating the documentation. 2013-04-28 15:03:45 -04:00
inventory Allow modules to be categorized, and also sort them when generating the documentation. 2013-04-28 15:03:45 -04:00
messaging Update rabbitmq_user/vhost/parameter to pass the node to rabbitmqctl using -n flag to rabbitmqctl rather than setting the environment variable. 2013-05-26 14:51:50 +01:00
monitoring new airbrake_deployment module 2013-05-24 14:40:37 -04:00
net_infrastructure Add newline at end of file 2013-05-11 17:21:29 -04:00
network Fixup fetch doc formatting. 2013-05-29 10:45:31 -04:00
notification Merge pull request #2931 from caredotcom/flowdock_nochange 2013-05-18 13:03:00 -07:00
packaging Lots of formatting fixes 2013-05-24 23:46:23 -04:00
source_control Fix typo in git module documentation preventing it to be processed by ansible-doc 2013-05-24 01:33:47 +02:00
system authorized_key: Set manage_dir default value 2013-05-30 16:16:14 -04:00
utilities Fix empty requirements specifications in modules documentation 2013-05-16 17:15:21 +02:00
web_infrastructure Allow modules to be categorized, and also sort them when generating the documentation. 2013-04-28 15:03:45 -04:00