Derek Carter
547395a2be
added inventory_hostname_short varible
2012-07-30 13:26:48 -04:00
willthames
ad9b8e2312
Output version string when --version is passed using optparse's version argument
2012-07-30 14:19:02 +10:00
Michael DeHaan
17be5537d6
When sudoing to another user, the umask may be set such that the next user might not be able to read/execute
...
the file. Deal with this.
2012-07-28 08:48:05 -04:00
Michael DeHaan
fcdc281c28
If sudoing to a user other than root, the home directory of the original user is very unlikely to be readable by the
...
sudoed to user, so just use tmp. Data will be readable by others (briefly before deletion) but never writeable.
2012-07-27 20:53:50 -04:00
Michael DeHaan
aa40c5f3b3
remove commented out debug lines
2012-07-27 20:44:55 -04:00
Michael DeHaan
ee5f12cd40
Slight tweaks on vars_prompt upgrades
2012-07-27 19:00:48 -04:00
Petros Moisiadis
c717934b7e
Improved 'vars_prompt' syntax to support prompt text and (non-)private input
...
An example of the new syntax:
vars_prompt:
- name: 'secret_variable_name"
prompt: "Enter secret value: "
private: "yes"
- name: "nonsecret_variable_name"
prompt: "Enter non-secret value: "
private: "no"
2012-07-27 19:00:48 -04:00
Michael DeHaan
a65b4fef97
Fix up chain invocations of template
2012-07-26 00:39:44 -04:00
Michael DeHaan
19fc8eea80
Things that happen inside multiprocessing shouldn't make side effects, ergo append ansible_facts only
...
in playbook code.
This technically means with_items calls can't continuously add facts I guess, but I can't see anyone
ever trying that.
2012-07-25 21:30:49 -04:00
Michael DeHaan
da4562f495
changes to not clear the setup cache between runs, and also decide to run plays with no tasks
...
in them if it looks like they are not tagged, because if that is the case, then we may just
be gathering facts about them.
2012-07-25 20:45:51 -04:00
Michael DeHaan
f371092845
rm stray comment
2012-07-25 20:31:57 -04:00
Michael DeHaan
e035ce97ce
blue on black, tears on a river, push on a shove, it don't mean much
...
(make colorized playbook runs not suck on black terminals)
2012-07-25 20:31:26 -04:00
Lorin Hochstein
b63a3bd0c7
Save module name and args when processing list of items.
...
This is necessary because daisy-chained modules will overwrite
these values.
2012-07-25 13:26:07 -04:00
Michael DeHaan
8d7f526df6
importing/not-importing methods should be colorized
2012-07-24 20:41:24 -04:00
Michael DeHaan
d3e8e8ff54
Fix output message
2012-07-24 20:37:27 -04:00
Michael DeHaan
c16b691883
Copy module needs to use src as transfer path.
2012-07-24 20:35:10 -04:00
Michael DeHaan
263432daa1
Changed no hosts to red. Not sure this is the right color choice, but there is no orange :)
2012-07-24 20:21:49 -04:00
Michael DeHaan
82cca242e3
use AnsibleError so that if there is an error it does not print a traceback
2012-07-24 20:16:35 -04:00
Michael DeHaan
8fa4dc3920
Small change to previous patch, make ranges of hosts inclusive.
2012-07-24 20:10:05 -04:00
Michael DeHaan
416b8d59a9
Merge branch 'devel' of https://github.com/fangchin/ansible into devel
2012-07-24 19:57:51 -04:00
Michael DeHaan
15062b38e1
Fix typo
2012-07-24 19:50:16 -04:00
Michael DeHaan
12ff9b5b9a
Move color coding bits to module, use over rest of playbook
2012-07-24 19:30:02 -04:00
Chin Fang
5315dd146d
Added lib/ansible/inventory/expand_hosts.py
2012-07-24 12:43:35 -07:00
Chin Fang
e3b2521f01
Added a host expansion feature to ansible's inventory parsing
2012-07-24 12:38:52 -07:00
Jan-Piet Mens
44a9226ece
file mode now correctly set after chaining from copy
2012-07-24 16:43:36 +02:00
Michael DeHaan
3a2df329af
Tweak the way chained callbacks work
2012-07-23 22:12:26 -04:00
Michael DeHaan
dd6399b5ae
Fixup args being passed into file from copy, tweak preservation of changed attribute.
2012-07-23 21:56:21 -04:00
Michael DeHaan
153f3932b5
reinstate delete_remote_files
2012-07-23 21:30:09 -04:00
Michael DeHaan
632a83c79e
Remove unused function
2012-07-23 21:28:18 -04:00
Michael DeHaan
479f8b8c26
Templating neccessary here.
2012-07-23 21:10:16 -04:00
Michael DeHaan
9b8793e42e
Fix a glitch with daisy chain logic
2012-07-23 21:01:59 -04:00
Michael DeHaan
183330a9fa
Merge pull request #662 from tima/regex-cond-tasks
...
Importing re in runner for doing conditional tasks using pattern matching i.e. re.search(). Also conditionally outputting item when skipping.
2012-07-23 17:52:52 -07:00
Michael DeHaan
cbea17e4c5
Fix up async
2012-07-23 20:46:35 -04:00
Michael DeHaan
cac7afd700
async is under construction
2012-07-23 20:06:18 -04:00
Michael DeHaan
1f44c07ddf
Fix assemble usage, some issues still with async.
2012-07-23 19:40:21 -04:00
Timothy Appnel
4b9b9a8a5b
Importing re in runner for doing conditional tasks using pattern matching i.e. re.search(). Also conditionally outputting item when skipping.
2012-07-23 19:36:26 -04:00
Michael DeHaan
ec12cc4154
Save the transfer of the module file for new style modules, because we can inject the arguments into the modules.
...
Module consumers using the API don't have to know how this works. base64 stuff is only there
because escaping a docstring inside a docstring was a bit of a challenge :)
2012-07-23 19:18:45 -04:00
Michael DeHaan
617f9dc942
Added some caching logic to improve external inventory scripts, removed some debug statements.
2012-07-22 11:53:19 -04:00
Michael DeHaan
57f12ac9e3
Using __slots__ in more places, in particular, hosts and groups, where we are apt to create a fair amount of objects.
2012-07-22 11:40:02 -04:00
Michael DeHaan
0b891fc8fb
Tweaking daisychain internals to allow get_url to modify the path destination when downloading to a directory.
...
Minor module refactoring.
2012-07-22 11:08:16 -04:00
Michael DeHaan
396b81b647
Remove this check as it wasn't really needed and in recent refinements keeps the group_vars stuff from working
...
as desired.
2012-07-22 10:06:10 -04:00
Michael DeHaan
d0f4358730
Port the copy module over to the new "common module" logic.
2012-07-21 17:07:42 -04:00
Michael DeHaan
d76c8c9c85
Various cleanup around runner's constructor and how daisy chaining is invoked.
2012-07-21 16:51:31 -04:00
Michael DeHaan
1682dd06c0
Avoid duplicate call to fetch inventory variables
2012-07-21 16:23:00 -04:00
Michael DeHaan
54c9c1e25c
Some streamlining of first_available_file code
2012-07-21 16:15:36 -04:00
Michael DeHaan
2d06ee4c0d
Fix some subtle things that were keeping 'hostvars' from being usable in templates.
2012-07-20 12:34:26 -04:00
Michael DeHaan
2b6d8a8be5
Fix some issues with the setup cache
2012-07-20 11:58:08 -04:00
Michael DeHaan
5a67a556cd
Script to migrate YAML users to the INI format, so we can deprecate YAML inventory (which we are now doing).
2012-07-20 11:15:57 -04:00
Michael DeHaan
dcca08b27b
Don't let with_items erase 'hostvars'
2012-07-20 10:02:35 -04:00
Michael DeHaan
b574c70006
host and group vars should update the setup cache
2012-07-20 10:00:51 -04:00
Michael DeHaan
ba3466af95
The following paths are now implict and optional in vars_files:
...
./group_vars/groupname.yml (for all groups the host is in)
./host_vars/hostname.yml (for the hostname given in the inventory)
This requires an actual inventory file, not script and the paths are relative
to the directory of the inventory file.
2012-07-20 09:43:45 -04:00
Michael DeHaan
db1a4d8fac
Make 'assemble' use the new daisychain logic
2012-07-20 09:17:42 -04:00
Michael DeHaan
6fb74ae2f9
preserve 'changed' attributes in daisychain logic
2012-07-20 09:13:10 -04:00
Michael DeHaan
d72c0c8898
replace module daisy-chaining logic
2012-07-20 08:57:50 -04:00
Michael DeHaan
6e84374c2a
Make hostvars work post refactoring
2012-07-20 08:29:44 -04:00
Michael DeHaan
b0eedfbf92
Merge pull request #639 from goozbach/issue-627
...
improved output in with_items fixes : #627
2012-07-20 16:36:49 -07:00
Michael DeHaan
85b9fa580c
Merge pull request #644 from bradobro/common_fix
...
AnsibleModule now correctly reads param values with '"'.
2012-07-20 14:31:24 -07:00
bradobro
a4a09fec82
AnsibleModule (in module_common.py) now correctly reads param values containing '='.
2012-07-20 21:19:38 +00:00
Stephen Fromm
8195375412
Sanitize possible password argument when logging invocation; taken from user module
2012-07-20 11:57:36 -07:00
Derek Carter
34e2584220
improved output in with_items fixes : #627
2012-07-20 14:01:54 -04:00
Rodney Quillo
5f068913ee
Suppress Ubuntu ssh -tt error ioctl error.
2012-07-20 13:23:14 +08:00
Michael DeHaan
a94ec130d2
Common module code upgrades
2012-07-17 23:09:57 -04:00
Michael DeHaan
9006d4557d
Added code to allow insertion of boilerplate into modules to make them able to share lots of code, the result
...
should be a huge reduction of total ansible source, at a slight cost of difficulty in original module development.
We need to apply this now to all modules, but may need to have some exemptions to things like command, which should
subclass this module.
2012-07-17 22:34:52 -04:00
Peter Sankauskas
4b66d98332
Adding missing colon... can't believe I missed that... sorry
2012-07-18 17:48:13 -07:00
Michael DeHaan
b38f8bfa80
Merge pull request #620 from pas256/patch-1
...
Conditional Imports should only import the first vars_file found in list
2012-07-18 16:31:45 -07:00
Peter Sankauskas
413fb15e0a
Conditional Imports should only import the first file in the list, not all of them. This change stops looping through the vars_files list as soon as a file is found.
2012-07-18 15:31:04 -07:00
Seth Vidal
5ad9bc8833
when using -i"hostname," on the cli - don't complain about the host named "" not being a host - just clip it from the list
2012-07-18 16:56:41 -04:00
Michael DeHaan
bfed0f14ec
Merge pull request #613 from ludovicc/devel
...
Allow local plays to execute when --ask-sudo-pass is used on the command line
2012-07-18 10:27:51 -07:00
Ludovic Claude
26dc607c5c
Revert "Change previous fix to a one line change relative to upstream"
...
This reverts commit 0d53b1b097
.
2012-07-18 19:02:56 +02:00
Ludovic Claude
0d53b1b097
Change previous fix to a one line change relative to upstream
2012-07-18 17:52:51 +02:00
Ludovic Claude
c4303c8c04
Avoid spurious error when mixing a local play with remote plays depending on --ask-sudo-pass
2012-07-18 12:05:12 +02:00
Jeroen Hoekx
f1b1611956
Fix typo while handling custom facts.
...
This fixes #611 .
2012-07-18 11:50:34 +02:00
Michael DeHaan
8bb8314d10
Inject vars need to pushed further up to make with_items work as desired.
2012-07-17 20:09:18 -04:00
Michael DeHaan
3c2cbae68e
Plays and tasks now yell when they see parameters they do not understand, so that typos like 'var' for 'vars'
...
don't result in people having to ask questions about what is wrong with their playbook
2012-07-17 19:09:36 -04:00
Michael DeHaan
e4a546e8bb
Make it possible to use variables from 'vars' in the paths to task level include statements.
2012-07-17 18:57:02 -04:00
Dave Hatton
72ca9e58e7
meaningful messages if the remote md5 fails
2012-07-17 09:14:16 +01:00
Michael DeHaan
0edd0d4736
Fixing template calls
2012-07-16 20:26:39 -04:00
Michael DeHaan
5f69c557b9
Fix for the way host variables were being swallowed, plus some overall simplification. Deciding what
...
dictionary to use for templating now happens in exactly one place (executor_internal) and the "inject"
dictionary is passed to what needs it.
2012-07-15 14:19:11 -04:00
Dave Hatton
c3205595b3
format fixes to make fetch more usable
2012-07-16 11:43:37 +01:00
Michael DeHaan
b542dd8466
Fix import in ssh connection
2012-07-15 13:12:11 -04:00
Michael DeHaan
80edea2934
with_items handling code should apply to all modules, was screwed up in refactoring to only apply to 'normal'
...
modules.
2012-07-15 12:51:56 -04:00
Michael DeHaan
1754de3335
Misc code cleanup, mostly whitespace preferences, removing unused imports, plus a few fixes here and there.
2012-07-15 12:29:53 -04:00
Michael DeHaan
4b73931351
misc code cleanup, don't pass parameters to the connection object we can already get from Runner
2012-07-15 11:54:39 -04:00
Michael DeHaan
6341e75e33
misc code cleanup
2012-07-15 11:20:59 -04:00
Michael DeHaan
031ba43d22
minor code cleanup
2012-07-15 11:09:15 -04:00
Michael DeHaan
1d8bb17785
misc code cleanup
2012-07-15 10:57:22 -04:00
Michael DeHaan
5a63a48e6b
No need to feed variables into the setup module for preservation since the file is no longer saved to disk.
2012-07-15 10:24:38 -04:00
Michael DeHaan
227c500ad7
Misc cleanup/formatting
2012-07-15 10:22:15 -04:00
Michael DeHaan
867b2437cc
consolidate output code in callbacks.py, from utils, remove extra functions
2012-07-15 10:12:49 -04:00
Michael DeHaan
bc71c6ddd7
add space between function
2012-07-15 09:33:48 -04:00
Michael DeHaan
cb55cd6f8d
removed unused function
2012-07-15 09:33:22 -04:00
Michael DeHaan
68a9adc1be
Indentation cleanup (partial)
2012-07-15 09:32:47 -04:00
Michael DeHaan
244b923559
No longer need to calculate setup metadata location since we don't write
...
the setup file to disk.
2012-07-15 09:25:17 -04:00
Michael DeHaan
61d8e2e7c7
with_items should be processed inside the task class, also make first_available_file
...
and with_items incompatible. Most cases that would need this could be solved
with vars_files.
2012-07-15 09:17:04 -04:00
Michael DeHaan
706cfd9ade
Misc cleanup -- moved function out of utils, removed debug statement.
2012-07-15 08:50:23 -04:00
Michael DeHaan
19a2fc00dc
Clean up imports in utils, add nicer recursion depth limit check.
2012-07-15 08:46:58 -04:00
Michael DeHaan
60d64251f8
Allow gather_facts: False in a playbook as a way of disabling the fact step if you know
...
you aren't going to need it.
2012-07-14 19:49:42 -04:00
Michael DeHaan
64c51ade1e
Change the way we do with_items to make them happen next to each other in runner, which eliminates the problem of with_items and vars_files sometimes not playing nice with each other.
...
(Also a fix for the user module error handling when the user
is not present at the time of the return. This can only really be caused by multiple ansible executions).
2012-07-14 19:18:33 -04:00
Michael DeHaan
028f216689
Error handling and magic around with_items, to let you know when variables are usable inside it and when not.
2012-07-14 13:23:14 -04:00
Michael DeHaan
102b22be1f
Make the logic behind vars_files smarter, so host specific vars go into the setup cache, but other variables
...
are usable top level. This allows vars_files data to be used, most of the time, just fine in with_items,
(error handling pending) but is mostly a memory and efficiency thing.
2012-07-14 13:12:19 -04:00