ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity
9010 commits 10 branches 167 tags 272 MiB
Commit graph

9010 commits

This branch
This branch
All branches
Author SHA1 Message Date
Ashok Raja R
cb3c6417dd pause plugin doesn't flush raw_input prompt 
##### Issue Type:

Bugfix Pull Request

##### Ansible Version:

ansible 1.4.3

##### Environment:

N/A

##### Summary:

We are using a wrapper python script to run ansible-playbook. We use subprocess to execute and print the stdout as and when its written. Problem is when we use pause it doesn't display the prompt string as raw_input does not flush stdout before reading from stdin.

It looks like a dirty fix to add "\n" to the prompt string but i don't see any other way to over come this. If anyone else have a better fix please do propose/suggest.

##### Steps To Reproduce:

```yaml
#File: test_play.yml
- name: Test
  hosts: $nodes
  gather_facts: false

  tasks:
    - name: Waiting for User
      local_action: pause prompt="Do you want to continue (yes/no)? "
```

```python
#!/usr/bin/env python
#File: test.py
import shlex, subprocess

def run_process(process):
    process = process.encode("utf-8")
    command = shlex.split(process)
    p = subprocess.Popen(command, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
    for line in iter(p.stdout.readline, b''):
        print line,

cmd = "/usr/bin/python -u /usr/bin/ansible-playbook -i hosts.txt test_play.yml -e 'nodes=local'"
run_process(cmd)
```

```
shell $ python test.py
```

##### Expected Results:
```
PLAY [Test] *******************************************************************

TASK: [Waiting for User] ******************************************************
[localhost]
Do you want to continue (yes/no)? :
```

##### Actual Results:
```
PLAY [Test] *******************************************************************

TASK: [Waiting for User] ******************************************************
[localhost]
```
 2014-02-28 11:28:38 +05:30
Michael DeHaan
f95786b52d Merge pull request #6208 from jctanner/yum-rhn-fix 
Fixes #6205 Add install_repoquery parameter to the yum module
 2014-02-27 18:33:37 -05:00
Michael DeHaan
9a3891b65c Add vault documentation. 2014-02-27 18:00:02 -05:00
Michael DeHaan
1a6db5449a Document vault and make some cross-references in places where people should read about vault. 2014-02-27 17:44:21 -05:00
Michael DeHaan
5cae9807d9 Trim pipelining docs a bit. 2014-02-27 16:55:36 -05:00
James Cammarata
df9de6ea71 Expand the source path in the action plugin when not using a remote source 
Fixes #6209
 2014-02-27 12:50:35 -06:00
James Tanner
aeccbeeed2 add failsafe comment for install_repoquery 2014-02-27 13:42:05 -05:00
James Tanner
122a7021bc remove install_repoquery docstring 2014-02-27 13:29:15 -05:00
James Tanner
3f43fa529d Install yum-utils by default 2014-02-27 13:16:30 -05:00
James Tanner
58c78539bb Fix typo 2014-02-27 12:40:51 -05:00
James Tanner
da210522f3 Fix up docstring type and extra info about list 2014-02-27 12:39:27 -05:00
James Tanner
79fb252dc9 Update docstring for rhn details 2014-02-27 12:34:53 -05:00
James Tanner
f89e5315af Add install_repoquery parameter to the yum module 2014-02-27 12:18:25 -05:00
James Cammarata
c11e2100e0 Save the original transport in runner after detecting the smart transport 
Fixes #6192
 2014-02-27 10:30:50 -06:00
Michael DeHaan
956eb91de0 Merge pull request #6198 from jlaska/integration_ec2 
First pass at ec2 module tests
 2014-02-27 10:44:37 -05:00
Michael DeHaan
829f959dce Merge pull request #6201 from cchurch/devel 
Escape subversion parameters for running svn commands
 2014-02-27 10:36:44 -05:00
Michael DeHaan
cd7d7eb1bc Merge pull request #6202 from muffl0n/unarchive_destdir 
unarchive: output dest in error-message
 2014-02-27 10:36:10 -05:00
Richard Isaacson
73fa767a6b Added instance_tenancy functionality per social request. 2014-02-27 09:29:00 -06:00
muffl0n
17946b23d5 output dest in error-message 2014-02-27 13:29:26 +01:00
Chris Church
adeea2c3f3 Added integration test for subversion parameters that need escaping. 2014-02-26 22:44:03 -05:00
Chris Church
5c2c29e71f Pass svn arguments as a list of strings instead of using string substition to ensure all parameters are escaped properly. 2014-02-26 22:23:26 -05:00
Richard Isaacson
ccb64e6358 Merge pull request #6199 from risaacson/issues_5773 
column must always be less than len(probline)
 2014-02-26 16:32:18 -06:00
Richard C Isaacson
9c8bbe2904 column must always be less than len(probline) 
Fixes related to GH-5773.
 2014-02-26 16:28:34 -06:00
James Laska
b589bf1d2e First pass at ec2 module tests 2014-02-26 16:43:30 -05:00
James Cammarata
14ba10393b Minor tweak to region config in boto configuration file 2014-02-26 15:40:33 -06:00
James Cammarata
88acb48e61 Merge branch 'ec2_boto_config_region' of https://github.com/willthames/ansible into willthames-ec2_boto_config_region 2014-02-26 15:32:05 -06:00
James Cammarata
2a383786dd And remove the expanduser calls from the action_plugin 2014-02-26 15:29:00 -06:00
James Cammarata
32a2636dc7 Add expanduser calls on src/dest in the module too 2014-02-26 15:19:45 -06:00
Richard Isaacson
21b2f3395a Merge pull request #6197 from risaacson/issues_5116 
When looking for double colon len(line) must be longer then 1.
 2014-02-26 15:11:14 -06:00
James Cammarata
3274785350 Merge pull request #5689 from pgehres/devel 
Adding the region to the output of the ec2 module's creation of a new in...
 2014-02-26 14:45:12 -06:00
Richard C Isaacson
585766201d When looking for double colon len(line) is longer then 1. 
Addresses GH-5116.

It comes up that when parsing json that if you are missing the last double quote on the last variable and the next line is just '}' we will get an out of range error. In this instance we will also then make sure that the line is long enough to have two colons.
 2014-02-26 14:25:56 -06:00
James Tanner
e3672dded0 Remove breakpoint 2014-02-26 14:53:36 -05:00
James Tanner
b74105c689 Add --vault-password-file to bin/ansible-pull 2014-02-26 14:52:57 -05:00
James Cammarata
d6b912c429 Modifying the wait logic for newly created images to avoid tracebacks 
Fixes #4619
 2014-02-26 13:33:31 -06:00
James Tanner
a37a6983be Switch from skipIf to SkipTest for TestVaulLib 2014-02-26 14:01:31 -05:00
James Cammarata
b758ed9417 Merge pull request #6150 from hkariti/fix_join_bug 
Fix incorrect use of .join on list causing a traceback
 2014-02-26 12:50:07 -06:00
James Tanner
f5359c310f Add negative tests for VaultLib 2014-02-26 13:38:58 -05:00
James Cammarata
96f1c3ce2e Move where the expanduser call is made, to avoid issues with None 2014-02-26 12:33:17 -06:00
James Cammarata
e659d55d62 Merge branch 'devel' of https://github.com/muffl0n/ansible into muffl0n-devel 2014-02-26 12:28:26 -06:00
James Cammarata
5ff20c1ae7 Merge branch 'scottanderson42-ec2-params' into devel 2014-02-26 11:38:36 -06:00
James Tanner
baed7a0ed9 Fixes #6187 Add unit tests for VaultLib 2014-02-26 12:10:09 -05:00
Michael DeHaan
33857855ad removing some unusued files. Paramiko alt was an experiment to attempt pipeline for paramiko, ssh_old is the non-pipelining-supported earlier 
version of the OpenSSH transport, which is configurable now and unified.
 2014-02-26 11:26:52 -05:00
James Tanner
35def422a3 Addresses #6188 Add --vault-password-file to bin/ansible and bin/ansible-playbook 2014-02-26 11:01:03 -05:00
James Cammarata
8a7c68dc18 Merge branch 'ec2-params' of https://github.com/scottanderson42/ansible into scottanderson42-ec2-params 
Conflicts:
	lib/ansible/module_utils/ec2.py
	library/cloud/ec2
 2014-02-26 09:37:26 -06:00
James Cammarata
168e3cf685 Revert "Adding a Makefile target for integration tests - "make integration"" 
This reverts commit 6f1a58abd3.
 2014-02-26 09:30:16 -06:00
James Cammarata
6f1a58abd3 Adding a Makefile target for integration tests - "make integration" 2014-02-26 09:26:48 -06:00
James Tanner
7acd2f3a2d Addresses #6188 Add --vault-password-file option to the ansible-vault command 2014-02-26 10:01:59 -05:00
James Tanner
1e33c96083 Update changelog for ec2_snapshot 2014-02-26 09:21:22 -05:00
Michael DeHaan
404765162d Merge pull request #6184 from patrys/patch-1 
Properly match existing security group
 2014-02-26 08:10:27 -05:00
Michael DeHaan
c2307b93e7 Merge pull request #6183 from gkoller/devel 
mysql_db: Emphasize target is on remote host. List supported file types.
 2014-02-26 08:09:59 -05:00