1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Commit graph

25873 commits

Author SHA1 Message Date
Yunge Zhu
79f9fc415d add redis cache facts (#48652) 2019-02-19 12:43:23 +08:00
Zim Kalinowski
103b4c1d09 Adding cosmosdb account facts module (#51993) 2019-02-19 11:18:12 +08:00
Zim Kalinowski
d6600b0ab6 fixed deallocated vm facts problem (#52540) 2019-02-18 21:20:50 -05:00
Kevin Breit
a499244a53 New module - meraki/meraki_content_filtering (#51223)
* Initial commit
- Module mostly works but doesn't work for URL categories
- Additional tests should be added
- Documentation is needed
- Module is close to being complete

* Improved documentation
- Added parameter documentation
- Added examples

* Lint changes and bug fixes
- Fixed content filtering syntax bug per Meraki documentation update

* Change test cases so they work

* Remove duplicate key

* Improve documentation and check mode
2019-02-18 19:27:21 -05:00
Kevin Breit
48128ec2fc meraki_ssid - Modifying SSID won't work when specifying number (#51645)
* Fix bug when specifying SSID by number
- Migrated integration test to blocks with always
- Minor URL fixes

(cherry picked from commit ed79c294f2e3f82d4828226004c055dcd7ce9f63)

* Create changelog file

* Add new line
2019-02-18 19:25:41 -05:00
Alex Vasilenko
20ed819acd Fix exception handling in credtash lookup (#51099)
Exception does not have property message and ansible returns completely different exception because of this
2019-02-18 18:28:35 -05:00
Dominik Holler
4df55bea2f provider_segmentation_id is int (#51600)
According to the OpenStack Networking API
the attribute provider:segmentation_id of a network has to be
an integer.
Even if neutron accepts provider:segmentation_id to be a
string, other implementations may not.
2019-02-18 18:26:03 -05:00
Kevin Breit
c254b93796 Meraki performance fixes for net and org lookups (#51395)
* Performance fixes for net and org lookups
- Both methods had duplicate lookups
- This should significantly improve performance
- Currently untested

* Add ChangeLog file

* Change from bugfix to bugfixes and change indent
2019-02-18 23:58:27 +01:00
Brian Coca
5e9b089ec2
Avoid resolving module_paths for docs (#51453)
alternate to #51419
2019-02-18 15:51:49 -05:00
Felix Fontein
8388c89a29 docker modules: add missing option types (#52422)
* Add missing option types for docker modules.

* Reorder argument_spec.

* First part of option reordering/reformatting.

* Second part of option reordering/reformatting.

* Forgot two required: false.

* Normalize booleans.

* Added missing period.
2019-02-18 15:40:52 -05:00
Guillaume Martinez
0e9ff44df1 blockinfile: don't use aliases in documentation exemples (#52220) 2019-02-18 15:19:49 -05:00
Chris Archibald
3b29b502e7 Docs changes to na_ontap_nvme_subsystem (#52289)
* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* update docs

* Revert "Revert "changes to clusteR""

This reverts commit 8e56b999e6cf6a65de339e516f7134a6b6b39cba.

* fix some merge issues
2019-02-18 15:11:45 -05:00
Matt Martz
42cf50fbac Do not send "Connection: close" when requesting a tunnel. Fixes #32750 (#46070) 2019-02-18 14:58:50 -05:00
Hannes Ljungberg
0bf9052e06 docker_swarm_service: Remove defaults (#52420)
* Remove update_parallelism default

* Remove update_delay default

* Add documentation about removing defaults

* Present porting guide changes as a list
2019-02-18 14:19:19 -05:00
Dave Buckley
367c62c9b5 fix pep8 on os_security_group_rule.py (#35924) 2019-02-18 14:14:41 -05:00
Pablo Piaggio
d1d4f4bd27 Add support for macro contexts that have colons (#51853)
Currently when used with macro contexts that have a colon inside, 
macro_name gets truncated. A common case is contexts that represent a 
Windows drive. Examples:

  - 'C_DRIVE_THRESHOLD: "C:"'
  - 'C_DRIVE_THRESHOLD: "D:"'

This happens because line 189 assumes there are only one colon in 
macro_name, and thus two substrings to join.

To solve this, it is necessary considering that macro_name could have 
more that one colon. After the split, the first element is the proper 
Zabbix macro name. Then, the solution is joining all the remaining 
substrings after that.

This is backwards compatible in the case macro_name have only one colon.
2019-02-18 17:51:35 +00:00
René Moser
a1ec74334a cloudscale_volume: fail fast on volume type change (#52231)
* cloudscale_volume: fail fast on volume type change

Currently a volume gets resized before the type change check. With this
change, we check early and ensure we fail before any changes made.

* fix too many blank lines
2019-02-18 17:48:47 +00:00
Paweł Rozlach
fcb6f136cd flatpak_remote: Handle empty output in remote_exists (#52010)
`flatpak remote-list -d` can return an empty output on Fedora 29 (version 1.2.0).
2019-02-18 17:40:51 +00:00
Nathaniel Case
686f4b35e3
Add enable become plugin patterned after runas (#52496) 2019-02-18 12:10:54 -05:00
Philippe Makowski
61743ab39a fix bug #47154 (#49881) 2019-02-18 17:09:23 +00:00
Alex Stephen
6ae04017d8 GCE deprecation warning (#52116)
* GCE deprecation warning

* porting guide typo

* fixing ignores

* moving error code back

* underscore marking on gce

* forgot to change status
2019-02-18 16:42:19 +00:00
Abhijeet Kasurde
e8b3adeb2b
VMware: add new module vmware_host_kernel_manager (#52503)
Signed-off-by: Aaron Longchamps <a.j.longchamps@gmail.com>
2019-02-18 21:57:49 +05:30
Matt Martz
77bfcad33a
Support unix socket with urls/uri (#43560)
* First pass at allowing unix socket with urls/uri. See #42341

* Only insert handler as needed

* Fix and add tests

* Add HTTPS functionality for unix sockets

* Additional test fixes

* Create context manager for monkey patching HTTPConnection.connect, de-dupe code, raise better errors

* doc

* Add a few more tests

* Fix __call__

* Remove unused import

* Patch HTTPConnection.connect with the functionality we want, instead of duplicating code and disabling

* Fix var name

* Remove unused var

* Add changelog fragment

* Update uri docs

* Fix rebase indentation issue
2019-02-18 10:21:42 -06:00
David Medberry
f67f391730 Update tower_credential.py (#51469)
misspelled word and poor capitalization (in the same sentence of the doc string)

+label: docsite_pr
2019-02-18 15:49:11 +00:00
Mikhail Yohman
1e12513e7b Bugfix: Fix return data and rework netbox_ip_address (#52415)
* Hopefully fixed the conflict and added the rework done

* Fixed PEP issues
2019-02-18 15:31:49 +00:00
Jiri Tyr
5f4840aaa8 Fixing state=present for jenkins_plugin module (#52051) 2019-02-18 15:18:49 +00:00
Matt Clay
687279c7bd Set user expires on FreeBSD using UTC. (#52276) 2019-02-18 09:59:13 -05:00
Zim Kalinowski
f6ba9be141 Fixed typo in azure_rm_cosmosdbaccount documentation (#52451) 2019-02-18 20:27:31 +05:30
Nilashish Chakraborty
bc403dbcda
Added new module - frr_facts (#51804)
* Add new module frr_facts

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix return value

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix review comments

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix review comments

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Handle empty row for mpls ldp neighbors

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix review comments

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix CI

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Remove timestamp from cliconf pluging

* Updated examples

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix sanity tests

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-02-18 19:35:40 +05:30
Hannes Ljungberg
c80ad43371 docker_swarm_service: Add working_dir option (#52425)
* Add working_dir option

* Check local mounts var to align with other checks

* Add changelog fragment

* Add trailing comma
2019-02-18 13:42:19 +00:00
Felix Fontein
37b0f5c81b docker: provide alternatives to ansible_facts results (#51192)
* Try to stop using ansible_facts for docker modules.

* Stop using facts returned from regular modules.
2019-02-18 13:41:34 +00:00
Felix Fontein
8222ebd23a docker_image: really deprecate state==build (#52412)
* Really deprecate state==build.

* Also explicitly deprecate use_tls.

* Add changelog.
2019-02-18 13:25:25 +00:00
Hannes Ljungberg
64b12d2c0d docker_swarm_service: Add groups option (#52428)
* Add groups option

* Add changelog fragment

* Remove whitespace

* Remove whitespace
2019-02-18 13:12:05 +00:00
Felix Fontein
1d8e9db4a9 crypto modules: add missing option types (#52421)
* Add missing crypto option types.

* Reorder argument_spec.

* Reorder option docs.
2019-02-18 10:24:17 +00:00
Matt Martz
9f82f3fd14 Alias ansible_model to ansible_product_name for Darwin. Fixes #52233 (#52242) 2019-02-18 10:22:44 +00:00
Miguel Angel Muñoz González
49ea68ca63 Fortinet's FortiOS fortios firewall service category (#52080) 2019-02-18 10:21:12 +00:00
Miguel Angel Muñoz González
993733848d Fortinet's FortiOS fortios firewall service custom (#52081) 2019-02-18 10:20:37 +00:00
snowjet
eaf238b033 Adds toggle port security on network create (#37390)
Added a new property, 'port_security_enabled' which is a boolean to
enable or disable port_security during network creation. The default
behaviour will enable port security, security group and anti spoofing
will act as before. When the attribute is set to False, security
group and anti spoofing are disabled on the ports created on this
network.

Shade supports this option in versions > 1.27.1
2019-02-18 05:03:27 -05:00
Hannes Ljungberg
18b968d486 docker_swarm_service: Add healthcheck option (#52419)
* Define yaml versions as strings

* Add healthcheck option

* Add changelog fragment

* Don’t set version_added as strings

* Use single quoted string

* Disable healthcheck tests on python 2.6

* Bring back quoting on already quoted version-added

* Python 2.6 compat

* Move functions to docker-common

* Move parse_healthcheck to docker-common

* Cast exception to str before printing failure

* Extend parse_healthcheck tests
2019-02-18 09:46:14 +00:00
Hannes Ljungberg
77d116f66e docker_swarm_service: Add stop_signal option (#52424)
* Add stop_signal option

* Add changelog fragment
2019-02-18 09:43:35 +00:00
Ondra Machacek
435e0c5dba Update kubevirt_vm with new feautures (#52311) 2019-02-18 15:12:23 +05:30
Yuwei Zhou
664e6fb9c8 modified storageaccount fact return curated result with connection string (#49702) 2019-02-18 16:48:56 +08:00
Zim Kalinowski
896e320142
adding postgresqlconfiguration facts (#45071) 2019-02-18 15:14:56 +08:00
Zim Kalinowski
fa73abcf5d
fixing force_update in azure_rm_mysqldatabase (#52389) 2019-02-18 14:20:30 +08:00
Joel Lappalainen
5426b26410 Fix az command to get object id (#52277) 2019-02-18 14:19:29 +08:00
Zim Kalinowski
8422e23533
Fixing azure_rm_postgresqldatabase force_update parameter (#52388) 2019-02-18 14:04:01 +08:00
Yuwei Zhou
2daaf4eedd fix non location error (#52312) 2019-02-18 13:54:41 +08:00
Zim Kalinowski
777441719f
azure_rm_cosmosdbaccount - fix for virtual network rules (#52416) 2019-02-18 11:58:43 +08:00
Garfield Lee Freeman
6b8f679ad1 Bug fixes and enhancements for panos connection (#52306) 2019-02-18 09:19:26 +05:30
Piotr Wojciechowski
97ebc95784 Fix typo in key name (#52432) 2019-02-17 22:45:13 -05:00
Abhijeet Kasurde
fad6443e58
Distribution: Add support for Linux Mint 18.3 (#52224)
* Distribution: Add support for Linux Mint 18.3
* Review comments

Fixes: #52210

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-18 08:28:04 +05:30
Zim Kalinowski
b7482e6a6d fix version import in common (#52005) 2019-02-18 09:54:59 +08:00
Sayed Anisul Hoque
7d6a94e7dc Fixed typos (#52426) 2019-02-17 22:49:40 +01:00
Felix Fontein
be3a47e2fe docker_common: improve image finding methods (#44692)
* Work around problem with Docker daemon that sometimes won't find image if prefixed with docker.io repo name.

* When tring library/xxx, docker-py also doesn't sometimes find the image.

* Add changelog.
2019-02-17 14:28:40 -05:00
Miguel Angel Muñoz González
36e0415d64 Fortinet's FortiOS log syslogd3 filter (#52262)
* Fortinet's FortiOS log syslogd3 filter

* Avoid Null Choices
2019-02-17 14:47:56 +00:00
Abhijeet Kasurde
52d8f9c397 pacman: Check for package list before installing (#52246)
Fixes: #45638

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-17 06:04:46 -05:00
Андрей Череваткин
88545b0292 Correct minor typo in filesystem module docs (#52413)
Changed 'filesytem' to 'filesystem'
2019-02-17 10:02:32 +05:30
Victor Fauth
3408de156a etcd3: Support authentication (#44383)
* etcd3: Support authentication

* etcd3: Comment argument check

* etcd3: Fixed wrong var names

* etcd3: Added in 2.8 instead of 2.7
2019-02-16 16:44:10 -05:00
Felix Fontein
ef3d86255d docker_* modules: remove from validate-modules ignore list (#52402)
* Remove docker_* modules from validate-modules ignore list.

* Adjust types of cacert_path, cert_path and key_path.

* Fix type of update_failure_action in docker_swarm_service.
2019-02-16 07:14:29 -08:00
Richlv
81d688a7c7 clarify how users are specified (#52260)
##### SUMMARY
Clarify that usernames - which Zabbix API documentation calls "aliases" - are to be specified for recipients

##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-02-16 03:07:29 -05:00
Matt Clay
f5c92f6bc1
Allow setting resource.RLIMIT_NOFILE in modules (#51989) 2019-02-15 17:52:35 -08:00
saranyasridharan
1db6d5598a Adding custom module to get PID of the process (#50896) 2019-02-15 17:08:55 -08:00
Dag Wieers
b4802350ec
Fix one issue (#52370) 2019-02-15 22:33:31 +01:00
Dane Summers
523cb8b5a4 cron - adds deprecation warnings (#37355). (#52322)
Adds deprecation warnings for both 'name', and 'reboot' option (although
not related to this change, it has been deprecated for quite a while)
2019-02-15 14:09:03 -05:00
Martin Krizek
50d7483632
Native Jinja2: raise undefined error immediately (#52237)
Fixes #52158
2019-02-15 19:36:12 +01:00
Matt Clay
02c9f70898 Fix sanity test failures (pep8). 2019-02-15 09:25:20 -08:00
Abhijeet Kasurde
db03f88b63
distribution: Add support for Cumulus Linux (#52309)
* Refactored code
* Added support for Cumulus Linux 2.5.4
* Added support for Cumulus Linux 3.7.3
* Test added

Fixes: #29969

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-15 22:30:51 +05:30
Dag Wieers
677c04c01d
Sanity fixes to parameter types (#52325) 2019-02-15 16:58:58 +01:00
Timo Runge
47190088b4 module_utils/mysql: Fixing unexpected keyword argument 'cursorclass' error after migratio… (#47809)
* Fixing unexpected keyword argument 'cursorclass' error after migration from MySQLdb to PyMySQL

* Adoptions for mysql.py as suggested by felixfontein.

* Adding changelog fragment.
2019-02-15 15:38:01 +00:00
David Soper
958653e282 Cisco Intersight module_utils and intersight_facts module (#51309)
* Cisco Intersight module_utils and intersight_facts module

* Add RETURN information and fix pylint, import, and pep8 issues.

* Review updates for specifying type of params/returns and not polluting ansible_facts.

* BSD one line license, validate_certs used, urls.fetch_urls replaces requests
2019-02-15 16:32:29 +01:00
Dag Wieers
c2fb581414 Fix various sonarcloud issues
This fixes various reported bugs through sonarcloud at:
https://sonarcloud.io/project/issues?id=Rodney-Reis_ansible&resolved=false&types=BUG
2019-02-15 07:19:04 -08:00
Dag Wieers
f9ab9b4d68 Assorted pylint fixes 2019-02-15 06:54:47 -08:00
Andrey Klychkov
8e0f95951d Module postgresql_idx: added ci tests, new params, returned values, code refactoring (#52230)
* postgresql_idx: ci tests, refactoring, return values

* postgresql_idx: ci tests, new params, return values

* postgresql_idx: ci tests, fix

* postgresql_idx: ci tests, fix

* postgresql_idx: ci tests, fix

* postgresql_idx: ci tests, fix

* postgresql_idx: ci tests, fix

* postgresql_idx: ci tests, fix

* postgresql_idx: ci tests, fix

* postgresql_idx: ci tests, fix

* postgresql_idx: ci tests, fix

* New module postgresql_table - fix tests

* New module postgresql_table - fix tests

* New module postgresql_table - fix tests

* New module postgresql_table - fix state choices order
2019-02-15 15:38:56 +01:00
Miguel Angel Muñoz González
b0606213dc Fortinet's FortiOS fortios_firewall_schedule_recurring (#52078) 2019-02-15 13:15:00 +00:00
Miguel Angel Muñoz González
db779e0fc8 Fortinet's FortiOS Firewall Schedule OneTime (#52076) 2019-02-15 13:14:32 +00:00
Miguel Angel Muñoz González
462155e7cf Fortinet's FortiOS log syslogd2 filter (#52259)
* Fortinet's FortiOS log syslogd2 filter

* Avoid null choices
2019-02-15 13:11:52 +00:00
Miguel Angel Muñoz González
f3ac33f6af Fortinet's FortiOS log setting (#52258) 2019-02-15 13:11:25 +00:00
Miguel Angel Muñoz González
7dc7d2cd56 Fortinet's FortiOS log null device setting (#52257) 2019-02-15 13:10:59 +00:00
Miguel Angel Muñoz González
e16f81e53e Fortinet's FortiOS log null device filter (#52256)
* Fortinet's FortiOS log null device filter

* Avoid null choices
2019-02-15 13:10:26 +00:00
Miguel Angel Muñoz González
66844328b7 Fortinet's FortiOS log memory global setting (#52251) 2019-02-15 13:09:47 +00:00
Miguel Angel Muñoz González
e4b70c0cdf Fortinet's FortiOS log memory setting (#52255) 2019-02-15 13:06:56 +00:00
Miguel Angel Muñoz González
ac6b5ab4d0 Fortinet's FortiOS log memory filter (#52250)
* Fortinet's FortiOS log memory filter

* Avoid null choices
2019-02-15 13:06:29 +00:00
Miguel Angel Muñoz González
3eba6363ff Fortinet's FortiOS log fortiguard override filter (#52168)
* Fortinet's FortiOS log fortiguard override filter

* Avoid null choices
2019-02-15 13:06:05 +00:00
Miguel Angel Muñoz González
8e6cf35a7e Fortinet's FortiOS system interface (#52247) 2019-02-15 13:03:44 +00:00
Miguel Angel Muñoz González
6592ac3421 Fortinet's FortiOS log fortiguard filter (#52167)
* Fortinet's FortiOS log fortiguard filter

* Avoid null choices
2019-02-15 13:03:10 +00:00
Miguel Angel Muñoz González
683a463580 Fortinet's FortiOS ips rule (#52121)
* Fortinet's FortiOS ips rule

* Avoid null choices

* Avoid null choices
2019-02-15 13:02:42 +00:00
Miguel Angel Muñoz González
98f122528f Fortinet's FortiOS log custom field (#52148) 2019-02-15 13:02:24 +00:00
Miguel Angel Muñoz González
49b21b64a0 Fortinet's FortiOS log disk filter (#52149)
* Fortinet's FortiOS log disk filter

* Avoid null choices
2019-02-15 13:02:03 +00:00
Miguel Angel Muñoz González
31da561d4a Fortinet's FortiOS log disk setting (#52150) 2019-02-15 12:41:01 +00:00
Miguel Angel Muñoz González
018db5e0c0 Fortinet's FortiOS log eventfilter (#52151) 2019-02-15 12:40:47 +00:00
Miguel Angel Muñoz González
769ddc44c3 Fortinet's FortiOS log fortianalyzer2 filter (#52157)
* Fortinet's FortiOS log fortianalyzer2 filter

* Avoid null choices
2019-02-15 12:40:26 +00:00
Miguel Angel Muñoz González
962741400b Fortinet's FortiOS log fortianalyzer filter (#52162)
* Fortinet's FortiOS log fortianalyzer filter

* Avoid null choices
2019-02-15 12:39:59 +00:00
Miguel Angel Muñoz González
405ce0bddf Fortinet's FortiOS log fortianalyzer override filter (#52163)
* Fortinet's FortiOS log fortianalyzer override filter

* Avoid null choices
2019-02-15 12:39:43 +00:00
Miguel Angel Muñoz González
5d6a18df99 Fortinet's FortiOS log syslogd2 setting (#52261) 2019-02-15 12:39:22 +00:00
Miguel Angel Muñoz González
dc81c9a5ee Fortinet's FortiOS log syslogd3 setting (#52264) 2019-02-15 12:39:01 +00:00
Miguel Angel Muñoz González
5065e0810d Fortinet's FortiOS log syslogd4 filter (#52265)
* Fortinet's FortiOS log syslogd4 filter

* Avoid null choices
2019-02-15 12:34:56 +00:00
Miguel Angel Muñoz González
46fbc6b329 Fortinet's FortiOS log syslogd4 setting (#52266) 2019-02-15 12:33:57 +00:00
Miguel Angel Muñoz González
d413e322a9 Fortinet's FortiOS log syslogd filter (#52267)
* Fortinet's FortiOS log syslogd filter

* Avoid null choices
2019-02-15 12:28:43 +00:00
Miguel Angel Muñoz González
505a9b25b3 Fortinet's FortiOS log syslogd override filter (#52268)
* Fortinet's FortiOS log syslogd override filter

* Avoid null choices
2019-02-15 12:26:22 +00:00
Miguel Angel Muñoz González
356978fbae Fortinet's FortiOS log syslogd override setting (#52269) 2019-02-15 12:25:33 +00:00
Miguel Angel Muñoz González
85ad67e245 Fortinet's FortiOS log syslogd setting (#52270) 2019-02-15 12:25:15 +00:00
Miguel Angel Muñoz González
747d96a8e2 Fortinet's FortiOS log threat weight (#52271) 2019-02-15 12:25:02 +00:00
Miguel Angel Muñoz González
256f492a19 Fortinet's FortiOS log webtrends setting (#52273) 2019-02-15 12:24:37 +00:00
Miguel Angel Muñoz González
73e82e8250 Fortinet's FortiOS report layout (#52294) 2019-02-15 12:23:09 +00:00
Miguel Angel Muñoz González
644545172f Fortinet's FortiOS report setting (#52295) 2019-02-15 12:22:54 +00:00
Miguel Angel Muñoz González
b0cd22cbb8 Fortinet's FortiOS report style (#52296) 2019-02-15 12:22:36 +00:00
Miguel Angel Muñoz González
25a9f88d74 Fortinet's FortiOS report theme (#52298) 2019-02-15 12:22:27 +00:00
Dag Wieers
25323155d2 doc_fragments: Clean up parameter types (cloud) (#52177)
* module_utils: Clean up parameter types (cloud)

This PR includes:

- Parameter types added
- Copyright format fixes
- Short license statement
- Description fixes (only for a few files, then I stopped :-))

* More cloud stuff

* Fix reported issue

* Fix quotes

* Use correct type

* Fix quotes

* Fix quotes

* Fix quotes

* Fix typo

* Fix boolean
2019-02-15 12:21:20 +00:00
Dag Wieers
203caf2570
Fix module issues (#52209) 2019-02-15 12:57:20 +01:00
Dag Wieers
cedd9d9926
crypto: Fix known issues in modules (#52302)
* crypto: Fix known issues in modules

This fixes a few issues reported by 'validate-modules'.

* Fix whitespace
2019-02-15 11:46:44 +01:00
Dag Wieers
9c1033422b doc_fragments: Clean up parameter types (network) (#52176)
* module_utils: Clean up parameter types

This PR includes:
- Parameter types added
- Copyright format fixes
- Short license statement
- Description fixes (only for a few files, then I stopped :-))

* More network stuff

* Fix typo

* Fix PEP8

* Fix booleans

* Fix typo
2019-02-15 09:52:48 +00:00
Zim Kalinowski
2f3960558d
Fix for PostgresSQL server update and storage_mb (#51653) 2019-02-15 17:46:52 +08:00
Zim Kalinowski
1f5cda37b3
Fix for MySQL server update and storage_mb (#51661) 2019-02-15 17:33:21 +08:00
japokorn
68d43130d0 New LUKS devices management module (#48991)
* New LUKS devices management module

- new module that uses cryptsetup (LUKS) functions for management
of encrypted devices
- unit tests included

* New LUKS devices management module

- modified interface by removing 'open' option and moving its functionality
into 'state' option
2019-02-15 09:25:14 +00:00
Zim Kalinowski
0c8c72a0bf
Fixing managed disk facts (#51781) 2019-02-15 17:07:30 +08:00
Dag Wieers
27dfdb6a6a doc_fragments: Clean up parameter types (database) (#52178)
* module_utils: Clean up parameter types (database)

This PR includes:

- Parameter types added
- Copyright format fixes
- Short license statement
- Description fixes (only for a few files, then I stopped :-))

* Fix validate-modules test ignores
2019-02-15 08:32:45 +00:00
Dag Wieers
fbca8a4615 doc_fragments: Clean up parameter types (storage) (#52179)
* module_utils: Clean up parameter types (storage)

This PR includes:

- Parameter types added
- Copyright format fixes
- Short license statement
- Description fixes (only for a few files, then I stopped :-))

* Fix quotes

* Fix rST issue
2019-02-15 08:31:12 +00:00
Jordan Borean
de118734e9
Ansible.Basic - add required_by to module spec (#51407)
* Ansible.Basic - add required_by to module spec

* fix typo in docs
2019-02-15 13:00:25 +10:00
Chris Archibald
994063bbf9 Add junction path to ontap_volume_clone (#51391)
* changes to clusteR

* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* add new option

* Fix issues
2019-02-14 21:12:50 -05:00
Dag Wieers
cd9471ef17 Introduce new 'required_by' argument_spec option (#28662)
* Introduce new "required_by' argument_spec option

This PR introduces a new **required_by** argument_spec option which allows you to say *"if parameter A is set, parameter B and C are required as well"*.

- The difference with **required_if** is that it can only add dependencies if a parameter is set to a specific value, not when it is just defined.
- The difference with **required_together** is that it has a commutative property, so: *"Parameter A and B are required together, if one of them has been defined"*.

As an example, we need this for the complex options that the xml module provides. One of the issues we often see is that users are not using the correct combination of options, and then are surprised that the module does not perform the requested action(s).

This would be solved by adding the correct dependencies, and mutual exclusives. For us this is important to get this shipped together with the new xml module in Ansible v2.4. (This is related to bugfix https://github.com/ansible/ansible/pull/28657)

```python
    module = AnsibleModule(
        argument_spec=dict(
            path=dict(type='path', aliases=['dest', 'file']),
            xmlstring=dict(type='str'),
            xpath=dict(type='str'),
            namespaces=dict(type='dict', default={}),
            state=dict(type='str', default='present', choices=['absent',
'present'], aliases=['ensure']),
            value=dict(type='raw'),
            attribute=dict(type='raw'),
            add_children=dict(type='list'),
            set_children=dict(type='list'),
            count=dict(type='bool', default=False),
            print_match=dict(type='bool', default=False),
            pretty_print=dict(type='bool', default=False),
            content=dict(type='str', choices=['attribute', 'text']),
            input_type=dict(type='str', default='yaml', choices=['xml',
'yaml']),
            backup=dict(type='bool', default=False),
        ),
        supports_check_mode=True,
        required_by=dict(
            add_children=['xpath'],
            attribute=['value', 'xpath'],
            content=['xpath'],
            set_children=['xpath'],
            value=['xpath'],
        ),
        required_if=[
            ['count', True, ['xpath']],
            ['print_match', True, ['xpath']],
        ],
        required_one_of=[
            ['path', 'xmlstring'],
            ['add_children', 'content', 'count', 'pretty_print', 'print_match', 'set_children', 'value'],
        ],
        mutually_exclusive=[
            ['add_children', 'content', 'count', 'print_match','set_children', 'value'],
            ['path', 'xmlstring'],
        ],
    )
```

* Rebase and fix conflict

* Add modules that use required_by functionality

* Update required_by schema

* Fix rebase issue
2019-02-15 10:57:45 +10:00
Emmanouil Kampitakis
1219aa811a Feature/alphanumeric password in passwordstore (#38121)
* Alphanumeric only password may be generated

* Bump the ansible version this will have been added to 2.8
2019-02-14 17:02:24 -05:00
Guillaume Martinez
f7328693f2 gitlab_runner: refresh deprecated documentation notes (#52221) 2019-02-14 05:04:55 -05:00
Matt Clay
3e778d3f8f Fix pycodestyle E117 issues. 2019-02-13 23:35:39 -08:00
Jordan Borean
7b8e814a10 Ansible.Basic: make module options case insensitive with dep warning (#51583)
* Ansible.Basic: make module options case insensitive with dep warning

* Add porting guide info
2019-02-13 21:55:43 -05:00
Yunge Zhu
bccf6d31bd add azure_applicationsecuritygroup module (#51214)
* add applicationsecurity group module

* fix lint
2019-02-13 19:34:44 -05:00
Matt Clay
1a4163cb88 Fix misuse of is not testing a string. 2019-02-13 15:10:01 -08:00
Adam Miller
ea0e2bf2b3 yum always return changes dict, not only in check mode (#51987)
Previously the yum module would provide a `changes` dict when
executed in check mode but omit it when not in check mode in favor
of the `results` data which is raw output from the yum command. This
pull request makes that output uniform.

Fixes #51724

Signed-off-by: Adam Miller <admiller@redhat.com>
2019-02-13 17:46:32 -05:00
René Moser
9e71ec71a3
cloudstack: ensure return api_timeout is int (#52191) 2019-02-13 23:11:22 +01:00
Felix Fontein
132d920113 Also return some information in case the docker daemon does not run, is not in swarm mode or not a swarm manager. (#52189) 2019-02-13 16:49:45 -05:00
Chris Archibald
6a06e9f485 New Module: na_ontap_nvme (#51182)
* changes to clusteR

* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* Add new module nvme
2019-02-13 20:36:58 +00:00
Miguel Angel Muñoz González
1b5575c669 Fortinet's FortiOS log fortianalyzer2 setting (#52159) 2019-02-13 20:15:37 +00:00
Miguel Angel Muñoz González
d875ca3e58 Fortinet's FortiOS log fortianalyzer override setting (#52164) 2019-02-13 20:12:20 +00:00
Miguel Angel Muñoz González
aac3ff364f Fortinet's FortiOS log fortianalyzer setting (#52165) 2019-02-13 20:11:03 +00:00
Miguel Angel Muñoz González
cd06cdf1dc Fortinet's FortiOS log fortianalyzer3 filter (#52160)
* Fortinet's FortiOS log fortianalyzer3 filter

* Avoid fields with empty choices

* Avoid fields with empty choices
2019-02-13 19:58:59 +00:00
Simon Westphahl
02e87b7d70 Raise AnsibleConnectionError on winrm connnection errors (#51744)
* Raise AnsibleConnectionError on winrm con errors

Currently all uncaught exceptions of the requests library that is used
in winrm will lead to an "Unexpected failure during module execution".

Instead of letting all exceptions bubble up we catch the connection
related errors (inkl. timeouts) and re-raise them as
AnsibleConnectionError so Ansible will mark the host as unreachable and
exit with the correct return code.

This is especially important for Zuul (https://zuul-ci.org) to
distinguish between failures and connection/host related errors.

* Update lib/ansible/plugins/connection/winrm.py

Co-Authored-By: westphahl <westphahl@gmail.com>

* Add changelog fragment
2019-02-13 14:55:55 -05:00
Miguel Angel Muñoz González
2de41ae8f4 Fortinet's FortiOS log fortianalyzer3 setting (#52161) 2019-02-13 19:55:31 +00:00
Miguel Angel Muñoz González
b51e3137a4 Fortinet's FortiOS log fortiguard override setting (#52169) 2019-02-13 19:54:41 +00:00
Miguel Angel Muñoz González
d643108d5c Fortinet's FortiOS log fortiguard setting (#52170) 2019-02-13 19:54:27 +00:00
Miguel Angel Muñoz González
402c41d97f Fortinet's FortiOS log gui display (#52171) 2019-02-13 19:54:19 +00:00
Matt Clay
3f387f225c Fix safe_eval on Python 3.8. 2019-02-13 11:54:03 -08:00
René Moser
02f51e865c cloudscale: combine docs in fragment (#52069)
* cloudscale: combine docs in fragment

* workaround false negative E305
2019-02-13 13:52:01 -06:00
Sandra McCann
6c17c55b51 move modules to community support (#52184) 2019-02-13 13:24:17 -06:00
おすし
c2a409a9e0 Fix: Yum module does not use proxy when username is not set #51548 (#51994)
* add test of yum with proxy

* Properly handle unauthenticated yum proxy config

Fixes #51548

* shell executable is bash
2019-02-13 14:10:47 -05:00
Felix Fontein
d7fd4d0550 docker_*: always use client.fail() over module.fail_json(), allow to always return data on failure (#51999)
* Always use client.fail() instead of module.fail_json().

* Allow to pass on results on module failure.

* Linting.
2019-02-13 14:10:23 -05:00
Sam Doran
ad386290b4
Update command/shell docs with note about modules for rebooting(#51499)
- Update integration test syntax
2019-02-13 13:54:36 -05:00
Kevin
c512471428 Add two more failure conditions to unarchive (#51914) 2019-02-13 13:40:26 -05:00
Matt Martz
cdb53ff1a4
Restore behavior for detecting only localhost, and no limit match. Fixes #52152 (#52172)
* Restore behavior for detecting only localhost, and no limit match. Fixes #52152

* Add test for non-matching limit
2019-02-13 11:52:30 -06:00
Jordan Borean
847d089d6b Re-add support for setting shell from play context (#52139)
* Re-add support for setting shell from play context

* Add integration tests

* Add more tests for shell override

* fix sanity issue
2019-02-13 11:49:13 -06:00
Matt Martz
b34d141eed
Disallow use of remote home directories containing .. in their path (CVE-2019-3828) (#52133)
* Disallow use of remote home directories containing .. in their path

* Add CVE to changelog
2019-02-13 10:38:28 -06:00
Juan Antonio Osorio
9f081ca04f identity: Add GSSAPI suport for FreeIPA authentication (#52031)
* identity: Add GSSAPI suport for FreeIPA authentication

This enables the usage of GSSAPI for authentication, instead of having
to pass the username and password as part of the playbook run.

If there is GSSAPI support, this makes the password optional, and will
be able to use the KRB5_CLIENT_KTNAME or the KRB5CCNAME environment
variables; which are standard when using kerberos authentication.

Note that this depends on the urllib_gssapi library, and will only
enable this if that library is available.

* identity: Add documentation for GSSAPI authentication for FreeIPA

This documentation describes how to use GSSAPI authentication with the
IPA identity modules.

* identity: Add changelog for GSSAPI support for IPA

This adds the changelog entry for the GSSAPI authentication feature for
the IPA identity module.
2019-02-13 15:38:13 +00:00
Chris Archibald
7d55dc1a38 Add ontap version to gather facts (#51181)
* changes to clusteR

* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* Add FlexGroup to Gather facts:

* fix call error
2019-02-13 15:33:38 +00:00
Chris Archibald
93237edcda New Module: na_ontap_qos_policy_group (#51392)
* changes to clusteR

* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* add new module na_ontap_qos_policy_group

* fix issues
2019-02-13 15:32:25 +00:00
Chris Archibald
311a076dae New Module: na_ontap_nvme_subsystem (#50887)
* changes to clusteR

* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* New module na_ontap_nvme_subsystem

* updates

* update author

* fix author
2019-02-13 14:36:48 +00:00
Alan Rominger
af9ff07c74 Send openstack inventory logs to stderr (#51827) 2019-02-13 13:36:37 +00:00
Abhijeet Kasurde
32fce43311
hashi_vault: fix multiple spaces in params (#51524)
Fixes param parsing in hashi_vault

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-13 18:32:00 +05:30
Miguel Angel Muñoz González
196e82ec8a Fortinet's FortiOS User Tacacs+ (#52071) 2019-02-13 11:37:03 +00:00
Miguel Angel Muñoz González
edcf07500f Fortinet's FortiOS Firewall Schedule Group (#52072) 2019-02-13 11:36:52 +00:00
Miguel Angel Muñoz González
05381db474 Fortinet's FortiOS fortios firewall service group (#52090) 2019-02-13 11:36:35 +00:00
Miguel Angel Muñoz González
3718a6b79f Fortinet's FortiOS fortios firewall shaper per ip shaper (#52092) 2019-02-13 11:36:14 +00:00
Miguel Angel Muñoz González
a5ed17e462 Fortinet's FortiOS fortios firewall shaper traffic shaper (#52093) 2019-02-13 11:36:03 +00:00
Miguel Angel Muñoz González
ac25361de5 Fortinet's FortiOS firewall shaping policy (#52094) 2019-02-13 11:35:45 +00:00
Miguel Angel Muñoz González
6dc44b18e1 Fortinet's FortiOS firewall shaping profile (#52095) 2019-02-13 11:35:36 +00:00
Miguel Angel Muñoz González
62f15c26b4 Fortinet's FortiOS firewall sniffer (#52096) 2019-02-13 11:35:29 +00:00
Miguel Angel Muñoz González
b8ffc1a917 Fortinet's FortiOS firewall ssh host key (#52097) 2019-02-13 11:35:20 +00:00
Miguel Angel Muñoz González
31180fa10f Fortinet's FortiOS firewall ssh local ca (#52098) 2019-02-13 11:35:00 +00:00
Miguel Angel Muñoz González
c21e41f4b8 Fortinet's FortiOS firewall ssh local key (#52099) 2019-02-13 11:34:06 +00:00
Miguel Angel Muñoz González
097a7c9d81 Fortinet's FortiOS firewall ssh setting (#52102) 2019-02-13 11:33:35 +00:00
Miguel Angel Muñoz González
312f2e9d1f Fortinet's FortiOS firewall ssl server (#52104) 2019-02-13 11:33:18 +00:00
Miguel Angel Muñoz González
1640ad6cfc Fortinet's FortiOS firewall ssl setting (#52105) 2019-02-13 11:33:01 +00:00
Miguel Angel Muñoz González
6fd031c820 Fortinet's FortiOS firewall ssl ssh profile (#52106) 2019-02-13 11:32:49 +00:00
Miguel Angel Muñoz González
bc0c1bd501 Fortinet's FortiOS firewall ttl policy (#52107) 2019-02-13 11:32:17 +00:00
Miguel Angel Muñoz González
8413d62727 Fortinet's FortiOS firewall wildcard fqdn custom (#52108) 2019-02-13 11:31:58 +00:00
Miguel Angel Muñoz González
47d1ab4c3d Fortinet's FortiOS firewall wildcard fqdn group (#52110) 2019-02-13 11:31:33 +00:00
Miguel Angel Muñoz González
abcdedfdf0 Fortinet's FortiOS ftp proxy explicit (#52113) 2019-02-13 11:31:23 +00:00
Miguel Angel Muñoz González
a1e2d290fc Fortinet's FortiOS system settings (#52112) 2019-02-13 11:31:04 +00:00
Miguel Angel Muñoz González
951ace650b Fortinet's FortiOS icap profile (#52114) 2019-02-13 11:30:42 +00:00
Miguel Angel Muñoz González
b18e8259cd Fortinet's FortiOS icap server (#52115) 2019-02-13 11:30:06 +00:00
Miguel Angel Muñoz González
30ab7135f0 Fortinet's FortiOS ips custom (#52118) 2019-02-13 11:29:53 +00:00
Miguel Angel Muñoz González
7d3247d3a5 Fortinet's FortiOS ips decoder (#52119) 2019-02-13 11:29:26 +00:00
Miguel Angel Muñoz González
4a9014fca1 Fortinet's FortiOS ips global (#52120) 2019-02-13 11:29:05 +00:00
Miguel Angel Muñoz González
7babf66d93 Fortinet's FortiOS ips settings (#52122) 2019-02-13 11:28:51 +00:00
Miguel Angel Muñoz González
364eb6e4a0 Fortinet's FortiOS ips rule settings (#52123) 2019-02-13 11:28:31 +00:00
Pilou
51270be883 tower modules: check that 'verify_ssl' defined in ~/.tower_cli.cfg isn't ignored (#50687)
* Check that verify_ssl defined in tower_cli.cfg isn't ignored

* Avoid to override verify_ssl value defined in tower_cli.cfg

By default, tower-cli library enables SSL certificates check. But
verify_ssl false value defined in config files read by default by
tower-cli library (for example /etc/tower/tower_cli.cfg) was ignored
because overriden by the tower_verify_ssl parameter default value.

* fix a typo in comment
2019-02-13 10:26:43 +00:00
Ondra Machacek
797a5218fb kubevirt: Add new kubevirt_vm module (#50768)
This module is managing virtual machines using KubeVirt.

Signed-off-by: Ondra Machacek <omachace@redhat.com>
2019-02-13 10:17:01 +00:00
Ross Williams
6e409a91ba Correct usage of sorted() in mongodb_user (#46792)
* Correct usage of sorted() in mongodb_user

sorted() can't be called on a list of dicts
without supplying a key parameter. This is
explained really well in the Sorting HOWTO
https://docs.python.org/3.6/howto/sorting.html#key-functions

This commit fixes #46791

* Fix PEP8 issues
2019-02-13 10:28:35 +01:00
Dag Wieers
21d43e6d94 win_product_facts: Fix RETURN information (#52058) 2019-02-13 19:09:30 +10:00
Straff
d4a07f9573 Added support for user-specified log file in win_package (#51104)
* Added support for user-specified log file in win_package - feature (#38353)

* added integration tests for win_package log_path support feature (#38353), and applied review feedback

* win_package log_path support feature (#38353) - fixed typo in win-package.py documentation

* win_package log_path support feature (#38353) - improved an integration test and better doc in win-package.py
2019-02-13 19:08:07 +10:00
Amol Kahat
563725ba98 Fixed typo from adress to address (#52143)
Signed-off-by: Amol Kahat <akahat@redhat.com>
2019-02-13 13:57:13 +05:30
Jiri Tyr
f49469f7bf Updating update_url for jenkins_plugin (#52086) 2019-02-13 01:32:34 -05:00
Matt Clay
04112d47a7 Fix more incorrect uses of is operator. 2019-02-12 20:04:20 -08:00
Will Thames
46fbcf08bc
aws_kms enhancements (#31960)
* Allow creation and deletion of keys (deletion just schedules for
  deletion, recreating an old key is just cancelling its deletion)
* Allow grants to be set, thus enabling encryption contexts to be
  used with keys
* Allow tags to be added and modified
* Add testing for KMS module
* Tidy up aws_kms module to latest standards
2019-02-13 13:06:58 +10:00
Matt Clay
0a461380a3 Fix incorrect use of is for comparisons.
See https://bugs.python.org/issue34850 for details.
2019-02-12 16:33:13 -08:00
Matt Davis
cd7a144515
fix docker default remote_user (#52137)
Fix bogus default value in config- exposed by become plugins (#50911) actually using this value in more cases.
2019-02-12 16:29:27 -08:00
Wojciech Sciesinski
a431e802ed Add posibilities to run the integration tests for PowerShell < 5.0 (#50808)
* Add posibilities to run the integration tests for PowerShell < 5.0

* Update of tests - based at a review comments for #50612

* The correction of YAML structure
2019-02-12 15:51:03 -05:00
Wojciech Sciesinski
a7528cdd25 Update the NuGet package provider when needed (#50759)
* Update the NuGet package provider when needed

* Update NuGet provider conditionally
2019-02-12 12:22:22 -08:00
Andrew Gaffney
9c35f18dd6 Custom jinja Undefined class for handling nested undefined attributes (#51768)
This commit creates a custom Jinja2 Undefined class that returns
Undefined for any further accesses, rather than raising an exception
2019-02-12 15:04:00 -05:00
Abhijeet Kasurde
4e0e09d2de docs: update docs about pipelining (#51856)
Additional documentation about `keep_remote_files` and
`pipelining` configurations.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-12 12:49:00 -05:00
hansmi
76ab88c9f5 callbacks/slack: Explicitly set Content-Type header (#51824)
There are other chat systems with hook implementations more or less
compatible with Slack, such as Rocket.Chat. The latter requires the
Content-Type header to be set to "application/json" (the body is JSON).

Signed-off-by: Michael Hanselmann <public@hansmi.ch>
2019-02-12 12:47:33 -05:00
Keith Maxwell
7fbacf920d Remove misleading statement passwords must be same (#49798)
* Remove misleading statement passwords must be same

Since 2.4 Ansible has supported multiple vault passwords:
<https://docs.ansible.com/ansible/latest/user_guide/vault.html#multiple-vault-passwords>

Meaning lines like the following are misleading:

> The password used with vault currently must be the same for all files you wish
> to use together at the same time.

-- `docs/docsite/rst/user_guide/vault.rst`

To demonstrate this with Ansible 2.7, save the following as `example.yaml`:

```
- name: Display output from two vaults with different passwords
  hosts: localhost
  connection: local
  vars_files: [one.yaml, two.yaml]
  tasks:
    - name: View secret from one.yaml vault
      debug: { var: one }
    - name: View secret from two.yaml vault
      debug: { var: two }
```

Then run the three following commands choosing two different passwords:

```
$ echo 'one: 1' | ansible-vault encrypt --vault-id id1@prompt --output=one.yaml
$ echo 'two: 2' | ansible-vault encrypt --vault-id id2@prompt --output=two.yaml
$ ansible-playbook --vault-id id1@prompt --vault-id id2@prompt example.yaml
```

`ansible-vault` stores an ID in plain text in the vault file.

* Remove note about default in Ansible 2.1

As requested by gundalow in https://github.com/ansible/ansible/pull/49798
2019-02-12 10:47:01 -05:00
rajaspachipulusu17
0825cbad40 Pluribus Networks prefix list network module with Unit test cases (#52064) 2019-02-12 20:40:58 +05:30
Chris Archibald
ce092ed939 New Modules: na_ontap_unix_group (#51390)
* changes to clusteR

* Revert "changes to clusteR"

This reverts commit 33ee1b71e4bc8435fb315762a871f8c4cb6c5f80.

* add new module ontap_unix_groups
2019-02-12 15:06:28 +00:00
Feilong Wang
af710bd048 Add OpenStack Magnum cluster module (#44686) 2019-02-12 14:52:11 +00:00
getjack
d33ad416d7 - Initial commit (#51738)
- Fix sanity checks
  - Fixed documentation trailing whitespaces
2019-02-12 14:33:58 +00:00
getjack
d9ffc42eee Added Ansible UTM Info Module for network interface address entities. (#51733)
* - Initial commit
- Fix sanity checks
  - Fixed documentation trailing whitespaces

* - Changed author github contact as he has no account i'll (steamx) take responsibility
2019-02-12 14:33:28 +00:00
Miguel Angel Muñoz González
9d514c7451 Fortinet's FortiOS Webfilter Content (#51800)
* Fortinet's FortiOS firewall content module

* Update fortios_webfilter_content.py
2019-02-12 14:32:03 +00:00
Miguel Angel Muñoz González
8e3391e2c7 Fortinet's FortiOS antivirus profile (#51808) 2019-02-12 14:31:46 +00:00
Miguel Angel Muñoz González
2a6ea40b94 Fortinet's FortiOS antivirus settings (#51810) 2019-02-12 14:28:30 +00:00
Miguel Angel Muñoz González
875723e315 Fortinet's FortiOS Application Group (#51813) 2019-02-12 14:27:49 +00:00
Miguel Angel Muñoz González
d5df3c51fa Fortinet's FortiOS Application Name (#51815) 2019-02-12 14:27:28 +00:00
getjack
748c9acba7 - Initial commit (#51731)
- Fix sanity checks
  - Fixed documentation trailing whitespaces
2019-02-12 12:12:57 +00:00
getjack
71651a4eee - Initial commit (#51736)
- Fix sanity checks
  - Fixed documentation trailing whitespaces
2019-02-12 12:12:07 +00:00
Miguel Angel Muñoz González
fb9f2ca1cd Fortinet's FortiOS antivirus quarantine (#51809) 2019-02-12 12:11:38 +00:00
Miguel Angel Muñoz González
32b66ed6fe Fortinet's FortiOS Application Rule Settings (#51816) 2019-02-12 12:03:42 +00:00
Bojan Vitnik
64a6dcdd1d New module: xenserver_guest_facts - returns facts of XenServer VMs (#49426)
* Initial commit for xenserver_guest_facts module
* New module: xenserver_guest_facts. Returns facts of XenServer VMs. Module is fully documented.
* Added unit tests for the module
* Moved FakeXenAPI import to a dedicated fixture, other fixes
* Removed unused imports, minor fixes to unit test code
2019-02-12 16:56:49 +05:30
Abhijeet Kasurde
47e1bf1862
VMware: Tag management to VMware object (#46945)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-12 16:53:33 +05:30
Abhijeet Kasurde
fab815fc3b
VMware: Handle duplicate VM names in vmware_vm_facts (#45412)
This fix changes facts returned from vmware_vm_facts to list of dict from
dict of dict.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-12 16:31:42 +05:30
Yadnyawalkya Tale
6d4307377f Fixed positional argument in azure_vm_virtualmachine (#52067)
Signed-off-by: Yadnyawalkya Tale <yadnyawalkyatale@gmail.com>
2019-02-12 16:17:59 +05:30
Abhijeet Kasurde
5c992fcc3f
ansible-vault: handle utf-8 filename in vault (#50341)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-12 16:13:51 +05:30
Miguel Angel Muñoz González
6afa00eecd Fortinet's FortiOS Authentication Rule (#51817) 2019-02-12 09:27:59 +00:00
Miguel Angel Muñoz González
95fa911713 Fortinet's FortiOS Authentication Scheme (#51821) 2019-02-12 09:21:51 +00:00
Sayed Anisul Hoque
63148b0cc7 Fixes the comment in the example of the sysctl module(#51547) 2019-02-12 14:30:21 +05:30
Miguel Angel Muñoz González
97ed97b5c4 Fortinet's FortiOS Application Custom (#51812) 2019-02-12 08:59:04 +00:00
Miguel Angel Muñoz González
420cad6141 Fortinet's FortiOS Authentication Setting (#51823) 2019-02-12 08:58:34 +00:00
Miguel Angel Muñoz González
023ca40392 Fortinet's FortiOS DLP Filepattern (#51829) 2019-02-12 08:58:13 +00:00
Miguel Angel Muñoz González
452e863cc6 Fortinet's FortiOS DLP FingerPrint sensitivity (#51832) 2019-02-12 08:57:38 +00:00
Miguel Angel Muñoz González
4864c9dbae Fortinet's FortiOS DLP Sensor (#51833)
* Fortinet's FortiOS DLP Sensor

* Empty choices removed
2019-02-12 08:57:23 +00:00
Miguel Angel Muñoz González
f1da012d1c Fortinet's FortiOS DLP Settings (#51834) 2019-02-12 08:56:59 +00:00
Miguel Angel Muñoz González
58fcb02b2a Fortinet's FortiOS DLP Fingerprint Doc source (#51837) 2019-02-12 08:55:51 +00:00
Miguel Angel Muñoz González
3d2bd9d47d Fortinet's FortiOS Dnsfilter domain filter (#51867) 2019-02-12 08:51:52 +00:00
Miguel Angel Muñoz González
394449b8a9 Fortinet's FortiOS Dnsfilter profile (#51870) 2019-02-12 08:51:34 +00:00
Miguel Angel Muñoz González
c0bee726c0 Fortinet's FortiOS Endpoint Control Client (#51872) 2019-02-12 08:48:53 +00:00
Miguel Angel Muñoz González
fb1c3808ec Fortinet's FortiOS Endpoint Control Forticlient EMS (#51886) 2019-02-12 08:39:25 +00:00
Miguel Angel Muñoz González
4a975e1857 Fortinet's FortiOS Endpoint Control Forticlient Registration Sync (#51887) 2019-02-12 08:39:02 +00:00
Miguel Angel Muñoz González
955396f68f Fortinet's FortiOS Endpoint Control Profile (#51889)
* Fortinet's FortiOS Endpoint Control Profile

* Fix too long lines

* Fix trailing space
2019-02-12 08:37:32 +00:00
Miguel Angel Muñoz González
34cb1f7eef Fortinet's FortiOS Endpoint Control Settings (#51890) 2019-02-12 08:33:21 +00:00
rajaspachipulusu17
a003de239d Pluribus Networks old modules to be deprecated (#51686)
* Pluribus Networks old modules to be deprecated

* Dox fixes
2019-02-12 13:43:22 +05:30
rajaspachipulusu17
48edffac60 Pluribus Networks vrouter ospf6 module with UT (#51793)
* Pluribus networks vrouter ospf6 module with UT

* Changes in check cli method
2019-02-12 13:41:30 +05:30
Hannes Ljungberg
70d8f02db7 docker_swarm_service: Extend env and add env_files support (#51762)
* Extend env and add env_files support

* Python 2.6 compat

* Handle lists passed as string

* Add changelog fragment

* Use correct link formatting

Co-Authored-By: hannseman <hannes@5monkeys.se>

* Fix typo

Co-Authored-By: hannseman <hannes@5monkeys.se>

* Handle empty env and env_files values
2019-02-12 08:06:58 +00:00
Felix Fontein
09f78d2f6c ufw: allow to insert rules relative to first/last IPv4/IPv6 rules (#49796)
* Insert should have type int.

* Add insert_relative_to option.

* Add changelog.

* Add tests.

* Improve comment.
2019-02-12 08:05:14 +00:00
rajaspachipulusu17
2e3964b474 Pluribus Networks vrouter interface ip module with UT (#51792)
* Pluribus networks vrouter interface ip module with UT

* Indetentation fix

* Changes in check cli method
2019-02-12 13:33:34 +05:30
rajaspachipulusu17
76534b45b0 Pluribus networks vflow table profile module with UT (#51722) 2019-02-12 13:32:59 +05:30
Piotr Wojciechowski
42f20091dd docker_swarm_facts: New module to retrieve Docker Swarm information (#50622)
* docker_swarm_facts: PR cleanup after rebasing

* docker_swarm_facts: Adding the features similar to docker_host_facts

* docker_swarm_facts: Minor documentation and documentation updates

* docker_swarm_facts: Minor documentation and documentation adjustments to changes in #51700

* docker_swarm_facts: Using AnsibleDockerSwarmClient class method to fail module if not run on swarm manager
module_utils\docker\swarm.py: Adjustment of error message to me bore descriptive if module fails because it is not run on swarm manager node
2019-02-12 00:59:31 -05:00
Piotr Wojciechowski
ea72f7001c docker_node_facts: Query may cover single or multiple nodes (#51701)
* docker_node_facts: Query may contain single or multiple nodes, additional option to query about the docker manager itself
docker_node_facts: Code update to use the module_utils/docker_swarm.py AnsibleDockerSwarmClient class methods

* docker_node_facts: Minor documentation update and error handling

* docker_node_facts: Minor documentation and code updates

* docker_node_facts: Minor documentation adjustments
2019-02-12 00:58:07 -05:00
Jordan Borean
179cbb9891
win_dsc - return warning from DSC invocation (#51927) 2019-02-12 13:50:00 +10:00
rajaspachipulusu17
338ad565a7 Pluribus Networks vrouter bgp network module with UT (#51791) 2019-02-12 09:07:15 +05:30
Ari Stark
2f85d62989 Add state option to git_config module (#50578)
* Add state option to git_config module

State present/absent option works like --set/--unset option for 'git config'.

* Change git_config to avoid useless parameter passed to git command

When unsetting value, command was : git config --unset foo ''.
Now command is : git config --unset foo.

* Add some integration tests to git_config module

* Add missing aliases file

* Change set up method

Using git command seems to cause troubles on some OS : changing config
by changing '.gitconfig' file.

* Remove some distros from tests pool

Git is not installed or is out of date on these distros.

* Fix aliases to skip tests on centos6

* Refactor tests of the git_config module

* Add use case when state=absent and value is defined
2019-02-11 21:49:53 -05:00
Simon Dodsley
984777b3d0 Update FlashArray facts to get new information (#51550) 2019-02-11 18:34:22 -05:00
onigra
063cd5ea44 Add force parameter to gem module (#51366) 2019-02-11 17:13:16 -05:00
Will Thames
9babd16942 k8s handle absent resources when waiting (#51682)
* k8s wait - don't try to call to_dict on None

Need to ensure that the resource dict is correctly returned for absent
resources

* Cope with resources without a namespace

Some resources (e.g. ClusterRoleBinding) do not have a Namespace.
Handle the lack of a namespace key.
2019-02-11 21:43:42 +01:00
Dag Wieers
031a1a5cc2 vsphere_file: New module to manage files on datastores (#48180) 2019-02-11 21:26:12 +01:00
Rémy Léone
b125b67ed2 Add a description of the description attribute 2019-02-11 11:58:44 -08:00
Matt Martz
c55317a2bd
Update connection plugins to use correct, non-deprecated, methods (#52038)
* Update connection plugins to use correct, non-deprecated, methods

* Update tests to reflect calling become plugins
2019-02-11 13:44:54 -06:00
Matt Clay
d033884465 Fix scaleway_lb test failures. 2019-02-11 11:20:33 -08:00
Abhijeet Kasurde
a4e79584ec include_vars: elaborate description of dir option (#52022)
based on work of thecjharries

Additional behavior documentation of 'dir' option in include_vars.

Fixes: #31761
2019-02-11 13:25:51 -05:00
Matt Martz
445ff39f94
Become plugins (#50991)
* [WIP] become plugins

Move from hardcoded method to plugins for ease of use, expansion and overrides
  - load into connection as it is going to be the main consumer
  - play_context will also use to keep backwards compat API
  - ensure shell is used to construct commands when needed
  - migrate settings remove from base config in favor of plugin specific configs
  - cleanup ansible-doc
  - add become plugin docs
  - remove deprecated sudo/su code and keywords
  - adjust become options for cli
  - set plugin options from context
  - ensure config defs are avaialbe before instance
  - refactored getting the shell plugin, fixed tests
     - changed into regex as they were string matching, which does not work with random string generation
     - explicitly set flags for play context tests
 - moved plugin loading up front
 - now loads for basedir also
 - allow pyc/o for non m modules
 - fixes to tests and some plugins
 - migrate to play objects fro play_context
 - simiplify gathering
 -  added utf8 headers
 - moved option setting
 - add fail msg to dzdo
 - use tuple for multiple options on fail/missing
 - fix relative plugin paths
 - shift from play context to play
 - all tasks already inherit this from play directly
 - remove obsolete 'set play'
 - correct environment handling
 - add wrap_exe option to pfexec
 - fix runas to noop
 - fixed setting play context
 - added password configs
 - removed required false
 - remove from doc building till they are ready

future development:
  - deal with 'enable' and 'runas' which are not 'command wrappers' but 'state flags' and currently hardcoded in diff subsystems

* cleanup

  remove callers to removed func
  removed --sudo cli doc refs
  remove runas become_exe
  ensure keyerorr on plugin
  also fix backwards compat, missing method is attributeerror, not ansible error
  get remote_user consistently
  ignore missing system_tmpdirs on plugin load
  correct config precedence
  add deprecation
  fix networking imports
  backwards compat for plugins using BECOME_METHODS

* Port become_plugins to context.CLIARGS

This is a work in progress:
* Stop passing options around everywhere as we can use context.CLIARGS
  instead

* Refactor make_become_commands as asked for by alikins

* Typo in comment fix

* Stop loading values from the cli in more than one place

Both play and play_context were saving default values from the cli
arguments directly.  This changes things so that the default values are
loaded into the play and then play_context takes them from there.

* Rename BECOME_PLUGIN_PATH to DEFAULT_BECOME_PLUGIN_PATH

As alikins said, all other plugin paths are named
DEFAULT_plugintype_PLUGIN_PATH.  If we're going to rename these, that
should be done all at one time rather than piecemeal.

* One to throw away

This is a set of hacks to get setting FieldAttribute defaults to command
line args to work.  It's not fully done yet.

After talking it over with sivel and jimi-c this should be done by
fixing FieldAttributeBase and _get_parent_attribute() calls to do the
right thing when there is a non-None default.

What we want to be able to do ideally is something like this:

class Base(FieldAttributeBase):
    _check_mode = FieldAttribute([..] default=lambda: context.CLIARGS['check'])

class Play(Base):
    # lambda so that we have a chance to parse the command line args
    # before we get here.  In the future we might be able to restructure
    # this so that the cli parsing code runs before these classes are
    # defined.

class Task(Base):
    pass

And still have a playbook like this function:

---
- hosts:
  tasks:
  - command: whoami
    check_mode: True

(The check_mode test that is added as a separate commit in this PR will
let you test variations on this case).

There's a few separate reasons that the code doesn't let us do this or
a non-ugly workaround for this as written right now.  The fix that
jimi-c, sivel, and I talked about may let us do this or it may still
require a workaround (but less ugly) (having one class that has the
FieldAttributes with default values and one class that inherits from
that but just overrides the FieldAttributes which now have defaults)

* Revert "One to throw away"

This reverts commit 23aa883cbed11429ef1be2a2d0ed18f83a3b8064.

* Set FieldAttr defaults directly from CLIARGS

* Remove dead code

* Move timeout directly to PlayContext, it's never needed on Play

* just for backwards compat, add a static version of BECOME_METHODS to constants

* Make the become attr on the connection public, since it's used outside of the connection

* Logic fix

* Nuke connection testing if it supports specific become methods

* Remove unused vars

* Address rebase issues

* Fix path encoding issue

* Remove unused import

* Various cleanups

* Restore network_cli check in _low_level_execute_command

* type improvements for cliargs_deferred_get and swap shallowcopy to default to False

* minor cleanups

* Allow the su plugin to work, since it doesn't define a prompt the same way

* Fix up ksu become plugin

* Only set prompt if build_become_command was called

* Add helper to assist connection plugins in knowing they need to wait for a prompt

* Fix tests and code expectations

* Doc updates

* Various additional minor cleanups

* Make doas functional

* Don't change connection signature, load become plugin from TaskExecutor

* Remove unused imports

* Add comment about setting the become plugin on the playcontext

* Fix up tests for recent changes

* Support 'Password:' natively for the doas plugin

* Make default prompts raw

* wording cleanups. ci_complete

* Remove unrelated changes

* Address spelling mistake

* Restore removed test, and udpate to use new functionality

* Add changelog fragment

* Don't hard fail in set_attributes_from_cli on missing CLI keys

* Remove unrelated change to loader

* Remove internal deprecated FieldAttributes now

* Emit deprecation warnings now
2019-02-11 11:27:44 -06:00
Zim Kalinowski
c581fbd0be adding missing items in postgresql facts documentation (#51677)
* adding missing items in postgresql facts documentation

* removed trailing whitespace
2019-02-11 11:07:38 -05:00
Zim Kalinowski
beba2fdc65 adding missing items in the documentation of mysql server facts (#51676)
* adding missing items in the documentation of mysql server facts

* removed trailing whitespace
2019-02-11 11:06:32 -05:00
James Cassell
953058d025 standardize connection variable names (#51776)
* standardize user/password connection vars

* docs: use ansible_user and ansible_password

* docs: var precedence for connection vars

* docs: ansible_become_pass -> ansible_become_password etc
2019-02-11 10:43:10 -05:00
Akira Yokochi
51061f8a5f fix a little typo in ini inventory doc (#52025) 2019-02-11 15:34:01 +00:00
Rémy Léone
accbcdeccb Add a Scaleway load-balancer module (#51741) 2019-02-11 15:28:55 +00:00
getjack
9dbb551528 - Initial commit (#51729)
- Fix sanity checks
  - Fixed documentation trailing whitespaces
2019-02-11 15:12:10 +00:00
Matt Martz
3c85ac1788
Promote include_tasks/role and import_tasks/role to stableinterface (#51975) 2019-02-11 09:06:38 -06:00
Bill Dodd
e0538610bf Update GetBiosBootOrder to use standard spec resources (#51764)
* update GetBiosBootOrder to use standard spec resources

* handle case where BootOrder is present but BootOptions is missing
2019-02-11 14:50:10 +00:00
Fabian von Feilitzsch
e81b74d6c8 Properly parse boolean env values as boolean (#51836) 2019-02-11 14:49:00 +00:00
Felix Fontein
4d3d8dd60f ufw: check values for direction depending on situation (#50402)
* Check values of 'direction'.

* Add changelog.

* Update lib/ansible/modules/system/ufw.py

Co-Authored-By: felixfontein <felix@fontein.de>

* Update lib/ansible/modules/system/ufw.py
2019-02-11 14:47:35 +00:00
Felix Fontein
a279892fae ufw: allow gre and igmp protocols (#51166)
* ufw: allow gre and igmp protocols.

* Add changelog.
2019-02-11 14:46:38 +00:00
Miguel Angel Muñoz González
95557077b6 Fortinet's FortiOS Extender Controller Extender (#51891) 2019-02-11 14:39:11 +00:00
Miguel Angel Muñoz González
06b725619b Fortinet's FortiOS Firewall Auth (#51892) 2019-02-11 14:36:15 +00:00
Bill Dodd
3b20b186d7 remove non-standard GetManagerAttributes, SetManagerAttributes (#51898) 2019-02-11 14:33:15 +00:00
Miguel Angel Muñoz González
158ae76d65 Fortinet's FortiOS Firewall Central SNAT Map (#51929) 2019-02-11 14:28:54 +00:00
Miguel Angel Muñoz González
b14008abb9 Fortinet's FortiOS Firewall DNStranslation (#51930) 2019-02-11 14:28:20 +00:00
Miguel Angel Muñoz González
c7af56849f Fortinet's FortiOS Firewall DoSPolicy6 (#51931) 2019-02-11 14:27:49 +00:00
Miguel Angel Muñoz González
a40ceb448e Fortinet's FortiOS Firewall DoSPolicy (#51932) 2019-02-11 14:26:17 +00:00
Miguel Angel Muñoz González
de077e60f5 Fortinet's FortiOS Firewall Identity based Route (#51933) 2019-02-11 14:26:00 +00:00
Miguel Angel Muñoz González
e7f4447092 Fortinet's FortiOS Firewall Interface Policy6 (#51935) 2019-02-11 14:25:44 +00:00
Miguel Angel Muñoz González
6f12e0d54e Fortinet's FortiOS Firewall Interface Policy (#51936) 2019-02-11 14:20:35 +00:00
Miguel Angel Muñoz González
cb6c8a0d26 Fortinet's FortiOS Firewall Internet Service Custom (#51937) 2019-02-11 14:20:22 +00:00
Miguel Angel Muñoz González
e0867459c7 Fortinet's FortiOS Firewall Internet Service (#51943) 2019-02-11 14:19:16 +00:00
Miguel Angel Muñoz González
bbb1e9e335 Fortinet's FortiOS Firewall Internet Service Group (#51945) 2019-02-11 14:19:03 +00:00
Miguel Angel Muñoz González
29567c9fdc Fortinet's FortiOS Firewall IpMacBinding Setting (#51947) 2019-02-11 14:18:24 +00:00
Miguel Angel Muñoz González
4742a55f31 Fortinet's FortiOS Firewall IpMacBinding Table (#51948) 2019-02-11 14:16:13 +00:00
Miguel Angel Muñoz González
e2f03df2b2 Fortinet's FortiOS Firewall IP translation (#51950) 2019-02-11 14:14:50 +00:00
Miguel Angel Muñoz González
6667604a3f Fortinet's FortiOS Firewall IPv6 EH Filter (#51954) 2019-02-11 14:14:20 +00:00
Miguel Angel Muñoz González
ebacea2116 Fortinet's FortiOS Firewall Multicast Address (#51964) 2019-02-11 13:47:01 +00:00
Mariusz Mazur
34671a64b3 k8s_auth: new k8s module for handling auth (#50807)
* k8s*: add a reference to k8s_auth in all the modules' descriptions

* k8s_auth: new k8s module for handling auth

* k8s_auth: ignore E203

Can't use module_utils.urls, since that lacks user CA support, which is
a critical feature of what this module does.
2019-02-11 07:55:34 -05:00
Miguel Angel Muñoz González
2aa500c9a4 Fortinet's FortiOS Firewall Multicast Policy6 (#51966) 2019-02-11 12:27:03 +00:00
Jérôme BAROTIN
b99de25f32 Enable changed var with ufw check mode (#49948)
* Enable 'changed' var with ufw check mode

* Fix from comment of the PR + Unit Test

* Fix on ufw module after the second review

- delete rules change works in check mode
- simplify execute def & use it on every call process
- improved regexp
- rename vars defaults to current_default_values

* Add ignore error to execute() and use it in get_current_rules()

* Update after third code review (introduce change in changed status)

* Adjust tests and fix some problems (#1)

* 'active' also appears in 'inactive'.

* 'reject' is also a valid option here.

* For example for reloaded, changed will be set back to False here.

* Improve and adjust tests.

* Fix after merging integration test

* handle "disabled" on default routed

* Add /var/lib/ufw/.. rules files

* add unit test

* Fix pep8 formatting error

* Separate ipv6 and ipv4 rules process from checkmode

* fix non-ascii error on ci

* Some change after review

* Add unit test with sub network mask

* rename is_match function by is_starting

* add changelog fragment
2019-02-11 11:05:35 +00:00
Miguel Angel Muñoz González
708f0b07ba Fortinet's FortiOS Firewall LDB monitor (#51955) 2019-02-11 10:59:54 +00:00
Miguel Angel Muñoz González
5c04f7c256 Fortinet's FortiOS Firewall Local In Policy6 (#51957) 2019-02-11 10:59:30 +00:00
Miguel Angel Muñoz González
70e738cfec Fortinet's FortiOS Firewall Local In Policy (#51962) 2019-02-11 10:58:58 +00:00
Miguel Angel Muñoz González
c9cea22854 Fortinet's FortiOS Firewall Multicast Address6 (#51963) 2019-02-11 10:49:34 +00:00
Miguel Angel Muñoz González
2016037fa5 Fortinet's FortiOS Firewall Multicast Policy (#51968) 2019-02-11 10:49:05 +00:00
Miguel Angel Muñoz González
30951d1db3 Fortinet's FortiOS Firewall Profile Group (#51969) 2019-02-11 10:47:59 +00:00
Miguel Angel Muñoz González
4219242aed Fortinet's FortiOS Firewall Profile Protocol Options (#51970) 2019-02-11 10:47:14 +00:00
Miguel Angel Muñoz González
bfd4e2a591 Fortinet's FortiOS Firewall Proxy Address (#51974) 2019-02-11 10:40:38 +00:00
Miguel Angel Muñoz González
da2eda41f7 Fortinet's FortiOS Firewall Proxy AddrGrp (#51982) 2019-02-11 10:39:37 +00:00
Miguel Angel Muñoz González
4262910e76 Fortinet's FortiOS Firewall Proxy Policy (#51983) 2019-02-11 10:37:33 +00:00
Felix Fontein
9b1cbcf3a4 openssl_csr: ignore empty strings in altnames (#51473)
* Ignore empty strings in altnames.

* Add changelog.

* Add idempotence check without SAN.

* Fix bug in cryptography backend.
2019-02-11 10:30:56 +00:00
Karsten Jakobsen
e6ae688e47 netbox: inventory: Fix VMs do not have device_roles, but instead use roles (#50761)
This makes sure that roles show up as device_role when using VMs
2019-02-11 06:40:24 +01:00
Guillaume Martinez
7b84c0ee80 gitlab_hook: renaming module name (#51979)
* gitlab_hook: renaming module name

* gitlab_hook: rename module in documentation

* gitlab_hook: remove plural in docs and code

* gitlab_hook: fix unit test functions
2019-02-11 00:30:36 +01:00
Hannes Ljungberg
153e996760 docker_swarm_service: Remove defaults (#51216)
* Drop descriptions of docker-py constraints <=3.0.0

* Properly indent documentation

* Clearer examples

* Spelling

* Fix example

* Revert "Drop descriptions of docker-py constraints <=3.0.0"

This reverts commit 8106215af62ae5880c3b748cec562a85f2247bdc.

# Conflicts:
#	lib/ansible/modules/cloud/docker/docker_swarm_service.py

* Add min versions for placement preferences

* Add endpoint_mode and publish to option_minimal_versions

* Restrict update max_failure_ratio and monitor versions

* Remove defaults and only pass required arguments

* Fix indentation

* Fix args documentation

* Fix replicas documentation

Co-Authored-By: hannseman <hannes@5monkeys.se>

* Add type to all documented options

* Add suboptions for mounts, secrets and configs

* Add suboptions to argument spec

* Remove redundant validation and casting

* Don’t default Spec.EndpointSpec.Mode to vip

* Use single quotes as string literal

* Catch ImportError explicitly

* Move init to top of class

* Align closing brackets

* Spelling

* Import LooseVersion

* Documentation fixes

* Documentation fix

* Documentation fixes

* Remove required: false and default=None

* Defaults for update_delay and update_parallelism

* Set correct key for default

* Handle empty idempotency

* Clearer image documentation

Co-Authored-By: hannseman <hannes@5monkeys.se>

* Clearer constraint documentation

Co-Authored-By: hannseman <hannes@5monkeys.se>

* Better documentation of corresponding service opts
2019-02-10 14:17:59 +00:00
Adam Miller
2721ed260e Properly handle unauthenticated yum proxy config (#51915)
Fixes #51548

Signed-off-by: Adam Miller <admiller@redhat.com>
2019-02-09 01:17:22 -05:00
Sloane Hertel
bcefd61437 Allow default regions list to use flexible credential types (#51451) 2019-02-09 00:22:56 -05:00
Nathaniel Case
7ad238b358
Document httpapi and cliconf plugins (#49503)
* Create new documentation pages for httpapi and cliconf

* Add new documentation to plugins toctree and Makefile

* Add DOCUMENTATION to cliconf

* Apply suggestions from code review
2019-02-08 11:04:05 -05:00
Geraint Jones
d1b2ef9c5c ios_user: include filter works just as well. (#51845) 2019-02-08 10:00:39 -05:00
Felix Fontein
0c2bb3da04 docker modules: various adjustments (#51700)
* Move docker_ module_utils into subpackage.

* Remove docker_ prefix from module_utils.docker modules.

* Adding jurisdiction for module_utils/docker to $team_docker.

* Making docker* unit tests community supported.

* Linting.

* Python < 2.6 is not supported.

* Refactoring docker-py version comments. Moving them to doc fragments. Cleaning up some indentations.
2019-02-08 08:16:11 +00:00
Trishna Guha
88df4e22d3
Removes superfluous commands nxos_vlan (#51796)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-02-08 11:10:45 +05:30
gyorgypeter
7fa5694975 VMware: Module for managing mirroring sessions. (#50338)
This module manages the mirroring sessions, and the necessary port settings.

* Correct Documentation and CS
* PEP8, YAML, Documentation Error Fix
* Added empty return statement

Co-Authored-By: gyorgypeter <32464524+gyorgypeter@users.noreply.github.com>
2019-02-08 10:16:57 +05:30
Abhijeet Kasurde
851d248096
VMware: do create VMDK for new VMs (#51753)
While creating new VM, don't assume the VMDKs are present,
create them as we attache the disk to VM.

Possible regression fix for introduced via #45953

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-08 10:14:04 +05:30
Jadi
bf40b8d118 Fixed wrong limit on 'Fetch all deployments' sample (#51897)
Fixes: #51675 

the sample for 'Fetch all deployments' is "{{ lookup('k8s', kind='Deployment', namespace='testing') }}" but it should be "{{ lookup('k8s', kind='Deployment') }}"
2019-02-08 08:17:50 +05:30
Guillaume Martinez
8fd3591275 copyright: edit deprecated email (#51912) 2019-02-08 01:48:25 +01:00
Jordan Borean
a39c4ad464
Final round of moving modules to new import error msg (#51852)
* Final round of moving modules to new import error msg

* readd URL to jenkins install guide

* fix unit tests
2019-02-08 10:07:01 +10:00
Jeremiah Mahler
ffbc9d99de fix Amazon system-release version parsing (#51521)
Previously it was assumed that the Amazon system-release
number was the final value of the string.  This isn't always
the case.  Some releases have the name at the end.

  Amazon Linux release 2
  Amazon Linux release 2 (Karoo)

Fix by instead looking for a number in the string.

Fixes #48823
2019-02-07 17:58:34 -05:00
Jordan Borean
c1e51ef486 Use common functions for handling import errors (#51851)
* Use common functions for handling import errors

* use refactored version of gitlab modules
2019-02-07 16:51:16 -05:00
Arbaz
28dcfa985f Include materialized views for ALL_IN_SCHEMA (#50957) 2019-02-07 16:38:28 -05:00
Miguel Angel Muñoz González
9566708473 Fortinet's FortiOS webfilter urlfilter (#51805) 2019-02-07 21:04:15 +00:00
Miguel Angel Muñoz González
6416ddfc2f Fortinet's FortiOS antivirus heuristic (#51806) 2019-02-07 21:03:43 +00:00
Adam Miller
9bb05b72b2 correctly detect pkg_mgr on fedora/rhel/centos rpm-ostree installed (#49256)
Check the path /run/ostree-booted which I'm told by upstream that it
will always be present when a host system is Fedora/RHEL/CentOS
Atomic/CoreOS vs "traditional" distro instance to detect the
non-traditional instance and ensure pkg_mgr selection is correct

Signed-off-by: Adam Miller <admiller@redhat.com>
2019-02-07 15:16:38 -05:00
Guillaume Martinez
959939b866 Refactor gitlab modules (#51141)
* gitlab_group: refactor module

* gitlab_user: refactor module

* gitlab_group, gitlab_user; pylint

* gitlab_project: refactor module

* gitlab_group, gitlab_project, gitlab_user: Enchance modules

- Add generic loop to update object
- Enchance return messages
- PyLint

* gitlab_runner: refactor module

* gitlab_hooks: refactor module

* gitlab_deploy_key: refactor module

* gitlab_group: enchance module and documentation

- Enchange function arguments
- Add check_mode break
- Rewrite module documentation

* gitlab_hook: enchance module and documentation

- Rewrite documentation
- Enchance function parameters
- Rename functions

* gitlab_project: enchance module and documentation

- Rewrite documentation
- Enchance function parameters
- Add try/except on project creation

* gitlab_runner: enchance module and documentation

- Rewrite documentation
- Fix Copyright
- Enchance function arguments
- Add check_mode break
- Add missing function: deletion

* gitlab_user: enchance module and documentation

- Rewrite documentation
- Enchance function parameters
- Add check_mode break
- Add try/except on user creation

* gitlab_deploy_key, gitlab_group, gitlab_hooks, gitlab_project,
gitlab_runner, gitlab_user: Fix residual bugs

- Fix Copyright
- Fix result messages
- Add missing check_mode break

* gitlab_deploy_key, gitlab_group, gitlab_hooks, gitlab_project, gitlab_runner, gitlab_user: pylint

* gitlab_runner: Add substitution function for 'cmp' in python3

* unit-test: remove deprecated gitlab module tests

- gitlab_deploy_key
- gitlab_hooks
- gitlab_project

Actually, they can't be reused because of the modification of the way that the module communicate with the Gitlab instance. It doesn't make direct call to the API, now it use a python library that do the job. So using a pytest mocker to test the module won't work.

* gitlab_deploy_key, gitlab_group, gitlab_hooks, gitlab_project, gitlab_runner, gitlab_user: add copyright

* gitlab_deploy_key, gitlab_group, gitlab_hooks, gitlab_project, gitlab_runner, gitlab_user: Support old parameters format

* module_utils Gitlab: Edit copyright

* gitlab_deploy_key, gitlab_group, gitlab_hooks, gitlab_project,
gitlab_runner, gitlab_user: Unifying module inputs

- Rename verify_ssl into validate_certs to match standards
- Remove unused alias parameters
- Unify parameters type and requirement
- Reorder list order

* gitlab_deploy_key, gitlab_group, gitlab_hooks, gitlab_project, gitlab_runner, gitlab_user: Unifying module outputs

- Use standard output parameter "msg" instead of "return"
- Use snail_case for return values instead of camelCase

* validate-module: remove sanity ignore

* BOTMETA: remove gitlab_* test

- This tests need to be completely rewriten because of the refactoring
of these modules
- TodoList Community Wiki was updated

* gitlab_user: Fix group identifier

* gitlab_project: Fix when group was empty

* gitlab_deploy_key: edit return msg

* module_utils gitlab: fall back to user namespace is project not found

* gitlab modules: Add units tests

* unit test: gitlab module fake current user

* gitlab_user: fix access_level verification

* gitlab unit tests: use decoration instead of with statement

* unit tests: gitlab module skip python 2.6

* unit tests: gitlab module skip library import if python 2.6

* gitlab unit tests: use builtin unittest class

* gitlab unit tests: use custom test class

* unit test: gitlab module lint

* unit tests: move gitlab utils

* unit test: gitlab fix imports

* gitlab_module: edit requirement

python-gitlab library require python >= 2.7

* gitlab_module: add myself as author

* gitlab_modules: add python encoding tag

* gitlab_modules: keep consistency between variable name "validate_certs"

* gitlab_modules: enchance documentation

* gitlab_runner: fix syntax error in documentation

* gitlab_module: use basic_auth module_utils and add deprecation warning

* gitlab_module: documentation corrections

* gitlab_module: python lint

* gitlab_module: deprecate options and aliases for ansible 2.10

* gitlab_group: don't use 'local_action' is documentation example

* gitlab_module: correct return messages

* gitlab_module: use module_util 'missing_required_lib' when python library is missing

* gitlab_module: fix typo in function name.

* gitlab_modules: unify return msg on check_mode

* gitlab_modules: don't use deprecated options in examples
2019-02-07 20:40:14 +01:00
rabin-io
a682a0292d Update yaml.py example to include A colon for single host in a group (#51830)
* Update yaml.py exmaple to include A colon

took me some time to find that out, you can have a single host under a group without the A colon, but if you add another host also w/o A colon, they will be parsed as a single line.

* Update yaml.py
2019-02-07 14:15:40 -05:00
Abhijeet Kasurde
c20722474a
ec2_vol_facts: set filters to default value (#51589)
Fixes: #51554

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-07 21:53:25 +05:30
Mike Sgarbossa
c459f040da use list instead of tuple and remove md5 on ValueError (#51357)
* use list instead of tuple and remove md5 on ValueError

Signed-off-by: michael.sgarbossa <msgarbossa@cvs.com>

* convert algorithms to list and add comment

Signed-off-by: michael.sgarbossa <msgarbossa@cvs.com>

* only convert to list if algorithms is not None

Signed-off-by: michael.sgarbossa <msgarbossa@cvs.com>

* new fragment for PR 51357

Signed-off-by: michael.sgarbossa <msgarbossa@cvs.com>

* fix lint: remove blank line
2019-02-07 11:23:11 -05:00
Viktor Utkin
d40f0313e2 spot instance request stay opened when module exit with timeout (#51535)
Fixes: #51534

* set valid_until equal to current time + spot_wait_timeout
* add setting ValidUntil to  value
* add changelog fragment
* fix shebang issue
2019-02-07 21:38:19 +05:30
Felix Geyer
890394aeed Remove unused imports and variable in hostvars.py (#51609) 2019-02-07 11:05:39 -05:00
Alexander Kharkevich
b93b3dd7a7 java_cert: support of different keystore type (JKS, JCEKS) (#49953)
* add differents type of keystores support (JKS, JCEKS)

* update documentation

* fix pep8 errors

* fix check in get_keystore_type
2019-02-07 10:45:28 -05:00
Dennis Israelsson
9243c927ba Ios static route new parameters (#41478)
* Update ios_static_route.py

* Update version_added
2019-02-07 10:38:20 -05:00
rajaspachipulusu17
0745d6a10a Pluribus Networks point feature module for vrouter pim config with UT (#51013) 2019-02-07 20:13:00 +05:30
ftntcorecse
e8209c23da Fortinet FortiManager Connection Plugin RC, plus associated utilities (#50336)
* PR Candidate for FortiManager Connection Plugin, plus associated Utilities.

* Update fortimanager.py

Adding additional comments

* Committing changes for PR as requested by Ansible Staff

* Minor doc change to kick off new shippable test. Unrelated code (not our stuff) caused a failure on the last test.

* Removed generic methods for get/set/etc. Moved a copy of FMGRLockCTX into the plugin for portability, and to left the original in the mod_utils/fortimanager.py as deprecated code for pre-2.7 customers still running on pyFMG and not the plugin.

Tested all playbooks and all modules, and all appears well.
2019-02-07 08:55:30 -05:00
Zim Kalinowski
d252cc7a2b adding cosmos db account module (#47181)
* adding cosmos db account module

* fixes

* fixed issues

* cosmos db account test fixes

* updating cosmosdb

* fixed required

* version from autogereneator

* several upgrades

* idempotency changes

* idempotency improvements

* updated cosmos db module with new idempotency check

* and idempotency check shall fail now....

* try to fail it again

* now should really fail

* one more

* introducing comparison template

* fixes + sorting of arrays

* updated comparisons

* don't compare if parameter is none

* one more test

* fixed compare

* fixed idempotency?

* more logging

* fix comparison rules

* make smaller change

* actually compare multiple write locations

* just change failover

* remove debugging stuff

* one more fix

* fixed remaining sanity test

* updating comparison stuff

* fix pep8

* fix pep8

* will pep8 finally work?

* one more fix

* cosmos db updates

* updating cosmos db account

* fixed pep8

* fix type

* fixed indent

* fixed problem with python 3

* another fix for python 3

* bool type here

* cosmos db fixes

* fix

* fix

* fix

* fixed syntax
2019-02-06 16:06:44 -08:00
Toshio Kuratomi
dfd8b659c0 Have update-bundled check for updates to all bundled code
Add a test for whether we have bundled code inside of ansible that needs to be updated
2019-02-06 13:59:55 -08:00
Jordan Borean
0f0d33a954 start getting modules to use shared import error code (#51787) 2019-02-06 12:39:17 -05:00
Jiří Stránský
0924a8cf67 Fix dictionary access in os_floating_ip module (#51444)
When using `nat_destination` parameter of `os_floating_ip` module, dot
syntax (`addr.addr`) is used to access a value in a dictionary,
resulting in the module crashing with this error:

AttributeError: 'dict' object has no attribute 'addr'

This is now fixed, when using correct syntax (`addr['addr']`), the
module seems to work fine.

Fixes #51443
2019-02-06 11:51:30 -05:00
Kevin Breit
f9f7b29a5a meraki_admin - Add documentation about absent priority (#51766)
* Add documentation about absent priority

* Remove 7 at the end of file
2019-02-06 10:06:57 -05:00
plumbeo
4d93c440b9 mysql_user: Match both single quotes and backticks when checking curr… (#40092)
* mysql_user: Match quotes, double quotes and backticks when checking current privileges

* Add changelog fragment for PR #40092
2019-02-06 14:20:43 +00:00
David Passante
cbde04606a Cloudstack: New module cs_vlan_ip_range (#51597) 2019-02-06 11:33:27 +01:00
Will Thames
7d181802fb Improve kubernetes validation warnings (#51683)
Warnings get printed at the end of loops, which means that if you're
running validation against a bunch of resources, the warning message
gets printed after a number of potentially unrelated resources.

Adding extra info about the resource failing validation will help
find the validation issues.
2019-02-06 08:09:41 +01:00
Strix
48642dd1d7 Copy/Paste error for ssl_ca (#51614)
* Copy/Paste error for ssl_ca

Whe `ssl_ca` is specified, the variable `ssl_cert` is checked. This is wrong

* fix connection over host/port
2019-02-06 01:53:16 -05:00
Felix Fontein
c9b08db979 acme_challenge_cert_helper: fix bad module.fail_json() call (#51795)
* Fix bad module.fail_json() call.

* Add changelog.
2019-02-06 15:45:35 +10:00
Jordan Borean
146a89b612
psrp - do not display bootstrap wrapper for eachach task (#51779) 2019-02-06 12:05:15 +10:00
Martin Krizek
9301c18428 Pass number of forks to TQM from CLI/config (#51669)
Fixes #51622
2019-02-05 15:23:12 -06:00
Sandra McCann
eb6989ecbc Add note to network agnostic modules for supported platforms (#51617)
* added doc fragment to multiple network modules
2019-02-05 15:18:54 -06:00
rhydian76
84a6519481 Windows facts for licensing information (#50079)
* Windows facts for ansible_winlicense_edition, ansible_winlicense_channel, ansible_winlicense_status added

* bugfix, replaced = with :

* changed facts to ansible_os_license_* in win_product_facts.ps1
Shortened the short_description in win_product_facts.py
removed errant - options: {} from  win_product_facts.py

* Code optimisations and changed return code to $null from NA when unknown license information returned from CIM SoftwareLicensingProduct class.

* code optimisation
2019-02-06 06:59:06 +10:00
Martin Krizek
33b07f322c
yum: disableexcludes is supported on centos6 (#51698)
* yum: disableexcludes is supported on centos6

* Add changelog
2019-02-05 18:18:56 +01:00
tatref
b682381d1d Update "yum group list" command (#51743) 2019-02-05 16:23:01 +00:00
Andrey Klychkov
fc4d04efc2 postgresql_user module: fix documentation (#51220)
* postgresql_user module: fix documentation

* postgresql_user module: fix documentation - fix typo, add a link
2019-02-05 04:24:14 -05:00
Hannes Ljungberg
4a5d38b55a docker_swarm_service: Enable tests (#51170)
* Enable tests

* Comment fixes

* Try lowering timeouts

* Comment fix

* Comment fix

* Comment fix

* Add a pause to let service update

* Fix comment

* Disable dns_search tests

* Disable dns_servers test

* Fix comment

* Fix comment

* Fix comment

* Fix comment

* Fix comment

* Fix comment

* Fix comment

* Revert "Disable dns_servers test"

This reverts commit 763e9da716b78f4986f313b3ba1ab98faacb742e.

* Revert "Disable dns_search tests"

This reverts commit 2859e4e3a5ebdca078de84d821bb53bbdf967dfd.

* Revert "Add a pause to let service update"

This reverts commit e990dfae1a62e9a42b07960819818bc75fd04427.

* Revert "Try lowering timeouts"

This reverts commit 1617772de81ecef0e560b38c7564646ec3874c3c.

* Ensure that services are running while testing

* Retry tasks on update out of sequence error

* Remove unnecessary check for APIError.explanation

Co-Authored-By: hannseman <hannes@5monkeys.se>

* Ignore errors when tearing down test suite

* Retry with a loop instead of tail recursion

* Initialize self.diff_trace in run

* Add change log fragment

* Actually raise error

* Add unit test for retrying

* Lint

* Change to bugfix

* Remove whitespace

* Mock docker dependency

* Use download.fedoraproject.org

* Revert "Use download.fedoraproject.org"

This reverts commit 5931791f7cfdd339f15068c8706b39905517abdf.
2019-02-05 08:25:29 +00:00
Abhijeet Kasurde
d8d4dc3f52
VMware: Check for category id before assigning (#51684)
Check if user specified category exists in environment,
before assigning it to the tag creation operation.

Fixes: #51381

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-05 11:50:15 +05:30
rajaspachipulusu17
d5797aa02f Pluribus Networks role module with Unit tests (#51261)
* Pluribus Networks role module with Unit tests

* pep8 sanity fixes

* Doc fix
2019-02-05 10:23:07 +05:30
Jordan Borean
915f3e0335
win_user_profile - fix issue on Server 2019 (#51708) 2019-02-05 06:16:29 +10:00
Jimmy Conner
41ccc2ee26 Update vmware_guest docs about resizing disks (#51496)
vmware_guest allows the expanding of disks, but not the shrinking of disks. Saying that "resizing" is not supported is a little misleading.
2019-02-04 14:43:10 -05:00
dw
30eea29373 Avoid accidental fork bombs due to try/except (#51633) (#51636)
WorkerProcess exceptions could previously cause StrategyBase loop to
resume in every child. See ticket description.
2019-02-04 13:52:26 -05:00
Dennis Lerch
e3006e8443 add diff_mode_enabled to documentation
option 'diff_mode_enabled' is not mentioned in documentation

+label: docsite_pr
2019-02-04 09:06:52 -08:00
Pilou
7a3582d651 uri: check unexpected failure doesn't occur when file cannot be saved (#45824)
* uri: fix TypeError when file can't be saved

Fix the following exception (and others):

    Traceback (most recent call last):
      File "/home/lilou/debug_dir/__main__.py", line 604, in <module>
        main()
      File "/home/lilou/debug_dir/__main__.py", line 554, in main
        write_file(module, url, dest, content, resp)
      File "/home/lilou/debug_dir/__main__.py", line 320, in write_file
        module.fail_json(msg="Destination dir '%s' not writable" % os.path.dirname(dest), **resp)
    TypeError: fail_json() got multiple values for keyword argument 'msg'

I would rather remove **resp from returned values but this module is
flagged as stableinterface.

* Static imports are more straight forward and preferred unless dynamic inclusion is required.
2019-02-04 10:29:05 -05:00
Martin Nečas
e0de42fe48 Ovirt vm state running wait false (#51024)
* ovirt change wait when state running

* add seting vm wait before creating module

* update wait for running vm

* ovirt vm sanity pylint correction

* ovirt add wait create

* update pep8 snytax

* update pep8 snytax 2
2019-02-04 14:52:37 +00:00
fessmage
70497df8d6 add-description-to-doc-postgresql_user-module (#51613)
* add-description-to-doc-postgresql_user-module

* fix trailing whitespaces

* Fix a small typo
2019-02-04 14:51:52 +00:00
Nathaniel Case
d14f16e31b
Restconf HTTPAPI plugin and modules (#49476)
* Initial code for restconf support

*  Add restconf httpapi plugin
*  Add restonf_get module

* Fix some ConnectionError usage
2019-02-04 09:28:26 -05:00
Ariel O. Barria
57349c0611 validate memory parameter for ovirt_vm (#46698) 2019-02-04 13:54:07 +00:00
vaneuk
2a0c356da9 added response_timestamps to ios_xr_command module (#50095) 2019-02-04 18:49:06 +05:30
Piotr Wojciechowski
daf1cfbde0 docker_node: Docker Swarm node operations module (#50584)
* * docker_node: New module for operations on Docker Swarm node
* Shared code for Docker Swarm modules

* * docker_node: Removed the attribute `force` as it is not used for any operation

* docker_node_facts: Update module to use client class AnsibleDockerSwarmClient instead of AnsibleDockerClient

* docker_node_facts: List of nodes can be provided as input, inspect all registered nodes or manager host itself

* docker_node: Update in method name called from AnsibleDockerSwarmClient

* docker_node: Additional method to shared module to get formatted output list of registered nodes

* docker_node: Additional method to shared module to get formatted output list of registered nodes

* docker_node: removed state list (featue moved to docker_swarm_facts)

* docker_node: Node labels manipulation (remove, replace, merge)

* module_utils/docker_swarm: Updated output for nodes list - adding swarm leader flag

* docker_node_facts: update in input and return values, update in documentation section

* docker_node: Updated operations on labels, tracking if change is required

* docker_node: Updated documentation, parameter 'hostname' is now required
docker_node_facts: Updated documentation

* * Failing Ansible tasl if not run on swarm manager - code cleanup

* * docker_node: Remove the 'action' list from output

* * docker_node: variable name change to be align with Python best practice, BOTMETA.yml update

* * module_utils/docker_swarm.py: fix for incorrect fail() action
* docker_node: documentation and code small updates

* * docker_node: revised labels manipulation

* docker_node_facts: Reverting to repository version, moving this change to separate PR

* * docker_node: Documentation update

* * docker_node: Update to node availability and role modification

* * docker_node: Update to check_mode handling

* * docker_node: Code cleanup

* docker_node_facts: Code cleanup

* docker_node_facts: Adding back the module with only update to use AnsibleDockerSwarmClient instead of AnsibleDockerClient
docker_node: cosmetic code changes
BOTMETA: updated on $team_docker

* docker_node: BOTMETA update
2019-02-04 13:08:46 +00:00
Abhijeet Kasurde
d37386d2c7
VMware: fix path for hw_files (#49116)
Fixes: #48929

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-04 12:02:55 +05:30
rajaspachipulusu17
449b7e9f10 Pluribus Networks snmp community module with unit tests (#51165) 2019-02-04 10:42:00 +05:30
Diane Wang
60e37c54cc VMware: add support for customize existing VM directly (#51215)
* add support for customize existing VM

* modify space issue

* move customize existing vm after reconfigure

* delete one debug line
2019-02-04 00:08:35 -05:00
swickera
2311f908d2 Added support for defining the ServerSelection attribute of the update searcher session, which allows specifying non-default update server sources. (#51334)
* Added support for defining the ServerSelection attribute of the update searcher session, which allows specifying non-default update server sources. This is useful if targeted systems have Windows Updates defaulted to WSUS or SCCM sources and we want to instead force searches to the online Windows Update catalog.

* fixed documentation formatting

* fixed documentation, added version_added info

* changed server_selection to a string value and refined documentation

* simplified parameter validation & result output, enhanced logging detail & documentation
2019-02-04 12:59:36 +10:00
Kairo Araujo
a355686987 new module: aix_devices, manage AIX devices (#32290)
* new module: aix_devices AIX devices management

This module discovery, defines, removes and modifies attributes of AIX
devices.

* Added hide attributes that can be used for aliases

Added hid attributes that can be used to manage aliases on en
interfaces.

* After tests: docs and attributes tests

Fixed attributes tests and doc explaining how to use
attributes with comma.

* Fixed grammar on module description

Fixed grammar on module description

* Included test/legacy/aix_devices.yml for tests

As discussed on IRC ansible-devel channes, was include the
legacy tests for further manual tests.

* Added 'attributes' as dictionary

Added 'attributes' as a dictionary makes the configuration
simple.

* Changed the added version from 2.5 to 2.7

Fixed the shippable error from 2.5 to 2.7

```
2018-06-01 08:28:02 ERROR: Found 1 validate-modules issue(s) which
need to be resolved:
2018-06-01 08:28:02 ERROR:
lib/ansible/modules/system/aix_devices.py:0:0: E307 version_added
should be 2.7. Currently 2.5 (75%)
```

* Various changes

* Revert

* Changed the tests to integration dir

* Implement 'available' state

'available' state is the AIX state used, that works same as 'present'

* The states were changed to AIX expressions and kept Ansible states.

Makes sense keep the states names to AIX and use the Ansible 'standards'
states.

'available' is 'present'
'removed' is 'absent'

It makes easy to AIX sysadmins use the module, however it keep the
Ansible meanings.

* Fixed choices according with latest patchset (commit)

* A few doc changes

Nothing material
2019-02-04 03:49:25 +01:00
Kairo Araujo
de67b8e5ee new module: AIX Volume Group creating, resizing, removing (#30381)
* new module: AIX Volume Group creating, resizing, removing

It is a module to manage Volume Groups to AIX Logical Volume
Manager. With this module is able to create, reisize and
remove a Volume Group.

* fixed suggestion for standards and PEP8

fixed suggestion on PR according with standards and PEP8

* Removed blank space in the end of line.

Removed blank space in the end of line.

* Improved validations, functions, pep8

- fixed pep8 and non-written conventions;
- fixed RETURN doc indentation for msg;
- fixed and improved the physical volume verification;
- pp_size, when not specified, is followed from AIX side;
- included volume group verification in the top;
- included state varyon and varyoff to be easy in playbooks;
- removed check_mode

* Implemented back module.check_module, pep8, return

Implemented back the module.check_module to permit be used.
Some corrections regarding module.exit_json() and
module.fail_json().
Some pep8 and non-written conventions

* removed exit_json() from functions and pep8

- ordered option parameters and pep8 compliance
- removed exit_json() from functions and moved to main()

* pep8, two spaces before function

pep8, two spaces before function

* changed single/double quotes

changed single/double quotes to non-written convention.

* removed command options parameters as global vars.

Commands options parameters was moved as global variables
to inside create_vg().

* include state to return.

included the state to return.

* no-underscore-variable applied to the code

no-underscore-variable was applied to the code

* Fixed version and doc

Fixed version and documentation sanity

* Fixed documentation for E325, E326

Fixed documentation for E325, E326 to force option

* Fixed E319 for return doc.

* Various improvements and cosmetic changes

* Fix whitespace issue
2019-02-04 03:30:10 +01:00
mcs94
2119fedf4d doc: fixing typo and grammar rundeck_project.py (#51674) 2019-02-03 22:30:22 +01:00
Jim Rollenhagen
07605923e1 Simplify regex filter code (#50202)
This was written when we were redefining `bool` in the same module. As
we aren't doing this any longer, simplify it back to just calling
`bool()`.
2019-02-03 15:10:16 -05:00
Felix Fontein
89a1c68f98 docker_volume: improve force option (deprecate, add new option) (#51145)
* docker_volume: Deprecating force option, adding recreate option.

* Add changelog.

* Remove mis-placed force: yes for docker_volume.
2019-02-03 15:09:24 -05:00
Feike Steenbergen
38e70ea317 Add session_role to postgresql modules (#43650)
* Allow session_role to be set for PostgreSQL

By implementing session_role it becomes possible to run the specific
PostgreSQL commands as a different role.
The usecase that is immediately served by this, is the one that one
ansible playbook can be shared by multiple users, which all have
their
own PostgreSQL login_user. They do not need to share login
credentials,
as they can share the role within the PostgreSQL database.

The following example may give some insight:

$ psql -U jdoe -X -d postgres

postgres=> CREATE DATABASE abc;
ERROR:  permission denied to create database
postgres=> set role postgres;
SET
postgres=# CREATE DATABASE abc;
CREATE DATABASE

fixes #43592

* Tests for session_role in PostgreSQL

* Bump version_added for session_role feature

* Remove explicit encrypted parameter from tests
2019-02-02 20:12:14 +01:00
Piotr Wojciechowski
e633b93f85 docker_host_facts: Get system-wide information about docker host (#51373)
* * docker_host_facts: Getting docker host info

* * docker_host_facts: Getting lists of containers, volumes, images and networks as in respective CLI commands

* * docker_host_facts: Adding filters, documentation update

* docker_host_facts: Code cleanup

* docker_host_facts: Adding verbose output option. Documentation update.

* docker_host_facts: Improving author information for ansibot

* docker_host_facts: documentation and small code updates, for `docker_disk_usage` returned type is always dict now
2019-02-02 07:52:16 -05:00
Dag Wieers
0846ea1fd3 Fix a potential issue with updating interfaces (#50464) 2019-02-02 12:44:57 +00:00
getjack
6bc5d4dd8e Added Ansible UTM Module for managing AAA groups. (#49860)
* Added Ansible UTM Module for managing AAA groups.

* - Fix sanity checks
  - Fixed documentation trailing whitespaces
  - Added missing documentation

* - Fixed minor language/typing/formatting issues.
2019-02-02 12:41:32 +00:00
Simon Dodsley
754e63ab67 Add module for Pure Storage FlashBlade to manage directory services (#44925) 2019-02-02 12:39:57 +00:00
Abhijeet Kasurde
18ed84b877 hashi_vault: add support for userpass authentication (#51538)
Added support for username and password authentication in hashi_vault
lookup plugin.

Fixes: #38878

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-02 12:32:53 +01:00
Kostiantyn Nemchenko
e81287593b postgresql_ext: cascade extension creating/deleting (#50717)
* postgresql_ext: cascade extension creating/deleting (#1)

* postgresql_ext: cascade extension creating/deleting

* Address code review feedback
2019-02-02 05:22:10 -05:00
Wojciech Wypior
d043003cff Fixes documentation example (#51643) 2019-02-01 21:32:02 -08:00
Kevin Breit
4493ba86ec Add response documentation (#51647) 2019-02-02 05:08:09 +01:00
Wojciech Wypior
1e4d2b1001 Ammends docstring (#51641) 2019-02-01 18:15:37 -08:00
Wojciech Wypior
041da7516d fixes issue #1186 (#51642) 2019-02-01 18:14:33 -08:00
Wojciech Wypior
cccb681c0a Adds aggregate functionality to the module (#51638) 2019-02-01 18:04:49 -08:00
Wojciech Wypior
803bf79dce Adds aggregate functionality to the module (#51639) 2019-02-01 18:03:45 -08:00
Wojciech Wypior
a5c630a81f Adds aggregate functionality to the module (#51640) 2019-02-01 17:53:06 -08:00
Wojciech Wypior
48704d45fd Fixes indentation style issues (#51637)
Fixes docstrings
2019-02-01 17:49:33 -08:00
Wojciech Wypior
fd2e0ddcac Adds clone_pools parameter (#51635)
Adds rate_limit parameter
Minor bug fixes
2019-02-01 17:47:46 -08:00
Simon Dodsley
99c00c6af1 Trivial nomenclature fix for NVMe hosts on Pure Storage FlashArray (#51616) 2019-02-01 14:54:30 -05:00
rajaspachipulusu17
a48af10b2c Pluribus Networks stp port module with UT (#51476) 2019-02-01 21:19:32 +05:30
Brian Coca
f54be74869 added missing version_added 2019-02-01 09:34:14 -05:00
Federico87
f94378fc2f ios_ntp module (#50705)
* ios_ntp module

* add execute_module for config func

* fix units test

* test empty list

* update example

* change want logic to follow have - removed try/except

* update commands list for config test

* add idempotent test case

* add more test
2019-02-01 09:20:02 -05:00
Anil Kumar Muraleedharan
004d8b03d4 Lenovo cnos l3interface (#51322)
* Adding cnos_l3_interface module in alignment with others vendors.
2019-02-01 09:17:52 -05:00
Simon Metzger
f3907c977c added support for breakout ports (#51607) 2019-02-01 15:15:42 +01:00
Andrea Tartaglia
b8790abcbe Added description to single net interface (#51602)
* Added description to single net interface

* ec2_instance single iface description changelog
2019-02-01 13:19:33 +00:00
Nilashish Chakraborty
beb2af83c1
frr: Add terminal and cliconf plugins (#51169)
* Added terminal plugin for FRR

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Added cliconf plugin for FRR

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Added cliconf plugin for FRR

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Override required methods

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix pep8 issues

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add get_supported_protocols and minor error regex fix

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Remove unused imports

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix review comments

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add get_diff and run_commands

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Set output to empty list

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Fix CI errors

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-02-01 17:56:31 +05:30
Juan Antonio Osorio
bac19c3301 identity: Autodetect FreeIPA server with DNS (#50988)
* identity: Autodetect FreeIPA server with DNS

This adds the ability for the freeIPA related modules to be able to
auto-detect the IPA server through DNS.

This takes advantage of the fact that a lot of FreeIPA deployments
configure their hosts to use IPA as the nameserver.

This check is only used if we didn't set neither the ipa_host parameter,
nor the environment variable IPA_HOST.

* identity: Specify docs for DNS discovery of ipa_host

These docs specify that it can now default to DNS if the 'ipa-ca' entry
is available.
2019-02-01 08:19:05 +00:00
Trishna Guha
9df6f152e1
add license_hostid fact nxos_facts (#51588)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-02-01 11:11:00 +05:30
chronidev
240d1a6afb Add coherency between check and normal mode for copy plugin action see issue #24633 (#51582)
* Add coherency between check and normal mode see issue #24633

* Add changelog fragment for the PR

* Make change following PR comment

* Remove trailing whitespace
2019-02-01 13:47:23 +10:00
Kevin Breit
c8484e19ca Correct spelling in meraki_ssid documentation (#51563)
Fix spelling error for address, which was addres.

+label: docsite_pr
2019-01-31 18:20:42 -06:00
Matt Clay
f6e129046a Fix performance issue with large task retries. (#51581) 2019-01-31 18:44:57 -05:00
Jordan Borean
769c237dc7
win_power_plan - move to Ansible.Basic and other fixes (#51575) 2019-02-01 08:07:37 +10:00
Alex Stephen
d1a9ba5cc0 Bug fixes for GCP modules (#51572) 2019-01-31 17:03:50 -05:00
Alex Stephen
27c5e38e10 Bug fixes for GCP modules (#51573) 2019-01-31 17:03:38 -05:00