ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity
8943 commits 10 branches 167 tags 272 MiB
Commit graph

3377 commits

Author SHA1 Message Date
Richard C Isaacson
292d84165e Clean up stray space at the end of a line after a period. 2014-02-03 11:52:37 -06:00
Richard Isaacson
f5ed7e1f0a Merge pull request #5828 from mxxcon/patch-1 
Updated htpasswd docs to have choices for crypt_scheme
 2014-02-03 09:46:10 -08:00
Pedro Romano
30c8f514a2 Allow the 'PATCH' method in the 'uri' module since 'httplib2' allows it 
and some APIs require it.
 2014-02-02 20:53:52 +00:00
Timur Batyrshin
db173453ba further compatibility with older versions of python-apt (#5853) 2014-02-02 23:15:19 +04:00
James Cammarata
fcb760c36c Merge pull request #5843 from jimi-c/issue_4088 
Adding no_log: capability for tasks
 2014-02-01 04:36:29 -08:00
James Cammarata
75e3b59bbd Adding no_log: capability for tasks 
Fixes #4088
 2014-01-31 16:58:46 -06:00
Michael Porter
8ccbf13a13 (#5822) Use mkstemp to open a temporary file (as NamedTemporaryFile doesn't take a delete argument in Python < 2.6) 2014-01-30 19:39:39 -05:00
Michael DeHaan
a1afd6987c Update copy 
Update copy documentation to reference synchronize module
 2014-01-30 17:43:40 -05:00
James Cammarata
9574f89471 Detect remote_user change in accelerate daemon and allow a restart 
Fixes #5812
 2014-01-30 14:40:41 -06:00
jctanner
086f879df9 Merge pull request #5823 from kustodian/authorized_keys 
Updated authorized_key module documentation regarding manage_dir
 2014-01-30 07:01:41 -08:00
Matt Martz
7498f212fc Update docs for rax_facts to include parameters added for other OpenStack clouds 2014-01-30 07:59:31 -07:00
mxxcon
ffac1b5c7f Updated docs to have choices for crypt_scheme 2014-01-30 01:05:05 -05:00
jctanner
086cf0acb7 Merge pull request #5745 from angstwad/cf-module-revert 
Add Rackspace Cloud Files module
 2014-01-29 17:01:57 -08:00
jctanner
434c78f263 Merge pull request #5744 from angstwad/revert 
Add Rackspace Cloud Files containers module
 2014-01-29 16:36:42 -08:00
jctanner
203a66eb48 Merge pull request #4865 from claco/rax_queue 
Add rax_queue module to create/delete Rackspace Cloud Queues
 2014-01-29 16:28:43 -08:00
jctanner
360f06b41d Merge pull request #5806 from sivel/rax-mod-utils-improvements 
Rax mod utils improvements
 2014-01-29 16:17:06 -08:00
jctanner
6c1f75c688 Merge pull request #5132 from sivel/rax-keypair 
Add rax_keypair module
 2014-01-29 16:15:29 -08:00
jctanner
6265128c9e Merge pull request #4941 from sivel/rax-clb-shared-vip 
Add ability to specify a VirtualIP ID for sharing a VIP with another LB
 2014-01-29 16:14:29 -08:00
Manuel Tiago Pereira
e563f847ec Fixes #5819: Added --executables to gem uninstall command. 2014-01-30 00:09:28 +00:00
Romeo Theriault
8ea59e8ce5 fix following redirects 2014-01-29 14:04:53 -10:00
kustodian
a7839208c7 Updated authorized_key module documentation regarding manage_dir 
Added a warning in the documentation about manage_dir when selecting an alternate directory for authorized_keys
 2014-01-29 23:39:43 +01:00
Wim
06576fed25 Add support for --copy-links 2014-01-29 23:05:51 +01:00
James Cammarata
cdc34477be Merge branch 'devel' of https://github.com/aclindsa/ansible into aclindsa-devel 2014-01-29 14:11:51 -06:00
Richard Isaacson
c997f03b95 Merge pull request #5821 from risaacson/issue5781 
If a executable is defined but not found the module should fail.
 2014-01-29 11:25:35 -08:00
Aaron Lindsay
59ac969d2b Add move_home option to user module 2014-01-29 14:10:26 -05:00
Richard C Isaacson
f0c4dace8d If a executable is defined but not found the module should fail. Addresses https://github.com/ansible/ansible/issues/5781. 2014-01-29 13:09:58 -06:00
jctanner
48c477ffc8 Merge pull request #5790 from geerlingguy/patch-3 
Mention shell module in command documentation
 2014-01-29 09:57:16 -08:00
jctanner
b411cce6f3 Merge pull request #5784 from geerlingguy/patch-1 
Update wait_for documentation - remove extra quote
 2014-01-29 09:51:48 -08:00
Michael DeHaan
83f43b82ad ansible -> ansibleworks 2014-01-28 20:29:41 -05:00
Richard C Isaacson
7a2df2733f Tested implementation adding action option for (add, delete, unique). 2014-01-28 20:29:41 -05:00
Richard C Isaacson
c198217900 Rough cut implementation based on @resmo's comments. 2014-01-28 20:29:41 -05:00
Richard C Isaacson
cd871384de Rough cut implementation based on @resmo's comments. 2014-01-28 20:29:41 -05:00
Richard C Isaacson
b00939acff Change to dynamically pick up the command from the PATH. 2014-01-28 20:29:41 -05:00
Richard C Isaacson
9650c118cf Formating and syntax fixes that were pointed out during code review. 2014-01-28 20:29:41 -05:00
Richard C Isaacson
ec04e30186 Added user option. 2014-01-28 20:29:41 -05:00
Richard C Isaacson
3a7e579bc2 First commit of the at module being very basic. 2014-01-28 20:29:41 -05:00
Matt Martz
07c76d7ec9 Update rax module DOCUMENTATION with new auth options 2014-01-28 13:59:49 -06:00
Brian Coca
46dfe07181 be permissive with BSD with service enabled upper/lower/mixed cases 
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
 2014-01-28 14:49:57 -05:00
James Tanner
3ec043ec17 Fixes #5750 Fail on missing ~/.ssh and ignore accept_hostkey if stricthoskeychecking is off 2014-01-28 11:49:35 -05:00
James Tanner
1584d8f01b Add ec2_vol snapshot example from #4189 2014-01-28 09:58:13 -05:00
jctanner
fca8ec3d3c Merge pull request #4508 from willthames/ec2_vol_snapshot 
Added ability to create EC2 volume from snapshot
 2014-01-28 06:22:14 -08:00
James Tanner
5cbe24913f Fix start/stop example in ec2 2014-01-27 17:48:42 -05:00
James Tanner
1641361057 Merge branch 'feat/ec2_start_stop' of git://github.com/Geryon/ansible into Geryon-feat/ec2_start_stop 2014-01-27 17:39:24 -05:00
Jeff Geerling
bb2cdb11fd Mention shell module in command documentation 
Users who use the command module for pretty much all shell commands may be stymied when they try using a command with <, >, $VAR, etc., and not know that they can use the `shell` module instead. This documentation fix clarifies this.
 2014-01-27 14:56:52 -06:00
jctanner
b8d3c0f865 Merge pull request #5506 from mohangk/fix_elb_register_new_instance 
Fix exception being thrown for new instance registration with ELB
 2014-01-27 12:19:44 -08:00
jctanner
ff6b44e3e4 Merge pull request #5787 from jirutka/fix-sysctl-bool 
sysctl: parse bool value as 0/1 and refactor a little bit
 2014-01-27 11:56:33 -08:00
jctanner
821858ed08 Merge pull request #5380 from dhml/devel 
ec2_group: rules can't reference containing group fix #5309
 2014-01-27 11:41:21 -08:00
Jakub Jirutka
8c9a63bcd0 sysctl: parse bool value as 0/1 and refactor a little bit 2014-01-27 20:26:11 +01:00
Jeff Geerling
40e5f641e4 Update wait_for documentation - remove extra quote 
The timeout is in seconds (int), and the extra quote at the end could throw someone off if they're copying and pasting the example.
 2014-01-27 12:09:54 -06:00
Mohan Krishnan
0f95961e33 Fix exception being thrown for new instance 
Currently if we are trying to register an instance that has not yet
been registered with the elb an exception is thrown.
 2014-01-27 20:18:55 +07:00
willthames
de659af82b Added the ability to add volumes to instances at creation time 
This allows a volume to be cloned from a snapshot, a brand new
volume to be created, or an ephemeral volumes to be associated
at time of instance creation.

This avoids any race conditions associated with creating extra volumes
after instance creation (e.g. writes happening before the volume is
mounted).

In addition, this allows the root volume to be edited
 2014-01-25 12:38:41 +10:00
James Tanner
17f0c9e477 Refactor ec2_elb_lb to use shared module snippet code 2014-01-24 15:33:41 -05:00
James Tanner
512c02b7d2 Fix missing description key 2014-01-24 15:13:01 -05:00
James Tanner
53b7a495ca Merge branch 'add_ec2_elb_lb_module' of git://github.com/jsdalton/ansible into jsdalton-add_ec2_elb_lb_module 2014-01-24 15:11:54 -05:00
Christopher H. Laco
745a480e5c Add rax_queue module to create/delete Rackspace Cloud Queues 2014-01-24 11:14:25 -05:00
Paul Durivage
2090e75e12 Use dict constructors 2014-01-23 22:05:46 -06:00
Paul Durivage
d8bf5033ec Fix revert artifacts, doc update 2014-01-23 22:05:36 -06:00
James Tanner
4b80156267 Standardize some parameters in ec2_key 2014-01-23 22:22:09 -05:00
jctanner
cbb2a4ce9b Merge pull request #5256 from zbal/ec2_keys 
Add ec2_key module.
 2014-01-23 19:14:46 -08:00
Paul Durivage
b24474ae58 Remove dict comprehension; use dict constructor 2014-01-23 21:05:52 -06:00
Paul Durivage
0a0ed538b2 Resolve revert conflicts 2014-01-23 20:43:31 -06:00
Paul Durivage
0cabb2fcc4 Imperfect revert w/ artifacts. 
Revert "Revert "Merge pull request #5540 from angstwad/cf-container-module""

This reverts commit c3408f205e.

Conflicts:
	library/cloud/rax_files
 2014-01-23 20:31:44 -06:00
Paul Durivage
95a436980a Doc updates; fix YAML problems 2014-01-23 19:19:35 -06:00
jctanner
3c455685bc Merge pull request #5603 from willthames/ec2_keypair_not_mandatory 
key_name is not required when creating ec2 instances
 2014-01-23 17:06:23 -08:00
Paul Durivage
48b09d85b4 Revert "Revert "Merge pull request #5496 from angstwad/cf-module"" 
This reverts commit b11d62270f.

Conflicts:
	library/cloud/rax_files_objects
 2014-01-23 18:57:22 -06:00
Paul Durivage
d298d3bfb4 Update documentation; fix YAML problems 2014-01-23 18:56:00 -06:00
James Tanner
b11d62270f Revert "Merge pull request #5496 from angstwad/cf-module" 
This reverts commit a807e3b9c8, reversing
changes made to df8ecdeded.
 2014-01-23 18:27:49 -05:00
James Tanner
c3408f205e Revert "Merge pull request #5540 from angstwad/cf-container-module" 
This reverts commit bedc616f74, reversing
changes made to a807e3b9c8.
 2014-01-23 18:27:33 -05:00
James Tanner
bec35cc0c1 Revert "Fix docstrings in rax_files_objects" 
This reverts commit e759832dd6.
 2014-01-23 18:27:22 -05:00
James Tanner
e759832dd6 Fix docstrings in rax_files_objects 2014-01-23 18:10:17 -05:00
jctanner
bedc616f74 Merge pull request #5540 from angstwad/cf-container-module 
Add module support for Rackspace Cloud Files Containers
 2014-01-23 14:46:11 -08:00
jctanner
a807e3b9c8 Merge pull request #5496 from angstwad/cf-module 
Module support for Rackspace Cloud Files
 2014-01-23 14:26:40 -08:00
jctanner
df8ecdeded Merge pull request #5210 from sivel/rax-dns-record 
rax_dns_record: Add rax_dns_record module
 2014-01-23 14:13:38 -08:00
jctanner
339ab7b077 Merge pull request #5208 from sivel/rax-dns 
Add rax_dns module
 2014-01-23 14:03:44 -08:00
James Tanner
86ba8f4dff Fix git module parameters to conform to code standards 2014-01-23 16:44:17 -05:00
James Tanner
18050d50ec Fixes #4108 Add sshopts and keyfile parameters to the git module 2014-01-23 16:22:43 -05:00
Caleb Brown
19f7db3065 Fix a bug in "hg" module so that pull is not set to a version. 
There is a bug in the `hg` module where if a `tag` is used it won't
properly be able to update to it.

This problem is exhibited on repository where a tag is moved from an
older commit to a newer commit.
 2014-01-23 15:56:36 +11:00
James Cammarata
1ca6e4bbb1 Adding a check for pending tranasctions to the yum module 
Fixes #4649
 2014-01-22 15:19:19 -06:00
Thoai Nguyen
5c4bb5730e reorder usermod options 2014-01-22 15:27:00 -05:00
jctanner
07b6d6ffd6 Merge pull request #5690 from sivel/rax-regex-fix 
rax module: Fix regex match
 2014-01-21 06:54:06 -08:00
jctanner
5e886b8ca6 Merge pull request #5699 from jpmens/un1 
module unarchive: documentation typos
 2014-01-21 06:36:49 -08:00
jctanner
62d96620e1 Merge pull request #5704 from zimbatm/default-grove-service 
notify/grove: set the service to "ansible" by default
 2014-01-21 06:30:32 -08:00
Rene Moser
a412eae9cd digital_ocean: added requirements in DOCUMENTATION 2014-01-21 14:09:21 +01:00
zimbatm
fe4d203b9a notify/grove: set the service to "ansible" by default 2014-01-21 12:44:21 +00:00
Jan-Piet Mens
d0912b84ef documentation typos 2014-01-21 09:03:14 +01:00
Matt Martz
89fbc64b60 Fix regex match, the printf match should work with 0 or more numeric padding characters, not 1 or more 2014-01-20 16:43:42 -06:00
Michael DeHaan
c91ba3a7c7 Merge pull request #5680 from biolds/devel 
Mark stat module as supporting check_mode
 2014-01-20 10:48:52 -08:00
jctanner
297a28aa79 Merge pull request #5333 from mvermaes/yum_fix 
yum module: Attempt #2 to cause yum to fail on invalid url
 2014-01-20 06:45:01 -08:00
jctanner
7b76ad9e62 Merge pull request #5676 from simonz05/bugfix-sysctl-multivalue2 
Correctly compare values returned by 'sysctl -e -n'
 2014-01-20 06:11:29 -08:00
Jakub Jirutka
012e3ae206 Fixes #5679: lineinfile ignores newline in line argument 2014-01-19 02:24:26 +01:00
Laurent Defert
f93b951bdd Mark stat module as supporting check_mode 2014-01-18 22:32:58 +01:00
Simon Zimmermann
3db808c840 correctly compare the values, better func name 2014-01-18 11:04:15 +01:00
Simon Zimmermann
055b404f13 Correctly compare values as returned from 'sysctl -e -n' 2014-01-18 10:50:24 +01:00
Simon Zimmermann
7495095496 fix str format error due to missing '%' in sysctl module 2014-01-17 22:31:12 +01:00
James Tanner
3bd99903a4 Fixes #5661 Handle null values for sysctl parameters 2014-01-17 11:30:07 -05:00
Michael DeHaan
2a46022bc7 Merge pull request #5658 from rishid/devel 
Add support for Scientific Linux for hostname module
 2014-01-16 17:55:24 -08:00
jctanner
450bb37c8c Merge pull request #5655 from scottgilbert/devel 
Allow keystring passed to authorized_key to contain blank lines and comments
 2014-01-16 14:22:57 -08:00
James Tanner
19cb22b6df Fixes #5656 quote values with multiple columns before calling 
the sysctl command. Calling sysctl should also not be true by default
 2014-01-16 16:30:13 -05:00
rishid
34f9349b5e Add support for Scientific Linux for hostname module 
hostname module was lacking support for Scientific Linux, this commit adds it.
 2014-01-16 16:08:51 -05:00
Scott Gilbert
0aedd0c0b2 Allow keystring passed to authorized_key to contain blank lines and comments 2014-01-16 12:14:37 -06:00
James Tanner
2c39576e80 Remove unused variable from authorized_key 2014-01-16 11:46:06 -05:00
jctanner
1f1fa6c09a Merge pull request #5322 from bcrochet/neutron-fip-select 
quantum_* modules: Neutron name change, keeping backward compatibility
 2014-01-16 08:37:38 -08:00
Rene Moser
849aab0a12 apt: fixed pkg=<name>=<version> fails if package is not yet installed. 
Reported and patch provided by https://github.com/msolo. Closes GH-5625.
 2014-01-16 11:05:12 +01:00
willthames
238da3cb02 ec2_elb module: Minor improvements to documentation 
ELB(s) cause a weird formatting behaviour - it appears as EL**s**
Added choices documentation to the state option
 2014-01-16 13:14:44 +10:00
James Tanner
e22af253bb Fixes #5486 Keep authorized key options in tact and ordered 2014-01-15 17:10:10 -05:00
James Tanner
c627358c37 sysctl module: append newline character to lines in the file 2014-01-15 10:25:27 -05:00
Michael DeHaan
6f49642286 All modules should be using /usr/bin/python in the shebang as ansible_python_interpreter processes this (see FAQ). 
Fixing for standardization purposes.
 2014-01-15 09:52:17 -05:00
René Moser
0f2bc0dad8 subversion: use LANG=C to prevent regex failures 
Fixes bug GH-5549.
 2014-01-15 10:05:31 +01:00
Michael Vermaes
c55d144c50 Fail yum on invalid url with .rpm suffix 2014-01-15 12:20:31 +08:00
Matt Paine
d392e067bf Enable changes to ttl of a record to be propogated to route53 2014-01-15 09:51:59 +10:00
jctanner
332d3d6a0e Merge pull request #5490 from rgbj/devel 
user module/OpenBSD: using login_class always makes status 'changed'
 2014-01-14 14:44:51 -08:00
jctanner
7d09c97621 Merge pull request #5472 from RSpiertz/apt_repository 
apt_repository: don't crash if default_file doesn't exist
 2014-01-14 14:26:19 -08:00
jctanner
09f7b11d1d Merge pull request #5435 from jkleckner/fix-mysql-dump-import 
mysql_db module: make dump and import to use port argument
 2014-01-14 13:06:33 -08:00
jctanner
6e39adb89e Merge pull request #5426 from lichesser/debian_release_4565 
setup module: Partial fix for #4565, reporting Debian release version. Works only for Debian 7 and later
 2014-01-14 13:00:08 -08:00
James Tanner
fbba0bb3fc Fixes #5601 Do not append extra args when checking for pip command options 2014-01-14 14:22:37 -05:00
jctanner
2e1d92c2ec Merge pull request #5141 from kisielk/hg 
hg module: Don't modify hgrc when running purge
 2014-01-14 10:24:37 -08:00
jctanner
e4d0ce5b08 Merge pull request #5383 from janitha/devel 
Fixes #5381 bug when easy_install is used with virtualenv
 2014-01-14 08:52:12 -08:00
jctanner
daf90e776e Merge pull request #5349 from sergevanginderachter/httpmonbugfix 
bigip_monitor_http: two small bug fixes
 2014-01-14 08:31:30 -08:00
jctanner
48cebedae1 Merge pull request #5323 from zroger/django-manage-virtualenv-fix 
django_manage module: need not require virtualenv in PATH
 2014-01-14 08:02:36 -08:00
James Tanner
17c50cc81e sysctl module: fail if reloading the file did not succeed 2014-01-14 10:48:57 -05:00
jctanner
9ed379b7f8 Merge pull request #5282 from rhaido/hard_link_fix 
file module: Added to the file module the functionality to force conversion hard link...
 2014-01-14 07:15:46 -08:00
Michael DeHaan
a7fbafe955 Merge pull request #5616 from resmo/fix/zypper_repo 
zypper_repository: claims to support check_mode, but does not.
 2014-01-14 06:02:42 -08:00
Michael DeHaan
5a305a60f7 Merge pull request #5604 from dbrgn/devel 
apt_key module: Case insensitive presence checking
 2014-01-14 06:01:08 -08:00
Michael DeHaan
28013885a1 Merge pull request #5613 from Oneiroi/mysql_user_grant_documentation 
Documentation update to yield example of "WITH GRANT OPTION" which is undocumented previous
 2014-01-14 06:00:22 -08:00
Rene Moser
62fd0b1269 zypper_repository: claims to support check_mode, but does not. Fixes GH-5614. 2014-01-14 14:20:18 +01:00
David Busby
b4f86abafd Documentation update to yield example of "WITH GRANT OPTION" which is undocumented previous 2014-01-14 12:04:32 +00:00
Danilo Bargen
7436da08fe apt_key module: Case insensitive presence checking 
Right now key_present() is case sensitive, only uppercase key IDs work. By using "grep -i", lowercase IDs should work too.
 2014-01-14 01:11:40 +01:00
James Tanner
ca05584495 Fixes #5469 Refactor sysctl module into object oriented code, 
and add a sysctl_set parameter to manage the values in /proc
 2014-01-13 18:53:02 -05:00
willthames
8fb5a66944 keypair is not absolutely required when creating ec2 instances 2014-01-14 09:12:01 +10:00
James Tanner
eeee1e1c5a Set accept_hostkey to False by default in the git module and fail 
early if the key is unknown
 2014-01-11 11:02:01 -05:00
James Tanner
8665b0638a Add an "accept_hostkey" parameter to the git module to help automatically 
accept hostkeys for git repos and prevent task hangs when the key is unknown
 2014-01-11 10:36:45 -05:00
Michael DeHaan
ea4bb9f57d Merge pull request #5562 from sivel/rax-clb-node-to-dict 
rax_clb module: Ensure the id attribute is returned for a node
 2014-01-09 14:58:03 -08:00
Matt Martz
e3adaa648a Ensure the id attribute is returned for a node 2014-01-09 14:05:32 -06:00
willthames
c06b63ce82 Added ability to create EC2 volume from snapshot 
ec2_vol module now takes optional snapshot argument
Added relevant module argument handler and documentation
 2014-01-09 14:40:01 +10:00
inetfuture(Aaron Wang)
64acd60d24 Fix npm documentation typo. 2014-01-09 08:53:17 +08:00
Tyler
2f813f7660 keep /usr/local/etc/rc.conf for backwards compatibility 2014-01-08 14:38:49 -05:00
Tyler
1a655b2dd7 Use /etc/rc.conf.local for sevice configuration on FreeBSD 
/etc/rc.conf.local is the preferred location for system-specific
startup configuration, and /usr/local/etc/rc.conf generally isn’t used.

see:
http://www.freebsd.org/doc/handbook/configtuning-core-configuration.html
 2014-01-08 13:48:11 -05:00
Paul Durivage
a85e021640 Completed documentation and examples 2014-01-08 09:39:29 -06:00
Paul Durivage
e822ddd910 Add rax_files_objects module for Rackspace Cloud Files support 
This squashed commit fixed typos, changed to Py 2.4 compatible exceptions
 2014-01-08 09:36:04 -06:00
Michael DeHaan
7bf2250ddf Merge pull request #5543 from jlund/improved-password-documentation 
Improved the documentation for password generation
 2014-01-07 19:28:11 -08:00
lichesser
7201972a56 Remove debugging code 
I guess this is left over from testing
 2014-01-08 02:34:59 +01:00
Joshua Lund
3b4f3f8ca3 Improved the documentation for password generation 2014-01-07 18:20:39 -07:00
Paul Durivage
41be035a43 Add module support for Rackspace Cloud Files Containers 2014-01-07 17:01:59 -06:00
James Tanner
c8bd14925d Fixes #5369 Do not pass --force-yes to aptitude 2014-01-07 15:53:28 -05:00
James Tanner
dee960716b Fixes #5353 create etc/hostname file in debian if it does not exist 2014-01-07 15:53:16 -05:00
jctanner
7520bac8ce Merge pull request #5404 from sivel/rax-improvements 
rax module: improvements
 2014-01-07 15:52:35 -05:00
Michael DeHaan
1e6926b9ab Merge pull request #5528 from dverhelst/devel 
Adding support for detecting RHEV Hypervisor in ansible_virtualization_type
 2014-01-07 15:51:21 -05:00
jctanner
9a69b1b0ec Merge pull request #5311 from willthames/ec2_refactor 
ec2 modules: Move more responsibility to common EC2 module
 2014-01-06 14:09:38 -08:00
jctanner
aa1f9f24c3 Merge pull request #5264 from drewlll2ll/file-fix 
file module: Fixed missing prev_state == 'directory' in file
 2014-01-06 14:07:07 -08:00
Alan Fairless
7a86083850 Fix postgresql_user to understand PG namespaces 
Previously postgresql_user quoted user supplied identifers to create
grant statements that look like this:

    GRANT SELECT on "tablename" to "user";

Which only works if the tablename is not in a namespace.  If you supply
a namespaced tabelname like "report.revenue" then it creates this
incorrect statement:

    GRANT SELECT on "report.revenue" to "user";

Which will not find the "revenue" table in the "report" namespace, but
will rather look for a table named "report.revenue" in the current
(default public) namespace.  The correct form is:

    GRANT SELECT on "report"."revenue" to "user";

This approach could have the unfortunate effect that code that
previously relied on the other behavior to grant privileges on tables
with periods in their names may now break.  PostgreSQL users
typically shouldn't name tables as such, and users can still access the
old behavior and use tablenames with periods in the if they must by
supplying their own quoting.
 2014-01-04 15:37:08 -06:00