James Tanner
ce29c158a9
Address #4573 Check interface keys and return gracefully on solaris zones
2013-11-06 18:11:22 -05:00
Jim Richardson
bbfe11fc1e
return True/False from remove_job_file()
...
revised fix for https://github.com/ansible/ansible/issues/4795
2013-11-04 14:14:53 -08:00
Jim Richardson
bcc08564e7
fix for https://github.com/ansible/ansible/issues/4795
...
Incorrect changed result in cron module.
Report changed=False if no cron is removed:wq
2013-11-03 17:43:51 -08:00
Hiroaki Nakamura
abed2c47fa
Fix for RHEL6.
2013-11-01 23:32:14 +09:00
Michael DeHaan
3705f41992
Merge pull request #4754 from mscherer/fix_4648
...
Fix 4648, cron module is not working on solaris
2013-10-31 14:49:25 -07:00
Michael DeHaan
d34a26e307
Undo an inadvertant revert from template changes so we still allow pythonic imports in module land.
2013-10-31 16:53:05 -04:00
Michael Scherer
9e7b02aaee
make cron module work on solaris
...
Cron on solaris do not take the same
set of option than vixie cron on linux, and
among the biggest difference, root cannot set
the crontab of a user directly from a file. Thus the
use of su to run the crontab command. Fix issue #4648
2013-10-31 19:58:26 +01:00
Michael Scherer
506ce6a809
remove unused function
2013-10-31 19:58:26 +01:00
Scott Dunlop
dbc1e20462
add "zle" as a supported ZFS compression type
...
ZFS supports "zle" compression, which compresses runs of null bytes efficiently.
2013-10-31 10:48:41 -07:00
James Tanner
d154bf8781
Revert templating enhancements from 73dbab70
e6c28658
d409352c
9858b1f2
4587528b
9b1fe455
214b0b05
8d3db803
7f9504d1
5031104c
35cb9dc2
2bd8cb57
1e85c754
2013-10-30 10:50:16 -04:00
jctanner
a1fcaf5c61
Merge pull request #4715 from mscherer/fix_4702
...
Fix #4702 , make setup work on windows
2013-10-29 06:03:49 -07:00
Michael Scherer
3f0b3a71ca
Fix #4702 , make setup work on windows
2013-10-28 23:41:18 +01:00
James Cammarata
0e9184eefd
Fixing authorized_keys module to make the key part detection better
...
Fixes #4677
Fixes #4657
Fixes #4599
2013-10-28 13:52:45 -05:00
Christian Berendt
2848cf34fc
changing permissions of modules to 0644
2013-10-28 14:50:35 +01:00
Michael DeHaan
3badedc983
Merge pull request #4424 from localvoid/firewalld-rich_rules
...
Add support for Rich Rules in firewalld module
2013-10-27 08:55:22 -07:00
Michael DeHaan
d0904ded84
Merge pull request #4600 from earchibald/devel
...
Added ['date_time']['tz_offset'] using %z to get the time offset rather ...
2013-10-27 08:30:28 -07:00
Michael DeHaan
b725361bce
Merge pull request #4560 from tronner/issue4461
...
Fix illegal set operation in FreeBSD section of user module.
2013-10-26 11:31:20 -07:00
Michael DeHaan
9858b1f2f3
Enable imports to work on a snippet based system, allowing for instance a library of common EC2 functions
...
to be reused between modules. See library/system/service and library/system/ping for initial examples. Can
work the old way to just import 'basic', or can import the new way to import multiple pieces of code from
module_utils/.
2013-10-26 11:09:30 -04:00
James Tanner
40574c1938
Fixes #4448 reloaded services should be started if not running
2013-10-25 15:30:02 -04:00
James Cammarata
aa0577c211
Merge branch 'fix_autorized_keys' of https://github.com/mscherer/ansible into mscherer-fix_autorized_keys
2013-10-24 20:13:38 -05:00
James Cammarata
b58b287fce
Fixing up authorized_keys to accept comments with spaces
2013-10-24 20:12:56 -05:00
Michael Scherer
951a91723d
make sure that options are quoted, as people can add a shell
...
script there with a comma that would produce invalid configuration
upon being wrote again
2013-10-24 23:51:55 +02:00
Michael Scherer
7672e9fef8
sort the option_key to have a constant predictable line
2013-10-24 23:47:34 +02:00
Michael Scherer
264945a1f7
adding a single comma at the end of the options list confuse the module
...
it start to duplicate line, because this create
a empty option in the list, and so the module add a new line along the previous
one. See
>>> ' a,b, '.strip().split(',')
['a', 'b', '']
2013-10-24 23:46:49 +02:00
Scott Sturdivant
4d24e2e29f
If the output of rcvar isn't a key=value pair, ignore it.
2013-10-21 14:20:54 -06:00
Eugene Archibald
30eb5c7342
Fixed (broken) tab to (correct) spaces for indentation
2013-10-19 17:04:37 -07:00
Michael DeHaan
21d4400c96
Misc pep8 fixes
2013-10-19 13:03:15 -04:00
Michael DeHaan
75e0a1c6de
Merge pull request #4592 from mscherer/fix_4586
...
setup module, replace ':' by '_' in interface name, fix #4586
2013-10-19 09:07:56 -07:00
Eugene Archibald
145c0b8be1
Added ['date_time']['tz_offset'] using %z to get the time offset rather than time zone.
2013-10-18 20:32:35 -07:00
Michael Scherer
d5c290b513
fix logic in module host to add aliases even if none exist already, fix #4563
...
self._has_aliases is used to know if a alias already exist, but
the test we want is to know if we need to add a new alias, which
is stored in self.aliases
2013-10-19 01:51:42 +02:00
Michael Scherer
fc211ac1a0
setup module, replace ':' by '_' in interface name, fix #4586
2013-10-19 00:24:07 +02:00
James Tanner
4f674ec522
Fixes #4554 Enumerate user homedir if not passed as an argument
2013-10-17 13:15:32 -04:00
Thomas Ronner
aee68511e6
Fix illegal set operation in FreeBSD section of user module.
2013-10-17 15:02:23 +00:00
jctanner
7e8e186b3b
Merge pull request #4517 from adfinis-sygroup/devel
...
Remove keys regardless of the options
2013-10-16 17:40:43 -07:00
James Tanner
23cbdba65e
Fixes #4350 Create homedirectory if create=yes and directory is missing
2013-10-16 20:08:41 -04:00
Hiroaki Nakamura
54243dc8f5
Add support for Fedora, OpenSUSE and ArchLinux.
...
Tested under Fedora 19 and OpenSUSE 12.3. Not tested on ArchLinux.
2013-10-16 01:15:47 +09:00
Hiroaki Nakamura
8c5eb96de4
Do not use shortcut conditional operator which is not supported in Python 2.4.
2013-10-15 23:41:49 +09:00
James Cammarata
35284818a9
Handle ssh key files that may only have a type/key specified
...
If a specified key did not have a comment, it would be ignored as
an invalid key.
Fixes #4513
2013-10-15 09:05:50 -05:00
Stefan Heinemann
af704562a9
Set the options of an authorized key comma separated
...
According to the sshd man page, no spaces are permitted between the
options of an authorized ssh key
2013-10-15 15:29:52 +02:00
Stefan Heinemann
346d46a94c
Don't mind the options of a key when removing it
...
This allows to remove a key without knowing the options in the
authorized_key file
2013-10-15 15:29:47 +02:00
Michael DeHaan
6ff4806b90
Merge branch 'devel' of git://github.com/shirou/ansible into devel
2013-10-14 11:50:25 -04:00
Keith Buck
36a8312de6
Improve the formatting and content for the sysctl module's description.
2013-10-14 07:16:47 +00:00
James Cammarata
49130c688d
Adding 'unique' option to authorized_key module and cleanup
...
A small refactoring of the authorized_key module to accomodate these
changes, plus fixing some things like not rewriting the file on every
new key. These changes bring the original feature for ssh options in-
line with the comments in #3798
Fixes #3785
2013-10-11 16:22:37 -05:00
David Minor
ed7d3f92a0
Add ssh key options parameter to authorized_key module
2013-10-11 16:22:37 -05:00
James Tanner
e3849f1be7
Fixes #4312 for older versions of usermod which do not have --append
2013-10-11 09:10:46 -04:00
Michael DeHaan
119b6d73dd
Remove examples of module antipattern of setting the choices array for boolean types.
2013-10-11 08:45:13 -04:00
Boris Kaul
5a34e572f5
Add support for Rich Rules in firewalld module
2013-10-10 20:09:52 +07:00
Boris Kaul
194a7dab9f
Fix timeout bug in firewalld module
2013-10-10 13:41:42 +07:00
James Tanner
b7f229d390
Second attempt at preventing ipv6 route enumeration on EL4 machines
2013-10-08 18:40:15 -04:00
James Tanner
4b1600aae5
Revert "Do not enumerate ipv6 routes in CentOS 4"
...
This reverts commit 5186c408f7
.
2013-10-08 15:51:12 -04:00
James Tanner
5186c408f7
Do not enumerate ipv6 routes in CentOS 4
2013-10-08 15:12:38 -04:00
Michael DeHaan
135f79f337
Add documentation about how passwords are generated.
2013-10-08 08:36:48 -04:00
James Cammarata
a2ac5d6df2
Better detection/categorization of ipv4 secondaries/virtual IPs
...
Fixes #3916
Fixes #3478
2013-10-07 15:18:33 -05:00
Michael DeHaan
c5672cf16e
Merge pull request #4389 from MattTheRat/devel
...
addresses #4371 - adds -m to usermod commands
2013-10-07 12:15:20 -07:00
Matt Warren
74c412e249
addresses https://github.com/ansible/ansible/issues/4371 - adding -m to home directory modification
2013-10-07 10:47:12 -04:00
Michael DeHaan
f6c3dce497
Merge pull request #4336 from orkaa/devel
...
Fixes service update-rc.d functionality on debian
2013-10-07 05:56:43 -07:00
Martijn Lina
4cd3b9d637
replace dashes in rc.conf keys (which are based on freebsd rc.d filenames) to underscores
2013-10-04 16:30:39 +02:00
Skylar Saveland
b47add0f32
fixes 4365 - Mac with cisco vpn client, GenericBsdIfconfigNetwork get_default_interfaces fails with index out of range
2013-10-03 18:58:11 -07:00
Adam Miller
323e8d4a8c
fixed firewalld get_service_enabled
2013-10-02 18:52:53 -05:00
Nace Oroz
672a0c04e4
Fixes service update-rc.d functionality on debian
2013-10-02 14:27:38 +02:00
cdigiovanni
7ff2b3befd
Added support to disable and enable upstart jobs
2013-09-30 14:50:47 -05:00
Brian Harring
f88fed2060
Enforce umask for cron module, so cron_file generated files are 0644.
...
Certain cron implementations get cranky if files in cron.* are group
writable.
2013-09-30 13:21:07 -04:00
Nils Pascal Illenseer
4ee6c6d5df
Add option 'lz4' for compression
2013-09-30 14:20:21 +02:00
Cristobal Rosa
617f7bb0a0
Added an space between code and comments in order to follow the coding standars
2013-09-28 00:02:43 +02:00
Cristobal Rosa
be279295b6
Added a new check to check whether an network interface is in promiscuous mode
2013-09-28 00:02:06 +02:00
James Cammarata
9dd2d1eb13
Merge pull request #4222 from lessmian/devel
...
Module lvol fails when decimal point is a colon
2013-09-25 14:54:58 -07:00
James Cammarata
301a00ccf5
Merge branch 'obsd-fix-release' of https://github.com/johanwiren/ansible into johanwiren-obsd-fix-release
2013-09-25 14:49:57 -05:00
James Cammarata
23417368df
Fixing up some open_iscsi docs and CHANGELOG update
2013-09-25 14:37:56 -05:00
James Cammarata
c98ed252fe
Merge branch 'open_iscsi_bis' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-open_iscsi_bis
2013-09-25 14:35:01 -05:00
Tomasz Lesniewski
385ffcdfb1
Module lvol fails when decimal point is a colon
2013-09-24 16:19:07 +02:00
Rene Moser
ff84812047
host: minor doc style improvements
2013-09-24 15:47:39 +02:00
Tomasz Lesniewski
e2815a56dc
Module lvol fails when decimal point is a colon
2013-09-24 15:06:18 +02:00
Michael DeHaan
314e1aafc1
Merge pull request #4220 from dagwieers/setup-dmidecode-fix
...
Fix for commented dmidecode output
2013-09-24 05:04:33 -07:00
Dag Wieers
5bd7664fac
Fix for commented dmidecode output
...
This patch fixes the problem that on some system dmidecode prints out warning information as commented text. For example:
[user@system ~]# dmidecode -s system-manufacturer
# SMBIOS implementations newer than version 2.6 are not
# fully supported by this version of dmidecode.
HP
So we remove all commented lines from the output.
2013-09-24 12:46:48 +02:00
Rene Moser
803b2b91a6
host: added another example
2013-09-24 09:15:16 +02:00
James Cammarata
a6d62ef59b
Minor pep8 cleanup
2013-09-23 16:37:42 -05:00
James Cammarata
4420379f59
Fixing some bugs found during testing in the host module
2013-09-23 16:05:43 -05:00
James Cammarata
da0d50c383
Merge branch 'feature/host' of https://github.com/resmo/ansible into resmo-feature/host
2013-09-23 15:42:30 -05:00
James Cammarata
a8fac7906d
Merge branch 'devel' of https://github.com/drybjed/ansible into drybjed-devel
2013-09-23 15:10:40 -05:00
James Cammarata
c31ece58fa
Added version_added string to new modprobe module and CHANGELOG update
2013-09-23 15:02:02 -05:00
James Cammarata
4d7b5da25d
Merge branch 'modprobe-module' of https://github.com/stygstra/ansible into stygstra-modprobe-module
2013-09-23 15:00:50 -05:00
James Cammarata
d1f713938e
Modified env fact gathering to use the native python method
...
Also updated CHANGELOG for this feature
2013-09-23 14:17:40 -05:00
James Cammarata
19343288df
Merge branch 'env_facts' of https://github.com/bcoca/ansible into bcoca-env_facts
2013-09-23 13:46:11 -05:00
Maciej Delmanowski
551b93c547
Made re.search string shorter
2013-09-23 12:27:14 +02:00
Maciej Delmanowski
40b0471e95
Add Linux Container identification
2013-09-23 12:15:33 +02:00
Johan Wirén
e9554e5da2
Fixed setup module to no longer break on OpenBSD release versions.
2013-09-22 14:05:22 +02:00
James Cammarata
4efdf0d49f
More housekeeping
...
* Modified version_added strings in recent modules
* Added firewalld inclusion to the CHANGELOG
2013-09-21 01:06:34 -05:00
James Cammarata
8721ad2909
Moving firewalld module from net_infra to system
2013-09-21 01:02:19 -05:00
René Moser
0ba7acd205
host: code cleanup
2013-09-20 22:50:03 +02:00
James Cammarata
c2e02fbd6b
Minor tweak to service changed logic from the previous commit
2013-09-19 15:00:25 -05:00
James Cammarata
f62093da56
Merge branch 'service-enable-fix' of https://github.com/gottwald/ansible into gottwald-service-enable-fix
2013-09-19 14:59:53 -05:00
Petr Svoboda
8d290e3394
Fix traceback in service module when svc_cmd is None (2nd fix)
...
When service module is used on unsupported Linux system where init
script is used directly, LinuxService.svc_cmd is None so .endswith()
fails.
This extends fix from e2f20db534
also
for state=restarted.
Fixes issue #3533
2013-09-19 14:36:02 -05:00
René Moser
bcaab4236b
host: updated version_added
2013-09-19 20:09:38 +02:00
Rene Moser
7f96dd832f
added module host
...
Add or remove entries in /etc/hosts using tasks:
- host: ip=127.0.0.1 hostname=localhost aliases=foobar.com,localhost.foobar.com
- host: ip=127.0.0.1 hostname=localhost state=present
- host: ip=192.168.1.1 state=absent
- host: hostname=localhost state=absent
- host: ip=::1 hostname=localhost aliases=ip6-localhost,ip6-loopback
2013-09-19 20:09:38 +02:00
David Stygstra
58620ca477
Add Python 2.4 support to modprobe module
2013-09-19 00:04:20 -04:00
David Stygstra
27a08dc647
Module to manage kernel modules
2013-09-19 00:02:44 -04:00
James Cammarata
f4c5f37ca6
Merge branch 'issue_3417_systemd_stuff' into devel
2013-09-16 09:30:39 -05:00
James Cammarata
02033f9ec8
Merge branch 'archlinux-fact' of https://github.com/Schnouki/ansible into Schnouki-archlinux-fact
2013-09-16 07:45:38 -05:00
r-p-e
2f887c6dca
Add some more OpenBSD facts
...
added:
* ansible_distribution
* ansible_distribution_release
* ansible_distribution_version
2013-09-15 17:58:29 +02:00
Ingo Gottwald
f7adbf2f29
Bugfix service module: Only change service state when needed
2013-09-13 22:04:37 +02:00
Thomas Jost
dfb10e646e
Add Archlinux "distribution" fact
2013-09-12 11:55:08 +02:00
James Cammarata
72eaa0570e
Allow service module to manage services not ending in .service
...
Fixes #3417
2013-09-11 15:48:36 -05:00
James Cammarata
5110b2d440
Slight refactorization of the sysctl module
...
* Added in support for freebsd-style sysctl commands
* Replaced some functionality that was provided by module_common
* Simplified some logic in a couple of places (ie, not checking
a split with len() but instead limiting the split to 1)
Fixes #3380
2013-09-11 13:15:17 -05:00
James Cammarata
3e9b63febd
Compare exploded values in the sysctl module to avoid whitespace errors
...
Fixes #3931
2013-09-10 23:24:24 -05:00
James Cammarata
b2741f451e
Fixes to the service module for Ubuntu 12.04 (LTS)
...
Fixes #3615
Fixes #3572
2013-09-10 22:19:15 -05:00
James Cammarata
9a3a3e648b
Check for systemd ownership of a service even if an init.d script exists
...
Also slight modification to the error message in the earlier commit that
modified the update-rc.d detection portion of the code
Fixes #3474
2013-09-10 19:37:51 -05:00
James Cammarata
7c8aa669cf
Minor fix to account for template service names in systemctl
2013-09-10 11:31:13 -05:00
James Cammarata
6c3af4df81
Fix for update-rc.d based systems that also have systemd installed
...
By default, the service module had assumed that if the system had the
update-rc.d binary, the service was either managed via upstart or standard
sysV init-style scripts. This patch adds a check for systemctl ahead
of the other methods when update-rc.d is detected, and also simplifies
the logic around the detection of systemctl-managed services
2013-09-10 11:15:30 -05:00
James Laska
546788a1b6
The required package for selinux is libselinux-python
2013-09-06 16:26:48 -04:00
Brian Coca
c2d1607490
Added collection of user's env
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-09-06 08:55:37 -04:00
James Cammarata
82e1722fff
Merge branch 'aix_wpar_facts' of https://github.com/mplonka/ansible into mplonka-aix_wpar_facts
2013-09-05 23:49:29 -05:00
James Cammarata
26a8d4ce9f
Added 'reloaded' state to list of states checked for bounced services
...
Fixes #3556
2013-09-03 09:49:19 -05:00
Serge van Ginderachter
a351c25c59
Introduce open-iscsi module to manage targets on the initiator.
2013-09-03 13:31:28 +02:00
Raul Melo
461858e476
Fix issue 3908. There was some ilegal operations over the sets
2013-08-27 17:07:42 +02:00
James Cammarata
ceddc37f07
Fix for the cron module on FreeBSD
...
Apparently crontab on freebsd does not like the file path coming before
the "-u username" portion of the command to install the crontab
2013-08-24 21:37:10 -05:00
Hiroaki Nakamura
a0da0afe00
Fix a bug in DebianStrategy.get_permanent_hostname(). Use strip, not split!
2013-08-25 07:46:23 +09:00
Hiroaki Nakamura
4f91238e34
Rewrite with "try ... finally" instead of "with" statement to support Python 2.4.
2013-08-25 07:44:18 +09:00
Hiroaki Nakamura
3b1d7d88b5
Remove extra sysloggings.
2013-08-25 07:35:20 +09:00
Hiroaki Nakamura
f4ba0e78a4
Raise an error on unsupported platform/distributions.
2013-08-25 07:32:37 +09:00
Hiroaki Nakamura
ce2b37e2ff
Add a hostname module, which sets system's hostname.
2013-08-25 00:49:15 +09:00
Marcin Płonka
61298e4703
Skipping facts not available on AIX WPARs
2013-08-24 07:24:05 +02:00
shirou
e18ede85a0
supports nested values of ohai.
2013-08-23 17:00:56 +09:00
Michael DeHaan
5e049a5df7
Merge branch 'fix_service_with_initscript' of git://github.com/psvo/ansible into devel
2013-08-10 18:05:35 -04:00
Andy Wilson
bc30203abe
docfix: grammar in docstring for sysctl module
2013-08-08 12:23:30 -05:00
Petr Svoboda
e2f20db534
Fix traceback in service module when svc_cmd is None
...
When service module is used on unsupported Linux system where init
script is used directly, LinuxService.svc_cmd is None so .endswith()
fails.
Fixes issue #3533
2013-08-08 14:24:20 +02:00
Michael Scherer
cfa5a0f94d
Add urpmi as a package manager for mandriva-based distribution
2013-08-04 00:03:50 +02:00
James Cammarata
e32a6110af
Removing skipped=True so the task is just marked as not-changed
2013-08-03 12:15:09 -05:00
James Cammarata
d98ad7b374
Set result to skipped when vol group is missing and lv state=absent
...
Fixes issue #3714 - lvol module state=absent fails (with error) if
the volume group doesn't exist
2013-08-02 20:32:56 -05:00
rishid
07ef8c4d84
Verify groups string is not empty before trying add user to groups
2013-08-01 21:19:11 -04:00
Brian Coca
0ae7bcf3e2
fixed bug from prev update
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-08-01 00:24:34 -04:00
Brian Coca
1e1f117886
whitespace updates on new lines
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-07-31 23:26:28 -04:00
Brian Coca
d8e8aa714e
now uses get_bin_path for lvg executables
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-07-31 22:32:41 -04:00
Michael DeHaan
8cc13590b4
Make exceptions handling python 2.4 compatible.
2013-07-29 13:27:16 -04:00
Michael DeHaan
fc9aa5f014
Continue on mount errors, don't fail the setup module.
2013-07-22 13:57:35 -04:00
Brian Coca
3f85a82ae9
use global to fail as its not in self
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-07-22 10:54:20 -04:00
Michael DeHaan
1acd9b6325
Update CHANGELOG
2013-07-21 10:12:28 -04:00
Michael DeHaan
e589365279
Merge branch 'iss_cron' of git://github.com/dirtyharrycallahan/ansible into dh_cron
2013-07-21 10:00:11 -04:00
Michael DeHaan
588b20c012
Merge pull request #3602 from bcoca/fine_tune_stat_exception
...
narrowed down exception
2013-07-20 09:45:31 -07:00
Michael DeHaan
3b3b600a98
Merge pull request #3470 from langemeijer/devel
...
Only append non_unique parameter if a uid is provided as well to user module
2013-07-20 09:11:52 -07:00
Brian Coca
b7b1c714f9
narrowed down exception we ignore and fail if any other unexpected one
...
crops up.
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-07-20 11:51:52 -04:00
Florian Tham
ceff31241b
fix fatal error when removing logical volumes
2013-07-19 10:59:11 +02:00
Antti Rasinen
7b8f24adda
Make zfs set_property accept values with embedded spaces
...
Converting the argument list to a string with ' '.join causes
the shell interpreter to misparse spaces in property values.
Since the zfs command does not need shell anywhere, using
a list instead of a string works just as well with run_command.
Fixes #3545 .
2013-07-16 14:01:14 +03:00
Antti Rasinen
7670572578
Fix zfs property parsing
...
Current property parser breaks when values contain spaces. Since
zfs get -H returns tab separated lines, it is better to explicitly
split on tabs than on whitespace.
2013-07-16 13:49:19 +03:00
trbs
38b6087495
fix missing json module for issue #3363 print JSON error as string instead
2013-07-15 16:50:31 +02:00
Brian Coca
80b9b01e97
now won't throw exception if we don't have permission to stat a mtab
...
entry on linux (weird chromebook issue)
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-07-14 22:59:24 -04:00
Michael DeHaan
8fe15f0a30
Merge pull request #3426 from trbs/services_sleep_option
...
sleep option for service module which adds a pauze between stopping and ...
2013-07-12 08:18:22 -07:00
Michael DeHaan
3a84254f6d
Merge pull request #3496 from johanwiren/bsd-ipv6-facts
...
Fix for populating default_ipv6 on BSD systems
2013-07-11 05:55:53 -07:00
Michael DeHaan
d1398594ce
Merge pull request #3497 from johanwiren/bsd-gateway
...
Updated setup module to collect gateway fact for BSD systems
2013-07-11 05:55:26 -07:00
Michael DeHaan
952760c605
Merge pull request #3388 from bcoca/fixed_user_create_doc
...
updated module docs to reflect 'correct' on_create vs on_creation
2013-07-11 05:34:37 -07:00
Johan Wirén
1c247c9eb4
Updated GenericBsdIfconfigNetwork to collect gateway
2013-07-11 00:05:53 +02:00
Johan Wirén
10e9194744
Fix for populating default_ipv6 on BSD systems
2013-07-10 22:54:33 +02:00
Joshua Lund
cc275ca2be
Added a new with_file example to the authorized_key documentation
2013-07-10 14:09:03 -06:00
Patrick Callahan
8f14ffe56b
Bug fixes and enhancements.
...
Bugs:
(1) no longer allow empty jobs
(2) strip the header added by crontab package used in openSuSE and SuSE
(3) try not to leak temp files when things go wrong
(4) issue returning job names under certain conditions
Enhancements:
(1) Allow all special times not just reboot.
(2) Fail earlier by performing more input validation
(3) Add feature to allow removing cron file under /etc/cron.d
ToDo:
(1) Validate times (minute, hour, ...)
(2) Strip white space from fields such as name and job such that name=foo equals name=' foo'.
(3) More testing
2013-07-09 03:21:40 +00:00
Brian Coca
0664e36aa2
fixed check mode
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-07-08 15:41:39 -04:00
Casper Langemeijer
922a71fced
Only append non_unique parameter if a uid is provided as well
2013-07-08 11:46:38 +02:00
Aaron Brady
efc4bc10d4
Make the CPU facts Hyperthreading aware
2013-07-03 16:25:35 +01:00
trbs
3b2173b6df
sleep option for service module which adds a pauze between stopping and starting a service using state=restarted. This helps for bad scripts that exist immediatly after signaling a process to stop.
2013-07-03 17:08:07 +02:00
Antti Rasinen
93fc3391fe
Fix service enable on FreeBSD
...
Some services have a knob (i.e. rc.conf setting) whose name
differs from that of the script. For example, lockd process
is controlled with a script called lockd, but the rc.conf
value is rpc_lockd_enable.
Fixes issue #3382 .
2013-07-03 14:52:23 +03:00
Brian Coca
9f75397310
updated module docs to reflect 'correct' on_create vs on_creation
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-06-30 20:32:05 -04:00
Michael DeHaan
15bf8a8398
Merge pull request #3315 from madduck/fix-service-updatercd-changed
...
Let update-rc.d set changed flag properly
2013-06-30 16:09:39 -07:00
Michael DeHaan
681696846a
Styling: semicolon
2013-06-30 18:56:03 -04:00
Michael DeHaan
fc8ffc1864
Styling: blank lines
2013-06-30 18:52:33 -04:00
Serge van Ginderachter
f000dcd526
add more support for different size formats
2013-06-24 22:37:31 +02:00
martin f. krafft
85b8538e0e
Expand usage of Python 2.6 if statement
...
Syntax like "'foo' if bar else 'baz'" is not supported by all Python
versions targetted by Ansible. Hence we break it up.
Signed-off-by: martin f. krafft <madduck@madduck.net>
2013-06-23 09:19:27 +02:00
martin f. krafft
3df2e15277
Let update-rc.d set changed flag properly
...
When update-rc.d is used to enable/disable service, the changed flag was
always true (see #2189 ). This commit fixes that.
Signed-off-by: martin f. krafft <madduck@madduck.net>
2013-06-22 20:04:37 +02:00
Michael DeHaan
3f8aa8aec5
Fix up some module docs formatting errors.
2013-06-19 22:37:09 -04:00
Patrick Callahan
b5b862fe6f
bug fix: modify get_device_facts to handle servers with multiple pci domains
...
On machines with multiple pci domains get_device_facts would fail to
find a matching pci device causing setup to fail. Also on some platforms
there is additional information between the pci information and 'host'.
Modified get_device_facts to call lspci with the -D option and modified
the regex to account for the pci domain and to be more selective.
2013-06-18 22:48:05 -04:00
Michael DeHaan
575e052c6c
Merge pull request #3147 from toshywoshy/setup_mtab_without_bind
...
changed get_mount_facts to ignore mount types 'none'
2013-06-18 17:56:49 -07:00
Michael DeHaan
61ac8d03af
Clarify module docs
2013-06-18 20:19:29 -04:00
Michael DeHaan
51ba3d8c3d
Merge pull request #3230 from sayap/openrc
...
Add OpenRC support to the service module.
2013-06-18 17:13:06 -07:00
Brian Coca
c9c7b01620
now mount/unmount are searched for instead of hardcoded
...
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-06-17 17:01:35 -04:00
Yap Sok Ann
bcca609bc6
Add OpenRC support to the service module.
2013-06-17 11:29:48 +08:00
Michael DeHaan
fe9849530c
Merge pull request #3120 from chrisgardner/solaris-os-facts
...
Add Solaris O/S distribution facts
2013-06-16 20:18:43 -07:00
Michael DeHaan
2eb3a9a3c9
Resolve docs conflict.
2013-06-16 22:48:11 -04:00
Michael DeHaan
572f49b11f
Fix merge conflict.
2013-06-16 22:47:29 -04:00
Michael DeHaan
c3544de1df
Merge pull request #3228 from skvidal/facts.d
...
first cut and docs for facts.d mechanism for setup module
2013-06-16 19:46:02 -07:00
Michael DeHaan
936e61fc28
Merge pull request #3181 from melodous/devel
...
HP-UX virtualization facts
2013-06-16 19:26:07 -07:00
trbs
a4223e119d
fixed x-bits in git
2013-06-16 22:22:16 -04:00
Michael DeHaan
78fdedd490
Merge remote branch 'origin' into devel
...
Conflicts:
library/web_infrastructure/django_manage
2013-06-16 22:15:30 -04:00
Michael DeHaan
f0d66f0cda
Merge pull request #3176 from jpmens/sol-epoch
...
setup epoch time doesn't have tics on Python 2.6.4 (Solaris).
2013-06-16 19:06:19 -07:00
Seth Vidal
36df7e8c95
cut and docs for facts.d mechanism for setup module
2013-06-15 18:31:31 -04:00
Jan-Piet Mens
5c69918d53
DOCS: standardize on EXAMPLES (a.k.a. Docs-JumboPatch JetLag Edition)
...
Migrated all examples: in DOCUMENTATION=''' string to standalone EXAMPLES=''' string
Added deprecation warning to moduledev.rst and remove deprecated example from it
Fixed up a few typos and uppercased some acronyms.
add consistency to how EXAMPLES are formatted
2013-06-15 20:54:25 +02:00
Raul Melo
f9f0f5ce2c
HP-UX virtualization facts
2013-06-12 18:59:20 +02:00
Jan-Piet Mens
f6521d88f5
setup epoch time doesn't have tics on Python 2.6.4 (Solaris).
2013-06-11 09:13:32 +02:00
Jan-Piet Mens
3f301fd439
Protect None value in setup module
2013-06-11 07:08:55 +02:00
Michael DeHaan
790a145f6c
Use get_bin_path for blkid and add some aliases to the filesystem module.
2013-06-10 10:39:19 -04:00
Joshua Lund
51c7441244
Updates to the authorized_key documentation
...
* Clarified the meaning of 'user'
* Changed 'sshdir' to 'path' in the example
* 'sshdir' is used internally in the module, but the argument is 'path'
* Made the capitalization consistent in the descriptions
2013-06-07 15:43:42 -06:00
Toshaan Bharvani
f76043f404
changed get_mount_facts to ignore mount types 'none'
2013-06-07 16:55:33 +02:00
Raul Melo
2475bc416c
Facts for HP-UX
2013-06-05 14:01:18 +02:00
Chris Gardner
2ba47318dc
Use first line from /etc/release in "distribution_release" for consistency across Solaris and derivatives.
2013-06-03 22:33:01 +01:00
Michael DeHaan
788680a15d
Merge branch 'devel' of git://github.com/trbs/ansible into more_users
2013-06-03 11:50:17 -04:00
Michael DeHaan
c3ff4ccb35
These options to bypass the check code seem to need to occur before said checks.
2013-06-01 18:32:02 -04:00
Chris Gardner
f0a4a17ff6
Add Solaris O/S facts "distribution" and "distribution_*"
2013-06-01 20:32:28 +01:00
Michael DeHaan
caa07e7fab
pep8 fixes
2013-06-01 12:29:03 -04:00
Michael DeHaan
15560c9801
Fix module labelled incorrectly.
2013-06-01 12:25:24 -04:00
Michael DeHaan
d434252ba4
Docs standardization
2013-06-01 12:20:45 -04:00
Michael DeHaan
417be6f81e
Docs standardization
2013-06-01 12:16:24 -04:00
Michael DeHaan
b9e72cdd98
Warn when there is a space in the mount module opts parameter.
2013-06-01 11:33:17 -04:00
trbs
3b3afe2283
Add support for Open and NetBSD platforms for user and group modules, including a new login_class parameter for FreeBSD, OpenBSD and NetBSD.
2013-05-31 20:53:37 -04:00
Michael DeHaan
9122efb24a
Merge pull request #3083 from mvo5/feature/facts-add-statvfs
...
add "size_{total,free}" to the "mount" facts
2013-05-31 14:22:58 -07:00
Michael DeHaan
049b77be6d
Merge pull request #3076 from mmoya/userspace-arch-facts
...
Provide userspace_{architecture,bits} facts
2013-05-31 14:20:38 -07:00
Michael DeHaan
514f18acac
Merge branch 'solaris-network-facts' of git://github.com/chrisgardner/ansible into devel
2013-05-31 17:16:13 -04:00
Michael DeHaan
47b9db0d98
Remove debug statement in previous patch.
2013-05-31 17:13:54 -04:00
Michael DeHaan
eec53347b5
Merge branch 'devel' of git://github.com/trbs/ansible into groups
2013-05-31 17:13:41 -04:00
Stephen Fromm
43d96ba335
cleanup to dmi fact discovery
...
When invoking dmidecode, first use module.get_bin_path() and secondly
use module.run_command.
Remove sub function execute() from get_dmi_facts().
Simplify get_dmi_facts() by only using two mechanisms to determine dmi
facts: first try /sys/devices/virtual/dmi and if not available, use
dmidecode executable.
2013-05-31 17:10:34 -04:00
Michael DeHaan
d078ad5a13
Merge pull request #3068 from lorin/authkey-default
...
authorized_key: Set manage_dir default value
2013-05-31 13:16:44 -07:00
Michael DeHaan
4afc0a5c03
Merge pull request #3044 from chrisgardner/solaris_facts
...
Solaris facts
2013-05-31 13:15:58 -07:00
Michael DeHaan
69d514100c
Refine error message.
2013-05-31 15:23:24 -04:00
Michael DeHaan
0b30c74e86
Merge branch 'rc.d-systemd' of git://github.com/glensc/ansible into sysd
2013-05-31 15:20:48 -04:00
Michael Vogt
6acf9a9b3b
use statvfs.f_bavail to match the output of "df -B1"
2013-05-31 21:20:40 +02:00
Michael Vogt
73a12b04a4
add "size_{total,free}" to the "mount" facts
2013-05-31 21:01:45 +02:00
Maykel Moya
d0843a7f55
Provide userspace_{architecture,bits} facts
...
When running inside a chroot userspace architecture might not
match that of the actual host.
This patch provides userspace_bits as reported by python's
platform.architecture(). Also provides userspace_architecture fact
if host is an x86 machine.
2013-05-31 12:24:43 +02:00
Chris Gardner
1b8adab2cc
Add Solaris network facts. IPv4 and IPv6 both working.
2013-05-31 00:57:23 +01:00
trbs
b537aff586
Fix for #3062 additional groups should only be added once.
...
Also consolidated duplicate groups code into one get_groups_set() method.
Removed unused call to user_group_membership.
Removed sorting operations on set functions cause sets are inherently unordered.
Minor style improvements to match the rest of the code.
The new function will make the order of group names passed to the system command less determistic.
Which was already the case for modify_user_usermod() but not for other methods.
It will also strip out duplicate group names automatically which was not always the case previously.
2013-05-30 19:18:18 -04:00
Lorin Hochstein
8c9cceacbf
authorized_key: Set manage_dir default value
...
This commit fixes a bug where the authorized_key module causes
the ~user/.ssh directory to be owned by root instead of the user,
when the manage_dir argument is not specified.
If the manage_dir argument was not specified, the module behaved as if
manage_dir was set to false, even though it's supposed to default to
true.
This module assumed that an optional argument, with no default
specified, will not be present in the module.params dictionary.
What actually seems to happen is that the argument does appear in
the module.params dictionary with a value of None.
The upside is that this line was evaluating to None instead of
true:
manage_dir = params.get("manage_dir", True)
I fixed the problem in this particular module by explicitly specifying
the default value for the manage_dir arugment. But if this bug
occurred because of a change in behavior in AnsibleModule, then other
modules may be broken as well.
2013-05-30 16:16:14 -04:00
Michael DeHaan
ad1a02aa55
Merge pull request #3064 from sfromm/issue2990
...
Verify /proc/modules is readable (issue #2990 )
2013-05-30 11:12:30 -07:00
Stephen Fromm
00b3a450c7
Verify /proc/modules is readable (issue #2990 )
2013-05-30 10:25:48 -07:00
Stephen Fromm
3127bab6d6
Use get_bin_path to find mkfs command (issue #2983 )
2013-05-30 10:25:35 -07:00
Chris Gardner
2b71ab6765
Fix typo. Solaris 9 should now correctly ignore 'brand' and use 'implementation'.
2013-05-30 08:51:03 +01:00
Chris Gardner
88115f4ab2
TODO: Separate IPv4 and IPv6
2013-05-30 08:39:11 +01:00
Jiří Kubíček
5cb0525430
Add some FreeBSD facts
...
added:
* ansible_distribution
* ansible_distribution_release
* ansible_distribution_version
* ansible_os_family
* ansible_pkg_mgr
* ansible_ssh_host_key_ecdsa_public
Also adds ECDSA public key for all plaforms.
2013-05-30 01:34:33 +02:00
Chris Gardner
6809b56233
Add Solaris network facts. IPv6 details overwrite IPv4 per interface, needs further work.
2013-05-30 00:06:57 +01:00
Chris Gardner
f482649cbb
Add clock speed to processor description for SPARC CPU.
2013-05-29 21:00:21 +01:00
Chris Gardner
68959e7f92
Use 'implementation' if 'brand' not available (Solaris 9). Add CPU socket/core counting.
2013-05-29 18:54:43 +01:00
Michael DeHaan
a581077b4d
Merge branch 'facter-fix' of git://github.com/flyapen/ansible into devel
2013-05-29 10:00:20 -04:00
Guillaume Lasmayous
1c0e01a72b
Implement NetBSD-specific subclass of Hardware in the setup module.
...
Defines memory and CPU facts:
- memfree_mb
- memtotal_mb
- swapfree_mb
- swaptotal_mb
- processor (a list)
- processor_cores
- processor_count
- devices
As a matter of fact, on NetBSD, it is possible to get memory, swap and
processor facts exactly as on Linux. Tested on NetBSD-5, NetBSD-6 and
NetBSD-6.1 (without Linux emulation).
2013-05-29 09:37:46 -04:00
Chris Gardner
9ca7165f88
Use kstat for Solaris CPU info
2013-05-28 22:44:06 +01:00
Chris Gardner
66c10410ec
Use kstat for Solaris CPU info
2013-05-28 22:36:49 +01:00
Kristof Keppens
c5b40ca2ff
change fix to lookup path with get_bin_path
2013-05-27 07:38:17 +02:00
Michael DeHaan
698b2fe9c5
Merge pull request #2992 from SirScott/service_pattern
...
Fixes #2991 : Service module pattern argument ignored.
2013-05-24 19:58:42 -07:00
Scott Sturdivant
922a1efbc0
Fixes #2924 : User creation always reports 'changed'
2013-05-23 13:43:23 -06:00
Scott Sturdivant
b274fb9774
Fixes #2991 : Service module pattern argument ignored.
2013-05-23 09:39:26 -06:00
Kristof Keppens
e2e10c1977
fix for facter being installed in a different location
2013-05-23 11:21:01 +02:00
Elan Ruusamäe
d3a2b1dbbb
no need to init None to None
2013-05-19 00:20:10 +03:00
Michael DeHaan
328065506e
Merge pull request #2941 from bcoca/setup_bin
...
no uses get_bin_path for 2nd use of ip tool
2013-05-18 13:22:24 -07:00
Michael DeHaan
39673fe8c0
Merge pull request #2940 from madema/patch-3
...
-o and -r option don't exist on AIX
2013-05-18 13:21:48 -07:00
Ton Kersten
8926684942
Fix issue 2906
2013-05-18 15:57:10 -04:00
Brian Coca
8d6e18fc90
no uses get_bin_path for 2nd use of ip tool (fixes reported issue with openwrt)
...
module needs this added to many tool invokations, but his is a start
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-05-16 08:32:49 -04:00
madema
58d59c180d
-o and -r option don't exist on AIX
2013-05-16 14:30:42 +02:00
Michael DeHaan
6b4f09d7dc
Style fix.
2013-05-11 17:21:49 -04:00
Michael DeHaan
584508dda6
Merge pull request #2866 from madema/patch-2
...
Fixed an error in the get_cpu_facts of the AIX class
2013-05-11 11:10:17 -07:00
Michael DeHaan
dab846a631
Merge pull request #2865 from madema/patch-1
...
Added AIX class in the service module to control AIX SRC processes.
2013-05-11 11:09:41 -07:00
Michael DeHaan
53db51a0a2
Merge pull request #2863 from lonerr/freebsd-group
...
FreeBSD group operations is now supported properly.
2013-05-11 11:08:13 -07:00
Michael DeHaan
cb54922bcd
Merge pull request #2862 from lonerr/freebsd-user
...
Fixed errors in FreeBSD user manipulations.
2013-05-11 11:07:32 -07:00
Michael DeHaan
67e67bca1f
Change filesystem module message.
2013-05-11 14:03:40 -04:00
Michael DeHaan
63e510a632
Merge pull request #2853 from abulimov/module_mkfs
...
Module filesystem
2013-05-11 11:02:43 -07:00
Elan Ruusamäe
6949a9fbe4
LinuxService: avoid enforcing systemd even if init.d script was found
2013-05-11 13:24:00 +03:00
madema
02e41f3e56
Update service
2013-05-10 18:16:23 +03:00
madema
cf4dbf1f40
Fixed an error in the get_cpu_facts of the AIX class
...
assumed proc0 as the first processor but can be different in a LPAR environment
2013-05-08 16:13:13 +03:00
madema
f7c3b73336
Added AIX class in the service module to control AIX SRC processes.
2013-05-08 16:10:22 +03:00
lonerr
dcb22d1760
FreeBSD group operations is now supported properly.
2013-05-08 13:36:55 +04:00
lonerr
b2db6483ac
Fixed errors in FreeBSD user manipulations.
2013-05-08 13:03:18 +04:00
Oleg
3531fbdb29
fix for authorized_key: skip chown and chmod if authorized_key_file is link
2013-05-08 01:47:41 +02:00
Alexander Bulimov
f4de40fc43
renamed mkfs and moved to system/filesystem
2013-05-06 18:08:38 +04:00
Luciano Cavalheiro da Silva
d18d2de18e
Fix #2836 . Ensure proper handling of option "system=yes" in module "group".
2013-05-04 21:24:02 -03:00
rektide
4f21dc4cd1
Duplicate pull #2803 in ipv6, fixing setup module's handling of venet & unknown interface types.
2013-05-02 17:19:22 -04:00
Michael DeHaan
2cf30148ba
Test for the existance of a file that might not be present on older RHEL.
2013-04-30 09:26:25 -04:00
James Mills
efc5a83f66
Fixed setup module to accomodate venet interfaces (OpenVZ)
2013-04-29 10:08:24 +10:00
Michael DeHaan
391fb98ee2
Allow modules to be categorized, and also sort them when generating the documentation.
2013-04-28 15:03:45 -04:00