Naewis
1ca775248f
java_certs : Not enough info on error ( #5550 )
...
* java_certs : Not enough info on error
Just bumped into an issue when the message was "Internal module failure, cannot extract public certificate from pkcs12, error: "
Seems that the issue #2560 doesn't cover all cases. To make debugging easier, I propose to add error output on json return instead of only expose standard output.
* java_certs - add missing fragment message
* Word-smithing.
Co-authored-by: Felix Fontein <felix@fontein.de>
2022-11-28 22:44:24 +01:00
Rainer Leber
b1094d840f
Redirect and Remove sap modules ( #5592 )
...
* redirect and remove sap modules
* remove botmeta redirect
* add changelog fragment
* revert runtime.yml changes and add new entries
* Update meta/runtime.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
* Update changelogs/fragments/5592-redirect-remove-sap-modules.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
* Update changelogs/fragments/5592-redirect-remove-sap-modules.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
* Update 5592-redirect-remove-sap-modules.yml
Fix indentation
* Fix RST syntax.
* Update meta/runtime.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
* Update meta/runtime.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
2022-11-27 13:59:29 +01:00
Alexei Znamensky
a3b748a15e
udm_share: fix sanity checks ( #5557 )
...
* udm_share: fix sanity checks
* add changelog fragment
2022-11-26 18:41:45 +01:00
Pino Toscano
911769d2f3
redhat_subscription: improve wording wrt Satellite ( #5581 )
...
Do not mention an explicit version of Satellite for an environment to
use; future versions of Satellite will support that, and older versions
are long EOL.
Also mention Katello next to Red Hat Satellite.
2022-11-26 18:37:58 +01:00
Alexei Znamensky
79929830c4
udm_user: sanity ( #5559 )
...
* fix parameter email
* fix parameter groups
* fix parameters home_telephone_number, mail_alternative_address, mobile_telephone_number, pager_telephonenumber
* fix parameter phone
* fix parameter samba_privileges
* fix parameter samba_user_workstations
* fix parameter secretary
* fix parameter serviceprovider
* remove lines from ignore files
* add changelog fragment
2022-11-23 18:43:58 +01:00
Mike Raineri
5c1c8152ec
Redfish: Expanded SimpleUpdate command to allow for users to monitor the progress of an update and perform follow-up operations ( #5580 )
...
* Redfish: Expanded SimpleUpdate command to allow for users to monitor the progress of an update and perform follow-up operations
* Update changelogs/fragments/3910-redfish-add-operation-apply-time-to-simple-update.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
* Update plugins/modules/redfish_command.py
Co-authored-by: Felix Fontein <felix@fontein.de>
* Update changelogs/fragments/4276-redfish-command-updates-for-full-simple-update-workflow.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
* Updated based on feedback and CI results
* Update plugins/modules/redfish_command.py
Co-authored-by: Felix Fontein <felix@fontein.de>
* Update plugins/modules/redfish_command.py
Co-authored-by: Felix Fontein <felix@fontein.de>
* Update plugins/modules/redfish_info.py
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
2022-11-23 07:46:39 +01:00
Guillaume MARTINEZ
c7481c5c96
[GitLab] Add modules to manager project badges ( #5534 )
...
* [GitLab] Add modules to manager project badges
Signed-off-by: Lunik <lunik@tiwabbit.fr>
* first review
Signed-off-by: Lunik <lunik@tiwabbit.fr>
* Update plugins/modules/gitlab_project_badge.py
Co-authored-by: Felix Fontein <felix@fontein.de>
Signed-off-by: Lunik <lunik@tiwabbit.fr>
Co-authored-by: Felix Fontein <felix@fontein.de>
2022-11-18 23:49:25 +01:00
Alexei Znamensky
83ff4429e8
scaleway_organization_info: sanity checks ( #5571 )
...
* scaleway_organization_info: fix sanity checks
* remove lines from ignore files
* Update plugins/modules/scaleway_organization_info.py
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
2022-11-17 07:19:30 +01:00
Alexei Znamensky
8ad43fd774
jenkins_plugin: fix sanity checks ( #5565 )
...
* jenkins_plugin: fix sanity checks
* update BOTMETA
* add changelog fragment
* fix copyright
* Update plugins/module_utils/jenkins.py
Co-authored-by: Felix Fontein <felix@fontein.de>
* Update plugins/module_utils/jenkins.py
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
2022-11-17 06:55:46 +01:00
Alexei Znamensky
0624951e17
add dependency manager ( #5535 )
...
* add dependency manager
* add plugins/module_utils/deps.py to BOTMETA
* ditch usng OrderedDict to keep compatibility with Python 2.6
* Update plugins/module_utils/deps.py
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
2022-11-17 06:55:00 +01:00
Alexei Znamensky
6a03108609
rax_scaling_group: fix sanity check ( #5563 )
...
* rax_scaling_group: fix sanity check
* add changelog fragment
* added missing call to expanduser()
2022-11-16 21:58:55 +01:00
Alexei Znamensky
801e3d86ef
redhat_subscription: fix sanity check ( #5555 )
...
* redhat_subscription: fix sanity check
* removed ignore lines
2022-11-16 06:44:18 +01:00
Alexei Znamensky
270dc133b3
spotinst_aws_elasticgroup: sanity checks ( #5553 )
...
* spotinst_aws_elastigroup: add elements to parameter do_not_update
* spotinst_aws_elastigroup: add docs for parameter token
* add missing docs
* add changelog fragment
* Update plugins/modules/spotinst_aws_elastigroup.py
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
2022-11-15 22:37:48 +01:00
Alexei Znamensky
9874462abb
lxd_project: refactored os.path.expanduser() to module utils ( #5549 )
...
* lxd_project: refactored os.path.expanduser() to module utils
* add changelog fragment
2022-11-15 21:04:29 +01:00
Alexei Znamensky
6c7e9116e1
gconftool2: refactored to use ModuleHelper + CmdRunner ( #5545 )
...
* gconftool2: refactored to use ModuleHelper + CmdRunner
* add changelog fragment
* removed old code commented out
2022-11-15 21:02:45 +01:00
Doc_Tiebeau
27a4ffc293
Fix: Duplicate vmid in proxmox_disk module #5492 ( #5493 )
...
https://github.com/ansible-collections/community.general/issues/5492
2022-11-13 21:03:30 +01:00
Alexei Znamensky
bc0f99386b
xfconf: prune deprecated facts-generation code ( #5502 )
...
* xfconf: prune deprecated facts-generatin code
* add changelog fragment
* adjust changelog fragment
* Update changelogs/fragments/5502-xfconf-facts-deprecation.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
2022-11-10 21:18:52 +01:00
Tong He
7610501c66
Fix a logical flaw when deleting a build in the jenkins_build module ( #5514 )
...
* Fix the logical flaw when deleting a build in the jenkins_build module.
* Fix the logical flaw when deleting a Jenkins build in the jenkins_build module.
* Adding changelogs.
* Update tests/unit/plugins/modules/test_jenkins_build.py
Co-authored-by: Felix Fontein <felix@fontein.de>
* Attempt to mock the exception classes.
* Remedy the CI issues when mocking the exception classes.
* Assuming a way to mock the get_build_status function.
* Near to the feasible approach.
* Calls the correct class when unit testing.
* Fix sending wrong arguments when unit testing.
* Directly assign the argument value in the unit testing.
* Fix errors calling different classes.
Co-authored-by: Felix Fontein <felix@fontein.de>
2022-11-10 21:18:01 +01:00
Alexei Znamensky
6b20572ea1
Short descriptions (batch3) - massive fix on Capitalization and trailing period ( #5521 )
...
* short_description fix batch 3
* Update plugins/modules/telegram.py
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
2022-11-09 21:09:09 +01:00
Alexei Znamensky
f683d6a05d
short_description fix batch 2 ( #5520 )
2022-11-09 13:57:41 +01:00
Alexei Znamensky
97b584e261
Short descriptions (batch1) - massive fix on Capitalization and trailing period ( #5503 )
...
* short_description fix batch 1
* Update plugins/modules/ali_instance.py
Co-authored-by: Felix Fontein <felix@fontein.de>
* Update plugins/modules/apt_rpm.py
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
2022-11-09 07:18:40 +01:00
wh1t3 r4bb1t
621fb6a619
one_vm: fix for 'NoneType' object has no attribute 'split' in get_vm_labels_and_attributes_dict ( #5489 )
...
* Fix for 'NoneType' object has no attribute 'split'
* Added changelog to fix
* Update changelogs/fragments/5489-nonetype-in-get-vm-by-label.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
* Fix line ending in changelog
Co-authored-by: Felix Fontein <felix@fontein.de>
2022-11-08 23:00:05 +01:00
Alexei Znamensky
858eaac500
minor docs update ( #5501 )
2022-11-08 14:03:07 +01:00
Guillaume MARTINEZ
4fed0e13db
[Scaleway] Add module to manage containers ( #5496 )
...
Signed-off-by: Lunik <lunik@tiwabbit.fr>
Signed-off-by: Lunik <lunik@tiwabbit.fr>
2022-11-07 21:04:55 +01:00
Guillaume MARTINEZ
bc7e7f8fcb
[Scaleway] Remove unused sensitive values filtering ( #5497 )
...
* [Scaleway] Remove unused sensitive values filtering
Signed-off-by: Lunik <lunik@tiwabbit.fr>
* Try adding function back.
Maybe that works aound the bug in pylint. (Also it won't be a breaking change anymore.)
Signed-off-by: Lunik <lunik@tiwabbit.fr>
Co-authored-by: Felix Fontein <felix@fontein.de>
2022-11-07 20:57:33 +01:00
Alexei Znamensky
b696aa72b2
cpanm: using CmdRunner ( #5485 )
...
* cpanm: using CmdRunner
* add changelog fragment
2022-11-07 20:15:00 +01:00
Alexei Znamensky
8758f6a43f
mksysb: using CmdRunner ( #5484 )
...
* mksysb: using CmdRunner
* add changelog fragment
* adjust code when check_mode true
* Update plugins/modules/mksysb.py
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
2022-11-07 20:02:10 +01:00
Yuhua Zou
c757e20d10
fix the issue#5275: iso_create doesn't add folders ( #5468 )
...
* fix the issue
* add changelog
* add changelog file
* Update changelogs/fragments/5468-iso-create-not-add-folders.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
2022-11-07 07:00:55 +01:00
Alexei Znamensky
7a9af2b601
hponcfg: using CmdRunner ( #5483 )
...
* hponcfg: using CmdRunner
* add changelog fragment
2022-11-07 06:43:21 +01:00
Felix Fontein
ac6ac73276
Document attributes (_info and _facts modules for now) ( #5481 )
...
* Add attributes docs fragment.
* Use attributes for _info and _facts modules.
2022-11-06 21:16:43 +01:00
Felix Fontein
8de0221ae6
Convert copyright docstings to proper copyright comments ( #5480 )
...
* Drop stable-3 from weekly CI; migrate stable-4 from nightly to weekly.
* Convert copyright docstings to proper copyright comments.
2022-11-06 20:28:56 +01:00
Alexei Znamensky
8fb2228125
snap: fix regex to support option values with whitespaces ( #5475 )
...
* snap: fix regex to support option values with whitespaces
* add changelog fragment
2022-11-06 11:41:11 +01:00
Alexei Znamensky
fb90b5cbe8
ansible_galaxy_install: using CmdRunner ( #5477 )
...
* ansible_galaxy_install: using CmdRunner
* fix sanity checks
* add changelog fragment
2022-11-06 11:40:30 +01:00
Guillaume MARTINEZ
1e17ec13b8
[Scaleway] Add module to manage container namespaces ( #5416 )
...
* [Scaleway] Add module to manage container namespaces
Signed-off-by: Lunik <lunik@tiwabbit.fr>
* Fix CI
Signed-off-by: Lunik <lunik@tiwabbit.fr>
* fix botmeta
Signed-off-by: Lunik <lunik@tiwabbit.fr>
* fix typo in loop var name
Signed-off-by: Lunik <lunik@tiwabbit.fr>
* Add missing required lib check
Signed-off-by: Lunik <lunik@tiwabbit.fr>
* fix integration tests assertions
Signed-off-by: Lunik <lunik@tiwabbit.fr>
Signed-off-by: Lunik <lunik@tiwabbit.fr>
2022-11-05 20:44:33 +00:00
Guillaume MARTINEZ
db7e5f12f5
[Scaleway] Add module to manage functions ( #5463 )
...
* [Scaleway] Add module to manage function
Signed-off-by: Lunik <lunik@tiwabbit.fr>
* fix integration tests assertions
Signed-off-by: Lunik <lunik@tiwabbit.fr>
* Update plugins/modules/scaleway_function.py
Co-authored-by: Felix Fontein <felix@fontein.de>
Signed-off-by: Lunik <lunik@tiwabbit.fr>
Co-authored-by: Felix Fontein <felix@fontein.de>
2022-11-05 20:43:47 +00:00
Reto Kupferschmid
1a97ca1a6f
ldap_attrs: escape ldap search filter ( #5435 )
...
* escape ldap search filter
* move escape to separate line
* add changelog fragment
* Update changelogs/fragments/5435-escape-ldap-param.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
* fix encoding
* fixup! fix encoding
Co-authored-by: Felix Fontein <felix@fontein.de>
2022-11-04 07:07:06 +01:00
Felix Fontein
b531ecdc9b
Unflatmap community.general ( #5461 )
...
* Move files.
* Update imports and references.
* Move wrongly placed files.
* Reverse redirects, deprecate long → short name redirects.
* Simplify contribution guidelines for new modules.
* Rewrite BOTMETA.
* Add changelog fragment.
* Fix ignore.txt files.
2022-11-02 20:42:29 +00:00
Felix Fontein
2b0bebc8fc
Fix defaults.
2022-11-02 21:00:09 +01:00
Simon-TheUser
5cb9a9e4f0
nsupdate: issues/4657 ( #5377 )
...
* Insert new entries before deleting old ones.
resolves #4657
* Slight wording changes.
* lint fix
* Address lint
* Added changelog
Fixed lint
* More linting
* Update changelogs/fragments/5377-nsupdate-ns-records-with-bind.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
2022-11-02 20:13:50 +01:00
Guillaume MARTINEZ
5fe0f57033
[Scaleway] Add module to manage function namespaces ( #5415 )
...
* [Scaleway] Add module to manage function namespaces
Signed-off-by: Lunik <lunik@tiwabbit.fr>
* rename short_descriptions
Signed-off-by: Lunik <lunik@tiwabbit.fr>
* handle changed verification on hashed secret values
Signed-off-by: Lunik <lunik@tiwabbit.fr>
* fix syntax for python 2.6
Signed-off-by: Lunik <lunik@tiwabbit.fr>
* fix missing argon2 in unittest
Signed-off-by: Lunik <lunik@tiwabbit.fr>
* fix missing value on description field
Signed-off-by: Lunik <lunik@tiwabbit.fr>
Signed-off-by: Lunik <lunik@tiwabbit.fr>
2022-11-02 20:11:04 +01:00
Alex Groshev
dc66aefa40
fix int options idempotence bug and add new test to check it ( #5443 )
2022-11-01 21:40:17 +01:00
Felix Fontein
f84a9bf932
Fix non-matching defaults. ( #5452 )
2022-11-01 19:25:51 +01:00
Felix Fontein
5f4e593116
Revert "Fix non-matching defaults in docs ( #5446 )"
...
This reverts commit a978bff2c7
2022-11-01 19:12:21 +01:00
Felix Fontein
a978bff2c7
Fix non-matching defaults in docs ( #5446 )
...
* Allow to pass options as lookup options.
* Adjust tests.
* Fix non-matching defaults.
2022-11-01 18:11:02 +01:00
Felix Fontein
2830a3452d
Remove deprecated features, bump version to 6.0.0 ( #5326 )
...
* Bump version to 6.0.0.
* sender option is now required.
* Default of want_proxmox_nodes_ansible_host changed from true to false.
* username is now an alias of user, and no longer of workspace.
* Remove deprecated return values in favor of end_state.
* Remove debug option.
* Change default of ignore_volatile_options from true to false.
* gitlab_group must now always contain the full path.
* Change default of norc from false to ture.
* Remove deprecated property.
* Add PR URL.
* Adjust bitbucket unit tests.
* Adjust module_helper integration test.
2022-10-25 08:07:21 +02:00
Martin
091bdc77c3
ldap_attrs: search_s based _is_value_present ( #5385 )
...
* search_s based _is_value_present
* Fix formatted string and ldap import
* Add changelog fragment
* Remove superfluous import ldap
* Improve fragment
* Code format {x} prefix
* Lower-case fixes
* Fix suggestions to changelog
* Break with the past and let bools be bools
* Let ldap_attrs break on invalid DN's
2022-10-25 08:01:57 +02:00
Alexander Holzapfel
b9d0864957
Send string instead of boolean to proxmox api ( #5198 )
...
* Send string instead of boolean to proxmox api
* Add changelog fragment.
* Update plugins/modules/cloud/misc/proxmox_kvm.py
Co-authored-by: castorsky <csky57@gmail.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: castorsky <csky57@gmail.com>
2022-10-23 18:25:03 +02:00
Guillaume MARTINEZ
2680739153
[Scaleway] Add module to manage container registries ( #5399 )
...
* [Scaleway] Add module to manage container registries
Signed-off-by: Lunik <lunik@tiwabbit.fr>
* first review
Signed-off-by: Lunik <lunik@tiwabbit.fr>
* lint documentation on return value
Signed-off-by: Lunik <lunik@tiwabbit.fr>
* second review
Signed-off-by: Lunik <lunik@tiwabbit.fr>
* second review *bis
Signed-off-by: Lunik <lunik@tiwabbit.fr>
* second review *ter
Signed-off-by: Lunik <lunik@tiwabbit.fr>
* Fix typo.
Signed-off-by: Lunik <lunik@tiwabbit.fr>
Co-authored-by: Felix Fontein <felix@fontein.de>
2022-10-23 17:18:06 +02:00
Alexei Znamensky
f5ca03047d
django_manage: deprecate venv creation when missing ( #5405 )
...
* deprecate venv creation when missing
* add changelog fragment
* fix sanity checks
* Update changelogs/fragments/5404-django-manage-venv-deprecation.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
* Update plugins/modules/web_infrastructure/django_manage.py
Co-authored-by: Felix Fontein <felix@fontein.de>
* Update plugins/modules/web_infrastructure/django_manage.py
Co-authored-by: Felix Fontein <felix@fontein.de>
* minor change to help future removal of feature
Co-authored-by: Felix Fontein <felix@fontein.de>
2022-10-23 16:33:14 +02:00
Alexei Znamensky
baa8bd52ab
pkgng: fix error-handling when upgrading all ( #5369 )
...
* pkgng: fix error-handling when upgrading all
* provide for rc=1 in check_mode + test
* fix name of task in test
* add changelog fragment
2022-10-23 11:42:53 +02:00
