ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity

xfconf: prune deprecated facts-generation code (#5502)

Browse source 
* xfconf: prune deprecated facts-generatin code

* add changelog fragment

* adjust changelog fragment

* Update changelogs/fragments/5502-xfconf-facts-deprecation.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
This commit is contained in:
Alexei Znamensky 2022-11-11 09:18:52 +13:00 committed by GitHub
parent 7610501c66
commit bc0f99386b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
changelogs/fragments/5502-xfconf-facts-deprecation.yml Normal file
View file

@ -0,0 +1,6 @@
removed_features:
- >
xfconf - generating facts was deprecated in community.general 3.0.0,
however two factoids, ``previous_value`` and ``type`` continued to be generated by mistake. This behaviour
has been removed and ``xfconf`` generate no facts whatsoever
(https://github.com/ansible-collections/community.general/pull/5502).

7
plugins/modules/xfconf.py
View file

@ -195,15 +195,12 @@ class XFConfProperty(StateModuleHelper):
default_state = 'present'
def update_xfconf_output(self, **kwargs):
self.update_vars(meta={"output": True, "fact": True}, **kwargs)
def __init_module__(self):
self.runner = xfconf_runner(self.module)
self.does_not = 'Property "{0}" does not exist on channel "{1}".'.format(self.vars.property,
self.vars.channel)
self.vars.set('previous_value', self._get(), fact=True)
self.vars.set('type', self.vars.value_type, fact=True)
self.vars.set('previous_value', self._get())
self.vars.set('type', self.vars.value_type)
self.vars.meta('value').set(initial_value=self.vars.previous_value)
if self.vars.disable_facts is False: