1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Commit graph

15060 commits

Author SHA1 Message Date
James Cammarata
85bbce9d6b Wrap unhandled errors from lookups in an AnsibleError
This provides better error handling, and prevents errors like KeyError
from bubbliing up to code in odd places.

Fixes #17482
2016-12-21 11:48:18 -06:00
James Cammarata
d70d279c4e Also fix default callback to use ignore_errors param
Rather than the value in the task, which may not be templated.

Related to #18289
2016-12-21 11:37:06 -06:00
Matt Clay
446888ef41 Switch from iteritems to items for py3. 2016-12-21 09:22:54 -08:00
Ganesh Nalawade
0d06b77970 Add 'update' parameter in junos_config module (#19046)
* Add update parameter in junos_config module which supports
configuration action like merge, replace and overwrite.

* Add support for replace along with update
argument
2016-12-21 11:56:55 -05:00
James Cammarata
dd0257b995 Template "original_task" fields in _process_pending_results
Since we no longer use a post-validated task in _process_pending_results, we
need to be sure to template fields used in original_task as they are raw and
may contain variables.

This patch also moves the handler tracking to be per-uuid, not per-object.
Doing it per-object had implications for the above due to the fact that the
copy of the original task is now being used, so the only sure way is to track
based on the uuid instead.

Fixes #18289
2016-12-21 10:09:06 -06:00
Brian Coca
7faa041636 added file flag preservation to atomic_move
preserves existing flag info if possible
2016-12-21 10:56:40 -05:00
Brian Coca
3691c784d2 fix check mode for all options
also simplified code paths and changed import away from *
fixes #19476
2016-12-21 09:36:46 -05:00
Jiri Tyr
91094ec96c Adding ldap_entry module (#19285)
* Adding ldap_entry module

* Introducing explicit option for LDAP attributes

* Fixing requirements of attributes option
2016-12-21 07:37:28 +01:00
Nehal J Wani
e907622121 jenkins_plugin: doc: Specify version as string (#18858)
If the plugin version expected is, say '1.20', then specifying it
as...
    version: 1.20
... will make the YAML parser interpret it as a float, and the
value obtained by the module will be 1.2 instead of 1.20, which
will cause downloading of wrong version of the module.

This patch updates the docs so that users don't face this issue.
2016-12-21 07:32:23 +01:00
Brian Coca
8c5d321a23 simplified unsafe writes 2016-12-20 15:54:10 -05:00
Adrian Likins
727ca6f436 Fix error on 'help module' in ansible-console (#19390)
If 'help xattr' for example, ansible-console would
traceback because module_docs.get_docstring() now
returns 4 values (module metadata was added)
2016-12-20 15:50:29 -05:00
Brian Coca
ebf835045f unique error messages to avoid confusion 2016-12-20 15:25:59 -05:00
Adrian Likins
ab560df15f Fix 3 char indent on AnsibleModule._unsafe_writes (#19542) 2016-12-20 10:36:17 -05:00
Adrian Likins
388510f379 Fix missing imports from sysctl module
This module was missing an import of get_exception()
and had an unused import of 're'
2016-12-20 10:23:48 -05:00
Matthew Gamble
8292cadc7f Tell pacman not to display progress bars
Displaying progress bars is not recommended for any scripted usage of
pacman, such as the ansible pacman module.
2016-12-20 09:47:25 -05:00
Ganesh Nalawade
c3c4ae87dd Add 'update' parameter in junos_config module (#19038)
* Fix # #5839 Add 'update' parameter in junos_config module

Add update parameter in junos_config module which supports
configuration action like merge, replace and overwrite.

* Fix documentation issue

* Fix review comment to add replace argument

Make replace and update argument mutually
exclusive, to support replace for backward
compatibility.
2016-12-20 07:27:26 -05:00
Peter Sprygada
f831ef692c update signature in network plugin (#19545)
Fix call to _update_module_args() to include module_name in the args
2016-12-20 07:07:42 -05:00
Ken Evensen
bcace3cfc4 Gconf2 module (#19540)
* Pull #19267 broke sysctl module.  Minor corrections

* Correct description.  Functional updates
2016-12-20 11:53:49 +00:00
tmshn
112d950794 [timezone module] Check if timedatectl command is actually available 2016-12-19 21:18:12 -05:00
Michael Herold
a532dd915a Adds description for ini_file "section: null" 2016-12-19 21:10:30 -05:00
Matthew Gamble
f24ab68f04 Improve and optimise pacman package installation
Previously, packages were installed one at a time in a loop. This caused
a couple of problems.

First, it was a performance issue - pacman would have to perform all of
its checks once per package. This is unnecessarily costly, especially
when you're trying to install several related packages at the same time.

Second, if a package you're trying to install depends on a virtual
package that is provided by several different packages (such as the
"libgl" package on Arch) and you aren't also installing something that
provides that virtual package at the same time, pacman will produce an
interactive prompt to allow the user to select a relevant package. This
is obviously incompatible with how ansible operates. Yes, this problem
could be avoided by installing packages in a different order, but the
order of installation shouldn't matter, and there may be situations
where it is not possible to control the order of installation.

With this refactoring, all of the above problems are avoided. The code
will now work out all of the packages that need to be installed from any
configured repositories and any packages that need to be installed from
local files, and then install all the repository packages in one go and
then all of the local file packages in one go.
2016-12-19 21:09:25 -05:00
Dag Wieers
93cfe73a76 Report detailed error when internal remote functions fail
This is a redesign in how plugins call _remote_checksum().

- _remote_stat() has been modified to report the real error as
  AnsiblError
- Action plugin **unarchive** calls _remote_stat() directly instead of
   _remote_checksum()
- Action plugin **unarchive** also handles the exceptions directly
- Ensure get_exception() returns native text

Two other action plugins, **template** and **fetch**, also do a remote checksum.
In **template** we already call _remote_stat(), just like we now do for
unarchive, in **fetch** we do call _remote_checksum() and we make the
exact same mistake as the unarchive plugin. So that one could use a
redesign as well.

This fixes #19494

Before:
```
[dag@moria ansible.testing]$ ansible-playbook -v test137.yml
Using /home/dag/home-made/ansible.testing/ansible.cfg as config file

PLAY [localhost]
******************************************************************************************************

TASK [unarchive]
******************************************************************************************************
fatal: [localhost]: FAILED! => {"changed": false, "failed": true, "msg":
"python isn't present on the system.  Unable to compute checksum"}

PLAY RECAP
******************************************************************************************************
localhost                  : ok=0    changed=0    unreachable=0
failed=1
```

After:
```
[dag@moria ansible.testing]$ ansible-playbook -v test137.yml
Using /home/dag/home-made/ansible.testing/ansible.cfg as config file

PLAY [localhost]
*************************************************************************************************************

TASK [unarchive]
*************************************************************************************************************
fatal: [localhost]: FAILED! => {"changed": false, "failed": true, "msg":
"Failed to get information on remote file (/tmp/): sudo: unknown user:
foobar\nsudo: unable to initialize policy plugin\n"}

PLAY RECAP
*******************************************************************************************************************
localhost                  : ok=0    changed=0    unreachable=0
failed=1
```
2016-12-19 21:04:48 -05:00
Adrian Likins
2597c1236d Better error msg for basic.get_bin_path()
Include the searched paths in the error message.
2016-12-19 20:55:52 -05:00
Adrian Likins
35fef6fb84 Better error message for module unsupported params
Keep track of all the unsupported parameters, and include
all of them in the error message as well as a list of the
supported params.
2016-12-19 20:47:39 -05:00
Fabio Alessandro Locati
06abeea5ad Improve YAML examples - windows/win_package.py (#19407)
* Improve YAML examples - windows/win_package.py

* Fix quote

* Fix typo
2016-12-19 13:58:28 -08:00
Fabio Alessandro Locati
3c64ccd6e1 Make examples in YAML format - windows/win_acl.py (#18836)
* Make examples in YAML format - windows/win_acl.py

* Raw string
2016-12-19 13:57:21 -08:00
Peter Sprygada
c546c12b60 fixes incorrect module name for action plugin (#19535)
This fixes a bug introduced in the action plugin for setting the
module name value for logging
2016-12-19 16:54:31 -05:00
Rezart Qelibari
507b96ff30 user: make system=yes work on Darwin systems. (#19464)
* Update system/user.py module.

Add ability to add real system users with next free system uid (< 500) on macOS.

* Improve syntax in system/user.py module.

Remove complex if else line and replace by simple comparison which yields the same boolean value.

* Remove "True" comparison of user.py.

Remove comparison to true, as it is not pep8 conform.
2016-12-19 16:35:56 -05:00
Chris Houseknecht
71685b3258 Update module_args['rsync_opts'] when connection type is docker (#19531) 2016-12-19 16:08:31 -05:00
Brian Coca
9816addcdc removed too generic 'infrastructure' 2016-12-19 15:25:39 -05:00
Brian Coca
e542976bb7 removed redundant else/return 2016-12-19 15:11:29 -05:00
Toshio Kuratomi
226124956c Allow timeout decorator to handle @timeout as well as @timeout() 2016-12-19 15:09:50 -05:00
Brian Coca
b4bd6c80de fixes to facts timeout
also now handle timeout exception correctly everywhere
2016-12-19 15:09:50 -05:00
Brian Coca
f533f6603c show filename for module 2016-12-19 14:48:19 -05:00
Rob
cfa8ce767b Add new parameters to taskdefinition module - network_mode and task_r… (#19493)
* Add new parameters to taskdefinition module - network_mode and task_role_arn

* Add version_added field for doco

* Change version_added parameter to 2.3
2016-12-19 18:16:35 +00:00
Fabio Alessandro Locati
a080d44a47 Improve YAML examples - system/solaris_zone.py (#19410) 2016-12-19 16:49:47 +00:00
Peter Sprygada
7814546735 cast injected json string to bytes in local modules (#19519)
this change will cast the locally injected ansible args to bytes
from string
2016-12-19 11:34:18 -05:00
Peter Sprygada
2a5a2773c8 adds new module net_command for network devices (#19468)
* new module net_command for sending a command to a network device
* adds unit test cases for module
* only works with connection=network_cli
2016-12-19 11:21:37 -05:00
Rob
b77ab1a6c9 Add support to ec2_eip to associate with a secondary ip address (#19484) 2016-12-19 15:45:38 +00:00
Ken Evensen
58b067532f gconftool2 module (#19461)
* Pull #19267 broke sysctl module.  Minor corrections

* Commit of gconftool2 module
2016-12-19 14:57:31 +00:00
Alex Sergeyev
28a3a13656 Support MariaDB engine version 10.1 (#19483) 2016-12-19 14:28:29 +00:00
redbloodmage
0568adc272 Added some clarity on the token confusion. (#19473) 2016-12-19 13:42:31 +00:00
Peter Sprygada
8f97ddd98a removes network os guess static method (#19467)
For devices that do not support mutliplexing, we cannot automatically
determine the network os.  This removes the os guess static method
from the terminal plugin.  For this devices, the network_os
value must be configured
2016-12-19 07:47:29 -05:00
Matthew
c58461596a Support pacman packages using different types of compression (#19503)
It's possible to compress packages using several different compression
methods, or not compressed at all. Previously, the pacman module only
supported files compressed using xz. This update ensures that all
compression types currently supported by pacman are supported by the
ansible pacman module.

The list of supported compression methods at the time of writing can be
found here:
https://git.archlinux.org/pacman.git/tree/scripts/makepkg.sh.in#n747
2016-12-19 12:08:45 +00:00
Will Thames
87c0c33241 Fix include_role docs to be valid YAML (#19506)
Remove the colon from one of the documentation notes, which was
causing documentation schema validation to fail.
2016-12-19 10:45:01 +00:00
Brian Coca
48dee1b6d0 still needs static for task object 2016-12-16 23:52:11 -05:00
Dag Wieers
39c9c6b942 Ensure that command/shell errors are displayed
This fix ensures that if there are specific module errors (in our case
the python interpreter was not found) then command and shell returns a
proper error.

It also fixes a few other imperfections that we noticed during
troubleshooting:

- Return the real RC if it were available
- Improve a dictionary evaluation using .get()
- Return an RC of -1 if it is unknown (instead of returning 0)

This fixes #18846
2016-12-16 21:46:02 -05:00
Dag Wieers
41614fd8e6 Display proper error on group_vars syntax error
This fix ensures a proper error is shown when a group_vars files cannot
be parsed correctly. Without this patch you get:

```
[dag@moria ansible.testing]$ ansible-playbook test132.yml
ERROR! Unexpected Exception: dictionary update sequence element #0 has length 1; 2 is required
to see the full traceback, use -vvv
```

With this patch you get:
```
[dag@moria ansible.testing]$ ansible-playbook test132.yml
ERROR! Problem parsing file '/home/dag/home-made/ansible.testing/group_vars/test135': line 1, column 1
```

This fixes #18843
2016-12-16 21:13:41 -05:00
Brian Coca
5d82fe545f minor docs and option fixes 2016-12-16 16:17:52 -05:00
Brian Coca
884b529195 removed unused 'static' option
the task level directive is what actually controls this, this option was never used
2016-12-16 15:23:36 -05:00
Jake Morrison
00859a4ced Handle inability to read /proc for ansible_service_mgr. Fixes #18957 2016-12-16 12:28:13 -05:00
Adrian Likins
5cd7a08418 Check solaris 'smbios' is exists before running it
smbios could potentially be None here, possibly causing
the solaris 8/9 failures seen at #19282

Fixes #19282
2016-12-16 12:10:16 -05:00
Ryan S. Brown
5204024f35 s3_sync module: Add ANSIBLE_METADATA parameter 2016-12-16 09:28:45 -05:00
tedder
be7a568b33 New module s3_sync: boto3-powered s3 synchronization
Syncs groups of files faster than the `s3` module and support content
type detection/overriding and globbing.
2016-12-16 09:26:30 -05:00
Fabio Alessandro Locati
f1b5dde4cb Improve YAML examples - packaging/kibana_plugin.py (#19409) 2016-12-16 09:08:38 +00:00
Dag Wieers
2f90091f0a Add an important example for SSHd
Sudoers is a great example to show how you can prevent shutting yourself
out. But SSHd is at least as important to avoid syntax errors causing a
lot of grieve. So I think it deserves a spot in this list :-)
2016-12-15 20:42:51 -05:00
Fabio Alessandro Locati
fb0779f657 Improve YAML examples - windows/win_regedit.py (#19400) 2016-12-15 15:05:18 -08:00
Fabio Alessandro Locati
b6f2565d60 Improve YAML examples - windows/win_template.py (#19408) 2016-12-15 15:04:49 -08:00
Fabio Alessandro Locati
beb6ed08cd Improve YAML examples - windows/win_owner.py (#19406) 2016-12-15 15:00:28 -08:00
Fabio Alessandro Locati
12205598c3 Improve YAML examples - windows/win_acl_inheritance.py (#19405) 2016-12-15 15:00:03 -08:00
Fabio Alessandro Locati
5a87f26658 Improve YAML examples - windows/win_get_url.py (#19404) 2016-12-15 14:59:07 -08:00
Fabio Alessandro Locati
5f8f1fa782 Improve YAML examples - windows/win_iis_webapppool.py (#19403) 2016-12-15 14:57:26 -08:00
Fabio Alessandro Locati
83d0f621da Improve YAML examples - windows/win_iis_webapplication.py (#19402) 2016-12-15 14:56:29 -08:00
Fabio Alessandro Locati
f57418c2c1 Improve YAML examples - windows/win_user.py (#19401) 2016-12-15 14:56:04 -08:00
Fabio Alessandro Locati
9b3d9e1780 Improve YAML examples - windows/win_file_version.py (#19399) 2016-12-15 14:54:12 -08:00
Fabio Alessandro Locati
0aa16b36b7 Make the example in proper yaml format - windows/win_iis_virtualdirectory.py (#18829)
* Make the example in proper yaml format

* Add r
2016-12-15 14:53:30 -08:00
Fabio Alessandro Locati
75bcec0ef5 Fix conflict and typos (#18831) 2016-12-15 14:50:22 -08:00
Nathaniel Case
2405c0bbef Hopefully clear up some junos issues. (#17616) 2016-12-15 17:07:19 -05:00
Eric Beahan
dce8f3899e Modify an initial value causing exception when vlan_range param is present (#19019) 2016-12-15 16:31:34 -05:00
Tim Rupp
e0e1d3b561 Adds description parameter to pools (#19362)
This patch adds the description parameter as a supported param of
the bigip_pool module.

Tests for this change are available here

https://github.com/F5Networks/f5-ansible/blob/master/roles/bigip_pool/tasks/main.yaml#L732
2016-12-15 16:28:30 -05:00
Nathaniel Case
7900319fc3 Assorted python3 fixes for network code. (#18777) 2016-12-15 16:25:03 -05:00
ikelos
c49eac5645 Fix the junos zeroize function (#19142)
Currently this function directs to the standard NetworkModule,
whose run_commands function takes no arguments (other than self).

This directs the call to the connection's cli method to run the command
directly on the device.
2016-12-15 16:23:04 -05:00
Ganesh Nalawade
ee5d5c3e84 Fix #4103 Support json format in junos_command module (#19045) 2016-12-15 16:01:23 -05:00
Peter Sprygada
ad99d52679 adds feature to allow connection to set action plugin (#18762)
Connection plugin can define default action plugin to use by providing
action_handler instance variable.  This will override the default
action plugin normal
2016-12-15 15:47:39 -05:00
Peter Sprygada
0cef38cf02 adds feature to all modules to be run locally (#18763)
* adds new error AnsibleModuleExit to handle module returns
* adds new action plugin network for attaching connection to network modules
* adds new shared module local to receive connection
* splits out function to update task_args with common updates

This commit provides a mechansim for running local modules that require
a connection object for interative commands tyically implemented for
network devices.  It provides a way to locally import modules (post fork)
and run them using exception handling to exit.
2016-12-15 15:47:29 -05:00
Fabio Alessandro Locati
066872cdc6 Improve examples (#18830) 2016-12-15 10:43:50 -08:00
Fabio Alessandro Locati
8dc3b60d0f Remove unneeded quotes - windows/win_uri.py (#18828) 2016-12-15 10:38:02 -08:00
Fabio Alessandro Locati
cf5449c5d9 Remove unneeded quotes - windows/win_unzip.py (#18827) 2016-12-15 10:37:02 -08:00
Fabio Alessandro Locati
439f98005f Highly rewrite and fix the examples - windows/win_iis_webbinding.py (#18823) 2016-12-15 10:34:20 -08:00
Artur Molchanov
a8d5358d7f systemd module: Allow to stop activating service (#19383)
* systemd module: Allow to stop activating service

Allow to stop service with ActiveState=activating.

* systemd: Fix incompatibility with Python 2.4
2016-12-15 11:14:33 -05:00
John R Barker
7dc86648c4 Docs typo (#19380) 2016-12-15 13:32:28 +00:00
Ryan S. Brown
197658aff4 Handle when the AMI launch permissions are unset.
Use an empty list to avoid a TypeError because `'NoneType' is not iterable``
2016-12-14 19:45:14 -05:00
Michael Gugino
250f862573 Fix bug #5328 apache module loading (#19355)
* Fix bug #5328 apache module loading

Currently, the apache2_module module parses apache configs
for correctness when enabling or disabling apache2 modules.

This behavior introduced a conflict condition when transitioning
between mpm modules, such as mpm_worker and mpm_event.

This change accounts for the specific error condition raised
by ``apachectl -M``:
``AH00534: apache2: Configuration error: No MPM loaded.``
When loading or unloading a module with a name that contains 'mpm_',
apache2_module will ignore the error raised by apachectl if stderr
contains 'AH00534'.

Fixes #5328

* Add AH00534 warning

* Added changes from PR #5629

* Modified ignore_configcheck behavior
2016-12-14 13:18:19 -08:00
Toshio Kuratomi
0b440a9289 Code smell test for iteritems and itervalues (#19292)
* Code smell test for iteritems and itervalues

* Change the keydict object in authorized_keys so it doesn't throw a false postive

keydict is a bad data structure anyway.  We don't use the iteritems and
itervalues methods so just disable them so that the code-smell tests do
not trigger on it.

* Change release templates so they work with py3
2016-12-14 12:16:16 -08:00
Brian Coca
f550b4541f bad/missing fact plugin is a warning (#19350) 2016-12-14 14:25:19 -05:00
Steve Kuznetsov
d5324c11a0 Factored polling std{out,err} reads into a function
The process to poll for data in the stdout and/or stderr pipes during a
low-level command execution was repetitive. Factoring this out into a
function DRYs out the code.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
2016-12-14 10:14:31 -08:00
Tim Rupp
362c86d323 Fixes map call usage
For the comparisions that need to be done, this map call needs
to convert to a list because the six import in ansible changes
the behavior of map to return an iterator instead of a list
2016-12-14 10:00:47 -08:00
Ondra Machacek
f84f97d035 cloud: ovirt: Add support to upload/copy/move disks (#19337) 2016-12-14 12:43:25 -05:00
Brian Coca
ed933421fe correct template lookup path
now all paths get 'templates/'
2016-12-14 12:25:08 -05:00
Ondra Machacek
5400a06ac4 cloud: ovirt: Various fixes for oVirt modules (#19141)
*  cloud: ovirt: fix various issues in ovirt modules

* cloud: ovirt: add support for nfs version

* cloud: ovirt: Fix facts documentation

* Add proper documentation fragmet
* Add proper argument_spec
* Fix return values

* cloud: ovirt: fix pep8
2016-12-14 11:42:15 -05:00
Robin Roth
afca957396 Fix UnboundLocalError remote_head in git (#19057)
* Fix UnboundLocalError remote_head in git

Fixes #5505

The use of remote_head was a leftover of #4562.
remote_head is not necessary, since the repo is unchanged anyway and
after is set correctly.

Further changes:
* Set changed=True and msg once local_mods are detected and reset.
* Remove need_fetch that is always True (due to previous if) to improve
clarity
* Don't exit early for local_mods but run submodules update and
switch_version

* Add test for git with local modifications
2016-12-14 08:36:15 -08:00
Ondra Machacek
fa96438f4c cloud: ovirt: Add support to list nested entities parameters (#19300) 2016-12-14 11:15:50 -05:00
Andrea Tartaglia
59227d8c31 Removed dict.iteritems() in several other files.
This is for py3 compatibility #18506
2016-12-14 08:01:45 -08:00
Dag Wieers
7c71c678fa Fix regression in search path behaviour
This PR fixes a few issues:

- Missing role parent directory for relative paths
- Fix integration tests (add missing stage)
- Redesign integration tests
- Incorrect order with tasks-lookups
- Duplicate paths are listed
- Repetitive tasks/tasks or files/files were possible

==== using copy with test.txt
Before:
```
   491 1481281038.29393: search_path:
        /home/dag/home-made/ansible.testing/roles/test134/files/test.txt
        /home/dag/home-made/ansible.testing/roles/test134/tasks/test.txt
        /home/dag/home-made/ansible.testing/roles/test134/tasks/files/test.txt
        /home/dag/home-made/ansible.testing/roles/test134/tasks/tasks/test.txt
        /home/dag/home-made/ansible.testing/files/test.txt
        /home/dag/home-made/ansible.testing/test.txt
```

After:
```
 32505 1481280963.22418: search_path:
        /home/dag/home-made/ansible.testing/roles/test134/files/test.txt
        /home/dag/home-made/ansible.testing/roles/test134/test.txt
        /home/dag/home-made/ansible.testing/roles/test134/tasks/files/test.txt
        /home/dag/home-made/ansible.testing/roles/test134/tasks/test.txt
        /home/dag/home-made/ansible.testing/files/test.txt
        /home/dag/home-made/ansible.testing/test.txt
```

==== Using copy with files/test.txt

Before:
```
 31523 1481280499.63052: search_path:
        /home/dag/home-made/ansible.testing/roles/test134/files/test.txt
        /home/dag/home-made/ansible.testing/roles/test134/tasks/files/test.txt
        /home/dag/home-made/ansible.testing/roles/test134/tasks/files/test.txt
        /home/dag/home-made/ansible.testing/roles/test134/tasks/tasks/files/test.txt
        /home/dag/home-made/ansible.testing/files/files/test.txt
        /home/dag/home-made/ansible.testing/files/test.txt
```

After:
```
 31110 1481280299.38778: search_path:
        /home/dag/home-made/ansible.testing/roles/test134/files/test.txt
        /home/dag/home-made/ansible.testing/roles/test134/tasks/files/test.txt
        /home/dag/home-made/ansible.testing/files/test.txt
```

==== Using template with files/test.txt.j2
Before:
```
 30074 1481280064.15191: search_path:
        /home/dag/home-made/ansible.testing/roles/test134/templates/files/test.txt.j2
        /home/dag/home-made/ansible.testing/roles/test134/tasks/files/test.txt.j2
        /home/dag/home-made/ansible.testing/roles/test134/tasks/templates/files/test.txt.j2
        /home/dag/home-made/ansible.testing/roles/test134/tasks/tasks/files/test.txt.j2
        /home/dag/home-made/ansible.testing/templates/files/test.txt.j2
        /home/dag/home-made/ansible.testing/files/test.txt.j2
```

After:
```
 29201 1481279823.52752: search_path:
        /home/dag/home-made/ansible.testing/roles/test134/templates/files/test.txt.j2
        /home/dag/home-made/ansible.testing/roles/test134/files/test.txt.j2
        /home/dag/home-made/ansible.testing/roles/test134/tasks/templates/files/test.txt.j2
        /home/dag/home-made/ansible.testing/roles/test134/tasks/files/test.txt.j2
        /home/dag/home-made/ansible.testing/templates/files/test.txt.j2
        /home/dag/home-made/ansible.testing/files/test.txt.j2
```

This fixes #19048
2016-12-14 10:33:14 -05:00
René Moser
18b7852940 cloudstack: utils: fail friendlier if no zones available (#19332) 2016-12-14 11:37:26 +01:00
Toshio Kuratomi
c6b42028c4 Fixes for uri under python3 and local (non-httptester) testing 2016-12-13 15:46:07 -08:00
Simon Li
de714e5af8 Use volume as input parameter name to match image. 2016-12-13 23:25:21 +00:00
Simon Li
9bfa2963b6 Add version_added 2.3 as suggested by shippable 2016-12-13 23:25:20 +00:00
Simon Li
178811d174 Return an error if volume_src wasn't found 2016-12-13 23:25:20 +00:00
Simon Li
e861195773 Add volume_src to os_volume
Depending on the OpenStack installation it may be quicker to create a volume from an existing volume (copy-on-write) compared to from a snapshot (allocating a completely new volume).

This adds a new `volume_src` parameter to the `os_module` which accepts a volume id or name.
2016-12-13 23:25:19 +00:00
Ken Evensen
6b62b9f48c Adding pamd module for Ansible (#19029) 2016-12-13 15:34:44 -05:00
Adrian Likins
08a5d506bb Fix errors on 'ansible-playbook --flush-cache' (#18754)
Add a unit test, and split out the flush cache logic to
it's own method.
Fixes #18708
2016-12-13 14:35:15 -05:00
Adrian Likins
6c4f554f5a Provide slightly better msg on fact cache error (#18759)
If the configured fact_cache plugin (fact_caching config)
fails, raise a fatal error instead of failing mysteriously
later.

Fixes #18751
2016-12-13 14:34:58 -05:00
Carlos E. Garcia
0b8011436d minor spelling changes 2016-12-13 13:51:13 -05:00
Michael Scherer
054a3fccf8 Cleanup import for sysctl module 2016-12-13 13:26:54 -05:00
Michael Scherer
f9460f3c80 Use type='path' instead of 'str' for deploy_helper 2016-12-13 13:25:45 -05:00
Michael Scherer
db8719cf8b Add support for NetBSD
While I only checked on NetBSD 7.0, it seems to use the same
rc system as FreeBSD so it should be working for now.
2016-12-13 13:24:34 -05:00
Michael Scherer
6ffd494efb Cleanup imports for user
Some class use shutil, who was not imported, and we want to
avoid '*' for future refactoring.
2016-12-13 11:53:18 -05:00
Lumír 'Frenzy' Balhar
84544ee8fd Fix AST nodes for Python 3 and enable dependent test_uri (#18597)
* Enable tests on python 3 for uri

* Added one more node type to SAFE_NODES into safe_eval module.

ast.USub represents unary operators. This is necessary for
parsing some unusual but still valid JSON files during testing
with Python 3.
2016-12-13 07:37:39 -08:00
Ondra Machacek
95ef9fd9f9 cloud: ovirt: Add ovirt_tags and ovirt_tags_facts modules (#19295) 2016-12-13 09:14:09 -05:00
Toshio Kuratomi
51491c9904 Remove itervalues (not available on py3) 2016-12-13 05:40:48 -08:00
Toshio Kuratomi
a8af6c6baf Fix some SSL errors in mail.py causing SMTP Syntax Errors (Rebase of https://github.com/ansible/ansible-modules-extras/pull/708 ) (#19253)
* Rebase of https://github.com/ansible/ansible-modules-extras/pull/708

708 was full of extraneous merge commits interwoven with commits to
implement the feature. In the end the only way I could clean this up
in reasonable time was to just take a regular diff between the PR and
the base.  This lost the history of intermediate commits but I've
preserved attribution to @dayton967 via git's --author field.

Although I preserved the logic of the PR, there were a few additional
things that I cleaned up:

* Fixed import of email.mime.multipart
* Used the argspec to set port and timeout to integers instead of having
  ad hoc code inside of the module.
* Used argspec's choices for secure instead of ad hoc code inside of the
  module.
* Removed some unused variables
* Made secure_state a python boolean instead of using 0 and 1
* Used secure with string comparisons instead of turning it into an
  integer code.  This is much more readable.
* Fixed catching of SMTPExceptions (SMTPException wasn't imported
  directly so it needed to use the smtplib namespace.)
2016-12-13 04:28:24 -08:00
René Moser
a28d898c29 cloudstack: cs_securitygroup_rule: fix impossible to set icmp_code and icmp_type to 0 (#19258) 2016-12-13 06:58:17 +01:00
Andrea Tartaglia
ef391a11ec Removed dict.iteritems() in modules. (#18859)
This is for py3 compatibility, addressed in #18506
2016-12-12 15:16:23 -08:00
Vlad Glagolev
4b27d08643 dropped 'BOOLEANS' choices, converted env vars to str 2016-12-12 14:25:19 -08:00
Clark Boylan
a65e34ce77 Fix synchronize retries (#18535)
* Fix synchronize retries

The synchronize module munges its task args on every invocation of
run(). This was problematic because the munged data was not fit for use
by a second pass of the synchronize module. Correct this by using a copy
of the task args on every invocation of run() so that the original args
are not affected.

Local testing using this playbook seems to confirm that things work as
expected:

  - hosts: all
  tasks:
    - delay: 2
      register: task_result
      retries: 1
      until: task_result.rc == 0
      synchronize:
        dest: /tmp/out
        mode: pull
        src: /tmp/nonexistent/

fixes #18281

* Update synchroncization fixture assertions

When we started operating on a copy of the task args the test assertions
were no longer asserting things about the munged state but of the
pristine state. Convert the copy of task args to a class member so that
it can be compared against later in testing and update the assertions to
check this munged copy.
* Shuffle objects around for cleaner testing

Attach the temporary args dict to the task rather than the action as
this makes updating the existing tests cleaner.
2016-12-12 13:33:30 -08:00
ikelos
9e5d4de49a Fix overwrite parameter in module_utils.junos (#18671)
The overwrite parameter is forcibly set to false, meaning a module
passing that parameter will have no effect.  The overwrite facility
is necessary to ensure that conflicting options can be written the
configuration (which, in replace mode, they cannot).

This change ensures that if overwrite is set, it will not be changed
to False in the logic.
2016-12-12 15:57:29 -05:00
Patrick Ogenstad
05e5474c52 Disable CLI errors when typing enable (#18531) 2016-12-12 15:55:22 -05:00
Juan Antonio Valiño García
40ddbe026d Fixes #18663. Bad handling of existing config in dellos9 module. (#18664)
* Fixes #18663. Bad handling of existing config in dellos9 module.

The dellos9 module doesn't build correctly the internal
structures used to represent the existing config of the managed
network device. This leads to apply changes every time the
playbook is run, even if the existing config is the same that the
one you are trying to push into the device.

Probably this problem exist also in the dellos6 and dellos10
modules, but I only fixed it in the dellos9 module.

The fix modifies two methods. The first one is `get_config`,
where the return clause didn't work correctly when the flow
doesn't enter in the `if` block. In that case the `contents`
variable is not an array an this should be handled.

The second fix is in the `get_sublevel_config` method. In this
case the indentation whitespaces of the parents should be rebuild
because further functions and methods required it to handle
correctly comparisons used to check if changes should be pushed
into device.

* Fixes #18663 for dellos10 module with the same patches as dellos9.
2016-12-12 15:51:32 -05:00
Matt Clay
43785aa246 Add --all option to ansible-doc. 2016-12-12 12:16:29 -08:00
Nehal J Wani
ead0022255 Open temp file only once
mkstemp() returns a tuple containing an OS-level handle to an open file
(as would be returned by os.open()) and the absolute pathname of that
file, in that order.

This patch makes sure that the fd opened by tempfile.mkstemp() is
re-used and closed properly.
2016-12-12 10:11:46 -08:00
Fabio Alessandro Locati
470d1e3aea Remove unused quotes (#19207) 2016-12-12 14:07:03 +00:00
Fabio Alessandro Locati
4b9a65fd7c Improve quotes - notification/hall.py (#19166) 2016-12-11 22:16:42 +00:00
Fabio Alessandro Locati
64e4c2798c Improve quotes - notification/nexmo.py (#19168) 2016-12-11 22:14:15 +00:00
Fabio Alessandro Locati
5e9b763937 Remove useless quotes - notification/sns.py (#19169) 2016-12-11 22:14:00 +00:00
Fabio Alessandro Locati
3d15f622b0 Always run on localhost - notification/rocketchat.py (#19170) 2016-12-11 22:13:40 +00:00
Fabio Alessandro Locati
cf5424e165 Remove useless quotes - monitoring/statusio_maintenance.py (#19173) 2016-12-11 20:00:11 +00:00
Kevin Burke
114e3cb7a4 Fix typos in git.py (#19186) 2016-12-11 17:17:05 +01:00
Evan Kaufman
aaf13e07fe Handle byte/string conversion on read/write with text module_utils (#19188)
Fixes ansible/ansible-modules-core#5840, moved from ansible/ansible-modules-core#5847
2016-12-11 09:00:01 +01:00
Vlad Glagolev
45b2f4b479 Source Mage GNU/Linux package manager support (#19072)
* added alpha version of the 'sorcery' module

* fully conforming YAML

* use bundled check for executables

* - codex_list(): use commands instead of checksums to get sorcery version and verify codex equality - renamed: - manage_depends() -> match_depends() - tocast -> cast_queue, todispel -> dispel_queue, needs_recast -> depends_ok - SORCERY_LOG -> SORCERY_LOG_DIR, SORCERY_STATE -> SORCERY_STATE_DIR - removed: - SORCERY_VERSION_FILE - CODEX - added commentary to match_depends() and manage_spells() - fixed bug about dropped dependency line for previously existed dependency - fixed bug about not fixing depends for the 'latest' state - simplified several code constructions

* cleaned up some docs

* do not use separate message for Codex update, rely on the 'changed' status instead

* use built-in list conversion (_check_type_list()) for spells

* corrected spell name extraction from list in match_depends()

* avoid non-matching dependencies line duplication in depends file

* added more complex playbook example

* tiny stylistic fix for docs

* replaced ternary construction with a regular statement

* replaced yet another ternary construction with a regular statement

* enable Python 2.4 compatibility by splitting try-finally block

* enable Python 2.4 compatibility by replacing 'with' statement with try-except+try-finally blocks

* unify spells' assign

* replaced one regex with startswith()

* go Ansible 2.1

* added dummy RETURN template

* go Ansible 2.2

* better clarify permissions' requirements

* - updated copyright years - fixed rebuild command bug - re-used run_command_environ_update dict for env var management

* handle Python 3.5

* Revert "handle Python 3.5"

This reverts commit 33a5a0eb64c1193318298e111f063cdd5f93b73a.

* handle Python 3.5 (2nd try)

* go Ansible 2.3

* clarity++
2016-12-10 16:38:15 -05:00
Fabio Alessandro Locati
4bfb83c966 Native YAML - notification/mqtt.py (#19164) 2016-12-10 11:44:59 -08:00
Alexandre Garnier
0f7abad38f Fix python 2.4 compatibility
`start` keyword of `enumerate` is only available since python 2.6
2016-12-10 11:06:11 -08:00
Chris Houseknecht
65491cc839 For docker add --blocking-io only when missing (#19171) 2016-12-10 10:51:03 -05:00
Irina Muchnik
9f58e69d63 Fix secure temp file creation (#19096)
* For realz this time

* Fix tempfile.mkstemp (#2)

* back to square one, removing temp file from the mix

* Adding temp back

* Adding tuple  back

* Adding another tuple back

* Trying to get around weird Jenkins behavior of blowing up when both .hpi and jpi file found

* Incorporating PR feedback

* Delete .hpi file instead of backing it up, some basic clean up

* Moving file deletion to the right location

* Blank lines. They always get me.
2016-12-10 09:33:34 -05:00
Fabio Alessandro Locati
2adde7a6d1 Remove unused quotes - notification/pushbullet.py (#19149) 2016-12-10 09:29:02 -05:00
Fabio Alessandro Locati
c3887138c5 Remove unused quotes (#19150) 2016-12-10 09:28:38 -05:00
Fabio Alessandro Locati
261fad8fee Remove unused quotes - notification/hipchat.py (#19151) 2016-12-10 09:28:15 -05:00
Fabio Alessandro Locati
617e82fe8c Remove unused quotes - notification/twilio.py (#19152) 2016-12-10 09:27:56 -05:00
Fabio Alessandro Locati
e788f13956 Remove unused quotes - files/unarchive.py (#19155) 2016-12-10 09:27:35 -05:00
Fabio Alessandro Locati
90a698c367 Remove unused quotes - notification/rocketchat.py (#19156) 2016-12-10 09:25:25 -05:00
Fabio Alessandro Locati
372352f35d Remove unused quotes - web_infrastructure/deploy_helper.py (#19157) 2016-12-10 09:24:36 -05:00
Fabio Alessandro Locati
e32b0da0b0 Improve examples - monitoring/logicmonitor_facts.py (#19158) 2016-12-10 09:24:13 -05:00
Fabio Alessandro Locati
a8fa008bbe Remove unused quotes - source_control/github_hooks.py (#19159) 2016-12-10 09:23:19 -05:00
Fabio Alessandro Locati
b42cda4dd2 Remove deprecated example (#19161) 2016-12-10 09:21:25 -05:00
Chris Houseknecht
b02491ba70 Add --blocking-io option when docker connection (#19140) 2016-12-10 09:20:35 -05:00
Rene Moser
b1ea79af51 cloudstack: cs_role: doc fixes. 2016-12-10 11:40:30 +01:00
René Moser
a8fc8249b4 cloudstack: new module cs_role (#19134) 2016-12-10 10:33:05 +01:00
Matt Clay
2cb6a10a0e Fix module names in module docs. 2016-12-09 18:13:57 -07:00
Matt Clay
cd47cb2a15 Remove remnants of obsolete fireball mode. 2016-12-09 16:56:34 -07:00
Matt Clay
ac7edef2be Fix modules with documentation errors. 2016-12-09 16:08:26 -07:00
Fabio Alessandro Locati
9a075b5917 Avoid using an object if it does not exists (#19058) 2016-12-09 17:36:39 -05:00
Fabio Alessandro Locati
28a12e8b27 Use dbus only if it is present (#19060) 2016-12-09 17:35:55 -05:00
Fabio Alessandro Locati
3b509b1095 Avoid extending a class if it does not exists (#19059) 2016-12-09 17:31:07 -05:00
Kash
6b1586748f Fixes #4538 passing int params as required by boto (#18999) 2016-12-09 14:39:02 -05:00
Yury V. Zaytsev
395b59ea6c Update ec2_vpc_peer.py (#19069)
Document `peering_id` module parameter.
2016-12-09 11:24:48 -05:00
José Sabater Montes
66ced41485 Add new Amazon EBS volume types. Fixes issue 4041 of ansible-modules-core 2016-12-09 10:27:54 -05:00
Adam Chainz
0b8aada1bc Cloudformation - allow re-using an existing template (#19009)
* Allow re-using an existing template when updating a stack by not passing 'template' or 'template_url'. This is a big one for me as our deploy process creates a new stack and then modifies the old one; to avoid changing the resources inside the old one, we have had to avoid using the Ansible module and use the AWS CLI instead in order to pass `--use-previous-template`.
* Split create and update logic into separate functions
* Remove dead `update` variable
2016-12-09 10:24:10 -05:00
Maarten Bezemer
7b4eb078c6 Leave current secutiry groups as-is if not provided (#19043) 2016-12-09 10:21:16 -05:00
Tom Paine
1d80f5cf0f Update ec2_group.py (#19033)
PR move of https://github.com/ansible/ansible-modules-core/pull/3588

##### ISSUE TYPE
- Docs Pull Request

##### COMPONENT NAME
ec2_group.py

##### ANSIBLE VERSION

```
ansible 2.0.2.0
  config file = /Users/tpai/src/cm-secure/ansible.cfg
  configured module search path = Default w/o overrides
```
##### SUMMARY

Make it clear you can specify the created group in the rules list, allowing idempotent use for group<->group networking rules.

This is a really useful feature that isn't obvious enough in the docs.
2016-12-09 10:11:17 -05:00
Andy Freeland
cb9b5ab146 Include volume encryption status in 'ec2_vol_facts' module (#19017) 2016-12-09 10:01:13 -05:00
Fabio Alessandro Locati
ea46d5548b Native YAML - cloud/softlayer/sl_vm.py (#19056)
* Native YAML - cloud/softlayer/sl_vm.py

* Pointless to delegate/localaction, since we are already running on localhost
2016-12-09 09:11:31 -05:00
Fabio Alessandro Locati
ee27c688fd Unquote strings that do not need quotes and retab - clustering/consul.py (#18834) 2016-12-09 08:49:43 -05:00
Fabio Alessandro Locati
b811350f00 Native YAML - web_infrastructure/jira.py (#18832) 2016-12-09 08:48:59 -05:00
Fabio Alessandro Locati
21940f8c8e Remove unneeded quotes - source_control/bzr.py (#18825) 2016-12-09 08:48:15 -05:00
Fabio Alessandro Locati
19f0b5f1cc Remove unneeded quotes - notification/slack.py (#18826) 2016-12-09 08:46:27 -05:00
Fabio Alessandro Locati
6c06aeb792 Explicitally add the state - system/authorized_key.py (#18837) 2016-12-09 08:40:16 -05:00
Fabio Alessandro Locati
464e1b6a5a Improve the dependency on univention (aka: declare it and fail nicely if it is not present) (#18840) 2016-12-09 08:39:40 -05:00
Fabio Alessandro Locati
60f6bab430 Remove x bit - windows/win_copy.py (#18824) 2016-12-09 08:30:27 -05:00
Fabio Alessandro Locati
013722d974 Inline attays (#19061) 2016-12-09 06:00:34 -05:00
Fabio Alessandro Locati
e5bc2e0570 Put spaces between graphs and var name (#19063) 2016-12-09 05:59:50 -05:00
Andy Freeland
72310ff3e8 Fix wait parameter in ec2 module docs (#19037)
Fixes #18913.
2016-12-09 05:51:43 -05:00
Fabio Alessandro Locati
2b47246e94 Native YAML - source_control/gitlab_user (#19053) 2016-12-09 05:49:00 -05:00
Fabio Alessandro Locati
ba22514d47 Native YAML - source_control/gitlab_group (#19054) 2016-12-09 05:48:33 -05:00
Fabio Alessandro Locati
503f4c48db Inline array in example (#19055) 2016-12-09 05:48:03 -05:00
Fabio Alessandro Locati
3fa1ddc9db Native YAML - source_control/gitlab_project (#19062)
* Native YAML - source_control/gitlab_project

* Use example domain as for RFC2606
2016-12-09 05:44:43 -05:00
René Moser
345e39e1b1 cloudstack: cs_instance: fix userdata not up to date (#18942)
Fixes unnecessary VM restart.

VM userdata is currently not returned by the API listVirtualMachine and task will always be marked as changed in has_changed(), which will result in an unnecessary VM restart if force=true.

Reported by @Mayeu
2016-12-09 07:03:18 +01:00
Matt Clay
1da20c9716 Clean up issue templates. (#19011)
* Remove legacy GitHub templates.
* Remove references to module repos.
2016-12-08 17:18:30 -05:00
Matt Clay
c709b22e5c Fix differences with devel. 2016-12-08 11:35:21 -05:00
James Cammarata
fa5386c488 Some additional module cleanup of mistakes made during merging 2016-12-08 11:35:20 -05:00
James Cammarata
6ba6819446 Re-adding the init py for modules 2016-12-08 11:35:20 -05:00
Matt Davis
cb1888125d add metadata to doc support (#18802)
fix broken module docs
change doc AST id extraction to use == instead of in
2016-12-08 11:35:20 -05:00
Fabio Alessandro Locati
c786f7ca3c Native YAML - monitoring/logicmonitor.py (#18790)
* Native YAML - monitoring/logicmonitor.py

* Fix comments as well

* Fix quotes
2016-12-08 11:35:20 -05:00
Matt Clay
851b264fb0 Add missing znode module description. 2016-12-08 11:35:20 -05:00
Fabio Alessandro Locati
f5da520bbb Consistency in space between parenthesys (#18796) 2016-12-08 11:35:20 -05:00
Fabio Alessandro Locati
f8832bf302 Native YAML - monitoring/boundary_meter (#18791)
* Native YAML - monitoring/boundary_meter

* Fix apikey
2016-12-08 11:35:19 -05:00
Fabio Alessandro Locati
327cff7274 Native YAML - monitoring/pagerduty_alert (#18784) 2016-12-08 11:35:19 -05:00
Toshio Kuratomi
df9059936b Metadata Status needs to be a list, not a scalar.
The default metadata was specified with a string "preview" instead of
the list ["preview"].
2016-12-08 11:35:19 -05:00
James Cammarata
14833f1c7a A few more organizational cleanups from the repo merge 2016-12-08 11:35:19 -05:00
James Cammarata
011ea55a8f Relocating extras into lib/ansible/modules/ after merge 2016-12-08 11:35:18 -05:00
James Cammarata
c65ba07d2c Cleaning up diffs after extras modules merge 2016-12-08 11:35:18 -05:00
Toshio Kuratomi
2cfa25c930 Add metadata for xbps
Pass pyflakes
2016-12-08 11:35:18 -05:00
James Cammarata
d2fc24b771 Removing unnecessary files before repo merge 2016-12-08 11:35:18 -05:00
Toshio Kuratomi
bd12c4bfe7 Refreshed metadata for extras modules 2016-12-08 11:35:18 -05:00
Ryan S. Brown
92588923f4 Style fix for xbps module 2016-12-08 11:35:18 -05:00
Dino Occhialini
3821ea020f Add XBPS module (#1749)
Adds xbps module for managing Void Linux packages.

Currently supports:
* Installation
* Removal
* Updating Specific Packages
* Updating All Packages
* Updating package cache
2016-12-08 11:35:18 -05:00
Slezhuk Evgeniy
867c85af05 Add 'link' action to jira module 2016-12-08 11:35:17 -05:00
Ben Tomasik
62acd6286f Add check mode support (#3523) 2016-12-08 11:35:17 -05:00
0livd
ff4deba55d Fetch vmid from the ProxmoxAPI when not set (#3591)
The vmid is no longer a required parameter
For the 'present' state:
 If not set, the next available one will be fetched from the API
For the 'started', 'stopped', 'restarted' and 'absent' states:
 If not set, the module will try to fetch it from the API based on the hostname
Inspired from the behavior of the proxmox_kvm module
2016-12-08 11:35:17 -05:00
Fabian Krämer
320ae068ed Allow Datadog monitors to be retrieved by id instead of name. (#3456) 2016-12-08 11:35:17 -05:00
David Stygstra
5454c562e9 Fix #3410 (#3411)
A port with the same name as the bridge is implicitly created for every
bridge, but it doesn't show in in `ovs-vsctl list-ports BRIDGE`.
2016-12-08 11:35:17 -05:00
MDCollins
7d8d830aee Update the status codes to look for (#2120)
Creation of a maintenance window returns a 201 (PagerDuty Developer documentation is unfortunately incorrect). Deleting a maintenance window returns a 204.
2016-12-08 11:35:17 -05:00
Colin Walters
5bfbeadca3 yum_repository: use https:// for EPEL examples (#3464)
This whole module is really lacking in security guidelines, but
downloading RPMs via plain `http://` without gpg is quite bad.  Let's
use `https://` for the EPEL examples for a start.
2016-12-08 11:35:17 -05:00
Arthur
9513388819 Update route53_zone.py fix indentation typo in examples (#3255) 2016-12-08 11:35:17 -05:00
Bill Wang
246ce5aa85 improve example for module ec2_vpc_subnet_facts (#3511) 2016-12-08 11:35:17 -05:00
Ondra Machacek
937117d871 Add oVirt ovirt_permissions and ovirt_permissions_facts modules (#3160) 2016-12-08 11:35:17 -05:00
Ondra Machacek
1d7c2eb00d Add oVirt ovirt_external_providers and ovirt_external_providers_facts modules (#3168) 2016-12-08 11:35:17 -05:00
Ondra Machacek
995ac40e8e Add oVirt ovirt_vmpools and ovirt_vmpools_facts modules (#3171) 2016-12-08 11:35:17 -05:00
Ondra Machacek
55274a4eec Add oVirt ovirt_quotas and ovirt_quotas_facts modules (#3172) 2016-12-08 11:35:17 -05:00
Ondra Machacek
f6e257201c Add oVirt ovirt_nics and ovirt_nics_facts modules (#3205) 2016-12-08 11:35:17 -05:00
Ondra Machacek
489272890a Add oVirt ovirt_templates and ovirt_templates_facts modules (#3221) 2016-12-08 11:35:17 -05:00
Ondra Machacek
42737bc7c3 Add oVirt ovirt_storage_domains and ovirt_storage_domains_facts modules (#3222) 2016-12-08 11:35:16 -05:00
Ondra Machacek
190357e51f Add oVirt ovirt_vms_facts module (#3226) 2016-12-08 11:35:16 -05:00
Ondra Machacek
1057c2f89d ovirt_vms: Add new cloud_init_nics parameter (#3557) 2016-12-08 11:35:16 -05:00
Ondra Machacek
370d8332ae Add oVirt ovirt_affinity_labels and ovirt_affinity_labels_facts modules (#3570) 2016-12-08 11:35:16 -05:00
Ondra Machacek
6ade61a3ba Add oVirt users/groups and users_facts/group/facts modules (#3153) 2016-12-08 11:35:16 -05:00
Ondra Machacek
77c3868670 Add ovirt_networks and ovirt_networks_facts modules (#3148) 2016-12-08 11:35:16 -05:00
Ondra Machacek
68e83bba91 Add ovirt_datacenters and ovirt_datacenters_facts modules (#3146) 2016-12-08 11:35:16 -05:00
Ondra Machacek
c12b705df8 Add ovirt_clusters and ovirt_clusters_facts modules (#3138)
* Add ovirt_clusters and ovirt_clusters_facts modules

* Add return values examples

* Improve documentation

* Added all cluster parameters
2016-12-08 11:35:16 -05:00
Krzysztof Magosa
c385c6746a kubernetes: handle situation when target host does not have yaml library (fixes #3301) (#3449) 2016-12-08 11:35:16 -05:00
Ondra Machacek
32c7f1eae7 Add new ovirt_mac_pools module (#3646)
This patch adds new module to manage oVirt MAC pools.
2016-12-08 11:35:16 -05:00
Constantin
4bdbbed49c Fix: convert owner_ids to a list of strings (#3488) 2016-12-08 11:35:16 -05:00
Ben Tomasik
163f16658e Add check mode support (#3522) 2016-12-08 11:35:16 -05:00
Tristan de Cacqueray
8a02b5d702 Use parameters in os_stack update (#3560)
This change makes os_stack module idempotent. Otherwise, re-use of the
module fails with:
Error updating stack: ERROR: The Parameter (...) was not provided.

Fixes #3165.
2016-12-08 11:35:16 -05:00
Fabio Alessandro Locati
7a2d1a4210 Make main() calls conditional - commands (#3655) 2016-12-08 11:35:16 -05:00
Fabio Alessandro Locati
cefb569797 Make main() calls conditional - messaging (#3654) 2016-12-08 11:35:16 -05:00
Fabio Alessandro Locati
6f019c1066 Make main() calls conditional - web_infrastructure (#3653) 2016-12-08 11:35:16 -05:00
Fabio Alessandro Locati
cbe3f4e5e1 Make main() calls conditional - system (#3652) 2016-12-08 11:35:15 -05:00
Fabio Alessandro Locati
45b31fa514 Make main() calls conditional - source_control (#3651) 2016-12-08 11:35:15 -05:00
Fabio Alessandro Locati
007abb5373 Make main() calls conditional - packaging (#3650) 2016-12-08 11:35:15 -05:00
Fabio Alessandro Locati
95be8b8276 Make main() calls conditional - network (#3649) 2016-12-08 11:35:15 -05:00
Fabio Alessandro Locati
9f7ad2ca3b Conditional main - monitoring (#3648) 2016-12-08 11:35:15 -05:00
Fabio Alessandro Locati
e788ce068a Make main() calls conditional - clustering (#3647) 2016-12-08 11:35:15 -05:00
Fabio Alessandro Locati
96780cf035 Make main() calls conditional - notifications (#3656) 2016-12-08 11:35:15 -05:00
Fabio Alessandro Locati
afa6fa9a89 Make main() calls conditional - cloud (#3657) 2016-12-08 11:35:15 -05:00
Fabio Alessandro Locati
11e3ec26ea Make main() calls conditional - files (#3658) 2016-12-08 11:35:15 -05:00
Fabio Alessandro Locati
06bf2e1e63 Make main() calls conditional - database (#3659) 2016-12-08 11:35:15 -05:00
Ondra Machacek
103e3341f5 ovirt_vms: Add support to specify template version (#3567) 2016-12-08 11:35:15 -05:00
René Moser
3c48b4a7a1 cloudstack: cs_ip_address: implement VPC support (#3403) 2016-12-08 11:35:15 -05:00
René Moser
93ebe0f7c1 cloudstack: cs_staticnat: implement VPC support (#3409) 2016-12-08 11:35:15 -05:00
Fabio Alessandro Locati
7d1a006629 Native YAML, improve quotation (#3643) 2016-12-08 11:35:15 -05:00
Fabio Alessandro Locati
8b31d48410 Native YAML - monitoring/sensu_check (#3635) 2016-12-08 11:35:14 -05:00
Fabio Alessandro Locati
3b5826b828 Native YAML - monitoring/datadog_event (#3637) 2016-12-08 11:35:14 -05:00
Fabio Alessandro Locati
616752c2e3 Correct indentation in examples - files/blockinfile.py (#3630)
* indentation in with_items section is out, correct that.
2016-12-08 11:35:14 -05:00
Matthew Krupcale
a6f0a279a9 FreeIPA module polymorphic restructuring and small fixes. (#3485)
* Moved JSON-RPC client IPAClient class to ansible.module_utils.ipa, which is extended by all ipa modules
* ipa_user: incorporate displayname and userpassword attributes in module_user
* ipa_user: capitalized "I" in comment
* ipa_user: updated get_ssh_key_fingerprint to include possibility of the uploaded SSH key including user@hostname comment, which also appears in the queried fingerprint. This fixes a mismatch in the calculated and queried SSH key fingerprint in the user_diff calculation when the user already exists.
* ipa_hbacrule: ipaenabledflag must be 'TRUE' or 'FALSE', not 'NO'
* ipa_sudorule: ipaenabledflag must be 'TRUE' or 'FALSE', not 'NO'
* Add author to files missing it
2016-12-08 11:35:14 -05:00
Fabian von Feilitzsch
92a53a7182 Check values for vm_id and vm_names instead of keys (#3621) 2016-12-08 11:35:14 -05:00
Jon Hawkesworth
50deb312fe Fix documentation error on read message from file example. 2016-12-08 11:35:14 -05:00
Fabio Alessandro Locati
2ea57deb72 Native YAML - cloud/centurylink/clc_loadbalancer.py (#3632) 2016-12-08 11:35:14 -05:00
Fabio Alessandro Locati
cc25f24475 Native YAML - system (#3625)
* Native YAML - system

* Remove comment that is not applicable to the code
2016-12-08 11:35:14 -05:00
Fabio Alessandro Locati
737c6afb54 Native YAML - database/misc/mongodb_user.py (#3631) 2016-12-08 11:35:14 -05:00
Fabio Alessandro Locati
cd54cd973a Native YAML - cloud/amazon/lambda.py (#3628) 2016-12-08 11:35:14 -05:00
Fabio Alessandro Locati
723556fc98 Native YAML - notification leftovers (#3626) 2016-12-08 11:35:14 -05:00
Fabio Alessandro Locati
2f369dff88 Native YAML - cloud/misc (#3615)
* Native YAML - cloud/misc

* Fix mistake
2016-12-08 11:35:14 -05:00
Fabio Alessandro Locati
75f9cb30e1 Add quotes for non-floats decimals (#3609) 2016-12-08 11:35:14 -05:00
Fabio Alessandro Locati
d9231d065e Native YAML - cloud/openstack (#3614) 2016-12-08 11:35:14 -05:00
Fabio Alessandro Locati
fb2ddac407 Native YAML - database/postgresql/postgresql_ext (#3617) 2016-12-08 11:35:14 -05:00
Fabio Alessandro Locati
c284125e66 Native YAML - cloud/serverless (#3618) 2016-12-08 11:35:13 -05:00
Fabio Alessandro Locati
d11a5bd492 Native YAML - windows (#3602)
* Native YAML - windows

* Fix baskslash

* Sorry
2016-12-08 11:35:13 -05:00
Fabio Alessandro Locati
684045a316 Fix spacing (#3616) 2016-12-08 11:35:13 -05:00
Fabio Alessandro Locati
4561c75d1c Normalize YAML - Cloud/VMWare (#3612) 2016-12-08 11:35:13 -05:00
Fabio Alessandro Locati
1a7b9090df Native YAML - cloud/cloudstack (#3613) 2016-12-08 11:35:13 -05:00
Fabio Alessandro Locati
00eb0d27d9 Cloud lxc (#3611)
* Native YAML - cloud/lxc

* debug var uses naked vars
2016-12-08 11:35:13 -05:00
Fabio Alessandro Locati
1e9333f822 Cloud amazon and azure (#3610)
* Native YAML - cloud/amazon

* Native YAML - cloud/azure
2016-12-08 11:35:13 -05:00
Fabio Alessandro Locati
06a8f1d79b Use native YAML - Packaging (#3588)
* Fix kibana

* More native YAML

* More native YAML

* More native YAML

* More native YAML. Now only languages/ is missing

* Use native yaml sintax for packaging/languages as well

* Some more and quote fixes

* Fix wrong grouping
2016-12-08 11:35:13 -05:00
Fabio Alessandro Locati
d344d7863a Native YAML - files (#3608) 2016-12-08 11:35:13 -05:00
Fabio Alessandro Locati
47442b7c22 Native YAML - databases/pgsql (#3606) 2016-12-08 11:35:13 -05:00
Fabio Alessandro Locati
51798cba0e Native YAML - Databases/mysql (#3605) 2016-12-08 11:35:13 -05:00
Fabio Alessandro Locati
13b970d04b Native YAML - Databases/MsSQL (#3604) 2016-12-08 11:35:13 -05:00
Fabio Alessandro Locati
7ac053576e Native YAML - Database/musc (#3603) 2016-12-08 11:35:13 -05:00
Fabio Alessandro Locati
fb50f129ea Native YAML - remote_management (#3601) 2016-12-08 11:35:13 -05:00
Fabio Alessandro Locati
8a6df38cc5 Native YAML - messaging (#3599) 2016-12-08 11:35:12 -05:00
Fabio Alessandro Locati
5209969a7c Native YAML - Web infrastructure (#3594)
* Native YAML

* YAML for jira as well

* Native YAML for Jboss

* Fix missing spaces
2016-12-08 11:35:12 -05:00
Dag Wieers
367a0c5d99 Bugfix for newer policycoreutils-python (eg. RHEL7) (#3569)
The policycoreutils python API for RHEL6 and RHEL7 are sufficiently
different, requiring some additional definitions and specific conversion
that works on old and new implementations.

It also implements a fix for non-ascii error messages (like when using a
French locale configuration).

This fixes #3551.
2016-12-08 11:35:12 -05:00
Shinichi TAMURA
335a28443d timezone: Fix TypeError
closes #3337
2016-12-08 11:35:12 -05:00
Fabio Alessandro Locati
75563d5325 Native YAML - notifications (#3598) 2016-12-08 11:35:12 -05:00
Fabio Alessandro Locati
951b87492a Native YAML (#3596) 2016-12-08 11:35:12 -05:00
Fabio Alessandro Locati
f4a4492992 bigpanda: Use delegate_to (over local_action) (#3586)
* Fix YAML, naed variables

* Fix spaces
2016-12-08 11:35:12 -05:00
Fabio Alessandro Locati
f8f0893922 Native YAML (#3583) 2016-12-08 11:35:12 -05:00
Fabio Alessandro Locati
cb1b8edfa9 Native YAML - Network (#3587)
* Fix citrix native yaml

* Fix snmp native yaml and connectio

* Fix more native syntax

* More native syntax

* Fix openvswitch native syntax

* More YAML code !

* More fixes

* Improve nmcli
2016-12-08 11:35:12 -05:00
Fabio Alessandro Locati
d092d53198 Native YAML (#3584) 2016-12-08 11:35:12 -05:00
Fabio Alessandro Locati
b6cf2e422d Native YAML + add comments (#3582) 2016-12-08 11:35:12 -05:00
Fabio Alessandro Locati
c40bb574c6 Native YAML (#3581) 2016-12-08 11:35:12 -05:00
Fabio Alessandro Locati
f85fd14242 Native YAML (#3580) 2016-12-08 11:35:12 -05:00
Fabio Alessandro Locati
c2474b8a3f Native YAML (#3579) 2016-12-08 11:35:12 -05:00
Fabio Alessandro Locati
23cfa31a7b Native YAML (#3578) 2016-12-08 11:35:12 -05:00
John R Barker
1684792efa nagios - Better comment: example (#3595) 2016-12-08 11:35:12 -05:00
Fabio Alessandro Locati
45c55607f1 Native YAML (#3577) 2016-12-08 11:35:11 -05:00
Fabio Alessandro Locati
79e1e01e4c Native YAML (#3576) 2016-12-08 11:35:11 -05:00
Fabio Alessandro Locati
9a399d9945 Native YAML (#3575) 2016-12-08 11:35:11 -05:00
Fabio Alessandro Locati
ccb9cb38d9 Native YAML (#3574) 2016-12-08 11:35:11 -05:00
Fabio Alessandro Locati
53448af053 Native YAML (#3573) 2016-12-08 11:35:11 -05:00
Fabio Alessandro Locati
dfb6861a94 Native YAML (#3593) 2016-12-08 11:35:11 -05:00
Fabio Alessandro Locati
34a504ea10 Native YAML (#3585)
* Native YAML

* Fix YAML lists
2016-12-08 11:35:11 -05:00
dimid
0c320e1c17 Fix name/package parameter convert when passed list of values using with_items. (#3556) 2016-12-08 11:35:11 -05:00
René Moser
c3c2427cbb cloudstack: new module cs_region (#3568) 2016-12-08 11:35:11 -05:00
Fabio Alessandro Locati
aef588f3a3 Use native YAML (#3440)
* Use native YAML

* Add comment on quotes and column
2016-12-08 11:35:11 -05:00
Dorian Dietzel
1f32d68310 Added new option to select the active a10 partition (#2628)
* Added new option to select the active a10 partition

* added version_added to the description of the new option

* added RETURN documentation

* fixed indents

* Removed empty cases, removed unneeded aliases

* removed artifacts from merging

* updated version_added to 2.3

* removed host, username and password option

* removed write_config and validate_certs documentation
2016-12-08 11:35:11 -05:00
Aaron Chen
fa4b353da8 elasticsearch-plugin: fix local variable 'name' referenced before assignment (#3431) 2016-12-08 11:35:11 -05:00
Toshio Kuratomi
82475637ef Remove iteritems from portage module for python3 2016-12-08 11:35:11 -05:00
William L. Thomson Jr
e95641f371 Portage module improvements (#3520)
* packaging/os/portage.py: Added portage parameter --keep-going

* packaging/os/portage.py: Added portage parameter --load-avg [FLOAT]

* packaging/os/portage.py: Added portage parameter --jobs[=INT]

* packaging/os/portage.py: Added myself to Authors
2016-12-08 11:35:11 -05:00
Matt Clay
380ce0c3a7 Fix ast parse issue for python 2.6. 2016-12-08 11:35:11 -05:00
Jesse Keating
f6e47e4055 Handle empty datadog_monitor message (#3468)
Since message is not required, it may be of type None, which cannot have
a replace() called on it.
2016-12-08 11:35:10 -05:00
John R Barker
7e6fe97f57 Update version_added, update docs (#3542)
k: v in docs now

Minor tweaks after https://github.com/ansible/ansible-modules-extras/pull/1883
2016-12-08 11:35:10 -05:00
Dorn-
fb610b7d07 Add a new module to handle schema with postgres (#1883) 2016-12-08 11:35:10 -05:00
Eric Chou
c570d533b9 add a10_server_axapi3 module (#3239)
* add a10_server_axapi3 module

* added return documentation

* modified a10_server_axapi3.py per feedback

* fixed line 60 s/action/operation/

* modified a10_server_axapi3.py per feedback

* modified a10_server_axapi3.py per feedback

* corrected YAML format error in documentation

* removed slp_server_ip and slp_server check in code since the arguments are labeled as required, per feedback

* 	modified:   a10_server.py
	modified:   a10_service_group.py
	modified:   a10_virtual_server.py

Changed main() block, restricted import to only functions used.

* removed space for main() to be last line

* removed invalid lines

* Modified Documentations for a10_server.py, a10_service_group.py, a10_virtual_server.py

* Take out alias:[] and choices:[] in Documentation from a10_service_group.py and a10_virtual_server.py since they are now the default

* deleted a10_server.py, a10_service_group.py, a10_virtual_server.py

* deleted 'version_last_modified' line in Documentation across a10_server.py, a10_service_group.py and a10_virtual_server.py as they were added in error, change validate_certs version_added in a10_server.py

* added newline after main()

* added newline after main() for a10_server_axapi3.py
2016-12-08 11:35:10 -05:00
Alexey Kostyuk
d1304eb749 Add ipinfoio_facts module (#3497)
* Add ipinfoio_facts module

* Updated ipinfoio_facts module docs
2016-12-08 11:35:10 -05:00
Andrea Tartaglia
a6c0227a8f py3 - ported ec2_vpc_route_table iterkeys to dict.keys() (#3503)
* ported ec2_vpc_route_table iterkeys to dict.keys() for py3

Addresses ansible/ansible#18507

* Removed '.keys()'
2016-12-08 11:35:10 -05:00
René Moser
5374c7cd09 cloudstack: cs_instance: implement vpc support (#3402)
* cloudstack: cs_instance: implement vpc support

* cloudstack: cs_instance: distinguish VPC and non VPC VMs
2016-12-08 11:35:10 -05:00
René Moser
46e1380532 cs_snapshot_policy: extend volume determination (#3500) 2016-12-08 11:35:10 -05:00
Saravanan K R
b8a93bcfe1 Update the code fragment contents to have correct format (#3342) 2016-12-08 11:35:10 -05:00
René Moser
3b60cb3847 cloudstack: cs_snapshot_policy: ignore intervaltype in has_changed (#3499)
Fixes ValueError: invalid literal for int() with base 10: 'daily'
2016-12-08 11:35:10 -05:00
Ryan Brown
5940c705a3 Create serverless module for handling Serverless Framework deploys (#3352)
* Create `serverless` module for handling deploys on the Serverless Framework

* fix interpreter line

* Successfully exit when a stage is already absent
2016-12-08 11:35:10 -05:00
Jiri Tyr
c7ae273f13 Making yum_repository module compatible with Python 3 (#3487) 2016-12-08 11:35:10 -05:00
Ondra Machacek
36f1ecc5be Add oVirt ovirt_hosts and ovirt_storage_hosts_facts modules (#3225) 2016-12-08 11:35:10 -05:00
Ondra Machacek
b4716df3ef Add oVirt ovirt_host_networks modules (#3227) 2016-12-08 11:35:10 -05:00
Ondra Machacek
7da62366ed Add oVirt ovirt_host_pm module (#3253) 2016-12-08 11:35:10 -05:00
Berislav Lopac
7f351a46e5 replace iteritems with items to ensure python3 compatibility 2016-12-08 11:35:10 -05:00
Andy Dirnberger
3a26a1bfcc Make Homebrew-related modules run on Python 3
Both the `homebrew` and `homebrew_cask` modules iterate over
dictionaries using `iteritems`. This is a Python 2-specific method whose
behavior is similar to `items` in Python 3+. The `iteritems` function in
the six library was designed to make it possible to use the correct
method.
2016-12-08 11:35:09 -05:00
Michael Scherer
64c994c641 Make the 'make' module run on python 3
Traceback:

    Traceback (most recent call last):
      File \"/tmp/ansible_d28_6uwl/ansible_module_make.py\", line 153, in <module>
        main()
      File \"/tmp/ansible_d28_6uwl/ansible_module_make.py\", line 119, in main
        rc, out, err = run_command(base_command + ['--question'], module, check_rc=False)
      File \"/tmp/ansible_d28_6uwl/ansible_module_make.py\", line 79, in run_command
        return rc, sanitize_output(out), sanitize_output(err)
      File \"/tmp/ansible_d28_6uwl/ansible_module_make.py\", line 95, in sanitize_output
        return output.rstrip(b(\"\\r\\n\"))
    TypeError: rstrip arg must be None or str

There is also a six.iteritems issue, fixed using six.
2016-12-08 11:35:09 -05:00
Rene Moser
583944207d redshift: fix version added 2016-12-08 11:35:09 -05:00
Koki Nomura
8ccf166a56 blockinfile: Fixes #1926 by comparing a marker to a whole line instead of a line prefix (#3339) 2016-12-08 11:35:09 -05:00
Marius Gedminas
cffd5601b6 letsencrypt: Locale-independent date parsing (#3314)
Should fix #3155.
2016-12-08 11:35:09 -05:00
Jiri Tyr
9453f6b97a yum_repository: Add diff support (#3460) 2016-12-08 11:35:09 -05:00
Jens Carl
90e0dc2a89 redshift: Fix error with boolean parameters (#3467) 2016-12-08 11:35:09 -05:00
Matthew Krupcale
cb765ce590 gluster_volume: Fixes gluster peer probe / volume creation issue. (#3486)
* gluster_volume: Fixes issue when creating a new volume failing due to peers not being present. The peers which are not 'localhost' should invoke wait_for_peer, but the find method returns -1 (not 0) on non-localhost peers.
2016-12-08 11:35:09 -05:00
Dag Wieers
c8a700834c Performance improvement using in-operator for hash lookups
Just a small cleanup for the existing occurrences.

Using the in-operator for hash lookups is faster than using .has_key()
http://stackoverflow.com/questions/1323410/has-key-or-in
2016-12-08 11:35:09 -05:00
Dag Wieers
a417a4f4b3 Performance improvement using in-operator on dicts
Just a small cleanup for the existing occurrences.

Using the in-operator for hash lookups is faster than using .keys()
http://stackoverflow.com/questions/29314269/why-do-key-in-dict-and-key-in-dict-keys-have-the-same-output
2016-12-08 11:35:09 -05:00
Nijin Ashok
b06003e5d2 Fix issue in adding RAW disk in block storage domain (#3432)
By default, sparse option is true in ovirt. So the raw disk
    creation in a block storage domain will fail with error "Disk
    configuration (RAW Sparse) is incompatible with the storage domain
    type".

    The commit adds sparse option where it is send as False when
    format is raw and True when format is qcow2
2016-12-08 11:35:09 -05:00
Maarten Bezemer
dd51ec94e7 mongodb_user: Allow pymongo version 3.2 in combination with mongodb 3.2 (#3474) 2016-12-08 11:35:09 -05:00
René Moser
ae9bc0cded cloudtack: cs_instance: doc fix for missing tag alias (#3484) 2016-12-08 11:35:09 -05:00
René Moser
a0c8b598ff cloudstack: fix state=absent, ip_address not None but falsy (#3483) 2016-12-08 11:35:09 -05:00
Abdoul Bah
318a06f6d6 New module proxmox_kvm (#3292)
* New module proxmox_kvm

* fixed qxl value vor vga param

> | Name | Type | Format | Description |
> |------|------|--------|-------------|
> | vga | enum | std \| cirrus \| vmware \| qxl \| serial0 \| serial1 \| serial2 \| serial3 \| qxl2 \| qxl3 \| qxl4 | Select the VGA type. If you want to use high resolution modes (>= 1280x1024x16) then you should use the options 'std' or 'vmware'. Default is 'std' for win8/win7/w2k8, and 'cirrus' for other OS types. The 'qxl' option enables the SPICE display sever. For win* OS you can select how many independent displays you want, Linux guests can add displays them self. You can also run without any graphic card, using a serial device as terminal. |

* Fix create_vm() fail on PV 4.3

* Set default for force as null in doc

* proxmox_kvm: revision fixes

* proxmox_kvm: more revision fixes

* Fix indentation

* revision fixes

* Ensure PEP-3110: Catching Exceptions

* KeyError, to KeyError as -- PEP-3110: Catching Exceptions

* Fix Yaml document syntax; Notes: => Notes -

* Refix documentation issue

* Fix Documentation

* Remove Notes: in description

* Add current state and it return value

* Update documentation

* fixed local variable 'results' referenced before assignment

* Fix fixed local variable 'results' referenced before assignment

* minor fixes in error messages

* merge upstream/devel int devel

* minor fixes in error messages

* Fix indentation and documentation

* Update validate_certs description
2016-12-08 11:35:09 -05:00
Brian Haggard
84e79770b3 Required and default are mutually exclusive (#3475) 2016-12-08 11:35:09 -05:00
René Moser
72eb8c7be9 ipify_facts: implement timeout (#3369) 2016-12-08 11:35:08 -05:00
jctanner
d2bb9c1298 vmware_guest: Fix the esxi_hostname docstring to match the arg dict's required= (#3479)
Fixes #3476
2016-12-08 11:35:08 -05:00
Davis Phillips
c2dcf62aee removed tabs and fixed formatting 2016-12-08 11:35:08 -05:00
Davis Phillips
24e8428a7b mend 2016-12-08 11:35:08 -05:00
Davis Phillips
e51f6c18eb added vDS support for config spec and note/annotation support 2016-12-08 11:35:08 -05:00
Toshio Kuratomi
4d3fec908b Remove need for translate/maketrans due to py3 differences
* translate() has a different api for text vs byte strings
* maketrans must be imported from a different location on py2 vs py3

Since this is such a small string outside of a loop we don't have to
worry too much about speed so it's better to have a single piece of code
that works on both py2 and py3
2016-12-08 11:35:08 -05:00
Abdul-Anshad-A
c2f4e7c852 Initial effort for pyVmomi snapshot ops
Make description optional during snapshot create
2016-12-08 11:35:08 -05:00
Davis Phillips
ce7c7b6804 Removed list value from description in dns_servers 2016-12-08 11:35:08 -05:00
Davis Phillips
bb017c4af8 updated version_added to 2.3 2016-12-08 11:35:08 -05:00
Davis Phillips
ae9aa2390f Added version_added to all the new params 2016-12-08 11:35:08 -05:00
Davis Phillips
ebdd9cf1a5 remove commented code and fixed formatting 2016-12-08 11:35:08 -05:00
Davis Phillips
995cc2cd2d closes 3305 adds customize support 2016-12-08 11:35:08 -05:00
Rene Moser
e1d79f341e cloudstack: new module cs_vpc 2016-12-08 11:35:08 -05:00
René Moser
8873263894 cloudstack: add new module cs_nic (#3392) 2016-12-08 11:35:08 -05:00
Fabio Alessandro Locati
9a1b5b5e18 Use native YAML (#3435) 2016-12-08 11:35:08 -05:00
Tristan Bessoussa
f68a45ca9a Fixed wrong variable name in the let's encrypt doc (#3398)
It could lead to unwanted error when dummy-paste to try this module.
2016-12-08 11:35:07 -05:00
James Hart
276c3410a5 consul: Pass through service_id if specified on a check (#3295)
Fixes #3249
The python-consul library already supports this, so it is just a simple
case of enablement.
This does not break the current logic in `add` of parsing as a check,
then parsing as a service if that fails… because service_name is
mandatory on a service registration and is invalid on a check
registration.
2016-12-08 11:35:07 -05:00
Fabio Alessandro Locati
39f4e17838 Improve yaml code and add an if to make the import more standard (#3424) 2016-12-08 11:35:07 -05:00
Fabio Alessandro Locati
7af000bdb1 Use native YAML (#3436) 2016-12-08 11:35:07 -05:00
Fabio Alessandro Locati
1e00adefd5 Use native YAML in the examples (#3441) 2016-12-08 11:35:07 -05:00
Matthieu Dolci
8822021132 ec2_customer_gateway: state present expect bgp_arn instead of bgp_asn (#3366) 2016-12-08 11:35:07 -05:00
Fabio Alessandro Locati
69fa44b6d1 Use native YAML (#3437) 2016-12-08 11:35:07 -05:00
Fabio Alessandro Locati
616c86529f Use native YAML (#3438) 2016-12-08 11:35:07 -05:00
Fabio Alessandro Locati
be834293ed Use native YAML (#3439) 2016-12-08 11:35:07 -05:00
Fabio Alessandro Locati
0a338a11c2 Normalize yaml example (#3426) 2016-12-08 11:35:07 -05:00
Fabio Alessandro Locati
df6200accc Normalize yaml example (#3425) 2016-12-08 11:35:07 -05:00
Fabio Alessandro Locati
07d96b62b5 Use native YAML (#3434) 2016-12-08 11:35:07 -05:00
Fabio Alessandro Locati
47297bb19c Use native YAML (#3433) 2016-12-08 11:35:07 -05:00
mattwwarren
727e533bfc ec2_elb_facts: fix errors with no names input (#3381)
* None being passed around results in a Bad Time (tm)

* need to return the full set of elbs for an empty list

* logic is hard
2016-12-08 11:35:07 -05:00
Jose Armesto
14fee8d5f7 ec2_lc_find: Set default value for AssociatePublicIpAddress, since is missing when is false (#3417) 2016-12-08 11:35:07 -05:00
Thomas Krahn
9814136d3e Ipa bugfixes (#3421)
* ipa_group: Fix: 'list' object has no attribute 'get'

* ipa_hbacrule: Fix: 'list' object has no attribute 'get'

* ipa_host: Fix: 'list' object has no attribute 'get'

* ipa_hostgroup: Fix: 'list' object has no attribute 'get'

* ipa_role: Fix: 'list' object has no attribute 'get'

* ipa_sudocmd: Fix: 'list' object has no attribute 'get'

* ipa_sudocmdgroup: Fix: 'list' object has no attribute 'get'

* ipa_sudorule: Fix: 'list' object has no attribute 'get'

* ipa_user: Fix: 'list' object has no attribute 'get'

* ipa_sudorule: Fix: invalid 'cn': Only one value is allowed

* ipa_hostgroup: module returns changed if assigned hosts or hostgroups are not in lowercase
2016-12-08 11:35:06 -05:00
Jason Ritchie
0f6aa07d88 Detect and correct PowerShell mishandling nssm Unicode output as UTF8 (#2867)
* extra detail on which step triggered 'change', detect and handle powershell mishandling nssm's unicode as utf8

* Simpler handling of nssm output encoding

Thanks @nitzmahone for a cleaner way to control PowerShell's behavior
2016-12-08 11:35:06 -05:00
Henrique Rodrigues
54c5ebf697 New ec2_group_facts module to be able to get facts from EC2 security groups (#2591)
Add `ec2_group_facts` module to gather facts from EC2 security groups
2016-12-08 11:35:06 -05:00
Andrew Gaffney
a8d80f7165 Fix bare variable references in docs 2016-12-08 11:35:06 -05:00
Krzysztof Magosa
c6b08ca623 tempfile: simple module creating temporary files/directories in OS-independent manner (#2991) 2016-12-08 11:35:06 -05:00
René Moser
de3aea7c36 cloudstack: cs_ip_address: fix returns on state=present (#3406)
In case poll_job=false the return must be None
2016-12-08 11:35:06 -05:00
René Moser
0324d7a681 new module nginx_status_facts (#3286)
* new module nginx_status_facts

* nginx_status_facts: remove requirement

* nginx_status_facts: implement timeout param

* nginx_status_facts: update example docs
2016-12-08 11:35:06 -05:00
jctanner
46174588ca Refactor usage of type() (#3412)
Addresses https://github.com/ansible/ansible/issues/18440
2016-12-08 11:35:06 -05:00
Jeremy Olexa
e44362b6f8 consul_kv, consul_acl: fix missing types bool (#3327)
* Specify bool in consul_kv: validate_certs param
* Specify bool in consul_acl: validate_certs param
* Specify bool in consul_kv: retrieve param
2016-12-08 11:35:06 -05:00
Christophe Biocca
55130b960b haproxy: Fix compatibility when map is actually imap. (#3350)
While I still have no idea why or how the `map` call is being swapped out while still running in python 2.7, this change will fix the following error, as well as improve py3 compatibility.
2016-12-08 11:35:06 -05:00
jctanner
b3795322e9 More isinstance fixes (#3405)
* More isinstance fixes
* Use double types
2016-12-08 11:35:06 -05:00
Thomas Krahn
32fef233f2 Add FreeIPA modules (#3247)
* Add FreeIPA modules

* Update version_added from 2.2 to 2.3

* ipa_*: Use Python 2.4 syntax to concatenate strings

* ipa_*: Replace 'except Exception as e' with 'e = get_exception()'

* ipa_*: import simplejson if json can't be imported

* ipa_hbacrule: Fix: 'SyntaxError' on Python 2.4

* ipa_sudorule: Fix: 'SyntaxError' on Python 2.4

* ipa_*: Fix 'SyntaxError' on Python 2.4

* ipa_*: Import get_exception from ansible.module_utils.pycompat24

* Add FreeIPA modules

* Update version_added from 2.2 to 2.3

* ipa_*: Fix 'SyntaxError' on Python 2.4

* ipa_*: Replace Python requests by ansible.module_utils.url

* ipa_*: Replace Python requests by ansible.module_utils.url

* ipa_*: Add option validate_certs

* ipa_*: Remove requests from Ansible module documentation requirements

* ipa_sudorule: Remove unnecessary empty line

* ipa_sudorule: Remove markdown code from example

* ipa_group: Add choices of state option

* ipa_host: Rename options nshostlocation to ns_host_location, nshardwareplatform to ns_hardware_platform, nsosversion to ns_os_version, macaddress to mac_address and usercertificate to user_certificate and add aliases to be backward compatible
2016-12-08 11:35:06 -05:00
Kei Nohguchi
cc95bc4935 openvswitch_bridge: Check VLAN ID only under fake bridge (#3374) 2016-12-08 11:35:06 -05:00
jctanner
6cfb44b4bb replace type() with isinstance() (#3404)
Replace use of type() with isinstance()

Addresses https://github.com/ansible/ansible/issues/18310
2016-12-08 11:35:06 -05:00
Michael Scherer
81286b8912 Fix chdir argument to be 'path' 2016-12-08 11:35:06 -05:00
René Moser
e1c0d2dd09 cloudstack: cs_network: cleanup dublicate VPC code (#3393)
Code has been moved to module utils, also see fe05c5e35a
2016-12-08 11:35:06 -05:00
Rene Moser
e93bdb80d3 cloudstack: fix VPC doc 2016-12-08 11:35:05 -05:00
Jens Carl
a79386f2f5 Add support for current Redshift node types (#3328) 2016-12-08 11:35:05 -05:00
Steve Gargan
687aaa197b consul_kv: remove default token (#3373)
changes default token from "anonymous" to None. Fixes #792
2016-12-08 11:35:05 -05:00
Steve Gargan
314f1ea15a allow services to be removed by name as well as id (#3372) 2016-12-08 11:35:05 -05:00
Eric
081719cc67 Return actual queue attributes with result from sqs_queue creation/update (#1362)
* Return actual queue attributes with result

Previously this was only returning the desired queue attributes, and not even returning the QueueARN for use elsewhere.  Now it will return "results.attributes" that is retrieved with boto's get_queue_attributes().

* update return structure to reflect current SQS config; add documentation of return values

* Remove redundancy from if/else statement
2016-12-08 11:35:05 -05:00
Ryan Morlok
7095959a55 Enhanced ecs_taskdefinition module.
Added support to explicitly manage task definitions be revision. If the
revision expectations of the ansible task cannot be met, an error is
thrown.

If revision is not explicitly specified, enhanced module to be
idempotent with respect to task definitions. It will search for an
active revision of the task definition that matches the containers and
volumes specified. If none can be found, a new revision will be created.
2016-12-08 11:35:05 -05:00
Nijin Ashok
b55c973444 Fix issue in activating the VM disk while attaching disk
Currently <active> tag is passed within the disk element which is
incorrect. As a result, disk will remain inactive even though the
default option is true.
2016-12-08 11:35:05 -05:00
Travis Truman
80f622a075 Add support for filtering flavors on ephemeral storage 2016-12-08 11:35:05 -05:00
Brian Coca
7de77be7b2 corrected version added 2016-12-08 11:35:05 -05:00
Fabian Krämer
2e2f24447a Add require_full_window option for Datadog monitors (#2653) 2016-12-08 11:35:05 -05:00
Loïc
405c6820b0 Add parameter hash_host (#3204)
* Add parameter hash_host

* Fix version_added

* Remove spurious whitespace
2016-12-08 11:35:05 -05:00
Brian Coca
bd29252ee7 corrected versionadded 2016-12-08 11:35:05 -05:00
Jason Cormie
78e8709085 Allow setting the visible name of a host in zabbix (#2919)
In Zabbix, the visible name defaults to the hostname.  This is not very
useful if you try to manage vmware VMs as the so called host_name within
zabbix must be set to the vcenter UUID.

This patch allows you to provide an alias which will be shown with
zabbix.  If its not supplied it will default to host_name.
2016-12-08 11:35:05 -05:00
Brian Coca
e33303acd5 added version avialable to docs 2016-12-08 11:35:05 -05:00
Trond Hindenes
cc42d7f38c Added support for IIS AppPool identities (#2675) 2016-12-08 11:35:05 -05:00
Iago Garrido
6036bb69d9 Fixes win_uri module ignoring body argument (#2504)
* Fixes win_uri module ignoring body argument

* Added body field of the response to the documentation
2016-12-08 11:35:04 -05:00
Adam Miller
bedf56a7fd provide useful error when invalid service name provided add offline mode to firewalld permanent operations
Signed-off-by: Adam Miller <maxamillion@fedoraproject.org>
2016-12-08 11:35:04 -05:00
Tom Paine
9fa6d9eda8 Update letsencrypt.py
Extend `remaining_days` description.
2016-12-08 11:35:04 -05:00
Michael Ansel
52e14bd172 jira: Specify the correct argument type (#3368)
By default, all arguments are considered strings, but the module code expects the `fields` parameter to be a proper Python dictionary.

Fixes #2600
2016-12-08 11:35:04 -05:00
Toshio Kuratomi
138f2cd847 Fix for dnf groupinstall
Previous fix to group install introduced a different bug trying to
strip() group names at the wrong level.  This patch fixes that.

Fixes #3358
2016-12-08 11:35:04 -05:00
Matt Clay
3ec6722a21 Simplify compileall checks. Remove py3 skip list.
Also applied updates to sanity.sh from ansible-modules-core.
2016-12-08 11:35:04 -05:00
Toshio Kuratomi
b82ceae75f Fix python3 syntax for octal numbers 2016-12-08 11:35:04 -05:00
Toshio Kuratomi
58ec3df13d Revert "add support for proxysql (#2917)"
This reverts commit 9d51f823956e47b02abd7754522b5bd4202bd82c.

proxysql is breaking docs build.  Reverting until those are fixed
2016-12-08 11:35:04 -05:00
Toshio Kuratomi
5cd11f5e39 Revert "several fixes to doc to avoid breaking doc build"
This reverts commit 6e4a182684a54e60be5318525c658cfe315d06ad.

reverting proxysql modules for owner to fix docs build so reverting this
fix as well.
2016-12-08 11:35:04 -05:00
Brian Coca
15a0cffee0 several fixes to doc to avoid breaking doc build 2016-12-08 11:35:04 -05:00
cameronurnes
ec8bd8ee77 Fix elf and elf_facts documentation formatting (#3348)
* This method breaks the output on the documentation site

* Conflicting quotes

* Conflicting quotes
2016-12-08 11:35:04 -05:00
Toshio Kuratomi
c41c3abb85 Archive is being added in 2.3 rather than 2.2 2016-12-08 11:35:04 -05:00
bmildren
e284af01b1 add support for proxysql (#2917)
* Adding support for proxysql

* Moved and restricted imports, updated exception handling

* Updated version_added, and mysqldb_found constant name

* Removed unnecessary parentheses
2016-12-08 11:35:04 -05:00
Toshio Kuratomi
82d2a4810e Fix installation of environment groups
In dnf, environment groups are separate from groups.  Need to handle
them separately when calling the API.

Fixes #2178

After upstream review, hande dnf-2.0 mandatory packages in groups

If mandatory packages in a group are not installed, a group will report
failure.  Fix this by catching the error and reporting after trying
to install the other packages and groups in the transaction.
2016-12-08 11:35:04 -05:00
Matt Clay
4ada3463ca Removed tests migrated to ansible/ansible repo. (#3330) 2016-12-08 11:35:04 -05:00
Matt Clay
db0ac4936b Skip shard count test in check mode. (#3329)
The shard count is not available in check mode.
2016-12-08 11:35:03 -05:00
Igor Gnatenko
16896194a8 dnf: fix compatibility with DNF 2.0 (#3325)
* dnf: fix compatibility with DNF 2.0

* Reimplement (copy) old dnf.cli.commands.parse_spec_group_file(),
  upstream uses argparse since 2.0.
* add_remote_rpm() has been changed to the add_remote_rpms()

Closes: https://github.com/ansible/ansible-modules-extras/issues/3310
Signed-off-by: Igor Gnatenko <ignatenko@redhat.com>

* fixup! dnf: fix compatibility with DNF 2.0
2016-12-08 11:35:03 -05:00
Scott Butler
5cb9bbbd18 Typo fix requested by marketing. 2016-12-08 11:35:03 -05:00
Andrew Gaffney
c238d3070a Minor fixes for openwrt_init for busybox ps and worthless exit codes 2016-12-08 11:35:03 -05:00
Yevgeniy Valeyev
e064fd3256 cloudtrail: Fix error on existing trail without S3 prefix (#2939) 2016-12-08 11:35:03 -05:00
Mike Rostermund
d50e2c654f lxd_container: doc: Correct name and state for example of deleting (#3299) 2016-12-08 11:35:03 -05:00
Thierno IB. BARRY
b09291be2c elasticsearch_plugin: add check mode support (#3043) 2016-12-08 11:35:03 -05:00
Andrew Gaffney
b69fb8a1ca Add openwrt_init module for managing services on OpenWrt (#3312) 2016-12-08 11:35:03 -05:00
Toshio Kuratomi
09c56140cd * Fix for spaces in the package spec. * Fix for python-2.6 compat 2016-12-08 11:35:03 -05:00
Toshio Kuratomi
d558c55cee install dnf python bindings if possible
Fixes #14427
2016-12-08 11:35:03 -05:00
Yanis Guenane
f9a36962bd network: Add new module openssl_privatekey
This module aims to allow a user to manage the lifecycle of OpenSSL
private keys. Internally it relies on the pyOpenSSL python library
to interact with openssl.

A user is able to specify :

  * key size (via `size` parameter)
  * key algorithm (via `type` parameter)
  * key location (via `path` parameter)

The most simple use case is:

```
- name: Generate ansible.com.pem SSL private key
  openssl_privatekey: name=ansible.com.pem
                      path=/etc/ssl/private
```

A user can speficy more settings:

```
- name: Generate ansible.com.pem SSL private key
  openssl_privatekey: name=ansible.com.pem
                      path=/etc/ssl/private
                      size=2048
                      type=DSA
```

A user can also force the regeneration of an SSL key:

```
- name: Generate ansible.com.pem SSL private key
  openssl_privatekey: name=ansible.com.pem
                      path=/etc/ssl/private
                      force=true
```
2016-12-08 11:35:03 -05:00
Hans-Joachim Kliemeck
1b4eea79d8 win_nssm: set application directory on change of application binary (#3267) 2016-12-08 11:35:03 -05:00
Scott Butler
8745feb567 Clarifies description of path parameter. 2016-12-08 11:35:03 -05:00
Grégory
c2a921ab7c Change azure default deployment mode to incremental (#3023)
* Changed default deployment mode to match with azure -cli behaviour. "Complete" mode by default is too dangerous.

* Set incremental as default behaviour for deployment mode.
2016-12-08 11:35:03 -05:00
Michal Klempa
39e3c530c0 maven_artifact: fix download of SBT published snapshot artifact (#3085)
Fixes #1717
2016-12-08 11:35:03 -05:00
Tim Rupp
9efcfaff48 Adds bigip_sys_global module (#3271)
This module can be used to change a variety of system parameters
typically used for bootstrapping.

Tests for this module can be found here

https://github.com/F5Networks/f5-ansible/blob/master/roles/bigip_sys_global/tasks/main.yaml

Platforms this was tested on are

12.1.0-hf1
2016-12-08 11:35:02 -05:00
Tim Rupp
10697854e0 Adds route_domain parameter to the selfip module. (#3272)
This patch allows one to specify a route_domain to create the
selfip in.
2016-12-08 11:35:02 -05:00
Tim Rupp
a27de3adcc Adds route advertisement state to the bigip_virtual_server module (#3273) 2016-12-08 11:35:02 -05:00
Ryan Conway
15f32cf3d5 Adds support for setting a virtual server's "source address translation" policy to a specific SNAT pool, in addition to the 'None' or 'Automap' options. (#3158) 2016-12-08 11:35:02 -05:00
Jens Carl
f60e0d88da Fix typo (#3289) 2016-12-08 11:35:02 -05:00
John R Barker
9fa1afc39f a10 - Use docs_fragments (#3281)
Remove duplicated documentation (common options defined in module_utils/a10.py).
Also tidy up formatting.
2016-12-08 11:35:02 -05:00
Tim Rupp
0055360315 Make irules module idempotent (#3175)
The irules module was failing to strip whitespace that is, for some
reason, automatically inserted by BIG-IP. This patch adds necessary
strips
2016-12-08 11:35:02 -05:00
Rene Moser
960f28692e docs: adjust version_added 2016-12-08 11:35:02 -05:00
Thierno IB. BARRY
60a32ba77f openvswitch_bridge: add fake bridge support (#3054)
* openvswitch_bridge: add fake bridge support

* openvswitch_bridge: check if vlan is between 0 and 4095
2016-12-08 11:35:02 -05:00
Andrea Scarpino
9b9ea97706 maven_artifact: Allow to specify a custom timeout (#2526) 2016-12-08 11:35:02 -05:00
Rowan
713b9bbdf3 Added proxied option to cloudflare_dns (#2961) 2016-12-08 11:35:02 -05:00
Pitsanu Swangpheaw
034f7d8b52 support proxmox resource pool (#2859) 2016-12-08 11:35:02 -05:00
Matthew Treinish
cbde91d765 Add TLS encyrption support to MQTT (#2700)
This commit adds module settings for configuring TLS encyption on the
mqtt notification module. Previously there was no way to configure
sending the messages encrpyted to mqtt.
2016-12-08 11:35:02 -05:00
jctanner
94175476b7 Implement a workaround for broken FindByInventoryPath method in pyvmomi (#3243)
* Add initial support for using a cluster instead of an esxi hostname
* FindByInventoryPath doesn't always work, so implement a fallback method to match the path
2016-12-08 11:35:02 -05:00
Michael Scherer
ceec679302 Make blockinfile work with python3
Traceback (most recent call last):
      File \"/tmp/ansible_ueg52c0b/ansible_module_blockinfile.py\", line 319, in <module>
        main()
      File \"/tmp/ansible_ueg52c0b/ansible_module_blockinfile.py\", line 259, in main
        if line.startswith(marker0):
    TypeError: startswith first arg must be bytes or a tuple of bytes, not str

Also clean imports while on it.
2016-12-08 11:35:02 -05:00
John Barker
7b94e3de38 Conditional main()
This is needed to allow the debugger work
2016-12-08 11:35:02 -05:00
Georg
be9fb2aa7d Update to firewalld doc
Missinformation about where available firewalld services are listed
2016-12-08 11:35:01 -05:00
Rene Moser
952add5920 docs: ec2_lc_facts: adjust version_added 2016-12-08 11:35:01 -05:00
Loïc
2e72ec40ae New module ec2_lc_facts (#2325)
New module to gather facts about AWS Autoscaling Launch Configurations
2016-12-08 11:35:01 -05:00
Steve Kuznetsov
c496c1b08e make: Expose std{out,err} of successful make commands (#3074)
When using the `make:` extras module, often the action taken
by the Make target is large. It is useful, therefore, to see
the output that `make` had to std{out,err} during execution
even when the target did not fail.

Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
2016-12-08 11:35:01 -05:00
YAEGASHI Takeshi
8bb9149a10 blockinfile: Add a newline at EOF when the file is newly created (#3174)
Ref: #2687
2016-12-08 11:35:01 -05:00
Brian Coca
9ca2fef23a corrected version 2016-12-08 11:35:01 -05:00
jhawkesworth
4a8fc74288 Win say (#2866)
* Add a text-to-speech module for windows.

* Fix documentation
2016-12-08 11:35:01 -05:00
Kevin Maris
0d8ceefd48 Respect include.* directives by default. 2016-12-08 11:35:01 -05:00
Toshio Kuratomi
ea05c56a41 Fix remaining python3 compile problems 2016-12-08 11:35:01 -05:00
Toshio Kuratomi
3901fe72d3 Fix amazon extras modules to compile under python3 2016-12-08 11:35:01 -05:00
Toshio Kuratomi
46a1f73778 Fix remaining centurylink modules for py3
Also update the imports to take advantage of the Ansiballz imports
2016-12-08 11:35:01 -05:00
Michael Scherer
8fb4fd6736 Fix pkgng on python 3
Fail with:

    Traceback (most recent call last):
      File \"/tmp/ansible_2rsl4fg1/ansible_module_pkgng.py\", line 353, in <module>
        main()
      File \"/tmp/ansible_2rsl4fg1/ansible_module_pkgng.py\", line 330, in main
        _changed, _msg = install_packages(module, pkgng_path, pkgs, p[\"cached\"], p[\"pkgsite\"], dir_arg)
      File \"/tmp/ansible_2rsl4fg1/ansible_module_pkgng.py\", line 161, in install_packages
        old_pkgng = pkgng_older_than(module, pkgng_path, [1, 1, 4])
      File \"/tmp/ansible_2rsl4fg1/ansible_module_pkgng.py\", line 121, in pkgng_older_than
        while compare_version[i] == version[i]:
    TypeError: 'map' object is not subscriptable
2016-12-08 11:35:01 -05:00
Alexandre Garnier
945ac72217 Really fix python 2.4 compatibility
PR #1544 didn't remove the keyword argument 'delete' not existing in `tempfile.NamedTemporaryFile()` in python 2.4
2016-12-08 11:35:01 -05:00
Steyn Huizinga
c21dd8c13b Fix for ansible/ansible-modules-extras#3173 (#3203) 2016-12-08 11:35:01 -05:00
James Kassemi
f4faf9842f Fix issue with multiple pages of results in ec2_lc_find (#3090) 2016-12-08 11:35:00 -05:00
Jeff
d8efe53d7c logicmonitor: Documentation and logging updates based on feedback (#2756) 2016-12-08 11:35:00 -05:00
Nick Piper
491b136f6e doc: Correction for spelling of 'azure_rm_deployment' in example (#3212) 2016-12-08 11:35:00 -05:00
matt colton
93627a1f0f sl_vm: update datacenter, cpu and memory options (#3236) 2016-12-08 11:35:00 -05:00
Michael Scherer
4bbfe36a6e Refactor some code in timezone module 2016-12-08 11:35:00 -05:00
Morgan Jones
be19af02f7 azure_rm_deployment: fix rg issue with _nic_to_public_ips_instance() (#2950)
Fix an issue with _nic_to_public_ips_instance() function. There was an assumption in the code that the Public IP sits in the same resource group, this isn't always the case.
2016-12-08 11:35:00 -05:00
Jonathan Sokolowski
90cc40e105 lvg: Initialise device list (#3141) 2016-12-08 11:35:00 -05:00
Michael Scherer
9bdb567c56 Make netscaler pass python3 sanity check 2016-12-08 11:35:00 -05:00
Michael Scherer
04996c3720 Make nmcli pass py3 sanity check
Cleanup include, do not use '*' for future refactoring.

Since nmcli is not present on EL5, we can safely use python
2.6 syntax only.
2016-12-08 11:35:00 -05:00
John R Barker
32c4190ac8 Remove reference to ansible-validate-modules (#3256)
ansible-validate-modules is now in ansible/ansible

During 2.3 we will be merge the modules into ansible/ansible so this file will go away.

The new testing documentation will refer to `ansible-test` which will wrap up the unit, integration, and ansible-validate-modules. So no need to document here.
2016-12-08 11:35:00 -05:00
John R Barker
3472cc6f3a Run validate-modules from ansible/ansible (#3242)
* Run validate-modules from ansible/ansible

* Update sanity.sh
2016-12-08 11:35:00 -05:00
Tim Rupp
56147c3771 Adds module to manage SNAT pools on a BIG-IP (#3217)
This module adds the ability to manage the lifecycle of SNAT pools on a BIG-IP.

Tests for this module can be found here

https://github.com/F5Networks/f5-ansible/blob/master/roles/bigip_snat_pool/tasks/main.yaml

Platforms this was tested on are

12.1.0 HF1
2016-12-08 11:35:00 -05:00
Tim Rupp
7bfb491ba5 Adds the bigip_hostname module (#3216)
This module can be used to change the hostname on a bigip. The
hostname must be set via the tmsh or API methods or else it will
not reflect properly in the config.

Tests for this module can be found here

https://github.com/F5Networks/f5-ansible/blob/master/roles/bigip_hostname/tasks/main.yaml

Platforms this was tested on are

12.0.0
12.1.0 HF1
2016-12-08 11:35:00 -05:00
Tim Rupp
5d3dafc02e Adds bigip_gtm_facts module (#3232)
This patch adds support for querying the GTM(DNS) facts from a
BIG-IP. This completes a previous PR that was requested but not
finished.

Tests for this module can be found here

https://github.com/F5Networks/f5-ansible/blob/master/roles/bigip_gtm_facts/tasks/main.yaml

Platforms this was tested on are

11.6.0
12.1.0 HF1
2016-12-08 11:35:00 -05:00
Michael Scherer
50b31a2343 Do not import splitter, since we do not use it 2016-12-08 11:35:00 -05:00
Michael Scherer
7f4fdba0c6 Make openvswitch* pass py3 sanity check 2016-12-08 11:35:00 -05:00
Michael Scherer
2a83eefaae Make consul modules pass sanity test for python 3 2016-12-08 11:34:59 -05:00
Michael Scherer
d4157095f3 Make bigpanda module pass python3 sanity check 2016-12-08 11:34:59 -05:00
Michael Scherer
9cac0b54c6 Make jabber module compile on python 3 2016-12-08 11:34:59 -05:00
Michael Scherer
60b6cb8305 Make mail compile on python 3 2016-12-08 11:34:59 -05:00
Michael Scherer
95929fb79f Make postgresql module in extras compile on py3 2016-12-08 11:34:59 -05:00
Michael Scherer
6963cd8ae7 Make mongodb modules compile on python 3 2016-12-08 11:34:59 -05:00
Michael Scherer
1bca0847a4 Make rax_clb_ssl module pass sanity check for py3 2016-12-08 11:34:59 -05:00
Michael Scherer
2ceb672016 Fix dnsmadeeasy module to pass py3 sanity check 2016-12-08 11:34:59 -05:00
Michael Scherer
b902ea297f Make mqtt pass python3 sanity tests 2016-12-08 11:34:59 -05:00
Toshio Kuratomi
3c1dea1933 Add python-2.6 requirement to the proxmox module 2016-12-08 11:34:59 -05:00
Michael Scherer
573958bd53 Do not leak login_password when using verbose, with no_log 2016-12-08 11:34:59 -05:00
Alex
88e940a3e1 zypper: fix for checking result is None (#3143) 2016-12-08 11:34:59 -05:00
Michael Scherer
1948bcb9e7 Make zabbix modules compile on python 3
Since the module is not compatible with python 2.4, we
do not need to use the get_exception trick
2016-12-08 11:34:59 -05:00
Michael Scherer
c1f7fa2f3b ovirt_auth: fix type and password leak (#3119)
Do not leak the password in log, and verify the path of ca_file
2016-12-08 11:34:59 -05:00
Ville Reijonen
e5688c709a win_scheduled_task: fix days_of_week var command typo (#3198) 2016-12-08 11:34:59 -05:00
Michael Scherer
adc62226d4 Make dnssimple compile on python 3 2016-12-08 11:34:58 -05:00
hyperized
d815890aa6 Update irc.py (#3144)
Proposal to update the example to YAML syntax.
2016-12-08 11:34:58 -05:00
Benjamin Copeland
2796370b57 statusio_maintenance: Fix minor typo (#3137) 2016-12-08 11:34:58 -05:00
Jasper Lievisse Adriaanse
83a6032b7a Remove incorrect statement, uri module doesn't require httplib2 anymore 2016-12-08 11:34:58 -05:00
Michael Scherer
8676924da5 Fix proxmox for python 3
Since it doesn't work on python 2.4, we can use the native
exception handling way for python 3
2016-12-08 11:34:58 -05:00
Michael Scherer
37b62a1db3 Remove gce from the blacklist for python 3 tests, forgot in #3179 2016-12-08 11:34:58 -05:00
Toshio Kuratomi
f77aa869b8 Few more places where gce modules need python3 compat exceptions 2016-12-08 11:34:58 -05:00
Michael Scherer
7ba630eda2 Make xenserver_facts compile on python 3
Since the xenapi is not needed on python 2.4, we can use the
regular exception handling code
2016-12-08 11:34:58 -05:00
Michael Scherer
9f5f85c9f0 Port ovirt to python 3
Since ovirt sdk is not running on python 2.4, we can use python 2.6
syntax directly for exceptions.
2016-12-08 11:34:58 -05:00
Michael Scherer
715b88a8a5 Make redis run on python 3 2016-12-08 11:34:58 -05:00
Michael Scherer
11d88bc1a8 Fix gce module to compile on python 3 (#3179) 2016-12-08 11:34:58 -05:00
Michael Scherer
da6851bdf4 Make expect module compile on python 3 2016-12-08 11:34:58 -05:00
Michael Scherer
415c2d4591 Make sensu_check compile on python 3 (#3177) 2016-12-08 11:34:58 -05:00
Eric D Helms
151c6d2f88 Fix broken entities reference in Katello module (#3136) 2016-12-08 11:34:58 -05:00
Patrik Lundin
896dec44a6 openbsd_pkg: Use correct part of name in match. (#3151)
* openbsd_pkg: Use correct part of name in match.

Previously this part of the code could assume that the name was a stem
with nothing else attached (like "autoconf"). With the introduction of the
branch syntax ("autoconf%2.13") this is no longer true.

Check if the package name was identified as using a "branch" style name,
and base the match on the leading part of the name if that is the case.

While here remove unnecessary "pass" and tidy up debug log message.

Problem reported by @jasperla.

* openbsd_pkg: Add missing "." in comment.
2016-12-08 11:34:58 -05:00
Ryan Currah
00adb6e5d4 Fix mongodb_user.py version detection logic (#3162)
Fix mongodb_user.py version detection logic for mongo srv 2.6 and mongo driver 2.7. The wrong variable was used for detecting the mongo driver version. This fix resolves the error "(Note: you must use pymongo 2.7+ with MongoDB 2.6.. 2.6.11)" no matter what version of pymongo you had installed for mongodb 2.6.
2016-12-08 11:34:57 -05:00
Ryan Brown
bbe8e1f53b Fix archive truncating archived file names based on prefix length (#3124)
When archiving multiple files, the full length of the calculated
`arcroot` would be removed from the beginning of all file names. If
there was no arcroot, the first two characters of all files would be
removed, so `file.txt` would become `le.txt`.

This patch uses the regular expressions substitution anchored to the
start of the string, so the arcroot is only removed if it is actually
present.
2016-12-08 11:34:57 -05:00
Ryan Brown
25da992785 Fix failure to apply bucket policy when creating a bucket from scratch (#3091) 2016-12-08 11:34:57 -05:00
Michael Scherer
9aec480f59 Make irc.py compile on python3 2016-12-08 11:34:57 -05:00
Michael Scherer
1f406d4530 Port virt to python3 (#3167) 2016-12-08 11:34:57 -05:00
Michael Scherer
9be3e67e21 Make sure that the token is not printed in log (#3115) 2016-12-08 11:34:57 -05:00
Michael Scherer
138aaa4ff3 Fix crypttab (#3121)
* Fix error in crypttab doc

* Use path type for file argument

This permit to make sure that $HOME and '~' are properly
expanded, even if in the case of crypttab, this might not make
a lot of sense
2016-12-08 11:34:57 -05:00
Ivan Bojer
3c06e2585a PanOS module for admin password change using PanOS API as the transport (#2930)
* PanOS module that allows admin password change.

* fixed a typo

* empty __init__.py

* added require ansible Python extension .py

* added version string

* added return docstring

* changed version to 2.2

* - changes to the format and module as requested by @privateip

* changed version back to 2.2 as 2.3 was failing automated tests

* Revert "changed version back to 2.2 as 2.3 was failing automated tests"

reverting version info

This reverts commit 71d520f3b4b69eb017c2b9f287a74cb77fae9d1c.
2016-12-08 11:34:57 -05:00
Toshio Kuratomi
badce91e80 Fix a couple undefined variables
One was a typo and one needed to have the variable defined in that scope
2016-12-08 11:34:57 -05:00
Tim Rupp
79895061b4 Fixes broken documentation in two modules (#3150)
The modules listed in this PR were using YAML that resulted in
blockquote tages being inserted into the generated RestructedText.

This PR fixes that so that the documentation once again looks correct
2016-12-08 11:34:57 -05:00
Aleksey Gavrilov
951f1d280c proxmox add exaples static ip (#3092) 2016-12-08 11:34:57 -05:00
Michael Scherer
b52d0f65d6 Fix wrong variable name 2016-12-08 11:34:57 -05:00
Michael Scherer
6769bbf1a6 Do not leak the solaris root password in the log 2016-12-08 11:34:57 -05:00
afunix
60d84aca07 gluster_volume adds replica and stripe arguments when adding bricks [#2754] (#2812) 2016-12-08 11:34:57 -05:00
Michael Scherer
343134bd0f Do not leak the channel token in log (#3117) 2016-12-08 11:34:57 -05:00
Michael Scherer
c50ac02b30 Add verification for the arguments of opendj_backendprop (#3116) 2016-12-08 11:34:56 -05:00
Eric D Helms
f4d83486a9 New module: Manage Foreman and Katello entities (#2450) 2016-12-08 11:34:56 -05:00
Michael Scherer
9ba5218631 Do not leak the newrelic token in log (#3118) 2016-12-08 11:34:56 -05:00
Michael Scherer
b03e95418e Do not leak the password of gitlab_user in log (#3122) 2016-12-08 11:34:56 -05:00
Ryan S. Brown
001cf5cfc5 lambda correct documentation of return output
The returns are actually nested under `configuration` keys, so the docs
need to reflect that. Also add the automatic return of the function
version, so it can be used to feed the `lambda_alias` module.
2016-12-08 11:34:56 -05:00
Ryan S. Brown
b7ca9d6567 lambda Support using the role name
Instead of needing the full role ARN, allow users to specify a role name
as long as the role exists in the same account.
2016-12-08 11:34:56 -05:00
Adam Miller
3ac2a498ae add offline mode to firewalld
Signed-off-by: Adam Miller <maxamillion@fedoraproject.org>
2016-12-08 11:34:56 -05:00
Peter Sprygada
00cc7c03fa Revert "update mask_passwords argument to be more descriptive in asa_config (#3109)" (#3110)
This reverts commit 271e300745b7200fc57383916d87efd6640d093e.
2016-12-08 11:34:56 -05:00
Peter Sprygada
1b6a424375 update mask_passwords argument to be more descriptive in asa_config (#3109)
This changes the passwords argument to mask_passwords to make the
argument more descriptive of its intended function
2016-12-08 11:34:56 -05:00
René Moser
9518290454 cloudstack: cs_portforward: fix rule not found if domain is not account's domain. (#3093)
cs_portforward will not find the rule and tries to create it resulting in an API error.

Thanks to @mostkopf for reporting.
2016-12-08 11:34:56 -05:00
Peter Sprygada
d698a9b5f7 fixes asa_config to allow config to include passwords, defaults or none (#3102)
The fix allows the asa_config module to request the config to contain
all default statements or password information necessary for vpn
tunnel endpoints
2016-12-08 11:34:56 -05:00
Peter Sprygada
817881d64f fixes problem where wrong ACL could be selected (#3099)
This fixes a bug where the wrong acl name could be matched in the running
config if the desired acl name is a starting subset.
2016-12-08 11:34:56 -05:00
Tim Rupp
6f0477a780 Fixes the enabled_vlans argument (#3061)
This argument had a couple of issues with it. First, as it was
being interpreted in the code, it did not check for idempotency.

Second, the model of having the parameters be "all_*" is going to
hinder the ability to "undo", so-to-speak, what the user did while
maintaining legibility.

Consider if the user specified "all_enabled_vlans='net1'" and then
decided they wanted to backout of this decision. What is the proper
argument to fulfill this wish? "all_enabled_vlans='...?'

This patch changes the all_enabled_vlans argument to be "enabled_vlans",
ensures that idempotency works, and also provides for a way to "undo" a
change to the enabled VLANs by allowing the user to specify the special
case VLAN named "ALL" (all capitals).

This makes the parameter more intuitive because the users will specify
which vlans they want to make the virtual available on

  * enabled_vlans="net1"

but also allows them to "undo" what they did by setting it back with
the case of all

  * enabled_vlans="ALL"
2016-12-08 11:34:56 -05:00
Tim Rupp
223d5cc7ee Adds copyright line for F5 contributed modules (#3081)
I was asked to do this as part of the contribution effort in house
2016-12-08 11:34:56 -05:00
Tim Rupp
de08965ab3 Corrects the required SDK version (#3095)
The SDK version that was mentioned originally was incorrect
2016-12-08 11:34:56 -05:00
Pieter Hollants
c2992fbb81 zypper_repository: Prepend --gpg-auto-import-keys before refresh command (#3088)
Fixes #3086.
2016-12-08 11:34:55 -05:00
Robin Roth
48ee364950 Add documention for enabled option in zypper_repository (#3083) 2016-12-08 11:34:55 -05:00
René Moser
d2eeabf129 slack: fix handling of html entities and escaping (#3032)
for < > & ' and "
2016-12-08 11:34:55 -05:00
Jonathan Mainguy
d4b94ec6bb fix timezone for centos6 (#3078) 2016-12-08 11:34:55 -05:00
John R Barker
66eaa464ee Typos in doc's strings (#3071) 2016-12-08 11:34:55 -05:00
Toshio Kuratomi
d52fc0f8a6 Update shippable config (#3063) 2016-12-08 11:34:55 -05:00
THEBAULT Julien
bfb1ad6690 Fix mongodb user compatibility check (#2731)
- Check the compatibility asap
2016-12-08 11:34:55 -05:00
Bryan Hundven
50092ed629 Fix the comment in the example. (#3050)
Fix the typo: `Crate` -> `Create`. Make a complete sentence.

Signed-off-by: Bryan Hundven <bryanhundven@gmail.com>
2016-12-08 11:34:55 -05:00
Ryan Brown
cdd874e61d Fix owner on gce_img 2016-12-08 11:34:55 -05:00
Rob
20cfe15e56 If parameters for policy, tags or versioning are not supplied, do not change the existing values defined for the bucket (#2938) 2016-12-08 11:34:55 -05:00
John R Barker
3a3612f57b asa_template is now deprecated (#2992)
* asa_template is now deprecated

* Delete asa_template

Since asa_template was added during 2.2 development, rather than
deprecate them
2016-12-08 11:34:55 -05:00
John R Barker
94bd3a70e5 Correct typos (#3055) 2016-12-08 11:34:55 -05:00
Ondra Machacek
7f51ec8bab ovirt_vms: wait for VM to be created for states stopped/suspended (#3044) 2016-12-08 11:34:55 -05:00
Thierno IB. BARRY
c0cfd1db45 elasticsearch_plugin: rewrite module to not use unsupported parameters (#2839)
* elasticsearch_plugin: rewrite module to not use unsupported parameters (#1785)

Avoid using parameters when they are not needed (#1785)

* elasticsearch_plugin: add version only during plugin installation and parse plugin name for its removal

* elasticsearch_plugin: join command args before running it
2016-12-08 11:34:55 -05:00
Tim Rupp
781dd9c459 Distinguish between untagged and tagged vlans
We were incorrectly making VLANS always be untagged when they could
be either tagged or untagged. This change corrects the arguments to
the vlan module to allow for specifying either untagged or tagged
interfaces. The arguments are mutually exclusive
2016-12-08 11:34:55 -05:00
Michael Scherer
9ec65db778 Use 'path' type for file arguments 2016-12-08 11:34:55 -05:00
Michael Scherer
c8bfab9c08 Add missing deps, since we use openssl to verify the date 2016-12-08 11:34:54 -05:00
Ryan Saunders
b48e1e9b65 Fix documentation typos and broken URL (#3039) 2016-12-08 11:34:54 -05:00
René Moser
91277fc0c7 twilio: fix false negative failure - sms was sent successfully (#3033) 2016-12-08 11:34:54 -05:00
Lujeni
e226211c5b Fix mongodb_user ssl_cert_reqs param (#2963) (#2965) 2016-12-08 11:34:54 -05:00
Michael Scherer
ead83cd148 Fix error in description of acme_directory (#3034) 2016-12-08 11:34:54 -05:00
Matt Clay
10ac3ba617 Revert "Set PRIVILEGED=true for Linux integration tests. (#3031)"
This reverts commit 7df7b52a5e4ce876910aaa61bc75d5e66d16adb6.
2016-12-08 11:34:54 -05:00
steve-dave
587636b525 ec2_win_password.py - handle missing or unparseable key file more intuitively (#2729) 2016-12-08 11:34:54 -05:00
shane-walker
f108f8ef72 Fixes #1375, will check for new and outdated packages when running. (#3020) 2016-12-08 11:34:54 -05:00
Matt Clay
eedca027ee Set PRIVILEGED=true for Linux integration tests. (#3031)
This should allow test_mount tests to run on Shippable.
2016-12-08 11:34:54 -05:00
Matt Clay
841ec9ef1b Fix handling of ansible-doc errors. (#3030) 2016-12-08 11:34:54 -05:00
Lujeni
477d174fbc Fix mongodb_user default role value when update_password is set (#2997) 2016-12-08 11:34:54 -05:00
jctanner
981d1d3f96 vmware_guest: set the cpu and memory settings on clone (#3027)
Fixes #3026
2016-12-08 11:34:54 -05:00
Ryan S. Brown
bdec3a7cbb Fix ec2_asg_facts when name parameter is None
Closes #3021
2016-12-08 11:34:54 -05:00
Tim Rupp
15df1c84ad Fixes the bigip_selfip module to respect traffic groups (#3009)
The code for traffic groups was not being tested and therefore
had errors associated with it. It is now covered in coverage tests
and bugs that were found in it have been fixed.

See this issue for details
https://github.com/F5Networks/f5-ansible/issues/28
2016-12-08 11:34:54 -05:00
nitzmahone
4ff086c1a8 Fix win_chocolatey version comparison
fixes #2995
2016-12-08 11:34:54 -05:00
Matt Clay
b2b3d99839 Add shellcheck to sanity checks. (#3013)
Also disable deprecation warnings during module validation.
2016-12-08 11:34:54 -05:00
Tim Rupp
5abc8a1927 Corrects an implied map() usage as list (#3010)
In the six package, the map() function returns an iterator instead
of a list. This code was continuing to use the map() return value
as if it were a list and this broke the address_class facts.

This patch changes the code to use the list() method on the return
value of map().
2016-12-08 11:34:53 -05:00
Tom Melendez
fd92b66332 Change 'values' to 'record_data' for gcdns module. (#3003)
Using values caused problems while creating an integration playbook as it is a reserved word.  Seeing as this module is not yet released, it's prudent to make this change now.  'record_data' is more descriptive and uses the _data convention that we've established for instances.

No functionality in the module has changed.
2016-12-08 11:34:53 -05:00
Ondra Machacek
e7afabf060 Fix example in ovirt_auth module (#3001)
This patch fix missing quotes in ovirt_auth revoke token example
2016-12-08 11:34:53 -05:00
Robin Roth
a9cd8abb75 List python-xml in requirements for zypper* (#2937) 2016-12-08 11:34:53 -05:00
René Moser
59e6203a17 composer: update docs about issues on macOS if installed by homebrew (#2987) 2016-12-08 11:34:53 -05:00
Ondra Machacek
999a6488cf Ovirt auth/vms/disks modules (#2836)
* Add oVirt module to manage VMs

This patch add oVirt module to manage Virtual Machines

* Add oVirt module to manage authentication

This patch add oVirt module to manage authentication

* Add oVirt module to manage disks

* Added VM state management and fixups
2016-12-08 11:34:53 -05:00
perbly
ec05027c7e added enabled vlan functionality for f5 vip (#2988)
* added vlan functionality for f5 vip

* line 91, : was missing after description
2016-12-08 11:34:53 -05:00
Matt Clay
2152291960 Remove script previously used by Travis. 2016-12-08 11:34:53 -05:00
Lujeni
aa6aedf26c Improve mongodb_user exception (#2962)
- Better error message
2016-12-08 11:34:53 -05:00
Matt Clay
46d0b4dc16 Test module docs on Shippable. (#2976) 2016-12-08 11:34:53 -05:00
Matt Clay
5d78239f07 Combined notes to avoid duplicate key warning. (#2980) 2016-12-08 11:34:53 -05:00
Rob
e07c71dd99 Modification of describe_gateways key so that it is consistent with w… (#2936)
* Modification of describe_gateways key so that it is consistent with what create_gateway returns.
Also added AnsibleModule spec to require bgp_ip on state=present as defined in the doc

* Don't remove CustomerGateways key to preserve backward compatibility
2016-12-08 11:34:53 -05:00
jctanner
4cb3e87ca4 vmware_guest: do not assume disk params contain a datastore (#2974)
* vmware_guest: do not assume disk params contain a datastore
* Fix missed line during connection refactor
2016-12-08 11:34:53 -05:00
Matt Clay
f3e2f5d002 Remove Travis config since we only use Shippable. (#2975) 2016-12-08 11:34:53 -05:00
Matt Clay
a88dae905d Enable python 3 sanity tests for more modules. (#2973) 2016-12-08 11:34:52 -05:00
Michael Scherer
5f0017d99d Remove duplicate key from the doc (#2970) 2016-12-08 11:34:52 -05:00
Michael Scherer
6b5b90c4b8 Merge duplicated notes, fix warning returned by ansible-doc (#2969) 2016-12-08 11:34:52 -05:00
Adrian Likins
f4943bcf4c Fix 'netapp_e_lun_mapping ... documentation error' (#2966)
The 'short_description' in netapp_e_lun_mapping was a
list instead of txt.

This fixes errors on 'ansible-doc -l' of form:

        ERROR! module netapp_e_lun_mapping has a documentation
        error formatting or is missing documentation

Fixes: #17634 (ansible/ansible)
2016-12-08 11:34:52 -05:00
Adrian Likins
50dcce185f Remove redundant doc keys for netapp_e_ modules (#2968)
Fixes #2967
2016-12-08 11:34:52 -05:00
jctanner
10e50652b2 vmware_guest: small refactor (#2955)
* use connecion method from module_utils
* use resource group related to host system

Addresses #2911
2016-12-08 11:34:52 -05:00
Michael Scherer
1702937ab3 Do not import xenapi without checking, so we can avoid (#1953)
backtrace
2016-12-08 11:34:52 -05:00
Michael Scherer
6967a32ce4 Fix the mysql_replication argument (#2111)
Login_password and master_password are password, should not
be logged. And config_file is a path t be expanded, so tagged as
such.
2016-12-08 11:34:52 -05:00
Hans-Joachim Kliemeck
443dba148c Fix mongodb user idempotence with 2.4 version (#2725) (#2920) 2016-12-08 11:34:52 -05:00
Alexandre Garnier
f06e2e7a0b Fix mixed type comparison resulting in wrong changed (#2772)
When using `use_max` or `use_min` in `pam_limits`, the new value is an integer compared with the actual_value which is a string, so they are always different and the module reports a changed but none occurred.
2016-12-08 11:34:52 -05:00
Matt Clay
839adc208f Update CI badge. 2016-12-08 11:34:52 -05:00
Matt Clay
d1ba765ba0 Cosmetic fix to test PR and merge hooks. (#2949) 2016-12-08 11:34:52 -05:00
Matt Clay
3e86ad1a3a Run same tests on Shippable as on Travis. (#2948)
Run the same tests as used on Travis.
2016-12-08 11:34:52 -05:00
Ryan S. Brown
dc6fd4ee8a Add lambda_event module 2016-12-08 11:34:52 -05:00
Ryan Sydnor
3c6ae0063b Add Amazon Elastic File System Facts (efs_facts) module
Also switch EFS module to using boto3_conn from boto3.Session
2016-12-08 11:34:52 -05:00
Ryan Sydnor
dfec3d3c4c Add Amazon Elastic File System (efs) module 2016-12-08 11:34:51 -05:00
Ryan Brown
d92c3c6fa8 Import Lambda alias module from https://github.com/pjodouin/ansible-lambda (#2829) 2016-12-08 11:34:51 -05:00
Ryan S. Brown
ce72e52c50 Fix redshift module Python 3.5 syntax 2016-12-08 11:34:51 -05:00
Ryan Brown
559093f1a3 Fix exception syntax for Python 3.x (#2940)
since boto already precludes python2.4, no need to use a common 2.4/3 syntax
2016-12-08 11:34:51 -05:00
Steyn Huizinga
4240d2a511 Add AWS Lambda module (#1270) 2016-12-08 11:34:51 -05:00
Jim Dalton
cee898f73a Add module for managing CloudWatch Event rules and targets (#2101) 2016-12-08 11:34:51 -05:00
Jens Carl
9f2b1abbc3 New ansible module for aws Redshift and Redshift subnet group (#185) 2016-12-08 11:34:51 -05:00
Adrian Likins
68823a4e2d Add modules for NetApp SANtricity storage platform (#2929)
The modules prefixed with netapp_e* are built to support the
SANtricity storage platform.

The modules provide idempotent provisioning for volume groups, disk
pools, standard volumes, thin volumes, LUN mapping, hosts, host groups
(clusters), volume snapshots, consistency groups, and asynchronous
mirroring.

They require the SANtricity WebServices Proxy.
The WebServices Proxy is free software available at
the NetApp Software Download site:

   http://mysupport.netapp.com/NOW/download/software/eseries_webservices/1.40.X000.0009/

Starting with the E2800 platform (11.30 OS), the modules will work
directly with the storage array.  Starting with this platform, REST API
requests are handled directly on the box.  This array can still be
managed by proxy for large scale deployments.
2016-12-08 11:34:51 -05:00
jctanner
3dedecd81e vmware_guest improve and fix some of the errors (#2926)
* Add more comments and fix issue with unit conversion
2016-12-08 11:34:51 -05:00
Marcin Kawa
dde76066d3 Fix undefined info error and accept HTTP 201 response code (#2643)
Prevent referenced before assignment error when `notify` argument is not specified and accept HTTP 201 (created) code.
2016-12-08 11:34:51 -05:00
jctanner
d9b5d9e551 vmware_guest: use the disk argument to modify disk size and type (#2918)
Fixes #2706
2016-12-08 11:34:51 -05:00
Rene Moser
bbf60e36eb zabbix_host: fix typos in arg spec of login_user
Credits to @JasonCormie
2016-12-08 11:34:51 -05:00
Ryan Brown
dae2daf692 New module: lambda_facts (#2874) 2016-12-08 11:34:51 -05:00
David Stygstra
3539238ec7 Use modprobe -r instead of rmmod in modprobe module (#2669)
If any modules that the module being removed depends on are unused, they
will also be removed. Fixes #2140.
2016-12-08 11:34:51 -05:00
Michael Grüner
3dd0752746 letsencrypt: Improve error handling (#2868)
* letsencrypt: improve error handling

Use the new "body" field of the info dict in case of a HTTPError.

* letsencrypt: HTTP 202 is a valid status while polling
2016-12-08 11:34:51 -05:00
Steve Gargan
b57b74e40b remove duration from lock delay as seconds are the only granularity supported. (#2877)
add utf header to file so that it loads correctly
2016-12-08 11:34:51 -05:00
René Moser
c203283889 jenkins_job fix: NameError: global name 'module' is not defined (#2910) 2016-12-08 11:34:50 -05:00
Tim Rupp
4e8566739e Fixes domains method not defined (#2907)
The domains method was not defined, and therefore when specifying
a parent domain during route domain creation, the process would
fail.

Tests have been added to detect this going forward
2016-12-08 11:34:50 -05:00
jctanner
b6fd074bd0 vmware_guest implement clonevm for multi-dc environments (#2909)
* Fix bug in processing of null return
* Fix multi-dc folder location by enhancing the foldermap and using it to search
* Remove unused functions
* Refactor finding vm by folder

Fixes #2900
2016-12-08 11:34:50 -05:00
Cougar
7dbdadb396 vmware_guest Fix: remove 'nic' and 'disk' requirements for facts (#2844) 2016-12-08 11:34:50 -05:00
Benjamin Doherty
ac72df08dd Updates to archive module based on code review (#2699)
* Use common file arguments on destination file
* Rename 'compression' to 'format' h/t @abadger
* Add support for plain 'tar' format
* Ensure check_mode is respected
2016-12-08 11:34:50 -05:00
Peter Sprygada
4932df69bc updates to asa_config module for Ansible 2.2
* clean up functions and remove unneeded code
* config difference now includes keyword argument
* module reports changed when save argument is yes with or without check_mode
* updated fail_json return with exc kwargs
* fixed up import statements
2016-12-08 11:34:50 -05:00
Peter Sprygada
dc52d3627a fixes a number of nagging issues in asa_acl due to refactoring
* fixes issues with import error
* removes need for filter attribute in Cli instance
* now filters config either from device or provided via config argument

ref: #2890
2016-12-08 11:34:50 -05:00
Rene Moser
edb24dac2d jenkins_job: refactoring 2016-12-08 11:34:50 -05:00
Rene Moser
3c04ed977d jenkins_job: implement diff support 2016-12-08 11:34:50 -05:00
Rene Moser
171b71cfa0 jenkins_job: rename enable to enabled and mutually exclusive with config
Jenkins stores the information about the state (disabled/enabled) in the config, which result in a race condition between `config` and `enabled` and we loose idempotency. It makes sense to define them mutually exclusive.

Renamed `enable` to `enabled`. Ansible uses the name `enabled` in many modules, e.g. service as it indicates a state not an action.
2016-12-08 11:34:50 -05:00
Rene Moser
bd4c935fd7 jenkins_job: default state to present 2016-12-08 11:34:50 -05:00
Will Thames
3eeda4f844 firewalld should fail nicely when service is stopped (#2871)
Ensure the HAVE_FIREWALLD checks check only for the
presence of the python dependencies, and not the age
of the library or the state of the service, which
are checked later.
2016-12-08 11:34:50 -05:00
Peter Sprygada
7ce98f52cf bug fix in asa_acl module for missing candidate config
This bug was introduced accidentally when refactoring to 2.2.  The instance
of the candidate config was deleted.  This adds the candidate config
instance back

fixes #2890
2016-12-08 11:34:50 -05:00
Tobias Wolf
62575fdf48 Fix one character typo in my previous PR for debconf module (#2899)
Small oops in the previous PR #2530 commit.

Instead of `diff_dict` it slipped through as `diffdict`.

Please merge and sorry.
2016-12-08 11:34:50 -05:00
Alex
e2795d1401 Start zypper in non-interactive mode (#2854) 2016-12-08 11:34:50 -05:00
sgujic
d34f3b4c05 Create temporary file in a secure manner. (#2887) 2016-12-08 11:34:49 -05:00
Nils Pascal Illenseer
acadc2ac9c Delete lxd container in state stopped (#2885)
If a lxd container is stopped, do not stop it before deleting it.
2016-12-08 11:34:49 -05:00
Gilles Gagniard
05c8630b48 GCE : Fix image family handling with libcloud > 0.20.1 (#2289)
* fix image family handling with libcloud > 0.20.1

* add missing import
2016-12-08 11:34:49 -05:00
Robyn Bergeron
7c27f57052 Updating GUIDELINES.md
Updating info on how issues are routed via bot.
2016-12-08 11:34:49 -05:00
Greg DeKoenigsberg
39c1c14a08 Update MAINTAINERS.md
We could have deleted this, but just in case there are links to it from elsewhere, providing a redirect to the now authoritative GUIDELINES.md.
2016-12-08 11:34:49 -05:00
Greg DeKoenigsberg
41d7066a58 Point to GUIDELINES.md 2016-12-08 11:34:49 -05:00
johanwiren
e98eb785df Fix share aliases logic (#2862) (#2875)
Fixes #2862
2016-12-08 11:34:49 -05:00
John R Barker
3f1c3a0532 Document a10_server new options (#2876)
* Document write_config and validate_certs
2016-12-08 11:34:49 -05:00
Steve Gargan
7cd3da9b58 correctly iterate and return results of any service checks. (#2878)
current implementation was breaking making the module unusable, changing to the list comprehension fixes this. Also default to seconds instead of throwing a exception when no duration units are supplied as this causes tests to fail
2016-12-08 11:34:49 -05:00
Matt Clay
d00e941a0e Remove stderr=False from calls to exit_json. (#2879) 2016-12-08 11:34:49 -05:00
Tim Rupp
7e36f4f302 Adds bigip_ssl_certificate module (#2831)
Adds bigip_ssl_certificate module

This module is another in the ongoing "bootstrapping saga" that is
being undertaken. With this module you can manage the lifecycle of
the SSL certificates on a BIG-IP. This includes those used for
SSL offloading.

Tests for this module can be found here

https://github.com/F5Networks/f5-ansible/blob/master/roles/__bigip_ssl_certificate/tasks/main.yaml

Platforms this was tested on are

12.0.0
12.1.0
2016-12-08 11:34:49 -05:00
Ryan S. Brown
a96261a391 Normalize variable naming in cloudformation_facts module using camel2snake 2016-12-08 11:34:49 -05:00
Ryan S. Brown
215a591771 cloudformation_facts: Connect boto3 using the module_utils AWS connection instead of calling boto3 directly 2016-12-08 11:34:49 -05:00
jmenga
0d6073aa47 New module cloudformation_facts (#2329) 2016-12-08 11:34:49 -05:00
Michael Scherer
f8b7ab1e10 Do not crash if the system do not have required modules (#2852) 2016-12-08 11:34:49 -05:00
Tobias Wolf
e969010cf9 Add diff mode output to debconf module (#2530)
Support diff such that the previous and current settings are visible
without debug output and just with `--diff` if requested.
2016-12-08 11:34:49 -05:00
sermilrod
03b1844150 adding jenkins_job module (#2521) 2016-12-08 11:34:48 -05:00
Werner Dijkerman
800e1c7bc0 Added new module opendj_backendprop for updating backend settings opendj (#2855)
Add opendj_backendprop
2016-12-08 11:34:48 -05:00
Peter Sprygada
32bbddee23 update asa_config module
* removes get_module() factory method for NetworkModule
* add src argument to provide path to config file
* add new choice to match used to ignore current running config
* add update argument with choices merge or check
* add backup argument to backup current running config to control host
* add defaults argument to control collection of config with or withoutdefaults
* add save argument to save current running config to startup config
2016-12-08 11:34:48 -05:00
Peter Sprygada
e2e0029fab roll up of updates to asa_template
This updates the asa_template module with updates for Ansible 2.2.

* removes get_module() in favor of NetworkModule
* fixes up import statements
2016-12-08 11:34:48 -05:00
Peter Sprygada
283cc51fdb added new functionality to asa_command
* commands argument now accepts a dict arguments
* only show commands are allowd when check mode is specified
* config mode is no longer allowed in the command stack
* add argument match with valid values any, all
2016-12-08 11:34:48 -05:00
Peter Sprygada
8e45ec9734 roll up updates to asa_acl module
* remove get_module() in favor of NetworkModule
* fix up import statements
* roll up fixes for NetworkConfig object handling
2016-12-08 11:34:48 -05:00
Filipe Niero Felisbino
9ba2f0f266 Fix attachment issue ( thanks @gunzy83 ) 2016-12-08 11:34:48 -05:00
Filipe Niero Felisbino
f4ace1e9cc Change attached parameter default to None 2016-12-08 11:34:48 -05:00
Filipe Niero Felisbino
f41900920f Add "version_added" to attached attribute 2016-12-08 11:34:48 -05:00
Filipe Niero Felisbino
1c1a17bfd2 Add attached parameter to ec2_eni module 2016-12-08 11:34:48 -05:00
Filipe Niero Felisbino
94d03b6b55 Add RETURN docs 2016-12-08 11:34:48 -05:00
Filipe Niero Felisbino
7ae8693bda Fix docs 2016-12-08 11:34:48 -05:00
Filipe Niero Felisbino
f8314c3e61 Fix the AMI creation/modification logic thus making it idempotent 2016-12-08 11:34:48 -05:00
Thierno IB. BARRY
bc55db2ff0 elasticsearch_plugin: Fix bug when using proxy (#2603) (#2838) 2016-12-08 11:34:48 -05:00
Nadir
5de3dbbf6d Added redrive policy options (#2245) 2016-12-08 11:34:47 -05:00
Robin Roth
6c9c4e7482 Zypper repo autoimport keys (#2132)
* zypper_repository add auto_import_keys options

* also give more output on failure (rc, stdout, stderr)

* be more specific in the doc for auto_import_keys

* add runrefresh option to zypper_repository

* this comes out of ansible/ansible-modules-extras#2411, where AnderEnder adds refresh to the zypper module
* adds a way to force zypper to refresh a repository
* can be used to refresh independently of auto_import_keys
* add option to run name=* runrefresh=yes
* name runrefresh to not break existing use to refresh (now alias to autorefresh)
* add version_added flag to autorefresh

* remove wrong version_added comment
2016-12-08 11:34:47 -05:00
EarlAbides
961c076e72 Fix ec2_asg_facts module when using name parameter (#2840) (#2841) 2016-12-08 11:34:47 -05:00
Tim Rupp
f48791e8bc Bugfix bigip_facts that was trying to check the length of an iterator (#2842)
Recently, a user reported that the bigip_facts module was failing with the error

    received exception: object of type 'itertools.imap' has no len()

This reported was occurring at line 1657 of the bigip_facts module

bug report is here

https://github.com/F5Networks/f5-ansible/issues/25

Upon further investigation, the map function for returning the specified
includes was returning an iterator, and calling len() on an iterator does
not work.

I believe this problem was caused by part of the Python 3.x effort insofar
as the inclusion of this line

https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/basic.py#L143

seems to affect our usage of map(), probably for the better anyway, and we need
to change our expectations in our module's code to no longer assume a list, but
instead assume an iterator.

After trawling through the module_utils/basic code, I think a list
comprehension is more appropriate here anyway, so I'm changing it to be
that. The affected user reported it works this way, and my own testing
on 2.2.0 supports that.
2016-12-08 11:34:47 -05:00
Kevin Hulquest
e47a5674fb Add facts and storage system modules. (#2748)
* Add facts and storage system modules.

* Update version metadata.

* Add facts and storage system modules.

Update version metadata.

Add init files.

* Fixes for review comments.

* Fixes for review comments.

* Update document fragments for api_* options to indicate they are required.

* Correct bad string concatenation.

* Add option description for validate_certs since basic_auth arg_spec is no longer extended.

* Add default value for validate_certs in docstring.

* Rename directory name so it applies to netapp and not simply eseries platform.

* Rename modules to differentiate other netapp modules.
2016-12-08 11:34:47 -05:00
Robin Roth
fb49e0401e Ensure the return value for changed is bool (#2830)
fixes #2827
2016-12-08 11:34:47 -05:00
Michael Grandjean
70e8bb3092 Fix typo in EXAMPLE section (#2833) 2016-12-08 11:34:47 -05:00
John R Barker
b7afa14f64 Minor tidyup (#2828) 2016-12-08 11:34:47 -05:00
Matt Clay
7e3af74fae Add python3 testing for module PRs. (#2825) 2016-12-08 11:34:47 -05:00
Ryan Brown
2858d24acb New module: execute_lambda (AWS) (#2558)
First version of execute_lambda module

Supports:
- Synchronous or asynchronous invocation
- Tailing log of execution (sync execution only)
- check mode
2016-12-08 11:34:47 -05:00
Monty Taylor
510e1140ce Error if shade is too old for domain_id on os_project (#2806)
* Error if shade is too old for domain_id on os_project

os_project's domain_id parameter requires shade >= 1.8.1 to work. Be
explicit.

Fixes #2805 os_project requires python-shade 1.8.1 or higher

* What I really meant was 1.8.0
2016-12-08 11:34:47 -05:00
Matt Martz
91abacfca7 Make sure we don't catch rc=0 as a timeout (#2823) 2016-12-08 11:34:47 -05:00
Toshio Kuratomi
3cb7e4bd0e Style cleanups:
* Don't use iterkeys
* Don't use wildcard imports
2016-12-08 11:34:47 -05:00
Michael Scherer
b255ac4ea6 Use six for iteration, to make it run on python3 (#2800) 2016-12-08 11:34:47 -05:00
Tim Rupp
acdbe5cb3f Adds allow_service parameter to bigip_selfip (#2808)
This parameter can be used to open up access to (among other things)
the mgmt address of a BIG-IP. It is necessary for configuring bigips
in an HA configuration.
2016-12-08 11:34:47 -05:00
Tobias Rueetschi
c0ad8b030e udm_user: change overridePWHistory and overridePWLength to snake_case 2016-12-08 11:34:47 -05:00
Tobias Rueetschi
e4dd122ab7 univention udm_user: override password history. 2016-12-08 11:34:46 -05:00
Tobias Rueetschi
10a2eb9304 udm_user: change code to fit documentation with snake_case instead of camelCase 2016-12-08 11:34:46 -05:00
Tobias Rueetschi
34445d515d udm_user: change camelCase to snake_case in documentation 2016-12-08 11:34:46 -05:00
Tobias Rueetschi
3d563324dd univention udm_user: pep8 2016-12-08 11:34:46 -05:00
Tobias Rueetschi
661cf5d5ea univention udm_share: add aliases as documented 2016-12-08 11:34:46 -05:00
Tobias Rueetschi
3709fb651d univention udm_share: change documentation, use camel_case for parameters, old parameter names as alias 2016-12-08 11:34:46 -05:00
Tobias Rueetschi
de34fdf681 univention udm_share: pep8 2016-12-08 11:34:46 -05:00
Tobias Rueetschi
8eb496989e univention udm_share: add example 2016-12-08 11:34:46 -05:00
Tobias Rueetschi
ea72534151 univention udm_share: change some parameters to type bool 2016-12-08 11:34:46 -05:00
Tobias Rueetschi
1cc3afdbdd univention udm_share: reorder documentation parameters 2016-12-08 11:34:46 -05:00
Tobias Rueetschi
7dd96079f0 univention udm_share: add documenation 2016-12-08 11:34:46 -05:00
Tobias Rueetschi
db4aca4621 univention udm_share: import only AnsibleModule from ansible.module_utils.basic 2016-12-08 11:34:46 -05:00
Tobias Rueetschi
6e4da8987e univention udm_share: add license information 2016-12-08 11:34:46 -05:00
Tobias Rueetschi
b38979321d univention udm_share: add required_if to the API 2016-12-08 11:34:46 -05:00
Tobias Rueetschi
bba8cdf0af univention udm_share: fix shebang 2016-12-08 11:34:46 -05:00
Tobias Rueetschi
afccc72d41 univention udm_share: adapt to library univention_umc 2016-12-08 11:34:46 -05:00
Tobias Rüetschi
a973d8e9c4 UCS udm_share: fix creating of new shares 2016-12-08 11:34:45 -05:00
Tobias Rüetschi
66380d6b7f UCS udm_share: added 2016-12-08 11:34:45 -05:00
Ethan Devenport
dcd7544b26 Added parameter choices for bus. 2016-12-08 11:34:45 -05:00
Ethan Devenport
403c1ddf7b Set variable types, defined choices, and cleaned up whitespace. 2016-12-08 11:34:45 -05:00
Ethan Devenport
f9e0830b44 Reverting recent commits back to initial PR and will move the new profitbricks_firewall_rule module and other recent changes to a new branch.
Revert "Added support for firewall rules, consolidated resource UUID retrieval methods for server and NIC modules, and set LAN type to int."

This reverts commit 464cbb89f225578386a830624633a55e39054544.
2016-12-08 11:34:45 -05:00
Ethan Devenport
e1960d2488 Added RETURN documentation. 2016-12-08 11:34:45 -05:00
Ethan Devenport
a3200fc98e Some further documentation updates including version. 2016-12-08 11:34:45 -05:00
Ethan Devenport
93a237f604 Minor documentation corrections. 2016-12-08 11:34:45 -05:00
Ethan Devenport
4b7a4e4495 Added support for firewall rules, consolidated resource UUID retrieval methods for server and NIC modules, and set LAN type to int. 2016-12-08 11:34:45 -05:00
Ethan Devenport
e2c8fec8d9 Included version_added for new options. 2016-12-08 11:34:45 -05:00
Ethan Devenport
267052d7a5 Removed us/lasdev datacenter which the cloud provider no longer maintains. 2016-12-08 11:34:45 -05:00
Ethan Devenport
6d8e3eac7b Additional provider features added and fixed some bugs. * Added support for SSH keys, image passwords, SSD disk type, and CPU family. * Adjusted server create so that IP address is returned in response. * Restructured remove server method(s) to handle change status properly, gracefully handle missing servers, and improve overall performance. * Prevent duplicate server names from being provisioned so removals can be handled appropriately. * Fixed a bug in the count increment being a string rather than an integer. * Fixed issue with create_volume returning invalid response. * Fixed type bug in volume instance_ids for volume removal and improved volume management. * Fixed type bug in instance_ids for proper server removal and moved boot volume creation into composite server build request. * General clean up. 2016-12-08 11:34:45 -05:00
Wong Hoi Sing Edison
d9a1b04e40 Fix ansible/ansible-modules-extras#1682: add dispersed volume support for gluster_volume (#2708) 2016-12-08 11:34:45 -05:00
afunix
32574aa358 gluster_volume module parses out additional hostnames provided by "gluster peer status" command [#1405] (#2811) 2016-12-08 11:34:45 -05:00
René Moser
4017be741a ec2_vpc_dhcp_options_facts: fix exception handling, fixes build (#2819) 2016-12-08 11:34:45 -05:00
Fabio Alessandro Locati
4af6033469 Require domain in rocketchat (#2803)
* Set the domain as required

* Add domain in the examples as well
2016-12-08 11:34:44 -05:00
Joe Smith
09776a9e52 Set explicit type for timeout (#2809)
vmware_maintenancemode.py needs explicit type for timeout, otherwise it reads timeout as string and breaks.
2016-12-08 11:34:44 -05:00
John R Barker
abaf6afc0a ec2_vpc_dhcp_options_facts.py no py3
Old PR was merged that hadn't been updated since we added the py3 checks
2016-12-08 11:34:44 -05:00
Tobias Rüetschi
e318c9b008 Feature udm dns zone (#2382)
* UCS udm_dns_zone: added

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_dns_zone: updated, add supports check mode

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_dns_zone: updated, add support to modify dns zones

* UCS udm_dns_zone: change string formating

* UCS udm_dns_zone: add a function to convert the time to the biggest unit

* UCS udm_dns_zone: add type definitions to the argument specification

* UCS udm_dns_zone: update function convert_time

* UCS udm_dns_zone: only modify object if it has changed

* UCS udm_dns_zone: add documentation

* UCS udm_dns_zone: fix checks

* UCS udm_dns_zone: if dns zone not exists, changed is always true

* UCS udm_dns_zone: documentation, add version_added

* UCS udm_dns_zone: add license and fix travis for python 3

* UCS udm_dns_zone: import common code for univention from ansible.module_utils.univention

* univention udm_dns_zone: adapt to library univention_umc

* univention udm_dns_zone: lint

* univention udm_dns_zone: add requirement python >= 2.6 to documentation

* univention udm_dns_zone: dont import time, its unused
2016-12-08 11:34:44 -05:00
Adam Števko
d56c34ea9e Add modules to configure Solaris/illumos networking (1st batch) (#2416)
* Add modules to configure Solaris/illumos networking (1st batch)

* Add choices to temporary flags
2016-12-08 11:34:44 -05:00
Olivier Boukili
f43eb7c79e new module: apache2_mod_proxy (#2148)
* module apache2_mod_proxy

* Moved state notes to state description.
2016-12-08 11:34:44 -05:00
TimothyVandenbrande
0b135aa6da This is an ansible module to control/create/adapt/remove VMs on a RHEV/oVirt environment. (#2202) 2016-12-08 11:34:44 -05:00
René Moser
d7b68e0e80 new modules for managing exoscale DNS (#2788) 2016-12-08 11:34:44 -05:00
Tobias Rüetschi
16464d5021 Feature udm group (#2396)
* UCS udm_group: added

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_group: updated

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_group: add key description

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* python styling

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_group: updated, add supports check mode

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_group: updated, add support to modify groups

* UCS udm_group: change string formating

* UCS udm_group: add type definitions to the argument specification

* UCS udm_group: import common code for univention from ansible.module_utils.univention

* univention udm_group: add documentation

* UCS udm_group: add requirement python >= 2.6

* univention udm_group: add more examples
2016-12-08 11:34:44 -05:00
Tobias Rüetschi
7506ea3a37 Feature udm dns record (#2394)
* UCS udm_dns: added

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_dns_record: fix multiple entries in different zones

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_dns -> udm_dns_record: renamed

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_dns_record: updated, add supports check mode

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_dns_record: updated, add support to modify dns records

* UCS udm_dns_record: change string formating

* UCS udm_dns_record: add type definitions to the argument specification

* UCS udm_dns_record: import common code for univention from ansible.module_utils.univention_umc

* UCS udm_dns_record: add documentation

* UCS udm_dns_record: update documenation

* univention udm_dns_record: pylint

* univention udm_dns_record: fix reverse zone entries
2016-12-08 11:34:44 -05:00
naslanidis
cbd2025223 new AWS module for ec2 dhcp option facts (#2001)
new ec2 dhcp option facts module
2016-12-08 11:34:44 -05:00
James Higgins
f7ac1f7f90 Just use netloc to identify bucket name for s3 locations (#2713) 2016-12-08 11:34:44 -05:00
René Moser
43ea275856 vmware_local_user_manager: fix global name 'module' is not defined (#2818) 2016-12-08 11:34:44 -05:00
alxsey
0bfaf34286 Implement template storage selection (#2755) 2016-12-08 11:34:44 -05:00
Mike Liu
73cf1f2755 Iptables enhancements (#2789)
* Add the flush parameter.

When specified the flush parameter indicates that this module should remove all
rules from the specified table. If no table parameter is specified then the
default filter table is flushed.

* Add support for setting chain policies.

The module supports setting the policy of a given chain and table to the
following target values, ACCEPT, DROP, QUEUE, and RETURN. This parameter ignores
all other unrelated parameters.

* Fix pep8 issues.

* Fix missing quotation.

* Make 'flush' and 'policy' parameters mutually exclusive.

This combination is not supported by the wrapped iptables command. 'flush' and
'policy' however, can both take the 'chain' argument.
2016-12-08 11:34:44 -05:00
bbooysen
41713d0819 typo fix (#2816)
Changed 'memroy' to 'memory'.
2016-12-08 11:34:43 -05:00
Tim Rupp
e4ddd4358c Fixes documentation bugs in bigip_irule (#2797)
The return docs were incorrect for this module. This patch fixes them
and adds some additional return values
2016-12-08 11:34:43 -05:00
Toshio Kuratomi
53e7fee617 We've decided that python-3.5 is our minimum pyhton3 version (#2798) 2016-12-08 11:34:43 -05:00
Tobias Rüetschi
3d1474bbd1 Feature udm user (#2406)
* Creating directory univention

* UCS udm_user: added

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_user: updating, added support to modify user groups

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_user: add key homedrive

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_user: add key userexpiry

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* python styling

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_user: updated, add supports check mode

Signed-off-by: Tobias Rüetschi <tobias.ruetschi@adfinis-sygroup.ch>

* UCS udm_user: updated, add support to modify users

* UCS udm_user: change string formating

* UCS udm_user: add type definitions to the argument specification

* UCS udm_user: only modify object if it has changed

* UCS udm_user: if user not exists, changed is always true

* UCS udm_user: import common code for univention from ansible.module_utils.univention_umc

* UCS udm_user: add a lot more attributes

* UCS udm_user: add license information

* UCS udm_user: fix API serviceprovider and unixhome

* UCS udm_user: add documentation

* univention udm_user: import only AnsibleModule from ansible.module_utils.basic

* univention udm_user: reorder documentation options

* univention udm_user: fix documentation

* univention udm_user: dont log password

* univention udm_user: add more examples
2016-12-08 11:34:43 -05:00
Massimo Gervasini
c934ab7e8b when write_config is no, we should not try to write any configuration changes 2016-12-08 11:34:43 -05:00
Toshio Kuratomi
66af5335c2 Moved the atomic modules to cloud/atomic. (#2784)
Similar category to docker and lxd
2016-12-08 11:34:43 -05:00
Tim Rupp
97d41d54ab Adds provision info to bigip facts (#2783)
This patch adds provision information to the bigip_facts module
through a "provision" include.
2016-12-08 11:34:43 -05:00
Russell Teague
150a044728 Fix vmware_dvs_portgroup destroy task (#2776)
Fixes #2761
2016-12-08 11:34:43 -05:00
Manuel Sousa
73c39c3aaf rabbitmq_queue - Update requirements to show minimum version of requests (#2786) 2016-12-08 11:34:43 -05:00
Manuel Sousa
d4d83fea2c rabbitmq_binding - Update requirements to show minimum version of requests (#2787) 2016-12-08 11:34:43 -05:00
Manuel Sousa
f7c732ad34 rabbitmq_exchange - Update requirements to show minimum version of requests (#2785) 2016-12-08 11:34:43 -05:00
Lingxian Kong
0446db9afd Add openstack os_server_group module (#2702) 2016-12-08 11:34:43 -05:00
Tim Rupp
e5f629500d New module bigip_irule
This module can be used to maintain the iRules for both LTM and GTM
on a BIG-IP. iRules should be supplied in their string form using
normal strings (unlikely), file lookups (likely), or template
lookups (likely).

Tests for this module can be found here

https://github.com/F5Networks/f5-ansible/blob/master/roles/__bigip_irule/tasks/main.yaml

Platforms this was tested on are

11.6.1
12.0.0
12.1.0
2016-12-08 11:34:43 -05:00
Tim Rupp
d84e3b6ed7 This module can be used as part of the bootstrapping of a BIG-IP. It allows one to configure the various NTP settings that are part of a BIG-IP.
Tests for this module can be found here

https://github.com/F5Networks/f5-ansible/blob/master/roles/__bigip_device_ntp/tasks/main.yaml

Platforms this was tested on are

11.6.0
12.0.0
12.1.0
12.1.0 HF1
2016-12-08 11:34:43 -05:00
Tim Rupp
57c3ae838d Addition of bigip_device_sshd module
This module can be used as part of the bootstrapping of a BIG-IP. It
allows one to configure the various SSHD settings that are part of
a BIG-IP.

Tests for this module can be found here

https://github.com/F5Networks/f5-ansible/blob/master/roles/__bigip_device_sshd/tasks/main.yaml

Platforms this was tested on are

11.6.0
12.0.0
12.1.0
12.1.0 HF1
2016-12-08 11:34:43 -05:00
Toshio Kuratomi
7a8b080506 Get hipchat, sns, and typetalk notification modules compiling on py3 (#2782) 2016-12-08 11:34:42 -05:00
Kevin Brebanov
4999bb28cd apk: Fix mutual exclusivity (#2768)
* apk: Fix mutual exclusivity

Ensure that 'name' and 'upgrade' are mutually exclusive.
Also add a note to the documentation to say so.

Fixes: #2767

* Fix documentation
2016-12-08 11:34:42 -05:00
Tim Rupp
9ff52723a9 Adds documentation fragment to bigip modules
This patch removes the common documentation bits and replaces them
with a doc fragment that already exists in core
2016-12-08 11:34:42 -05:00
Jiri Tyr
3dc7bfa6b8 Adding jenkins_plugin module (#1730) 2016-12-08 11:34:42 -05:00
Richard Metzler
7fddb83f91 letsencrypt: update URL for agreement pdf (#2696)
The Let's Encrypt Subscriber Agreement changed on Aug 01, 2016
https://letsencrypt.org/repository/
2016-12-08 11:34:42 -05:00
Matt Clay
2224a7b5a7 Enable CI on Shippable for OS X. (#2779) 2016-12-08 11:34:42 -05:00
Brian Coca
64e11d202c updated blacklist 2016-12-08 11:34:42 -05:00
Adrian Likins
9fb53e12ce Add a 'requirements:' field to cloudflare_dns doc (#2631)
cloudflare_dns.py makes use of the python
2.6 features (the string .format() method).
2016-12-08 11:34:42 -05:00
Brian Coca
24b4b1b762 renamed bmc to remote_management to clarify 2016-12-08 11:34:42 -05:00
Kevin Carter
eab15da081 Remove the subsystem lock loop (#2647)
This change removes the loop watching for "/var/lock/subsys/lxc" from
the lxc-container module. This change simply runs the command within
a container using the lxc CLI tools which should be responcible for
locking and unlocking on their own.

Closes-Issue: https://github.com/ansible/ansible-modules-extras/issues/690
Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>
2016-12-08 11:34:42 -05:00
ovcharenko
3e31eaf419 ufw fails asking for a direction for rules without an interface specified [#2758] (#2759) 2016-12-08 11:34:42 -05:00
Angus Williams
692fb45e26 bigip_pool_member: fix idempotency with session_state argument (#2745) 2016-12-08 11:34:42 -05:00
Tim Rupp
68d819e342 Another bootstrapping module, this module allows for one to manage route domains on a BIG-IP.
Tests for this module can be found here

https://github.com/F5Networks/f5-ansible/blob/master/roles/__bigip_routedomain/tasks/main.yaml

Platforms this was tested on are

11.6.0
12.0.0
12.1.0
12.1.0 HF1
2016-12-08 11:34:42 -05:00
Tim Rupp
f84b4f1168 Adds the bigip_selfip module
Another bootstrapping module, this module allows for one to manage
self IP addresses on a BIG-IP.

Tests for this module can be found here

https://github.com/F5Networks/f5-ansible/blob/master/roles/__bigip_selfip/tasks/main.yaml

Platforms this was tested on are

11.5.4 HF1
11.6.0
12.0.0
12.1.0 HF1
2016-12-08 11:34:42 -05:00
whiter
685803dbcc New module s3_website to manage static sites on Amazon S3 2016-12-08 11:34:42 -05:00
Rob White
f420adfc99 New module - ec2_asg_facts
Gathers facts about multiple of single AWS autoscaling groups.
2016-12-08 11:34:41 -05:00
nitzmahone
6db9ed981e clean up win_chocolatey doc bugs, remove redundant 2016-12-08 11:34:41 -05:00
Greyeye
4bae025666 pass flag to choco, allowemptychecksums and ignorechecksums (#2722) 2016-12-08 11:34:41 -05:00
Saravanan K R
75f395dd34 Added modules to manage Atomic Host Platform (host and image) (#1902)
* Added modules to manage Atomic Host Platform (host and image)

* Fixed review comments

* Fixed requirements and locale setting
2016-12-08 11:34:41 -05:00
Brian Coca
1cfdfac139 updated version_added to be string 2016-12-08 11:34:41 -05:00
Brian Coca
3787b9baf8 fixed incorrect import deps (#2747) 2016-12-08 11:34:41 -05:00
nitzmahone
2c87fe3b58 make the win_chocolatey force arg actually work
fixes #1561
2016-12-08 11:34:41 -05:00
nitzmahone
a2f9e0d2fe isolate chocolatey bootstrapper execution
fixes #2742
added output capture/return, exit code check to bootstrapper exec
2016-12-08 11:34:41 -05:00
Robyn Bergeron
fa511fa763 Update GUIDELINES.md 2016-12-08 11:34:41 -05:00
Robyn Bergeron
1f873bac54 creating GUIDELINES.md
Made a copy from MAINTAINERS.md (and then need to delete maintainers.md).
2016-12-08 11:34:41 -05:00
Shinichi TAMURA
a3860ecf1e Allow value to be bool where 'yes'/'no' are in choices (#2593)
* Changed type of 'details' argument to bool on ecs_service_facts module.

* Changed type of 'autostart' argument to bool on virt_* modules.

* Changed types of 'autoconnect' and 'stp' argument to bool on nmcli module.
('create_connection_bridge(self)' and 'modify_connection_bridge(self)' are not implemented yet?)

* Added conversion of 'value' argument when 'vtype' is boolean on debconf module.
2016-12-08 11:34:41 -05:00
Andrea Scarpino
b54d352a69 win_firewall_rule: fix "property X doesn't exist"
After commit 9392943 more properties are always sets with their defaults
values (e.g. service to 'any'). This causes no issue when the rule is created,
but causes an error message that says "The property 'X' cannot be found on this
object. Verify that the property exists." because the module checks for
any property value that has changed, but `netsh advfirewall firewall show rule`
does not list any property unless `verbose` is set. This patch solves this.

Fixes #2624
2016-12-08 11:34:41 -05:00
Tim Rupp
e68aa4747f Introduces the bigip_gtm_datacenter module (#1000)
This module can be used to manipulate data centers in a BIG-IP.
It supports both the iControl SOAP and iControl REST APIs, but default
to the REST API. With this module, you can perform operations similar
to those available in tmsh to create data centers and set the contact,
location, and description of those data centers.

This module is most useful in the initial provisioning of a BIG-IP
2016-12-08 11:34:41 -05:00
Tim Rupp
a32f37c9b6 Introduces the bigip_sys_db module (#998)
This module can be used to directly manipulate the system database
variables in a BIG-IP. It supports both the iControl SOAP and iControl
REST APIs, but default to the REST API. With this module, you can
perform operations similar to those available in tmsh to set system
variables such as turning off the default setup screen.

This module is most useful in the initial provisioning of a BIG-IP
2016-12-08 11:34:41 -05:00
Tim Rupp
e624a794ac Adds bigip_vlan module (#2661)
This module can be used to manage VLANs in BIG-IP on various software
versions. It is part of a bootstrapping effort underway to provide
modules necessary to bootstrap core settings in a BIG-IP.

Tests for this module can be found here

https://github.com/F5Networks/f5-ansible/blob/master/roles/__bigip_vlan/tasks/main.yaml

Platforms this was tested on are

  - 11.5.4 HF1
  - 11.6.0
  - 12.0.0
  - 12.1.0 HF1
2016-12-08 11:34:40 -05:00
ovcharenko
3c0a946f2d "Invalid interface clause" error in UFW module (#2559) (#2666)
Fixes GH-2559
2016-12-08 11:34:40 -05:00
George Christou
d6f62694e2 Fix bug in counting subnets by Name tag (#1643)
Fixes #1551
2016-12-08 11:34:40 -05:00
Onni Hakala
e863dcc92a Added example to add a port range (#2712)
I tried to google for this a bit and then figured out how it actually works.
2016-12-08 11:34:40 -05:00
Matt Clay
0de2d14bac Update call to generate-tests. 2016-12-08 11:34:40 -05:00
Trevor Kensiski
b2337a7ef7 Adding datadog monitor locked option. http://docs.datadoghq.com/api/#monitor-create (#2698) 2016-12-08 11:34:40 -05:00
Jose Armesto
980298024a Added module to find Launch Configurations (#1023)
* Added module to find Launch Configurations

* Simplified parameters to search
2016-12-08 11:34:40 -05:00
Naoya Nakazawa
44bcad7d8a ready_for_review datadog_event module: Datadog API http status code 202 is ok. Ref: http://docs.datadoghq.com/api/ (#2117)
* Use official datadog create event API.

* Fix exception
2016-12-08 11:34:40 -05:00
jctanner
859ff8e886 Fix vmware_guest disk and nic parameters and docstrings (#2705)
* Fix vmware_guest disk and nic parameters and docstrings
* vmware_guest: remove default for required params
2016-12-08 11:34:40 -05:00
Indrajit Raychaudhuri
384255cada Update homebrew_cask with additional cask features and doc updates (#2682)
Changes:
- Document missing 'path' option and remove redundant brew_path manipulation
- Add 'update_homebrew' option since 'brew cask update' as a synonym for
  'brew update' is available nowadays
- Add additional missing aliases documentation
- Port additional improvements (expanded support for brews path, cask path
  patterns etc.)
- Allow proper `list` type support for 'name' option.
2016-12-08 11:34:40 -05:00
Indrajit Raychaudhuri
8702ead0a7 Update homebrew_tap to support custom tap URL via optional 'url' option (#2672)
This allows doing 'brew tap <url>' where the URL is not assumed to be on GitHub,
and the protocol doesn't have to be HTTP. Any location and protocol that git can
handle is fine.

While at it, allow proper `list` type support for 'name' option and update
module documentation for option aliases.
2016-12-08 11:34:40 -05:00
Fernando José Pando
6c94aa4dd7 elb facts fixup (#2099)
* elb facts fixup

* return tags and logic fixup

* return tags and dont fail on nonexisting elb name
2016-12-08 11:34:40 -05:00
Robin Roth
85b1bd5c90 allow to specify versions with zypper (#2328)
* fixes #2158
* handles version-specifiers (>,<,>=,<=,=) correctly
* adds option "oldpackage", which is passed to zypper
  * this is implied as soon as a version is specified
  * it can be used independently to allow downgrades coming from repos
* add __main__ check
* extend documentation on version specifier
2016-12-08 11:34:40 -05:00
Matthieu Barthélemy
adfd990232 Slack: Fix #2393 - Enable markdown parsing when using custom messsage color (#2626) 2016-12-08 11:34:40 -05:00
Indrajit Raychaudhuri
69a3e66460 Add path type in homebrew 'path' option (#2692) 2016-12-08 11:34:40 -05:00
Allen Sanabria
14476c0e8b Now when number of shards is different than what is the stream currently, it will fail.\n\nShards can not be changed on an already created stream 2016-12-08 11:34:40 -05:00
Allen Sanabria
11f4aa6538 version bump 2016-12-08 11:34:39 -05:00
Allen Sanabria
88c08efacd Module requires boto due to ec2.py 2016-12-08 11:34:39 -05:00
Allen Sanabria
fd810d16bf Removed Ansible API based tests from this PR 2016-12-08 11:34:39 -05:00
Allen Sanabria
c6fdb7ceda Including unit tests.
* Including unit tests as per https://groups.google.com/forum/#!topic/ansible-devel/ejY4CjKeC34
* This test suite is automatically run in https://github.com/linuxdynasty/ld-ansible-modules
2016-12-08 11:34:39 -05:00
Allen Sanabria
b336c5a606 updated module to accept check_mode in every boto call 2016-12-08 11:34:39 -05:00
Allen Sanabria
2f5992c70f Removed test as they will not be ran by Ansible.
* I will include tests in my personal repo which will contain all
modules written by me with their associated tests.
2016-12-08 11:34:39 -05:00
Allen Sanabria
133b5ccdde Added test to kinesis_stream module.
* Update kinesis_stream based on tests.
* Added tests for kinesis_stream.
2016-12-08 11:34:39 -05:00
Allen Sanabria
24fb52c83b update doc string 2016-12-08 11:34:39 -05:00
Allen Sanabria
649e6f42b7 Create, Delete, and Modify a Kinesis Stream.
* Create a Kinesis Stream.
* Tag a Kinesis Stream.
* Update the Retention Period of a Kinesis Stream.
* Delete a Kinesis Stream.
* Wait for a Kinesis Stream to be in an ACTIVE State.
2016-12-08 11:34:39 -05:00
Brian Coca
7691af8ce6 added unsafe_writes to blockinfile (#2701)
depends on  http://github.com/ansible/ansible/issues/17016
2016-12-08 11:34:39 -05:00
Matt Martz
ed832c89f4 If rc is null, assume that a timeout happened. Fixes #2484 (#2485) 2016-12-08 11:34:39 -05:00
Dagobert Michelsen
87be961c1d Do not return failure when the package is installed and nothing is done (#1852) 2016-12-08 11:34:39 -05:00
Tim Rupp
a367a9ac01 Adds style conventions for bigip_node (#2697)
A number of coding conventions have been adopted for new F5 modules
that are in development. To ensure common usage across the modules,
this module needed to be updated to reflect those conventions.

No functional code changes were made.
2016-12-08 11:34:39 -05:00
Adam Števko
081e6ec032 Add support for managing OpenZFS pools (#2642) 2016-12-08 11:34:39 -05:00
Dan Keder
2bfbfbb3ff seport: fix a bug when SELinux port definition was already there (#2009) (#2694) 2016-12-08 11:34:39 -05:00
René Moser
a4427d55c3 apk: fix LANG != C while parsing stdout (#2689) 2016-12-08 11:34:38 -05:00
Kevin Brebanov
cf87e1d9b2 apk: Add support for updating virtual packages (#2686)
Fixes: #2389
2016-12-08 11:34:38 -05:00
Manuel Sousa
4289354ce5 RabbitMQ-Binding - Allow empty routing key (#2674)
Fixes: #1985
2016-12-08 11:34:38 -05:00
ovcharenko
bdf1a087cb Bug report: ufw: interface option causes an error (1.9.4) (#1491) (#2668) 2016-12-08 11:34:38 -05:00
trondhindenes
20844c1ef6 updated documentation for win_package (#2677) 2016-12-08 11:34:38 -05:00
Brian Coca
edcac217f5 make sure nic is always defined (#2678) 2016-12-08 11:34:38 -05:00
Matt Clay
38d1cce5d1 Use open_url directly to avoid failing tests. (#2680) 2016-12-08 11:34:38 -05:00
Indrajit Raychaudhuri
93fd941c66 List homebrew options aliases in documentation (#2671) 2016-12-08 11:34:38 -05:00
Indrajit Raychaudhuri
f901e215ad List pacman options aliases in documentation (#2670) 2016-12-08 11:34:38 -05:00
Linus Unnebäck
705f54ac18 iptables: remove duplicated documentation (#2673)
Fixes #1527
2016-12-08 11:34:38 -05:00
Allen Sanabria
dd63eb7a7a fixed error message for releasing an ip when not waiting for the nat gateway to delete successfully 1st 2016-12-08 11:34:38 -05:00
Allen Sanabria
ba17bdf1d0 fail_json when error and not exit_json 2016-12-08 11:34:38 -05:00
Allen Sanabria
38349f226a updated tests to reflect dict vs list 2016-12-08 11:34:38 -05:00
Allen Sanabria
1ddfa76c12 clean up documentation 2016-12-08 11:34:38 -05:00
Allen Sanabria
5a6f875487 updated catch statement to pass test (as e) 2016-12-08 11:34:38 -05:00
Allen Sanabria
cca24b0eac Make sure to catch if no gateways exist 2016-12-08 11:34:38 -05:00
Allen Sanabria
015cf1f785 Added default result of None in catch statement 2016-12-08 11:34:37 -05:00
Allen Sanabria
43da26404b Updated module to be compliant with test cases.
* Added integration tests
* Added unit tests
2016-12-08 11:34:37 -05:00
Allen Sanabria
ec2b499959 Fixed the missing argument to get_eip_allocation_id_by_address 2016-12-08 11:34:37 -05:00
Allen Sanabria
0d7d778c82 Manage AWS Nat Gateways
* Create an AWS Nat Gateway.
* Delete an AWS Nat Gateway.
* If Nat Gateway exist in subnet and the option is passed to not create one, it will then return the Nat Gateway object.
2016-12-08 11:34:37 -05:00
Serge van Ginderachter
c1fd6c6388 return a proper result set for getmaster/getslave (#2595)
* return a proper result set for getmaster/getslave

when not on a master/slave.
This allows for a cleaner error handling.

* A more uniform return of result keys for getmaster/slave
2016-12-08 11:34:37 -05:00
Serge van Ginderachter
121ef13e47 Exception handling for MySQLdb warnings (#2594)
Do not fail the module for warnings.
Return warnings in the module result set.

Fixes #719
Alternative to #720 and as discuseed over there.
2016-12-08 11:34:37 -05:00
Thierno IB. BARRY
4fc6fc438a Add kibana_plugin module (#2621)
* kibana_plugin: add the kibana_plugin module

* kibana_plugin: update doc

* kibana_plugin: add check mode and fix few coding style issues

* kibana_plugin: use return instead conditional statement for check mode
2016-12-08 11:34:37 -05:00
Jeff Wozniak
9d0eecc873 Add logicmonitor and logicmonitor_facts modules 2016-12-08 11:34:37 -05:00
Ben Doherty
0380006e00 expanduser() on dest 2016-12-08 11:34:37 -05:00
Ben Doherty
51ab6cdc0d Refactor computation of archive filenames, clearer archive filename 2016-12-08 11:34:37 -05:00
Ben Doherty
87c8a21d16 Don't try to walk over files when building archive 2016-12-08 11:34:37 -05:00
Ben Doherty
42112060b5 Rename 'archive' -> 'arcfile' in compress branch 2016-12-08 11:34:37 -05:00
Ben Doherty
b0211c72d7 Change 'creates' parameter to 'dest' 2016-12-08 11:34:37 -05:00
Ben Doherty
fb03fc8eb1 Refactor zip and tarfile loops together, branch where calls are different
This fixed a few bugs and simplified the code
2016-12-08 11:34:37 -05:00
Benjamin Doherty
8fc2a22b4c Add 'default' to docs for 'compression' option 2016-12-08 11:34:37 -05:00
Ben Doherty
102ee6a3b4 Some refactoring:
* rename archive -> arcfile (where it's a file descriptor)
* additional return
* simplify logic around 'archive?' flag
* maintain os separator after arcroot
* use function instead of lambda for filter, ensure file exists before file.cmp'ing it
* track errored files and fail if there are any
2016-12-08 11:34:36 -05:00
Ben Doherty
d4b51adf72 Reword comments slightly 2016-12-08 11:34:36 -05:00
Ben Doherty
e10e1e358c Documentation updates 2016-12-08 11:34:36 -05:00
Ben Doherty
506f3f68f1 Use different syntax in lambda 2016-12-08 11:34:36 -05:00
Ben Doherty
c9291e06f6 Make remove default to false. It's less frightening. 2016-12-08 11:34:36 -05:00
Ben Doherty
3c8d788c11 Don't use <x> if <y> else <z> syntax 2016-12-08 11:34:36 -05:00
Ben Doherty
c5b9bda656 Accept 'path' as a list argument, expose path and expanded_path,
Use correct variable in expanduser
2016-12-08 11:34:36 -05:00
Ben Doherty
2aa3f52bf3 Fix up for zip files and nesting logic.
* Don't include the archive in the archive if it falls within an archived path
* If remove=True and the archive would be in an archived path, fail.
* Fix single-file zip file compression
* Add more documentation about 'state' return
2016-12-08 11:34:36 -05:00
Ben Doherty
3be65b66d1 Add license 2016-12-08 11:34:36 -05:00
Ben Doherty
90fdc71728 Add compressed file source to successes when succeeds! 2016-12-08 11:34:36 -05:00
Ben Doherty
bab1f5c082 Add RETURN documentation 2016-12-08 11:34:36 -05:00
Ben Doherty
409f67584e Fix write mode for ZipFiles ('wb' is invalid!) 2016-12-08 11:34:36 -05:00
Ben Doherty
3465375e42 Drop extra double-quote from documentation 2016-12-08 11:34:36 -05:00
Ben Doherty
2e1ce01dff Initial commit of extras/archive module.
This manages compressed files or archives of many compressed files. You can maintain or update .gz, .bz2 compressed files, .zip archives, or tarballs compressed with gzip or bzip2.

Possible use cases:

* Back up user home directories
* Ensure large text files are always compressed
* Archive trees for distribution
2016-12-08 11:34:36 -05:00
Robin Schneider
f408a4db02 Use HTTPS instead of legacy HTTP for ansible.com (#2636)
Mechanical edit done by this "one-liner":

git ls-files -z "$(git rev-parse --show-toplevel)" | xargs --null -I '{}' find '{}' -type f -print0 | xargs --null sed --in-place --regexp-extended 's#http://www\.ansible\.com#https://www.ansible.com#g;'

Related to: https://github.com/ansible/ansible/issues/16869
2016-12-08 11:34:36 -05:00
James Tanner
3170180049 Consolidate to one module and use new arg spec 2016-12-08 11:34:36 -05:00
James Tanner
7b65afa83e add examples 2016-12-08 11:34:35 -05:00
James Tanner
222f9bc08a Remove print statements 2016-12-08 11:34:35 -05:00
James Tanner
d051701359 fix tabs 2016-12-08 11:34:35 -05:00
James Tanner
474b52ae47 Add the guest state module 2016-12-08 11:34:35 -05:00
James Tanner
855a408718 Rename module 2016-12-08 11:34:35 -05:00
James Tanner
4722144acf Add return data example 2016-12-08 11:34:35 -05:00
James Tanner
91e2c5e0ea Add template deployer 2016-12-08 11:34:35 -05:00
Matt Clay
d18720adde Enable FreeBSD tests on Shippable. (#2648) 2016-12-08 11:34:35 -05:00
Brian Coca
f6dc39a478 updated docs, version is 2.2 and explain changes 2016-12-08 11:34:35 -05:00
Jonathan Davila
94e95d8795 Updates to Sendgrid Module (#1275) 2016-12-08 11:34:35 -05:00
Ryan Brown
ea5cd3941b Improve module docs (#2638) 2016-12-08 11:34:35 -05:00
Matt Clay
210b6be359 Enable Windows tests on Shippable. (#2635) 2016-12-08 11:34:35 -05:00
Adrian Likins
c0e316209b Add RETURN docs for github_key (#2634) 2016-12-08 11:34:35 -05:00
Adrian Likins
66716d58a2 Use %s string formatting in system/timezone.py (#2632)
This module was using python 2.6 string .format().
To enable the module to run on python2.4, replace
the .format formatting with '%s' based string formatting.

There was also a use of a 'filename' variable in the
NosystemdTimezone.get() method that was never set.

An import of 'os' was also added for clarity.
2016-12-08 11:34:35 -05:00
Adrian Likins
fa1b0312eb Add a 'requirements:' field to homebrew doc (#2630)
homebrew.py and homebrew_cask.py make use of python
2.5 and 2.6 features like string .format() method.
2016-12-08 11:34:35 -05:00