mirror of
https://github.com/ansible-collections/community.general.git
synced 2024-09-14 20:13:21 +02:00
6f0477a780
This argument had a couple of issues with it. First, as it was being interpreted in the code, it did not check for idempotency. Second, the model of having the parameters be "all_*" is going to hinder the ability to "undo", so-to-speak, what the user did while maintaining legibility. Consider if the user specified "all_enabled_vlans='net1'" and then decided they wanted to backout of this decision. What is the proper argument to fulfill this wish? "all_enabled_vlans='...?' This patch changes the all_enabled_vlans argument to be "enabled_vlans", ensures that idempotency works, and also provides for a way to "undo" a change to the enabled VLANs by allowing the user to specify the special case VLAN named "ALL" (all capitals). This makes the parameter more intuitive because the users will specify which vlans they want to make the virtual available on * enabled_vlans="net1" but also allows them to "undo" what they did by setting it back with the case of all * enabled_vlans="ALL" |
||
---|---|---|
.. | ||
ansible |