Lorin Hochstein
1c5ac5cac8
Pretty-print "msg" when task fails
...
Several modules (e.g., pip) return stdout and stderr together in a "msg" variable (and the module development docs seem to suggest that the standard practice is to return status in this variable).
This change ensures that it is printed out with correct formatting (most importantly, with newlines appearing as newlines instead of \n).
2012-11-01 13:23:18 -04:00
Michael DeHaan
4399d9c3cb
Merge pull request #1505 from dhozac/delegate_to-port
...
Use default port if ansible_ssh_port is not set for the delegated node
2012-11-01 04:37:03 -07:00
Daniel Hokka Zakrisson
fbda2d4628
Use default port if ansible_ssh_port is not set for the delegated node
...
Also add testcase for it.
2012-11-01 12:00:49 +01:00
Michael DeHaan
4c4cc270fe
Merge pull request #1496 from dhozac/varnish-init-script
...
Fix service module for varnish initscript in EPEL
2012-10-31 04:33:31 -07:00
Daniel Hokka Zakrisson
20775c0b73
Fix service module for varnish initscript in EPEL
...
It outputs 'dead but pid file exists'.
2012-10-31 12:31:08 +01:00
Michael DeHaan
be300b562a
pyflakes fixes (mostly unused imports, unused vars)
2012-10-30 20:47:05 -04:00
Michael DeHaan
c0747b7baa
pep8 fixes
2012-10-30 20:42:07 -04:00
Michael DeHaan
27e518a0b1
Rename 'domainname' to 'domain'
2012-10-30 20:07:36 -04:00
Michael DeHaan
9251709941
Merge pull request #1490 from sfromm/issue1484
...
Make sure ownership is set correctly for user's new ssh keys
2012-10-30 17:03:07 -07:00
Michael DeHaan
ef4ca11282
Merge pull request #1489 from arrfab/my-branch
...
- Fixed some typos for the ansible config file in the man page
2012-10-30 17:02:40 -07:00
Michael DeHaan
768d293949
Merge pull request #1488 from dagwieers/lineinfile-create
...
Add option create= to lineinfile module
2012-10-30 17:02:00 -07:00
Michael DeHaan
91cf257e9c
Merge pull request #1487 from skvidal/devel
...
fix up remove and fix fixme checking to see if pkg was removed
2012-10-30 17:00:54 -07:00
Michael DeHaan
cceb99acd5
Simplify the group_by example a small bit
2012-10-30 20:00:21 -04:00
Michael DeHaan
0853ece810
Merge pull request #1474 from jhoekx/group-by-plugin-template
...
Add a group_by action plugin.
2012-10-30 16:54:07 -07:00
Michael DeHaan
f9a6265fb2
Merge branch 'vars_files-list-no-default' of git://github.com/dhozac/ansible into devel
2012-10-30 19:50:31 -04:00
Michael DeHaan
6dceef3a5f
Merge branch 'fix-var-in-var' of git://github.com/dhozac/ansible into devel
2012-10-30 19:48:32 -04:00
Serge van Ginderachter
1db563e064
Add domainname to ansible facts
2012-10-30 19:47:31 -04:00
Dag Wieers
aef9a95c1c
Merge pull request #2 from sergevanginderachter/dagwieers/lineinfile-create
...
Fix typo
2012-10-30 13:01:25 -07:00
Serge van Ginderachter
47d882f374
Fix typo
2012-10-30 19:43:22 +01:00
Dag Wieers
1e3dcfce4b
Add option create= to lineinfile module
...
We use the lineinfile module to modify configuration files of a proprietary application. This application reads configuration options from files, but does not require those files to exist (if the default options are fine). However this application may modify the configuration file at will, so we cannot copy or template those files. And after a silent install the configuration may not exist (depending on the response file).
Whatever the case, during deployment we need to make sure some configuration options are set after the installation.
So the cleanest way to handle this situation is to allow the lineinfile module to create the file if it is missing (and this is the expected behavior). When I proposed this behavior, @sergevanginderachter needed the same functionality and was now working around it as well.
2012-10-30 17:57:15 +01:00
Stephen Fromm
4619e99443
Make sure ownership is set correctly for user's new ssh keys
2012-10-30 09:37:23 -07:00
Fabian Arrotin
96770a3057
- Fixed some typos for the ansible config file
...
- added the ANSIBLE_CONFIG environment variable
2012-10-30 17:08:12 +01:00
Daniel Hokka Zakrisson
efe83daf19
Fix ${var.$other_var} and add test cases for it
2012-10-30 13:05:45 +01:00
Michael DeHaan
f0000a89b0
Merge pull request #1480 from dagwieers/command-fix2
...
Use return codes > 255 for Ansible-specific errors.
2012-10-30 05:04:44 -07:00
Michael DeHaan
730031ec1f
Merge pull request #1479 from wzzrd/selinux
...
More useful error message for if not HAVE_SELINUX
2012-10-30 05:04:28 -07:00
Dag Wieers
8d4f9febd8
Use return codes > 255 for Ansible-specific errors.
...
I had made and pushed this change after you already pulled the request.
@dhozac indicated that it would probably be better to use return codes > 255 for anything related to Ansible itself. Which makes sens :)
2012-10-30 10:36:11 +01:00
Seth Vidal
49dce05cdd
fix up remove and fix fixme checking to see if pkg was removed
2012-10-29 23:48:21 -04:00
Michael DeHaan
9a12873166
Merge pull request #1477 from skvidal/devel
...
add check that vars plugins are not handing back None
2012-10-29 16:02:26 -07:00
Michael DeHaan
08cc961dcf
Merge pull request #1475 from dagwieers/errors-fix
...
Missing errors-import causes traceback
2012-10-29 16:01:47 -07:00
Seth Vidal
7c1e0de141
fix removal case where first pkg in a list is not installed at all
...
and the next one gets ignored despite being installed.
also clean up unnecessary second check.
2012-10-29 13:48:20 -04:00
Seth Vidal
3fcc591f18
add check that vars plugins are not handing back None
2012-10-29 12:11:57 -04:00
Maxim Burgerhout
82cc382c6a
More useful error message for if not HAVE_SELINUX
2012-10-29 16:23:00 +01:00
Dag Wieers
3728b2f459
Missing errors-import causes traceback
2012-10-29 15:16:26 +01:00
Jeroen Hoekx
b336d40101
Add a group_by action plugin.
2012-10-29 13:10:23 +01:00
Michael DeHaan
ea8cb0b2e9
Merge pull request #1472 from jhoekx/action-host-letter
...
Send a host to runner executor instead of a letter.
2012-10-29 04:19:35 -07:00
Jeroen Hoekx
f963db6c2a
Fix output of pause plugin.
2012-10-29 10:57:13 +01:00
Jeroen Hoekx
77162e95e4
Send a host to runner executor instead of a letter.
...
Discovered in #1463 .
2012-10-29 09:45:44 +01:00
Daniel Hokka Zakrisson
e72fdccd87
Allow vars_files sequences without a default
2012-10-28 16:35:22 +01:00
Michael DeHaan
fb27cb45e1
Merge pull request #1465 from dhozac/no-default-file-args
...
Don't add file module arguments by default
2012-10-28 06:43:08 -07:00
Daniel Hokka Zakrisson
55a1473d50
Don't add file module arguments by default
...
This allows the postgresql_db module to work properly, as it uses
an argument named owner that conflicts with the file module.
2012-10-28 11:14:29 +01:00
Michael DeHaan
457cdb2be0
Add note about when you still have to use only_if
2012-10-27 18:22:16 -04:00
Michael DeHaan
2ae090b1db
Update 'who uses' page
2012-10-27 18:10:24 -04:00
Michael DeHaan
21258dcc66
Added 'when' as a shortcut around only_if.
2012-10-27 17:55:35 -04:00
Michael DeHaan
a768e9a9ff
Fix for sudo defaults if sudo is passed in via --extra-vars
2012-10-27 16:46:33 -04:00
Michael DeHaan
7d7ff9d616
Fixup setup.py path
2012-10-26 20:20:02 -04:00
Michael DeHaan
7f6aa2d3d5
Config parameter rename
2012-10-26 20:19:09 -04:00
Michael DeHaan
6ba30170dd
Make group_vars and host_vars available to usr/bin/ansible, and make vars_plugins exist
2012-10-26 19:55:59 -04:00
Michael DeHaan
e04dab904a
Use previous proven multiprocessing logic as the simplification didn't have the same Ctrl-C handling and may
...
be subject to race issues, though still don't pass Runner to each. Still seems performant.
2012-10-26 18:11:38 -04:00
Michael DeHaan
03f303fba3
Merge pull request #1460 from dhozac/init-sftp-paramiko
...
Initialize sftp variable to fix error on transferless session
2012-10-26 14:59:10 -07:00
Daniel Hokka Zakrisson
1052dd9c8f
Initialize sftp variable to fix error on transferless session
2012-10-26 23:54:21 +02:00
