mirror of
https://github.com/ansible-collections/community.general.git
synced 2024-09-14 20:13:21 +02:00
fix(opentelemetry): avoid storing inmemory if logs are disabled (#8373)
* fix(opentelemetry): avoid storing inmemory if logs are disabled * changelog * fix syntax * refactor * chore * chore * chore * fix
This commit is contained in:
parent
5f481939d4
commit
d87b9fe0dc
2 changed files with 12 additions and 3 deletions
3
changelogs/fragments/8373-honour-disable-logs.yaml
Normal file
3
changelogs/fragments/8373-honour-disable-logs.yaml
Normal file
|
@ -0,0 +1,3 @@
|
||||||
|
bugfixes:
|
||||||
|
- opentelemetry callback plugin - honour the ``disable_logs`` option to avoid storing task results since they are not used regardless (https://github.com/ansible-collections/community.general/pull/8373).
|
||||||
|
|
|
@ -555,6 +555,12 @@ class CallbackModule(CallbackBase):
|
||||||
|
|
||||||
self.otel_exporter_otlp_traces_protocol = self.get_option('otel_exporter_otlp_traces_protocol')
|
self.otel_exporter_otlp_traces_protocol = self.get_option('otel_exporter_otlp_traces_protocol')
|
||||||
|
|
||||||
|
def dump_results(self, result):
|
||||||
|
""" dump the results if disable_logs is not enabled """
|
||||||
|
if self.disable_logs:
|
||||||
|
return ""
|
||||||
|
return self._dump_results(result._result)
|
||||||
|
|
||||||
def v2_playbook_on_start(self, playbook):
|
def v2_playbook_on_start(self, playbook):
|
||||||
self.ansible_playbook = basename(playbook._file_name)
|
self.ansible_playbook = basename(playbook._file_name)
|
||||||
|
|
||||||
|
@ -604,7 +610,7 @@ class CallbackModule(CallbackBase):
|
||||||
self.tasks_data,
|
self.tasks_data,
|
||||||
status,
|
status,
|
||||||
result,
|
result,
|
||||||
self._dump_results(result._result)
|
self.dump_results(result)
|
||||||
)
|
)
|
||||||
|
|
||||||
def v2_runner_on_ok(self, result):
|
def v2_runner_on_ok(self, result):
|
||||||
|
@ -612,7 +618,7 @@ class CallbackModule(CallbackBase):
|
||||||
self.tasks_data,
|
self.tasks_data,
|
||||||
'ok',
|
'ok',
|
||||||
result,
|
result,
|
||||||
self._dump_results(result._result)
|
self.dump_results(result)
|
||||||
)
|
)
|
||||||
|
|
||||||
def v2_runner_on_skipped(self, result):
|
def v2_runner_on_skipped(self, result):
|
||||||
|
@ -620,7 +626,7 @@ class CallbackModule(CallbackBase):
|
||||||
self.tasks_data,
|
self.tasks_data,
|
||||||
'skipped',
|
'skipped',
|
||||||
result,
|
result,
|
||||||
self._dump_results(result._result)
|
self.dump_results(result)
|
||||||
)
|
)
|
||||||
|
|
||||||
def v2_playbook_on_include(self, included_file):
|
def v2_playbook_on_include(self, included_file):
|
||||||
|
|
Loading…
Reference in a new issue