From d87b9fe0dce577aad2e58f56626a5df50839a884 Mon Sep 17 00:00:00 2001
From: Victor Martinez <victormartinezrubio@gmail.com>
Date: Sun, 19 May 2024 20:49:10 +0200
Subject: [PATCH] fix(opentelemetry): avoid storing inmemory if logs are
 disabled (#8373)

* fix(opentelemetry): avoid storing inmemory if logs are disabled

* changelog

* fix syntax

* refactor

* chore

* chore

* chore

* fix
---
 changelogs/fragments/8373-honour-disable-logs.yaml |  3 +++
 plugins/callback/opentelemetry.py                  | 12 +++++++++---
 2 files changed, 12 insertions(+), 3 deletions(-)
 create mode 100644 changelogs/fragments/8373-honour-disable-logs.yaml

diff --git a/changelogs/fragments/8373-honour-disable-logs.yaml b/changelogs/fragments/8373-honour-disable-logs.yaml
new file mode 100644
index 0000000000..112b10a9f4
--- /dev/null
+++ b/changelogs/fragments/8373-honour-disable-logs.yaml
@@ -0,0 +1,3 @@
+bugfixes:
+  - opentelemetry callback plugin - honour the ``disable_logs`` option to avoid storing task results since they are not used regardless (https://github.com/ansible-collections/community.general/pull/8373).
+    
diff --git a/plugins/callback/opentelemetry.py b/plugins/callback/opentelemetry.py
index cb3d752686..54c1690a22 100644
--- a/plugins/callback/opentelemetry.py
+++ b/plugins/callback/opentelemetry.py
@@ -555,6 +555,12 @@ class CallbackModule(CallbackBase):
 
         self.otel_exporter_otlp_traces_protocol = self.get_option('otel_exporter_otlp_traces_protocol')
 
+    def dump_results(self, result):
+        """ dump the results if disable_logs is not enabled """
+        if self.disable_logs:
+            return ""
+        return self._dump_results(result._result)
+
     def v2_playbook_on_start(self, playbook):
         self.ansible_playbook = basename(playbook._file_name)
 
@@ -604,7 +610,7 @@ class CallbackModule(CallbackBase):
             self.tasks_data,
             status,
             result,
-            self._dump_results(result._result)
+            self.dump_results(result)
         )
 
     def v2_runner_on_ok(self, result):
@@ -612,7 +618,7 @@ class CallbackModule(CallbackBase):
             self.tasks_data,
             'ok',
             result,
-            self._dump_results(result._result)
+            self.dump_results(result)
         )
 
     def v2_runner_on_skipped(self, result):
@@ -620,7 +626,7 @@ class CallbackModule(CallbackBase):
             self.tasks_data,
             'skipped',
             result,
-            self._dump_results(result._result)
+            self.dump_results(result)
         )
 
     def v2_playbook_on_include(self, included_file):