1
0
Fork 0
mirror of https://github.com/DO1JLR/ansible_linux_desktop_setup.git synced 2024-09-14 19:54:51 +02:00

improve linting and pylint

This commit is contained in:
L3D 2023-04-13 23:19:42 +02:00
parent 8f48aa768d
commit c484325f23
8 changed files with 28 additions and 177 deletions

View file

@ -9,3 +9,5 @@ rules:
ignore: |
roles/
collections/
ansible/

View file

@ -36,7 +36,7 @@ python3 -m venv ansible
source ansible/bin/activate
# Install Ansible
pip3 install ansible-core
pip3 install --upgrade ansible-core ansible-lint pylint
```
Which playbook?

View file

@ -28,7 +28,9 @@ def become_pass(host):
"""
return variable for become password using gopass lookup
"""
passstring = str("\"ansible_become_pass\": \"{{ lookup('community.general.passwordstore', 'ansible/hosts/" + host + "/users/root') }}\"")
passstring = str("\"ansible_become_pass\": "
+ "\"{{ lookup('community.general.passwordstore', 'ansible/hosts/"
+ host + "/users/root') }}\"")
return passstring
def env(domain):

View file

@ -1,38 +0,0 @@
---
- name: check if ansible is not to old
hosts: localhost
roles:
- {role: ansible_version, tags: always, gather_facts: false}
- name: base packages setup
hosts: desk_minni.local
roles:
- {role: workstation_packages, tags: [base, packages, workstation]}
- name: user and ssh(d) setup
hosts: desk_minni.local
roles:
- {role: do1jlr.users, tags: [users, base]}
- {role: do1jlr.auth, tags: [auth, base]}
- {role: do1jlr.sshd, tags: [sshd, base]}
- {role: dotfiles, tags: [dotfiles, base]}
- name: fancy schnickschnack
hosts: desk_minni.local
roles:
- {role: akku-warning, tags: akku}
# - {role: pulseaudio, tags: [pulse, audio, pulseaudio]}
- {role: networkmanager, tags: networkmanager, when: ansible_os_family == 'Archlinux'}
- {role: openvpn, tags: ovpn}
- {role: nextcloud, tags: nextcloud, when: ansible_os_family == 'Archlinux'}
- {role: bat, tags: bat, when: ansible_os_family == 'Debian'}
- {role: install-firefox, tags: firefox}
- {role: copy_files}
- {role: do1jlr.i3wm, tags: i3wm}
- {role: ntp, tags: ntp}
- {role: xrandr, tags: xrandr}
- {role: arch-fonts, tags: fonts}
# - {role: winehq, tags: wine}
- {role: no-sleep, tags: sleep}
- {role: do1jlr.avahi_daemon, tags: [avahi_daemon, avahi]}
- {role: do1jlr.avahi_client, tags: [avahi_client, mdns]}

View file

@ -1,39 +0,0 @@
---
- name: check if ansible is not to old
hosts: localhost
roles:
- {role: ansible_version, tags: always, gather_facts: false}
- name: base packages setup
hosts: l14.local
roles:
- {role: workstation_packages, tags: [base, packages, workstation]}
- {role: amdgpu_firmware, tags: [amdgpu, firmware]}
- name: user and ssh(d) setup
hosts: l14.local
roles:
- {role: do1jlr.users, tags: [users, base]}
- {role: do1jlr.auth, tags: [auth, base]}
- {role: do1jlr.sshd, tags: [sshd, base]}
- {role: dotfiles, tags: [dotfiles, base]}
- name: fancy schnickschnack
hosts: l14.local
roles:
- {role: akku-warning, tags: akku}
# - {role: pulseaudio, tags: [pulse, audio, pulseaudio]}
- {role: networkmanager, tags: networkmanager, when: ansible_os_family == 'Archlinux'}
- {role: openvpn, tags: ovpn}
- {role: nextcloud, tags: nextcloud, when: ansible_os_family == 'Archlinux'}
- {role: bat, tags: bat, when: ansible_os_family == 'Debian'}
- {role: install-firefox, tags: firefox}
- {role: copy_files}
- {role: do1jlr.i3wm, tags: i3wm}
- {role: ntp, tags: ntp}
- {role: xrandr, tags: xrandr}
- {role: arch-fonts, tags: fonts}
# - {role: winehq, tags: wine}
- {role: no-sleep, tags: sleep}
- {role: do1jlr.avahi_daemon, tags: [avahi_daemon, avahi]}
- {role: do1jlr.avahi_client, tags: [avahi_client, mdns]}

View file

@ -1,38 +0,0 @@
---
- name: check if ansible is not to old
hosts: localhost
roles:
- {role: ansible_version, tags: always, gather_facts: false}
- name: base packages setup
hosts: t460p.local
roles:
- {role: workstation_packages, tags: [base, packages, workstation]}
- name: user and ssh(d) setup
hosts: t460p.local
roles:
- {role: do1jlr.users, tags: [users, base]}
- {role: do1jlr.auth, tags: [auth, base]}
- {role: do1jlr.sshd, tags: [sshd, base]}
- {role: dotfiles, tags: [dotfiles, base]}
- name: fancy schnickschnack
hosts: t460p.local
roles:
- {role: akku-warning, tags: akku}
# - {role: pulseaudio, tags: [pulse, audio, pulseaudio]}
- {role: networkmanager, tags: networkmanager, when: ansible_os_family == 'Archlinux'}
- {role: openvpn, tags: ovpn}
- {role: nextcloud, tags: nextcloud, when: ansible_os_family == 'Archlinux'}
- {role: bat, tags: bat, when: ansible_os_family == 'Debian'}
- {role: install-firefox, tags: firefox}
- {role: copy_files}
- {role: do1jlr.i3wm, tags: i3wm}
- {role: ntp, tags: ntp}
- {role: xrandr, tags: xrandr}
- {role: arch-fonts, tags: fonts}
# - {role: winehq, tags: wine}
- {role: no-sleep, tags: sleep}
- {role: do1jlr.avahi_daemon, tags: [avahi_daemon, avahi]}
- {role: do1jlr.avahi_client, tags: [avahi_client, mdns]}

View file

@ -1,38 +0,0 @@
---
- name: check if ansible is not to old
hosts: localhost
roles:
- {role: ansible_version, tags: always, gather_facts: false}
- name: base packages setup
hosts: workstation.local
roles:
- {role: workstation_packages, tags: [base, packages, workstation]}
- name: user and ssh(d) setup
hosts: workstation.local
roles:
- {role: do1jlr.users, tags: [users, base]}
- {role: do1jlr.auth, tags: [auth, base]}
- {role: do1jlr.sshd, tags: [sshd, base]}
- {role: dotfiles, tags: [dotfiles, base]}
- name: fancy schnickschnack
hosts: workstation.local
roles:
- {role: akku-warning, tags: akku}
- {role: pulseaudio, tags: [pulse, audio, pulseaudio]}
- {role: networkmanager, tags: networkmanager, when: ansible_os_family == 'Archlinux'}
- {role: openvpn, tags: ovpn}
- {role: nextcloud, tags: nextcloud, when: ansible_os_family == 'Archlinux'}
- {role: bat, tags: bat, when: ansible_os_family == 'Debian'}
- {role: install-firefox, tags: firefox}
- {role: copy_files}
- {role: do1jlr.i3wm, tags: i3wm}
- {role: ntp, tags: ntp}
- {role: xrandr, tags: xrandr}
- {role: arch-fonts, tags: fonts}
- {role: winehq, tags: wine}
- {role: no-sleep, tags: sleep}
- {role: do1jlr.avahi_daemon, tags: [avahi_daemon, avahi]}
- {role: do1jlr.avahi_client, tags: [avahi_client, mdns]}

View file

@ -16,28 +16,28 @@
- name: run do1jlr.base setup roles
hosts: all
roles:
#- {role: do1jlr.base, tags: [default, packages, base]}
#- {role: workstation_packages, tags: [default, workstation_packages, packages, setup]}
# - {role: do1jlr.base, tags: [default, packages, base]}
# - {role: workstation_packages, tags: [default, workstation_packages, packages, setup]}
- {role: ntp, tags: ntp}
- {role: do1jlr.avahi_client, tags: avahi}
- {role: do1jlr.avahi_daemon, tags: avahi}
#- {role: arch-fonts, tags: [font, fonts, arch-fonts]}
# - {role: arch-fonts, tags: [font, fonts, arch-fonts]}
#- name: user specific setup
# - name: user specific setup
# hosts: private
# roles:
#- {role: dotfiles, tags: [default, dotfiles, fancy]}
#- {role: manage_users, tags: [ssh, manage, manage_users]}
#- {role: authorized_keys, tags: [ssh, auth, authorized_keys]}
#- {role: sshd, tags: [ssh, sshd]}
#- {role: akku-warning, tags: [akku, akku_warning, akku-warning]}
#- {role: pulseaudio, tags: pulseaudio}
#- {role: networkmanager, tags: [nm, networkmanager]}
#- {role: copy_files}
#- {role: do1jlr.i3wm, tags: i3wm}
# - {role: xrandr, tags: xrandr}
#- {role: install-firefox, tags: firefox}
#- {role: nextcloud, tags: nextcloud}
#- {role: openvpn, tags: openvpn}
#- {role: winehq, tags: [wine, winehq]}
#- {role: no-sleep, tags: no_sleep}
# - {role: dotfiles, tags: [default, dotfiles, fancy]}
# - {role: manage_users, tags: [ssh, manage, manage_users]}
# - {role: authorized_keys, tags: [ssh, auth, authorized_keys]}
# - {role: sshd, tags: [ssh, sshd]}
# - {role: akku-warning, tags: [akku, akku_warning, akku-warning]}
# - {role: pulseaudio, tags: pulseaudio}
# - {role: networkmanager, tags: [nm, networkmanager]}
# - {role: copy_files}
# - {role: do1jlr.i3wm, tags: i3wm}
# - {role: xrandr, tags: xrandr}
# - {role: install-firefox, tags: firefox}
# - {role: nextcloud, tags: nextcloud}
# - {role: openvpn, tags: openvpn}
# - {role: winehq, tags: [wine, winehq]}
# - {role: no-sleep, tags: no_sleep}