mirror of
https://github.com/ansible-collections/community.general.git
synced 2024-09-14 20:13:21 +02:00
f14e566cc7
* pkgng: join package list into one command
Change the pkgng module so all packages being
installed (or upgraded) are acted on in one
command (per action). This will make installs
and upgrades a bit faster, because pkg will be
invoked fewer times per module run. More important,
module actions will be more atomic, making it less
likely that some packages are acted on because they
appear earlier in the argument list.
This change also improves the status reporting of
packages acted on, specifying the number of packages
for each action (install or upgrade).
* pkgng: make upgrade check lazily evaluated
Make upgrade_available an inner function so that the
if statement that checks whether installed packages
are up-to-date only runs the upgrade check on packages
that are already installed. This gets lazily evaluated
because of boolean operator short-circuiting:
https://docs.python.org/3.8/library/stdtypes.html#boolean-operations-and-or-not
Previously, the module would always check for upgrades,
even for not-installed packages, when running with
`state=latest`.
* pkgng: add changelog fragment
* pkgng: Apply changelog suggestions from code review
Co-authored-by: Felix Fontein <felix@fontein.de>
* pkgng: resolve pep8 style issue
Remove inline function. It's purpose would be confusing for
future maintainers, and someone refactoring it to a variable,
with good intentions, would introduce a performance regression.
Including the `query_update()` call in the if expression makes
the intent more legible and still ensures lazy evaluation of the
function call if the first `and` is `False`.
* pkgng: Fix changelog fragment syntax issue
Need to escape quotes so YAML doesn't eat them
Co-authored-by: Felix Fontein <felix@fontein.de>
* pkgng: Improve output message English grammar
Make word "package" plural only if reporting on more than one package
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| .keep | ||
| 3330-bugfix-keycloak-authentication-flow-requirements-not-set-correctly.yml.yml | ||
| 3393-pkgng-many_packages_one_command.yml | ||
| 3400-fix-gitLab-api-searches-always-return-first-found-match-3386.yml | ||
| 3401-nmcli-needs-type.yml | ||
| 3422-open-iscsi-mutual-authentication-support.yaml | ||
| 3425-mail_add_configurable_ehlo_hostname.yml | ||
| 3426-copy-permissions-along-with-file-for-jboss-module.yml | ||
| 3450-callback_opentelemetry-exception_handling.yml | ||
| 3453-fix-gitlab_group-require_two_factor_authentication-cant_be_null.yml | ||
| 3473-gitlab_deploy_key-fix_idempotency.yml | ||
| 3474-zypper_repository_improve_repo_file_idempotency.yml | ||
| 3478-yaml-callback.yml | ||
| 3496-callback_opentelemetry-enrich_stacktraces.yml | ||
| 3498-callback_opentelemetry-only_in_ci.yml | ||
| 3514-ufw_insert_or_delete_biased_when_deletion_enabled.yml | ||