1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/test/units/module_utils/basic
Jordan Borean 8bdd04c147 Fix remote_tmp when become with non admin user (#42396)
* Fix tmpdir on non root become

 - also avoid exception if tmpdir and remote_tmp are None
 - give 'None' on deescalation so tempfile will fallback to it's default behaviour
   and use system dirs
 - fix issue with bad tempdir (not existing/not createable/not writeable)
   i.e nobody and ~/.ansible/tmp
 - added tests for blockfile case

* Revert "Temporarily revert c119d54"

This reverts commit 5c614a59a6.

* changes based on PR feedback and changelog fragment

* changes based on the review

* Fix tmpdir when makedirs failed so we just use the system tmp

* Let missing remote_tmp fail

If remote_tmp is missing then there's something more basic wrong in the
communication from the controller to the module-side.  It's better to
be alerted in this case than to silently ignore it.

jborean and I have independently checked what happens if the user sets
ansible_remote_tmp to empty string and !!null and both cases work fine.
(null is turned into a default value controller-side.  empty string
triggers the warning because it is probably not a directory that the
become user is able to use).
2018-07-06 10:49:19 -07:00
..
__init__.py AnsibleModules.log() fix for python3 2015-10-12 13:30:27 -07:00
test__log_invocation.py Porting tests to pytest (#33387) 2017-12-05 12:43:13 -08:00
test__symbolic_mode_to_octal.py Split basic units (#33510) 2017-12-18 10:17:13 -08:00
test_argument_spec.py Allow subspec defaults to be processed when the parent argument is not supplied (#38967) 2018-05-07 11:23:13 -05:00
test_atomic_move.py Split basic units (#33510) 2017-12-18 10:17:13 -08:00
test_deprecate_warn.py Split basic units (#33510) 2017-12-18 10:17:13 -08:00
test_dict_converters.py Split basic units (#33510) 2017-12-18 10:17:13 -08:00
test_exit_json.py Split basic units (#33510) 2017-12-18 10:17:13 -08:00
test_filesystem.py Split basic units (#33510) 2017-12-18 10:17:13 -08:00
test_get_file_attributes.py AnsibleModule.get_file_attributes: add unit test 2017-12-18 15:49:25 -05:00
test_get_module_path.py Split basic units (#33510) 2017-12-18 10:17:13 -08:00
test_heuristic_log_sanitize.py Split basic units (#33510) 2017-12-18 10:17:13 -08:00
test_imports.py Split basic units (#33510) 2017-12-18 10:17:13 -08:00
test_log.py Split basic units (#33510) 2017-12-18 10:17:13 -08:00
test_no_log.py Split basic units (#33510) 2017-12-18 10:17:13 -08:00
test_platform_distribution.py Split basic units (#33510) 2017-12-18 10:17:13 -08:00
test_run_command.py Porting tests to pytest (#33387) 2017-12-05 12:43:13 -08:00
test_safe_eval.py Porting tests to pytest (#33387) 2017-12-05 12:43:13 -08:00
test_selinux.py Split basic units (#33510) 2017-12-18 10:17:13 -08:00
test_set_mode_if_different.py If check mode enabled and file missing set changed to true 32676 (#33967) 2018-01-04 20:33:14 -08:00
test_tmpdir.py Fix remote_tmp when become with non admin user (#42396) 2018-07-06 10:49:19 -07:00