1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/test/units/parsing
Adrian Likins dd0189839e Fix bug (#18355) where encrypted inventories fail 18355 (#18373)
* Fix bug (#18355) where encrypted inventories fail

This is first part of fix for #18355
* Make DataLoader._get_file_contents return bytes

The issue #18355 is caused by a change to inventory to
stop using _get_file_contents so that it can handle text
encoding itself to better protect against harmless text
encoding errors in ini files (invalid unicode text in
comment fields).

So this makes _get_file_contents return bytes so it and other
callers can handle the to_text().

The data returned by _get_file_contents() is now a bytes object
instead of a text object. The callers of _get_file_contents() have
been updated to call to_text() themselves on the results.

Previously, the ini parser attempted to work around
ini files that potentially include non-vailid unicode
in comment lines. To do this, it stopped using
DataLoader._get_file_contents() which does the decryption of
files if vault encrypted. It didn't use that because _get_file_contents
previously did to_text() on the read data itself.

_get_file_contents() returns a bytestring now, so ini.py
can call it and still special case ini file comments when
converting to_text(). That also means encrypted inventory files
are decrypted first.

Fixes #18355
2016-11-07 10:07:26 -05:00
..
utils Clean up shebangs for various files. 2016-11-02 17:00:27 -07:00
vault Many Cleanups to vault 2016-09-15 15:22:06 -07:00
yaml Move uses of to_bytes, to_text, to_native to use the module_utils version (#17423) 2016-09-06 22:54:17 -07:00
__init__.py Making the switch to v2 2015-05-03 21:47:26 -05:00
test_addresses.py allow for non standard hostnames 2015-12-21 13:42:34 -05:00
test_data_loader.py Fix bug (#18355) where encrypted inventories fail 18355 (#18373) 2016-11-07 10:07:26 -05:00
test_mod_args.py Revert "Track local_action internally to prevent it from being overridden" 2015-10-09 13:01:32 -04:00
test_splitter.py New unit tests for #13630 fix 2016-03-28 15:54:07 -04:00
test_unquote.py Break apart a looped dependency to show a warning when parsing playbooks 2015-10-27 12:39:42 -07:00