1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/plugins/modules/packaging/os
patchback[bot] d27c06faeb
[PR #3943/12c0220c backport][stable-4] Add option "options" to snap module (#4076)
* Add option "options" to snap module (#3943)

* Add functionality proposed in https://github.com/ansible-collections/community.general/issues/666

* Fix pylint errors mentioned in CI pipeline

* Fix pylint errors mentioned in CI pipeline (continued)

* Update plugins/modules/packaging/os/snap.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* Added tests
Fixed error occurring when called without options
Added changelog snippet

* Remove changelog entry as suggested in review

Co-authored-by: Felix Fontein <felix@fontein.de>

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* rewrite `if len(overall_options_changed) > 0` in a more Pythonic way
un-indent `if len(overall_options_changed) > 0` to only be executed after the options of all snaps have been checked

* better placement of local variable `overall_options_changed`

* Re-arrange code to reduce indentation level (suggested by reviewer)

* Re-arrange code to reduce indentation level (suggested by reviewer, continued)

* Re-arrange code to reduce indentation level (suggested by reviewer, continued)
Raise exception if option map returned by `snap set` contains list container (suggested by reviewer)
Handle Python2 type `long` correctly (suggested by reviewer)

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 12c0220c59)

* Fix version_added.

(cherry picked from commit 62d519de10)

Co-authored-by: marcus67 <marcus.rickert@web.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
2022-01-24 09:23:31 +01:00
..
apk.py
apt_repo.py
apt_rpm.py
copr.py
dnf_versionlock.py dnf_versionlock: new module (#3552) 2021-10-27 22:36:48 +02:00
flatpak.py Prepare for distutils.version being removed in Python 3.12 (#3936) (#3941) 2021-12-24 19:15:47 +01:00
flatpak_remote.py
homebrew.py Fixed typo in homebrew documentation (#3577) 2021-10-18 22:43:57 +02:00
homebrew_cask.py Prepare for distutils.version being removed in Python 3.12 (#3936) (#3941) 2021-12-24 19:15:47 +01:00
homebrew_tap.py
installp.py
layman.py
macports.py macports: add stdout and stderr to status (#3499) (#3500) 2021-10-11 06:55:09 +02:00
mas.py Prepare for distutils.version being removed in Python 3.12 (#3936) (#3941) 2021-12-24 19:15:47 +01:00
openbsd_pkg.py Prepare for distutils.version being removed in Python 3.12 (#3936) (#3941) 2021-12-24 19:15:47 +01:00
opkg.py Improve opkg module (#3554) 2021-10-14 21:14:32 +02:00
pacman.py pacman: add stdout and stderr as return parameters (#3758) (#3775) 2021-11-22 20:01:50 +01:00
pacman_key.py
pkg5.py
pkg5_publisher.py
pkgin.py Fix exception in pkgin module when all packages are already installed (#3583) 2021-10-22 07:47:27 +02:00
pkgng.py pkgng: add basic integration tests (#3526) 2021-10-22 07:32:35 +02:00
pkgutil.py
portage.py
portinstall.py
pulp_repo.py
redhat_subscription.py
rhn_channel.py
rhn_register.py
rhsm_release.py
rhsm_repository.py
rpm_ostree_pkg.py
slackpkg.py
snap.py [PR #3943/12c0220c backport][stable-4] Add option "options" to snap module (#4076) 2022-01-24 09:23:31 +01:00
snap_alias.py fix modules' output by using publish_cmd (#3655) 2021-11-01 13:53:02 +01:00
sorcery.py
svr4pkg.py
swdepot.py
swupd.py
urpmi.py
xbps.py
yum_versionlock.py
zypper.py
zypper_repository.py Prepare for distutils.version being removed in Python 3.12 (#3936) (#3941) 2021-12-24 19:15:47 +01:00