1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/lib/ansible
Dag Wieers d958440bcb win_firewall_rule: Implement idempotency, check-mode and diff support (#23162)
* win_firewall_rule: Small idempotency fix

This PR includes the following changes:
- an idempotency fix when `profile: any`
- better difference output to debug idempotency issues
- documentation fixes (remove `required: false`)
- Parameter handling fixes
- RDP example that matches default RDP rule
- Renamed parameter 'enable' to 'enabled' (kept alias)
- Renamed parameter 'profile' to 'profiles' (kept alias)

* Rewrite module completely

The logic is still intact, but various changes with a single goal:

- Make the module idempotent
- Implement check-mode
- Implement diff-mode
- Adapted integration tests

This fixes #18807 and #23455.

* Change casing to lowercase

* Improve the logic wrt. diff
2017-05-30 16:10:33 -07:00
..
cli path cli options now resolve relative paths to cli 2017-05-25 14:29:27 -04:00
compat ansible/compat/: PEP8 compliancy (#24689) 2017-05-18 08:36:11 +01:00
config Making the switch to v2 2015-05-03 21:47:26 -05:00
errors ansible/errors: PEP8 compliancy (#24693) 2017-05-18 08:34:57 +01:00
executor Ensure exit_json returns failed = False 2017-05-30 14:56:31 -07:00
galaxy Transition inventory into plugins (#23001) 2017-05-23 17:16:49 -04:00
inventory properlly report plugin name 2017-05-30 11:10:43 -04:00
module_utils Ensure exit_json returns failed = False 2017-05-30 14:56:31 -07:00
modules win_firewall_rule: Implement idempotency, check-mode and diff support (#23162) 2017-05-30 16:10:33 -07:00
parsing removed unused import 2017-05-24 11:55:56 -04:00
playbook Ensure when warning is checked before expanding (#25092) 2017-05-30 15:48:45 -04:00
plugins Ensure exit_json returns failed = False 2017-05-30 14:56:31 -07:00
template fix from https://github.com/ansible/ansible/pull/23001 2017-05-19 09:41:09 -04:00
utils ansible/utils/: PEP8 compliancy (#24686) 2017-05-30 18:09:44 +01:00
vars Transition inventory into plugins (#23001) 2017-05-23 17:16:49 -04:00
__init__.py Fix ziploader for the cornercase of ansible invoking ansible. 2016-04-29 08:47:49 -07:00
constants.py MAX_FILE_SIZE_FOR_DIFF (#25170) 2017-05-30 16:18:13 +01:00
release.py Bumping devel version to 2.4.0 2017-03-15 09:42:01 -05:00