1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/test/units/plugins
Matthias Fuchs 7871027c9d Share the implementation of hashing for both vars_prompt and password_hash (#21215)
* Share the implementation of hashing for both vars_prompt and password_hash.
* vars_prompt with encrypt does not require passlib for the algorithms
  supported by crypt.
* Additional checks ensure that there is always a result.
  This works around issues in the crypt.crypt python function that returns
  None for algorithms it does not know.
  Some modules (like user module) interprets None as no password at all,
  which is misleading.
* The password_hash filter supports all parameters of passlib.
  This allows users to provide a rounds parameter, fixing #15326.
* password_hash is not restricted to the subset provided by crypt.crypt,
  fixing one half of #17266.
* Updated documentation fixes other half of #17266.
* password_hash does not hard-code the salt-length, which fixes bcrypt
  in connection with passlib.
  bcrypt requires a salt with length 22, which fixes #25347
* Salts are only generated by ansible when using crypt.crypt.
  Otherwise passlib generates them.
* Avoids deprecated functionality of passlib with newer library versions.
* When no rounds are specified for sha256/sha256_crypt and sha512/sha512_crypt
  always uses the default values used by crypt, i.e. 5000 rounds.
  Before when installed passlibs' defaults were used.
  passlib changes its defaults with newer library versions, leading to non
  idempotent behavior.

  NOTE: This will lead to the recalculation of existing hashes generated
        with passlib and without a rounds parameter.
        Yet henceforth the hashes will remain the same.
        No matter the installed passlib version.
        Making these hashes idempotent.

Fixes #15326
Fixes #17266
Fixes #25347 except bcrypt still uses 2a, instead of the suggested 2b.

* random_salt is solely handled by encrypt.py.
  There is no _random_salt function there anymore.
  Also the test moved to test_encrypt.py.
* Uses pytest.skip when passlib is not available, instead of a silent return.
* More checks are executed when passlib is not available.

* Moves tests that require passlib into their own test-function.

* Uses the six library to reraise the exception.

* Fixes integration test.

When no rounds are provided the defaults of crypt are used.
In that case the rounds are not part of the resulting MCF output.
2018-08-27 08:40:41 -07:00
..
action Fix remote_tmp when become with non admin user (#42396) 2018-07-06 10:49:19 -07:00
cache Disable abstract-class-instantiated for smoketests 2017-07-25 15:58:23 -07:00
callback fix minor issues with debug and item labels (#41331) 2018-06-21 16:14:57 -04:00
cliconf new nos_command module (#43056) 2018-08-10 13:50:02 -07:00
connection psrp: Added new Windows connection plugin (#41729) 2018-08-21 16:43:13 -07:00
filter Fix module name in error text at parse_xml filter (#44313) 2018-08-20 10:19:16 +05:30
inventory Fix inventory plugin cache + add tests (#38229) 2018-05-24 15:34:54 -04:00
loader_fixtures Don't cache duplicate plugin names (#34420) 2018-01-04 16:47:23 -06:00
lookup Share the implementation of hashing for both vars_prompt and password_hash (#21215) 2018-08-27 08:40:41 -07:00
shell Add empty-init code-smell script. (#18406) 2016-11-07 15:02:13 -08:00
strategy New keyword: ignore_unreachable (#43857) 2018-08-23 11:41:02 -04:00
terminal Adding slx_command module and supporting module_utils. (#38235) 2018-04-11 12:59:34 +01:00
vars Add empty-init code-smell script. (#18406) 2016-11-07 15:02:13 -08:00
__init__.py Add empty-init code-smell script. (#18406) 2016-11-07 15:02:13 -08:00
test_plugins.py Don't cache duplicate plugin names (#34420) 2018-01-04 16:47:23 -06:00