mirror of
https://github.com/ansible-collections/community.general.git
synced 2024-09-14 20:13:21 +02:00
828968b0dd
fix(modules/gitlab_runner): Use correct argument to list all runners (#7790)
* fix(modules/gitlab_runner): Use correct argument to list all runners
python-gitlab 4.0.0 removed support for the `as_list=False` parameter.
This functionality is now available as `iterator=True`.
Without this change, the module actually only retrieves the first
20 results, which can lead to non-idempotent behavior, such as
registering a runner again.
* Add changelog entry (#7790)
* gitlab_runner: Check python-gitlab version when listing runners
* gitlab: Add list_all_kwargs variable to module_utils
* refactor(gitlab modules): use list_all_kwargs where it helps (#7790)
I did not change every instance of all=True or all=False, only those
which could obviously benefit from simplifying:
* Code using `all=True` but then searching for any items that match a
condition (no need to collect the full list).
* Code that basically reimplements `all=True` with manual pagination.
(These could be changed to `all=True`, but `list_all_kwargs` also
sets per_page to 100, to gather data faster.)
* gitlab_instance_variable: Use list_all_kwargs
* Add new changelog entry for gitlab module changes (#7790)
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| identity/keycloak | ||
| mh | ||
| net_tools/pritunl | ||
| oracle | ||
| remote_management/lxca | ||
| source_control | ||
| storage | ||
| _filelock.py | ||
| _mount.py | ||
| _stormssh.py | ||
| alicloud_ecs.py | ||
| btrfs.py | ||
| cloud.py | ||
| cmd_runner.py | ||
| consul.py | ||
| csv.py | ||
| database.py | ||
| deps.py | ||
| dimensiondata.py | ||
| gandi_livedns_api.py | ||
| gconftool2.py | ||
| gio_mime.py | ||
| gitlab.py | ||
| heroku.py | ||
| hwc_utils.py | ||
| ibm_sa_utils.py | ||
| ilo_redfish_utils.py | ||
| influxdb.py | ||
| ipa.py | ||
| jenkins.py | ||
| known_hosts.py | ||
| ldap.py | ||
| linode.py | ||
| locale_gen.py | ||
| lxd.py | ||
| manageiq.py | ||
| memset.py | ||
| module_helper.py | ||
| ocapi_utils.py | ||
| oneandone.py | ||
| onepassword.py | ||
| oneview.py | ||
| online.py | ||
| opennebula.py | ||
| pipx.py | ||
| proxmox.py | ||
| puppet.py | ||
| pure.py | ||
| rax.py | ||
| redfish_utils.py | ||
| redhat.py | ||
| redis.py | ||
| rundeck.py | ||
| saslprep.py | ||
| scaleway.py | ||
| snap.py | ||
| ssh.py | ||
| univention_umc.py | ||
| utm_utils.py | ||
| vardict.py | ||
| version.py | ||
| vexata.py | ||
| wdc_redfish_utils.py | ||
| xenserver.py | ||
| xfconf.py | ||