1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/changelogs/fragments
patchback[bot] d27c06faeb
[PR #3943/12c0220c backport][stable-4] Add option "options" to snap module (#4076)
* Add option "options" to snap module (#3943)

* Add functionality proposed in https://github.com/ansible-collections/community.general/issues/666

* Fix pylint errors mentioned in CI pipeline

* Fix pylint errors mentioned in CI pipeline (continued)

* Update plugins/modules/packaging/os/snap.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* Added tests
Fixed error occurring when called without options
Added changelog snippet

* Remove changelog entry as suggested in review

Co-authored-by: Felix Fontein <felix@fontein.de>

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* rewrite `if len(overall_options_changed) > 0` in a more Pythonic way
un-indent `if len(overall_options_changed) > 0` to only be executed after the options of all snaps have been checked

* better placement of local variable `overall_options_changed`

* Re-arrange code to reduce indentation level (suggested by reviewer)

* Re-arrange code to reduce indentation level (suggested by reviewer, continued)

* Re-arrange code to reduce indentation level (suggested by reviewer, continued)
Raise exception if option map returned by `snap set` contains list container (suggested by reviewer)
Handle Python2 type `long` correctly (suggested by reviewer)

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 12c0220c59)

* Fix version_added.

(cherry picked from commit 62d519de10)

Co-authored-by: marcus67 <marcus.rickert@web.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
2022-01-24 09:23:31 +01:00
..
.keep
3943-add-option-options-to-snap-module.yml [PR #3943/12c0220c backport][stable-4] Add option "options" to snap module (#4076) 2022-01-24 09:23:31 +01:00
4026-fix-mail-callback.yml Fix exception in the mail callback plugin (#4026) (#4064) 2022-01-20 09:30:03 +01:00
4030-proxmox-has-proxmoxer.yml Move Proxmox HAS_PROXMOXER check into module_utils. (#4030) (#4046) 2022-01-16 20:28:26 +01:00
4043-fix-no-log-opentelemetry.yml opentelemetry: no_log:true causes exception when generating trace (#4043) (#4051) 2022-01-17 21:57:46 +01:00
4052-fix-detection-of-installed-cargo-packages-with-hyphens.yaml Fix detection of installed cargo packages with hyphens in name (#4052) (#4054) 2022-01-18 19:40:37 +01:00
4056-add-missing-mail-headers.yml mail: add Date and Message-ID headers (#4056) (#4069) 2022-01-21 09:29:15 +01:00
4062-nmcli-ipv6-routes-support.yml Add nmcli support for IPv6 routes (#4062) (#4075) 2022-01-23 13:26:09 +01:00