mirror of
https://github.com/ansible-collections/community.general.git
synced 2024-09-14 20:13:21 +02:00
2ef0946370
* Fix wrong example, remove strictness and fix tests It was obvious that (because of an incorrect example) people were using the **xml** module incorrectly, specifying the `attribute` parameter where it was not supported (i.e. ignored). While this functionality would have been useful, it currently returns as if the information was requested from the parent, so we cannot simply make it to what would be expected. Therefor the real solution is to provide a warning when we find incorrect use, and deprecate this use. Then later we could implement this functionality correctly. While troubleshooting this issue, I found that in some cases our integration tests were not being run when we expected it. This fixes #53459 * Change warning * Fix weird sanity test error * Add a comment to the deprecate-test
52 lines
1.7 KiB
YAML
52 lines
1.7 KiB
YAML
---
|
|
- name: Setup test fixture
|
|
copy:
|
|
src: fixtures/ansible-xml-beers.xml
|
|
dest: /tmp/ansible-xml-beers.xml
|
|
|
|
|
|
- name: Get element attributes
|
|
xml:
|
|
path: /tmp/ansible-xml-beers.xml
|
|
xpath: /business/rating
|
|
content: attribute
|
|
register: get_element_attribute
|
|
|
|
- name: Test expected result
|
|
assert:
|
|
that:
|
|
- get_element_attribute.changed == false
|
|
- get_element_attribute.matches[0]['rating'] is defined
|
|
- get_element_attribute.matches[0]['rating']['subjective'] == 'true'
|
|
|
|
# TODO: Remove this in Ansible v2.12 when this incorrect use of attribute is deprecated
|
|
- name: Get element attributes
|
|
xml:
|
|
path: /tmp/ansible-xml-beers.xml
|
|
xpath: /business/rating
|
|
content: attribute
|
|
attribute: subjective
|
|
register: get_element_attribute_wrong
|
|
|
|
- name: Test expected result
|
|
assert:
|
|
that:
|
|
- get_element_attribute_wrong.changed == false
|
|
- get_element_attribute_wrong.matches[0]['rating'] is defined
|
|
- get_element_attribute_wrong.matches[0]['rating']['subjective'] == 'true'
|
|
- get_element_attribute_wrong.deprecations is defined
|
|
- get_element_attribute_wrong.deprecations[0].msg == "Parameter 'attribute=subjective' is ignored when using 'content=attribute' only 'xpath' is used. Please remove entry."
|
|
- get_element_attribute_wrong.deprecations[0].version == '2.12'
|
|
|
|
- name: Get element text
|
|
xml:
|
|
path: /tmp/ansible-xml-beers.xml
|
|
xpath: /business/rating
|
|
content: text
|
|
register: get_element_text
|
|
|
|
- name: Test expected result
|
|
assert:
|
|
that:
|
|
- get_element_text.changed == false
|
|
- get_element_text.matches[0]['rating'] == '10'
|