mirror of
https://github.com/ansible-collections/community.general.git
synced 2024-09-14 20:13:21 +02:00
c4e93b0b5f
* add support for filesystem removal (fix #355)
- Add 'state' option, defaults to 'present'.
- When state=absent, ignore other options (even 'dev' if the device
doesn't exist)
* test filesystem state=absent (+ check_mode + idempotency)
* fix doc-required-mismatch
* add changelog fragment
* fix blkid return code
* ext4dev may be deprecated
* base checks on UUID instead
* Update changelogs/fragments/1149-filesystem-fix-355-state-absent.yml
Co-authored-by: Felix Fontein <felix@fontein.de>
* Update plugins/modules/system/filesystem.py (version_added)
Co-authored-by: Felix Fontein <felix@fontein.de>
* use array for new run_command() calls; do not wipefs if no fs found
* use dd as a fallback
* do not use bare 'except' (pep8)
* force string type
* use dd anyway (wipefs not supported everywhere, possibly buggy with vfat, etc.)
* do not truncate regular files; update changelog fragment
* doc: update state description and an example; notice check_mode support
* do not wipe mounted fs, fail instead
* back to wipefs implementation
* update test's main conditions
* update changelog fragment
* explicit types
* fail state=absent on freebsd
* remove doc-missing-type exceptions (2.9, 2.10, 2.11)
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit a5ca990857)
Co-authored-by: quidame <quidame@poivron.org>
98 lines
2.1 KiB
YAML
98 lines
2.1 KiB
YAML
---
|
|
# We assume 'create_fs' tests have passed.
|
|
|
|
- name: filesystem creation
|
|
filesystem:
|
|
dev: '{{ dev }}'
|
|
fstype: '{{ fstype }}'
|
|
|
|
- name: get filesystem UUID with 'blkid'
|
|
command:
|
|
cmd: 'blkid -c /dev/null -o value -s UUID {{ dev }}'
|
|
changed_when: false
|
|
register: blkid_ref
|
|
|
|
- name: Assert that a filesystem exists on top of the device
|
|
assert:
|
|
that:
|
|
- blkid_ref.stdout | length > 0
|
|
|
|
|
|
# Test check_mode first
|
|
- name: filesystem removal (check mode)
|
|
filesystem:
|
|
dev: '{{ dev }}'
|
|
state: absent
|
|
register: wipefs
|
|
check_mode: yes
|
|
|
|
- name: get filesystem UUID with 'blkid' (should remain the same)
|
|
command:
|
|
cmd: 'blkid -c /dev/null -o value -s UUID {{ dev }}'
|
|
changed_when: false
|
|
register: blkid
|
|
|
|
- name: Assert that the state changed but the filesystem still exists
|
|
assert:
|
|
that:
|
|
- wipefs is changed
|
|
- blkid.stdout == blkid_ref.stdout
|
|
|
|
# Do it
|
|
- name: filesystem removal
|
|
filesystem:
|
|
dev: '{{ dev }}'
|
|
state: absent
|
|
register: wipefs
|
|
|
|
- name: get filesystem UUID with 'blkid' (should be empty)
|
|
command:
|
|
cmd: 'blkid -c /dev/null -o value -s UUID {{ dev }}'
|
|
changed_when: false
|
|
failed_when: false
|
|
register: blkid
|
|
|
|
- name: Assert that the state changed and the device has no filesystem
|
|
assert:
|
|
that:
|
|
- wipefs is changed
|
|
- blkid.stdout | length == 0
|
|
- blkid.rc == 2
|
|
|
|
# Do it again
|
|
- name: filesystem removal (idempotency)
|
|
filesystem:
|
|
dev: '{{ dev }}'
|
|
state: absent
|
|
register: wipefs
|
|
|
|
- name: Assert that the state did not change
|
|
assert:
|
|
that:
|
|
- wipefs is not changed
|
|
|
|
# and again
|
|
- name: filesystem removal (idempotency, check mode)
|
|
filesystem:
|
|
dev: '{{ dev }}'
|
|
state: absent
|
|
register: wipefs
|
|
check_mode: yes
|
|
|
|
- name: Assert that the state did not change
|
|
assert:
|
|
that:
|
|
- wipefs is not changed
|
|
|
|
|
|
# By the way, test removal of a filesystem on unexistent device
|
|
- name: filesystem removal (unexistent device)
|
|
filesystem:
|
|
dev: '/dev/unexistent_device'
|
|
state: absent
|
|
register: wipefs
|
|
|
|
- name: Assert that the state did not change
|
|
assert:
|
|
that:
|
|
- wipefs is not changed
|