patchback[bot] bdc7e48779 request for comments - pacman: speed up most operations when working with a package list (#3907) (#4176) ... * pacman: rewrite with a cache to speed up execution - Use a cache (or inventory) to speed up lookups of: - installed packages and groups - available packages and groups - upgradable packages - Call pacman with the list of pkgs instead of one call per package (for installations, upgrades and removals) - Use pacman [--sync|--upgrade] --print-format [...] to gather list of changes. Parsing that instead of the regular output of pacman, which is error prone and can be changed by user configuration. This can introduce a TOCTOU problem but unless something else calls pacman between the invocations, it shouldn't be a concern. - Given the above, "check mode" code is within the function that would carry out the actual operation. This should make it harder for the check code and the "real code" to diverge. - Support for specifying alternate package name formats is a bit more robust. pacman is used to extract the name of the package when the specified package is a file or a URL. The "<repo>/<pkgname>" format is also supported. For "state: latest" with a list of ~35 pkgs, this module is about 5 times faster than the original. * Let fail() actually work * all unhappy paths now end up calling fail() * Update copyright * Argument changes update_cache_extra_args handled as a list like the others moved the module setup to its own function for easier testing update and upgrade have no defaults (None) to let required_one_of() do its job properly * update_cache exit path Shift successful exit without name or upgrade under "update_cache". It is an error if name or upgrade isn't specified and update_cache wasn't specified either. (Caught by ansiblemodule required_one_of but still) * Add pkgs to output on success only Also align both format, only pkg name for now * Multiple fixes Move VersionTuple to top level for import from tests Add removed pkgs to the exit json when removing packages fixup list of upgraded pkgs reported on upgrades (was tuple of list for no reason) use list idiom for upgrades, like the rest drop unused expand_package_groups function skip empty lines when building inventory * pacman: add tests * python 2.x compat + pep8 * python 2.x some more * Fix failure when pacman emits warnings Add tests covering that failure case * typo * Whitespace black failed me... * Adjust documentation to fit implicit defaults * fix test failures on older pythons * remove file not intended for commit * Test exception str with e.match * Build inventory after cache update + adjust tests * Apply suggestions from code review Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/packaging/os/pacman.py Co-authored-by: Felix Fontein <felix@fontein.de> * changelog * bump copyright year and add my name to authors * Update changelogs/fragments/3907-pacman-speedup.yml Co-authored-by: Felix Fontein <felix@fontein.de> * maintainer entry Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 1580f3c2b4) Co-authored-by: Jean Raby <jean@raby.sh>		2022-02-09 12:35:26 +01:00
..
.keep	Rename changelogs/fragments/.empty -> changelogs/fragments/.keep	2020-08-07 08:17:57 +02:00
3703-force-install-homebrew-cask.yml	homebrew_cask: reinstall when force is install option (#4090) (#4145)	2022-02-02 21:54:52 +01:00
3907-pacman-speedup.yml	request for comments - pacman: speed up most operations when working with a package list (#3907) (#4176)	2022-02-09 12:35:26 +01:00
3916-fix-vdo-options-type.yml	vdo: Remove unused variable (#4163) (#4170)	2022-02-07 20:49:16 +01:00
4029-proxmox-refactor.yml	Refactor all Proxmox modules to use shared module_utils. (#4029) (#4164)	2022-02-07 17:48:11 +01:00
4150-gitlab-project-variable-absent-fix.yml	gitlab_project_variable: Allow delete without value (#4150) (#4157)	2022-02-05 21:20:41 +01:00