mirror of
https://github.com/ansible-collections/community.general.git
synced 2024-09-14 20:13:21 +02:00
1cddae2265
* nmcli: avoid changed status for most cases with VPN connections
Follow-up https://github.com/ansible-collections/community.general/pull/4746
* `nmcli connection show` includes vpn.service-type but not vpn-type.
Switching to vpn.service-type removes unneeded diffs while keeping
the same functionality, as vpn-type is an alias of vpn.service-type
per nm-settings-nmcli(1).
NetworkManager also adds `org.freedesktop.NetworkManager.` prefix for
known VPN types [1]. The logic is non-trivial so I didn't implement it
in this commit. If a user specifies `service-type: l2tp`, changed will
be always be True:
- "vpn.service-type": "org.freedesktop.NetworkManager.l2tp"
+ "vpn.service-type": "l2tp"
* The vpn.data field from `nmcli connection show` is sorted by keys and
there are spaces around equal signs. I added codes for parsing such
data.
Tests are also updated to match outputs of nmcli commands.
[1] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/blob/1.38.4/src/libnm-core-impl/nm-vpn-plugin-info.c#L619
* Add changelog
* Some suggested changes
* Make space stripping more flexible - works for cases without equal
signs.
* Keep vpn.data in a test case with no spaces
* nmcli: allow any string for vpn service-type
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| infinity | ||
| ldap | ||
| pritunl | ||
| cloudflare_dns.py | ||
| dnsimple.py | ||
| dnsimple_info.py | ||
| dnsmadeeasy.py | ||
| gandi_livedns.py | ||
| haproxy.py | ||
| ip_netns.py | ||
| ipify_facts.py | ||
| ipinfoio_facts.py | ||
| ipwcli_dns.py | ||
| lldp.py | ||
| netcup_dns.py | ||
| nmcli.py | ||
| nsupdate.py | ||
| omapi_host.py | ||
| snmp_facts.py | ||