patchback[bot] b42ab6b45d nmcli: Disallow Wi-Fi options not supported by nmcli (#3141) (#3249) ... * nmcli: Disallow Wi-Fi options not supported by nmcli By querying nmcli directly * Added changelog fragment * Added tests * Simplify `get_available_options()` * Update changelogs/fragments/3141-disallow-options-unsupported-by-nmcli.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Remove redundant `802-11-wireless` settings from test show outputs * Update `mocked_wireless_create(mocker)` * Update plugins/modules/net_tools/nmcli.py Co-authored-by: Ajpantuso <ajpantuso@gmail.com> * Address comment re. creating function & use nmcli naming conventions I.E. `setting`.`property` = `value` ``` nmcli> help set set [<setting>.<prop> <value>] :: set property value This command sets property value. Example: nmcli> set con.id My connection ``` * Added `ignore_unsupported_suboptions` option & improved `wifi(_sec)` doc * Corrected pep8 issues ``` ERROR: Found 2 pep8 issue(s) which need to be resolved: ERROR: plugins/modules/net_tools/nmcli.py:342:161: E501: line too long (236 > 160 characters) ERROR: plugins/modules/net_tools/nmcli.py:359:161: E501: line too long (237 > 160 characters) ``` * Fixed remaining sanity check issues and added even more docs * No need to split Note * Update plugins/modules/net_tools/nmcli.py 3.5.0 has already been released. Co-authored-by: Felix Fontein <felix@fontein.de> * Followed uniformity guideline for format macros from Ansible's dev guide * Addressed comment https://github.com/ansible-collections/community.general/pull/3141#discussion_r689098383 * Documentation cleanup continuation * Replace `NM_SETTING_*`s having a description with their numeric value * Splitting up long paragraphs. Also removed `wifi`.`seen-bssids` as it "`is only meant for reading`" * Addressed remaining comments and clarified `wake-on-lan` note * Update plugins/modules/net_tools/nmcli.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/net_tools/nmcli.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/net_tools/nmcli.py Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/modules/net_tools/nmcli.py Co-authored-by: Felix Fontein <felix@fontein.de> * Finishing addressing documentation comments. * Update plugins/modules/net_tools/nmcli.py Co-authored-by: Ajpantuso <ajpantuso@gmail.com> * Update plugins/modules/net_tools/nmcli.py Co-authored-by: Ajpantuso <ajpantuso@gmail.com> * Update nmcli.py * Added wifi-related `list` type options to `settings_type` method * Moved `edit_commands` `execution` logic into its own method * Move `unsupported_property` deletion into `main` function * Missing `.items()` * Resolved missing proper `nmcli conn edit` arguments * Resolve pylint issue `dangerous-default-value` Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Ajpantuso <ajpantuso@gmail.com> Co-authored-by: David Hummel <dhummel@Fingerling> (cherry picked from commit 8a62b79ef2) Co-authored-by: David Hummel <6109326+hummeltech@users.noreply.github.com>		2021-08-20 22:04:38 +02:00
..
action	fixed the utf-8 marker (#3162) (#3165)	2021-08-07 15:59:29 +02:00
become	Update BOTMETA, fix some plugin authors, improve BOTMETA extra sanity test (#3069) (#3087)	2021-07-26 14:13:28 +02:00
cache	[PR #3194/1fec1d0c backport][stable-3] Fix sanity failures (#3195)	2021-08-12 13:46:55 +02:00
callback	[PR #3194/1fec1d0c backport][stable-3] Fix sanity failures (#3195)	2021-08-12 13:46:55 +02:00
connection	[PR #3194/1fec1d0c backport][stable-3] Fix sanity failures (#3195)	2021-08-12 13:46:55 +02:00
doc_fragments	fixed the utf-8 marker (#3162) (#3165)	2021-08-07 15:59:29 +02:00
filter	fixed the utf-8 marker (#3162) (#3165)	2021-08-07 15:59:29 +02:00
inventory	Linode inventory plugin typo fixes (#3218) (#3221)	2021-08-17 07:20:29 +02:00
lookup	Add option for domain authorization (#3228) (#3246)	2021-08-20 16:55:48 +02:00
module_utils	redfish_info: Include Status property for GetChassisThermals (#3233) (#3240)	2021-08-20 13:37:44 +02:00
modules	nmcli: Disallow Wi-Fi options not supported by nmcli (#3141) (#3249)	2021-08-20 22:04:38 +02:00