1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/test/units
Dag Wieers fceb71128e Return code is not very useful to assume a task failed
So I thought I fixed it before, but there's still one location where
the `rc` value is influential to decide whether a task failed or not.

We already established in #24867 that it is up to the module to decide
what the return code actually means, not the task executor. We modified
the existing modules to move that logic into the module (eg. for
command, shell, etc.)

This relates to the integration tests of win_robocopy, where different
return codes have different meanings:

  - 0  --  No files copied.
  - 1  --  Files copied successfully! (changed)
  - 2  --  Some Extra files or directories were detected. No files were copied. (warning)
  - 3  --  (2+1) Some files were copied. Additional files were present. (changed)
  - 4  --  Some mismatched files or directories were detected. Housekeeping might be required!  (changed + warning)
  - 5  --  (4+1) Some files were copied. Some files were mismatched.  (changed + warning)
  - 6  --  (4+2) Additional files and mismatched files exist.  No files were copied. (warning)
  - 7  --  (4+1+2) Files were copied, a file mismatch was present, and additional files were present. (changed + warning)
  - 8  --  Some files or directories could not be copied! (changed + failed)
  - 9 - 15  --  Fatal error. Check log message! (failed)
  - 16  --  Serious Error! No files were copied! Do you have permissions to access $src and $dest? (failed)

This also fixes #24652
2017-06-27 15:40:27 -04:00
..
cli fixed issue with paths separator and others 2017-06-15 14:53:54 -04:00
contrib test/: PEP8 compliancy (#24803) 2017-05-30 18:05:19 +01:00
errors test/: PEP8 compliancy (#24803) 2017-05-30 18:05:19 +01:00
executor Return code is not very useful to assume a task failed 2017-06-27 15:40:27 -04:00
inventory test/: PEP8 compliancy (#24803) 2017-05-30 18:05:19 +01:00
inventory_test_data/group_vars Merge branch 'v2_final' into devel_switch_v2 2015-05-28 15:26:03 -05:00
mock test/: PEP8 compliancy (#24803) 2017-05-30 18:05:19 +01:00
module_utils renames dict_combine to dict_merge in network_common (#26073) 2017-06-25 18:46:41 -04:00
modules Add netscaler_server module (#25537) 2017-06-27 23:08:00 +05:30
parsing Cyptography pr 20566 rebase (#25560) 2017-06-27 06:00:15 -07:00
playbook Fix spelling mistakes (comments only) (#25564) 2017-06-12 07:55:19 +01:00
plugins re-enable non-pipelined mode for Powershell (#25012) 2017-06-26 22:58:09 -07:00
template test/: PEP8 compliancy (#24803) 2017-05-30 18:05:19 +01:00
utils test/: PEP8 compliancy (#24803) 2017-05-30 18:05:19 +01:00
vars Fix spelling mistakes (comments only) (#25564) 2017-06-12 07:55:19 +01:00
__init__.py Add empty-init code-smell script. (#18406) 2016-11-07 15:02:13 -08:00
conftest.py Fix bugs in ansible-test units command. (#24044) 2017-04-27 11:21:11 +08:00
test_constants.py 1st part of ansible config, adds ansible-config to view/manage configs (#12797) 2017-06-14 11:08:34 -04:00