1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/changelogs/fragments
patchback[bot] afc620fc74
Avoid incorrectly marking zfs tasks as changed (#2454) (#2483)
* Avoid incorrectly marking zfs tasks as changed

The zfs module will incorrectly mark certain tasks as having been
changed. For example, if a dataset has a quota of "1G" and the user
changes it to "1024M", the actual quota vale has not changed, but since
the module is doing a simple string comparison between "1G" and "1024M",
it marks the step as "changed".

Instead of trying to handle all the corner cases of zfs (another example
is when the zpool "altroot" property has been set), this change simply
compares the output of "zfs-get" from before and after "zfs-set" is
called

* update changelog format

* Update changelogs/fragments/2454-detect_zfs_changed.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* add note about check_mode

* Update plugins/modules/storage/zfs/zfs.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/storage/zfs/zfs.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* clarify check mode qualifications

* rephrase to avoid hypothetical

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 8e7aff00b5)

Co-authored-by: sam-lunt <samuel.j.lunt@gmail.com>
2021-05-10 18:16:49 +02:00
..
.keep Rename changelogs/fragments/.empty -> changelogs/fragments/.keep 2020-08-07 08:17:57 +02:00
2.5.2.yml Prepare 2.5.2. 2021-05-03 07:46:46 +02:00
2245-proxmox_fix_agent_string_handling.yml Proxmox inv fix agent string parsing (#2245) (#2255) 2021-04-17 10:43:59 +02:00
2246-terraform.yaml Fix for Terraform 0.15 (#2246) (#2261) 2021-04-17 22:49:27 +02:00
2282-nmap-fix-cache-support.yml nmap: fix cache support (#2282) (#2327) 2021-04-22 07:52:19 +02:00
2284-influxdb_retention_policy-fix_duration_parsing.yml influxdb_retention_policy: fix duration parsing to support INF values (#2396) (#2400) 2021-05-01 14:58:30 +02:00
2284-influxdb_retention_policy-idempotence.yml influxdb_retention_policy: ensure duration parameters are idempotent (#2281) (#2284) (#2353) 2021-04-26 07:28:10 +02:00
2329-hiera-lookup-plugin-return-type.yaml convert string returned by plugin to unicode (#2329) (#2339) 2021-04-24 12:48:02 +02:00
2337-mark-inventory-scripts-executable.yml Make inventory scripts executable (#2337) (#2358) 2021-04-26 22:24:40 +02:00
2340-jenkins_plugin-py2.yml Fix Python 2 compatibility issue. (#2340) (#2352) 2021-04-26 07:16:46 +02:00
2348-composer-no-interaction-option-discovery-to-avoid-hang.yaml composer: --no-interaction when discovering available options (#2348) (#2402) 2021-05-01 18:46:11 +02:00
2349-jira-bugfix-b64decode.yml jira - fixed base64 decode bug (#2349) (#2350) 2021-04-26 05:18:09 +00:00
2373-svr4pkg-fix-typeerror.yml Fix #2373 - TypeError: a bytes-like object is required, not 'str' (#2375) (#2418) 2021-05-03 07:55:55 +02:00
2407-puppet-change_stdout_to_console.yaml puppet - replace stdout with console in logdest option (#2407) (#2420) 2021-05-03 07:59:30 +02:00
2409-nmcli_add_slave-type_bridge_to_nmcli_command_if_type_is_bridge-slave.yml nmcli: Add 'slave-type bridge' to nmcli command if type is bridge-slave (#2409) (#2422) 2021-05-03 07:59:58 +02:00
2416-nmcli_compare_mac_addresses_case_insensitively.yml nmcli: Compare MAC addresses case insensitively (#2416) (#2424) 2021-05-03 08:08:10 +02:00
2430-linodev4-error-message.yml linode_v4 - fixed error message (#2430) (#2432) 2021-05-03 13:51:14 +02:00
2435-one_vm-fix_missing_keys.yml OpenNebula one_vm.py: Fix missing keys (#2435) (#2446) 2021-05-04 12:43:28 +02:00
2448-stackpath_compute-fix.yml fix stackpath_compute validate_config (#2448) (#2474) 2021-05-09 22:44:39 +02:00
2454-detect_zfs_changed.yml Avoid incorrectly marking zfs tasks as changed (#2454) (#2483) 2021-05-10 18:16:49 +02:00
ovirt-fixup.yml Remove programming error which prevents modules to work with devel. (#2381) 2021-04-30 05:50:45 +02:00