1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/tests
marcus67 12c0220c59
Add option "options" to snap module (#3943)
* Add functionality proposed in https://github.com/ansible-collections/community.general/issues/666

* Fix pylint errors mentioned in CI pipeline

* Fix pylint errors mentioned in CI pipeline (continued)

* Update plugins/modules/packaging/os/snap.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* Added tests
Fixed error occurring when called without options
Added changelog snippet

* Remove changelog entry as suggested in review

Co-authored-by: Felix Fontein <felix@fontein.de>

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

* rewrite `if len(overall_options_changed) > 0` in a more Pythonic way
un-indent `if len(overall_options_changed) > 0` to only be executed after the options of all snaps have been checked

* better placement of local variable `overall_options_changed`

* Re-arrange code to reduce indentation level (suggested by reviewer)

* Re-arrange code to reduce indentation level (suggested by reviewer, continued)

* Re-arrange code to reduce indentation level (suggested by reviewer, continued)
Raise exception if option map returned by `snap set` contains list container (suggested by reviewer)
Handle Python2 type `long` correctly (suggested by reviewer)

Co-authored-by: Felix Fontein <felix@fontein.de>
2022-01-24 06:39:37 +01:00
..
integration/targets Add option "options" to snap module (#3943) 2022-01-24 06:39:37 +01:00
sanity puppet: Add documentation and remove deprecation for show_diff, keep deprecation for alias show-diff (#3980) 2022-01-10 07:08:17 +01:00
unit Add nmcli support for IPv6 routes (#4062) 2022-01-23 13:02:03 +01:00
utils Restrict PyNaCL to 1.4.x on RHEL8 when using Python 3.6 (#4006) 2022-01-08 14:36:11 +01:00
.gitignore Initial commit 2020-03-09 09:11:07 +00:00
config.yml Add ansible-test config file. (#2404) 2021-05-01 22:21:17 +02:00
requirements.yml Remove community.kubernetes testing dependency. (#1682) 2021-01-27 07:17:00 +01:00