1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/test
Adrian Likins a14d0f3586 Use vault_id when encrypted via vault-edit (#30772)
* Use vault_id when encrypted via vault-edit

On the encryption stage of
'ansible-vault edit --vault-id=someid@passfile somefile',
the vault id was not being passed to encrypt() so the files were
always saved with the default vault id in the 1.1 version format.

When trying to edit that file a second time, also with a --vault-id,
the file would be decrypted with the secret associated with the
provided vault-id, but since the encrypted file had no vault id
in the envelope there would be no match for 'default' secrets.
(Only the --vault-id was included in the potential matches, so
the vault id actually used to decrypt was not).

If that list was empty, there would be an IndexError when trying
to encrypted the changed file. This would result in the displayed
error:

ERROR! Unexpected Exception, this is probably a bug: list index out of range

Fix is two parts:

1) use the vault id when encrypting from edit

2) when matching the secret to use for encrypting after edit,
include the vault id that was used for decryption and not just
the vault id (or lack of vault id) from the envelope.

add unit tests for #30575 and intg tests for 'ansible-vault edit'

Fixes #30575
2017-09-26 12:28:31 -04:00
..
compile Docs how to test (2nd) (#24094) 2017-04-28 09:08:26 +01:00
integration Use vault_id when encrypted via vault-edit (#30772) 2017-09-26 12:28:31 -04:00
legacy Add a code-smell test for smart quotes and remove smart quotes from all files 2017-09-18 16:49:16 -07:00
results Collect data from integration test runs. (#28650) 2017-08-25 18:14:47 -04:00
runner Add region to ansible-test AWS cloud config. (#30733) 2017-09-22 00:19:21 -07:00
sanity linode: PEP8 compliancy and doc fixes (#30922) 2017-09-26 09:48:08 -04:00
units Use vault_id when encrypted via vault-edit (#30772) 2017-09-26 12:28:31 -04:00
utils Run all Windows tests if change detection disabled (#30320) 2017-09-13 22:21:19 -07:00