1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/test/sanity/code-smell
Toshio Kuratomi 9f7b0dfc30 Remove automatic use of system six
* Enable the pylint no-name-in-module check.  Checks that identifiers in
  imports actually exist.  When we do this, we also have to ignore
  _MovedItems used in our bundled six.  This means pylint won't check
  for bad imports below ansible.module_utils.six.moves but that's
  something that pylint punts on with a system copy of six so this is
  still an improvement.
* Remove automatic use of system six.  The exec in the six code which
  tried to use a system library if available destroyed pylint's ability
  to check for imports of identifiers which did not exist (the
  no-name-in-module check).  That test is important enough that we
  should sacrifice the bundling detection in favour of the test.
  Distributions that want to unbundle six can replace the bundled six in
  ansible/module_utils/six/__init__.py to unbundle.  however, be aware
  that six is tricky to unbundle.  They may want to base their efforts
  off the code we were using:

  2fff690caa/lib/ansible/module_utils/six/__init__.py

* Update tests for new location of bundled six Several code-smell tests
  whitelist the bundled six library.  Update the path to the library so
  that they work.

* Also check for basestring in modules as the enabled pylint tests will
  also point out basestring usage for us.
2017-07-25 15:58:23 -07:00
..
ansible-var-precedence-check.py test/: PEP8 compliancy (#24803) 2017-05-30 18:05:19 +01:00
boilerplate.sh 1st part of ansible config, adds ansible-config to view/manage configs (#12797) 2017-06-14 11:08:34 -04:00
configure-remoting-ps1.sh Add test for ConfigureRemotingForAnsible.ps1. 2017-01-06 10:40:13 -08:00
empty-init.sh Add empty-init code-smell script. (#18406) 2016-11-07 15:02:13 -08:00
inappropriately-private.sh Cleanup and fixes for code smell scripts. 2016-11-03 23:56:30 -07:00
integration-aliases.py Test placement (#21801) 2017-02-22 12:43:45 -08:00
line-endings.sh Windows: Use the correct newline sequence for the platform (#21846) 2017-03-23 19:47:10 -07:00
no-basestring.sh Remove automatic use of system six 2017-07-25 15:58:23 -07:00
no-dict-iteritems.sh Remove automatic use of system six 2017-07-25 15:58:23 -07:00
no-dict-iterkeys.sh Remove automatic use of system six 2017-07-25 15:58:23 -07:00
no-dict-itervalues.sh Remove automatic use of system six 2017-07-25 15:58:23 -07:00
no-list-cmp.sh Initial ansible-test sanity docs. (#26775) 2017-07-14 14:24:45 +01:00
pylint-ansible-test.sh Add support for cloud tests to ansible-test. (#24315) 2017-05-05 16:23:00 +08:00
replace-urlopen.sh Remove automatic use of system six 2017-07-25 15:58:23 -07:00
required-and-default-attributes.sh Test reorganization and cleanup. (#18270) 2016-10-31 12:53:11 -07:00
shebang.sh Add integration test that modules are loaded from the expected locations (#24170) 2017-05-01 08:52:25 -07:00
skip.txt Initial ansible-test implementation. (#18556) 2016-11-29 21:21:53 -08:00
test-constraints.sh Fix bugs in ansible-test units command. (#24044) 2017-04-27 11:21:11 +08:00
use-compat-six.sh Update module_utils.six to latest (#22855) 2017-03-23 13:35:05 -07:00