mirror of
https://github.com/ansible-collections/community.general.git
synced 2024-09-14 20:13:21 +02:00
9c58827410
* Better handling of malformed vault data envelope
If an embedded vaulted variable ('!vault' in yaml)
had an invalid format, it would eventually cause
an error for seemingly unrelated reasons.
"Invalid" meaning not valid hexlify (extra chars,
non-hex chars, etc).
For ex, if a host_vars file had invalid vault format
variables, on py2, it would cause an error like:
'ansible.vars.hostvars.HostVars object' has no
attribute u'broken.example.com'
Depending on where the invalid vault is, it could
also cause "VARIABLE IS NOT DEFINED!". The behavior
can also change if ansible-playbook is py2 or py3.
Root cause is errors from binascii.unhexlify() not
being handled consistently.
Fix is to add a AnsibleVaultFormatError exception and
raise it on any unhexlify() errors and to handle it
properly elsewhere.
Add a _unhexlify() that try/excepts around a binascii.unhexlify()
and raises an AnsibleVaultFormatError on invalid vault data.
This is so the same exception type is always raised for this
case. Previous it was different between py2 and py3.
binascii.unhexlify() raises a binascii.Error if the hexlified
blobs in a vault data blob are invalid.
On py2, binascii.Error is a subclass of Exception.
On py3, binascii.Error is a subclass of TypeError
When decrypting content of vault encrypted variables,
if a binascii.Error is raised it propagates up to
playbook.base.Base.post_validate(). post_validate()
handles exceptions for TypeErrors but not for
base Exception subclasses (like py2 binascii.Error).
* Add a display.warning on vault format errors
* Unit tests for _unhexlify, parse_vaulttext*
* Add intg test cases for invalid vault formats
Fixes #28038
|
||
|---|---|---|
| .. | ||
| invalid_format | ||
| roles | ||
| aliases | ||
| empty-password | ||
| encrypted_file_encrypted_var_password | ||
| example1_password | ||
| example2_password | ||
| example3_password | ||
| faux-editor.py | ||
| format_1_0_AES.yml | ||
| format_1_1_AES.yml | ||
| format_1_1_AES256.yml | ||
| format_1_2_AES256.yml | ||
| password-script.py | ||
| runme.sh | ||
| runme_change_pip_installed.sh | ||
| test-vault-client.py | ||
| test_vault.yml | ||
| test_vault_embedded.yml | ||
| test_vault_embedded_ids.yml | ||
| test_vault_file_encrypted_embedded.yml | ||
| test_vaulted_inventory.yml | ||
| test_vaulted_template.yml | ||
| vault-password | ||
| vault-password-ansible | ||
| vault-password-wrong | ||
| vault-secret.txt | ||
| vaulted.inventory | ||