1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/test/units/plugins
Jordan Borean 8bdd04c147 Fix remote_tmp when become with non admin user (#42396)
* Fix tmpdir on non root become

 - also avoid exception if tmpdir and remote_tmp are None
 - give 'None' on deescalation so tempfile will fallback to it's default behaviour
   and use system dirs
 - fix issue with bad tempdir (not existing/not createable/not writeable)
   i.e nobody and ~/.ansible/tmp
 - added tests for blockfile case

* Revert "Temporarily revert c119d54"

This reverts commit 5c614a59a6.

* changes based on PR feedback and changelog fragment

* changes based on the review

* Fix tmpdir when makedirs failed so we just use the system tmp

* Let missing remote_tmp fail

If remote_tmp is missing then there's something more basic wrong in the
communication from the controller to the module-side.  It's better to
be alerted in this case than to silently ignore it.

jborean and I have independently checked what happens if the user sets
ansible_remote_tmp to empty string and !!null and both cases work fine.
(null is turned into a default value controller-side.  empty string
triggers the warning because it is probably not a directory that the
become user is able to use).
2018-07-06 10:49:19 -07:00
..
action Fix remote_tmp when become with non admin user (#42396) 2018-07-06 10:49:19 -07:00
cache Disable abstract-class-instantiated for smoketests 2017-07-25 15:58:23 -07:00
callback fix minor issues with debug and item labels (#41331) 2018-06-21 16:14:57 -04:00
cliconf Refactor ios cliconf plugin and ios_config module (#39695) 2018-06-06 11:12:45 +05:30
connection Base connection class for network-style connections (#41839) 2018-07-02 08:41:00 -04:00
filter Add cidr_merge filter (#36081) 2018-05-23 14:35:23 -05:00
inventory Fix inventory plugin cache + add tests (#38229) 2018-05-24 15:34:54 -04:00
loader_fixtures Don't cache duplicate plugin names (#34420) 2018-01-04 16:47:23 -06:00
lookup 1Password lookup plugin (#37207) 2018-05-17 17:29:47 -04:00
shell Add empty-init code-smell script. (#18406) 2016-11-07 15:02:13 -08:00
strategy Fix inserting noop tasks by using active state (#36056) 2018-06-06 12:34:25 +02:00
terminal Adding slx_command module and supporting module_utils. (#38235) 2018-04-11 12:59:34 +01:00
vars Add empty-init code-smell script. (#18406) 2016-11-07 15:02:13 -08:00
__init__.py Add empty-init code-smell script. (#18406) 2016-11-07 15:02:13 -08:00
test_plugins.py Don't cache duplicate plugin names (#34420) 2018-01-04 16:47:23 -06:00