1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/changelogs/fragments
sam-lunt 8e7aff00b5
Avoid incorrectly marking zfs tasks as changed (#2454)
* Avoid incorrectly marking zfs tasks as changed

The zfs module will incorrectly mark certain tasks as having been
changed. For example, if a dataset has a quota of "1G" and the user
changes it to "1024M", the actual quota vale has not changed, but since
the module is doing a simple string comparison between "1G" and "1024M",
it marks the step as "changed".

Instead of trying to handle all the corner cases of zfs (another example
is when the zpool "altroot" property has been set), this change simply
compares the output of "zfs-get" from before and after "zfs-set" is
called

* update changelog format

* Update changelogs/fragments/2454-detect_zfs_changed.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* add note about check_mode

* Update plugins/modules/storage/zfs/zfs.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/storage/zfs/zfs.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* clarify check mode qualifications

* rephrase to avoid hypothetical

Co-authored-by: Felix Fontein <felix@fontein.de>
2021-05-10 17:55:19 +02:00
..
.keep Rename changelogs/fragments/.empty -> changelogs/fragments/.keep 2020-08-07 08:17:57 +02:00
2284-influxdb_retention_policy-fix_duration_parsing.yml influxdb_retention_policy: fix duration parsing to support INF values (#2396) 2021-05-01 14:19:05 +02:00
2337-mark-inventory-scripts-executable.yml Make inventory scripts executable (#2337) 2021-04-26 21:24:26 +02:00
2348-composer-no-interaction-option-discovery-to-avoid-hang.yaml composer: --no-interaction when discovering available options (#2348) 2021-05-01 18:23:14 +02:00
2355-spotinst_aws_elastigroup-list-elements.yml spotinst_aws_elastigroup - fixed elements for many lists (#2355) 2021-04-27 13:18:29 +02:00
2369-lvol_size_bug_fixes.yml lvol - bug fix - Convert units to lowercase when using LVS or VGS command (#2369) 2021-05-03 21:25:52 +02:00
2373-svr4pkg-fix-typeerror.yml Fix #2373 - TypeError: a bytes-like object is required, not 'str' (#2375) 2021-05-03 07:25:08 +02:00
2407-puppet-change_stdout_to_console.yaml puppet - replace stdout with console in logdest option (#2407) 2021-05-03 07:26:47 +02:00
2409-nmcli_add_slave-type_bridge_to_nmcli_command_if_type_is_bridge-slave.yml nmcli: Add 'slave-type bridge' to nmcli command if type is bridge-slave (#2409) 2021-05-03 07:27:56 +02:00
2416-nmcli_compare_mac_addresses_case_insensitively.yml nmcli: Compare MAC addresses case insensitively (#2416) 2021-05-03 07:28:53 +02:00
2430-linodev4-error-message.yml linode_v4 - fixed error message (#2430) 2021-05-03 13:27:16 +02:00
2435-one_vm-fix_missing_keys.yml OpenNebula one_vm.py: Fix missing keys (#2435) 2021-05-04 12:21:55 +02:00
2448-stackpath_compute-fix.yml fix stackpath_compute validate_config (#2448) 2021-05-09 22:25:00 +02:00
2454-detect_zfs_changed.yml Avoid incorrectly marking zfs tasks as changed (#2454) 2021-05-10 17:55:19 +02:00
ipaddress.yml Remove vendored ipaddress module. (#2441) 2021-05-05 12:31:01 +02:00