1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/changelogs/fragments
sam-lunt 8e7aff00b5
Avoid incorrectly marking zfs tasks as changed ()
* Avoid incorrectly marking zfs tasks as changed

The zfs module will incorrectly mark certain tasks as having been
changed. For example, if a dataset has a quota of "1G" and the user
changes it to "1024M", the actual quota vale has not changed, but since
the module is doing a simple string comparison between "1G" and "1024M",
it marks the step as "changed".

Instead of trying to handle all the corner cases of zfs (another example
is when the zpool "altroot" property has been set), this change simply
compares the output of "zfs-get" from before and after "zfs-set" is
called

* update changelog format

* Update changelogs/fragments/2454-detect_zfs_changed.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* add note about check_mode

* Update plugins/modules/storage/zfs/zfs.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/storage/zfs/zfs.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* clarify check mode qualifications

* rephrase to avoid hypothetical

Co-authored-by: Felix Fontein <felix@fontein.de>
2021-05-10 17:55:19 +02:00
..
.keep
2284-influxdb_retention_policy-fix_duration_parsing.yml
2337-mark-inventory-scripts-executable.yml
2348-composer-no-interaction-option-discovery-to-avoid-hang.yaml
2355-spotinst_aws_elastigroup-list-elements.yml
2369-lvol_size_bug_fixes.yml
2373-svr4pkg-fix-typeerror.yml
2407-puppet-change_stdout_to_console.yaml
2409-nmcli_add_slave-type_bridge_to_nmcli_command_if_type_is_bridge-slave.yml
2416-nmcli_compare_mac_addresses_case_insensitively.yml
2430-linodev4-error-message.yml
2435-one_vm-fix_missing_keys.yml
2448-stackpath_compute-fix.yml fix stackpath_compute validate_config () 2021-05-09 22:25:00 +02:00
2454-detect_zfs_changed.yml Avoid incorrectly marking zfs tasks as changed () 2021-05-10 17:55:19 +02:00
ipaddress.yml Remove vendored ipaddress module. () 2021-05-05 12:31:01 +02:00