1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/lib/ansible
Jesse Keating 8cef210aea Make sure ssh pipes are empty before moving on
Resolves issue #5082

Code as it was would hit a scenario where one of the FDs was not ready for
reading the first time through -- but p.poll() would show the process as
complete. This would cause ansible to continue on, while leaving some content
left in a pipe.

The other scenario -- the one that causes the unclosed quote, is if we go
through select.select() and we do get stdout in the ready for reading -- we
read from it (9000 bytes), but that's not all that is there. Again we'd get to
the p.poll() check and it would be indeed not none, but we would have left some
of stdout on the FD and thus the json blob would be malformed.

Tested with and without full ssh debugging.
Tested with and without ControlPersist
Tested with and without ControlPersist sockets already created
2013-12-11 21:32:37 -08:00
..
callback_plugins add a way for callback to disable itself 2013-08-14 22:32:28 +02:00
inventory Improve Group.get_hosts() performance. 2013-11-18 03:48:55 +01:00
module_utils Addresses #5090 setup module was using path.is_file instead of path.isfile 2013-12-05 11:36:54 -05:00
playbook Merge pull request #4207 from ashorin/ansible 2013-11-12 14:37:07 -05:00
runner Make sure ssh pipes are empty before moving on 2013-12-11 21:32:37 -08:00
utils Fix traceback in template error detection code 2013-11-29 08:47:54 -06:00
__init__.py Version bump for 1.5 2013-11-21 16:33:23 -05:00
callbacks.py Fixes #4852 properly evaluate log_path writability 2013-11-18 10:40:49 -05:00
color.py These fields are booleans. 2013-08-10 18:16:01 -04:00
constants.py Merge pull request #4758 from alanfairless/group-host-var-dirs 2013-11-14 11:57:11 -08:00
errors.py Introduce exception AnsibleFilterError and use it in Jinja filters. Ignore this exception when trying to find the name of a task for display (callback) purpose. 2013-07-07 19:18:32 +02:00
module_common.py Ensure we are looking for the right import to determine if the module_style is new. Fixes #5148 2013-12-03 15:36:33 -06:00