mirror of
https://github.com/ansible-collections/community.general.git
synced 2024-09-14 20:13:21 +02:00
8bdd04c147
* Fix tmpdir on non root become
- also avoid exception if tmpdir and remote_tmp are None
- give 'None' on deescalation so tempfile will fallback to it's default behaviour
and use system dirs
- fix issue with bad tempdir (not existing/not createable/not writeable)
i.e nobody and ~/.ansible/tmp
- added tests for blockfile case
* Revert "Temporarily revert c119d54"
This reverts commit 5c614a59a6.
* changes based on PR feedback and changelog fragment
* changes based on the review
* Fix tmpdir when makedirs failed so we just use the system tmp
* Let missing remote_tmp fail
If remote_tmp is missing then there's something more basic wrong in the
communication from the controller to the module-side. It's better to
be alerted in this case than to silently ignore it.
jborean and I have independently checked what happens if the user sets
ansible_remote_tmp to empty string and !!null and both cases work fine.
(null is turned into a default value controller-side. empty string
triggers the warning because it is probably not a directory that the
become user is able to use).
108 lines
3.7 KiB
Python
108 lines
3.7 KiB
Python
# (c) 2016, Saran Ahluwalia <ahlusar.ahluwalia@gmail.com>
|
|
#
|
|
# This file is part of Ansible
|
|
#
|
|
# Ansible is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# Ansible is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with Ansible. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
from __future__ import (absolute_import, division, print_function)
|
|
__metaclass__ = type
|
|
|
|
import os
|
|
|
|
from ansible.errors import AnsibleActionFail
|
|
from ansible.compat.tests import unittest
|
|
from ansible.compat.tests.mock import patch, MagicMock, Mock
|
|
from ansible.plugins.action.raw import ActionModule
|
|
from ansible.playbook.task import Task
|
|
from ansible.plugins.loader import connection_loader
|
|
|
|
|
|
play_context = Mock()
|
|
play_context.shell = 'sh'
|
|
connection = connection_loader.get('local', play_context, os.devnull)
|
|
|
|
|
|
class TestCopyResultExclude(unittest.TestCase):
|
|
|
|
def setUp(self):
|
|
pass
|
|
|
|
def tearDown(self):
|
|
pass
|
|
|
|
# The current behavior of the raw aciton in regards to executable is currently in question;
|
|
# the test_raw_executable_is_not_empty_string verifies the current behavior (whether it is desireed or not.
|
|
# Please refer to the following for context:
|
|
# Issue: https://github.com/ansible/ansible/issues/16054
|
|
# PR: https://github.com/ansible/ansible/pull/16085
|
|
|
|
def test_raw_executable_is_not_empty_string(self):
|
|
|
|
task = MagicMock(Task)
|
|
task.async_val = False
|
|
|
|
task.args = {'_raw_params': 'Args1'}
|
|
play_context.check_mode = False
|
|
|
|
self.mock_am = ActionModule(task, connection, play_context, loader=None, templar=None, shared_loader_obj=None)
|
|
self.mock_am._low_level_execute_command = Mock(return_value={})
|
|
self.mock_am.display = Mock()
|
|
self.mock_am._admin_users = ['root', 'toor']
|
|
|
|
self.mock_am.run()
|
|
self.mock_am._low_level_execute_command.assert_called_with('Args1', executable=False)
|
|
|
|
def test_raw_check_mode_is_True(self):
|
|
|
|
task = MagicMock(Task)
|
|
task.async_val = False
|
|
|
|
task.args = {'_raw_params': 'Args1'}
|
|
play_context.check_mode = True
|
|
|
|
try:
|
|
self.mock_am = ActionModule(task, connection, play_context, loader=None, templar=None, shared_loader_obj=None)
|
|
except AnsibleActionFail:
|
|
pass
|
|
|
|
def test_raw_test_environment_is_None(self):
|
|
|
|
task = MagicMock(Task)
|
|
task.async_val = False
|
|
|
|
task.args = {'_raw_params': 'Args1'}
|
|
task.environment = None
|
|
play_context.check_mode = False
|
|
|
|
self.mock_am = ActionModule(task, connection, play_context, loader=None, templar=None, shared_loader_obj=None)
|
|
self.mock_am._low_level_execute_command = Mock(return_value={})
|
|
self.mock_am.display = Mock()
|
|
|
|
self.assertEqual(task.environment, None)
|
|
|
|
def test_raw_task_vars_is_not_None(self):
|
|
|
|
task = MagicMock(Task)
|
|
task.async_val = False
|
|
|
|
task.args = {'_raw_params': 'Args1'}
|
|
task.environment = None
|
|
play_context.check_mode = False
|
|
|
|
self.mock_am = ActionModule(task, connection, play_context, loader=None, templar=None, shared_loader_obj=None)
|
|
self.mock_am._low_level_execute_command = Mock(return_value={})
|
|
self.mock_am.display = Mock()
|
|
|
|
self.mock_am.run(task_vars={'a': 'b'})
|
|
self.assertEqual(task.environment, None)
|