mirror of
https://github.com/ansible-collections/community.general.git
synced 2024-09-14 20:13:21 +02:00
3221b25393
* fix passwordstore.py to be compatible with gopass.
...even when used with create=true.
The same output snippet matches for both, `pass` and `gopass`, but while `pass` returns `1` on a non-existant password, `gopass` returns `10`, or `11`, depending on whether a similar named password was stored.
So I'd propose to change `e.returncode == 1` to `e.returncode != 0` to cover both cases here.
What do you think?
* Update passwordstore.py, fix typo
* Add changelog fragment.
* Update changelogs/fragments/1589-passwordstore-fix-passwordstore.py-to-be-compatible-with-gopass.yaml
Co-authored-by: Felix Fontein <felix@fontein.de>
* Update changelogs/fragments/1589-passwordstore-fix-passwordstore.py-to-be-compatible-with-gopass.yaml
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 73b3ec09e5)
Co-authored-by: Paul Haerle <hello@phaer.org>
5 lines
392 B
YAML
5 lines
392 B
YAML
bugfixes:
|
|
- passwordstore lookup plugin - fix compatibility with gopass when used with
|
|
``create=true``. While pass returns 1 on a non-existent password, gopass
|
|
returns 10, or 11, depending on whether a similar named password was stored.
|
|
We now just check standard output and that the return code is not zero (https://github.com/ansible-collections/community.general/pull/1589).
|