1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/test
Jordan Borean 8bdd04c147 Fix remote_tmp when become with non admin user (#42396)
* Fix tmpdir on non root become

 - also avoid exception if tmpdir and remote_tmp are None
 - give 'None' on deescalation so tempfile will fallback to it's default behaviour
   and use system dirs
 - fix issue with bad tempdir (not existing/not createable/not writeable)
   i.e nobody and ~/.ansible/tmp
 - added tests for blockfile case

* Revert "Temporarily revert c119d54"

This reverts commit 5c614a59a6.

* changes based on PR feedback and changelog fragment

* changes based on the review

* Fix tmpdir when makedirs failed so we just use the system tmp

* Let missing remote_tmp fail

If remote_tmp is missing then there's something more basic wrong in the
communication from the controller to the module-side.  It's better to
be alerted in this case than to silently ignore it.

jborean and I have independently checked what happens if the user sets
ansible_remote_tmp to empty string and !!null and both cases work fine.
(null is turned into a default value controller-side.  empty string
triggers the warning because it is probably not a directory that the
become user is able to use).
2018-07-06 10:49:19 -07:00
..
cache Update ansible-test sanity command. (#31958) 2017-10-26 00:21:46 -07:00
integration Fix remote_tmp when become with non admin user (#42396) 2018-07-06 10:49:19 -07:00
legacy Fix some broken links (#42079) 2018-06-29 11:12:01 -07:00
results Collect data from integration test runs. (#28650) 2017-08-25 18:14:47 -04:00
runner Temporarily switch RHEL and Windows tests to AWS. 2018-06-29 16:23:54 -07:00
sanity Allow documentation of module options type (#42285) 2018-07-05 09:57:58 -04:00
units Fix remote_tmp when become with non admin user (#42396) 2018-07-06 10:49:19 -07:00
utils Make docs-build sanity test disabled by default. 2018-05-09 17:55:00 -07:00