mirror of
https://github.com/ansible-collections/community.general.git
synced 2024-09-14 20:13:21 +02:00
828968b0dd
fix(modules/gitlab_runner): Use correct argument to list all runners (#7790)
* fix(modules/gitlab_runner): Use correct argument to list all runners
python-gitlab 4.0.0 removed support for the `as_list=False` parameter.
This functionality is now available as `iterator=True`.
Without this change, the module actually only retrieves the first
20 results, which can lead to non-idempotent behavior, such as
registering a runner again.
* Add changelog entry (#7790)
* gitlab_runner: Check python-gitlab version when listing runners
* gitlab: Add list_all_kwargs variable to module_utils
* refactor(gitlab modules): use list_all_kwargs where it helps (#7790)
I did not change every instance of all=True or all=False, only those
which could obviously benefit from simplifying:
* Code using `all=True` but then searching for any items that match a
condition (no need to collect the full list).
* Code that basically reimplements `all=True` with manual pagination.
(These could be changed to `all=True`, but `list_all_kwargs` also
sets per_page to 100, to gather data faster.)
* gitlab_instance_variable: Use list_all_kwargs
* Add new changelog entry for gitlab module changes (#7790)
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| .keep | ||
| 8.4.0.yml | ||
| 7717-prevent-modprobe-error.yml | ||
| 7790-gitlab-runner-api-pagination.yml | ||
| 7843-proxmox_kvm-update_unsafe.yml | ||
| 7847-gitlab-issue-title.yml | ||
| 7881-fix-keycloak-client-ckeckmode.yml | ||
| 7916-add-redfish-set-service-identification.yml | ||
| 7919-onepassword-fieldname-casing.yaml | ||
| 7951-fix-redfish_info-exception.yml | ||
| 7956-adding-releases_events-option-to-gitlab_hook-module.yaml | ||
| 7963-fix-terraform-diff-absent.yml | ||
| 7970-fix-cargo-path-idempotency.yaml | ||
| 7976-add-mssql_script-transactional-support.yml | ||
| 7983-sudoers-add-support-noexec.yml | ||
| 7994-bitwarden-session-arg.yaml | ||
| 7996-Add templating support to Icinga2 Inventory.yml | ||
| 8003-redfish-get-update-status-empty-response.yml | ||
| pkgin.yml | ||