1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/plugins/module_utils
Mike Wadsten 787fa46217
fix(modules/gitlab_runner): Use correct argument to list all runners (#7790)
* fix(modules/gitlab_runner): Use correct argument to list all runners

python-gitlab 4.0.0 removed support for the `as_list=False` parameter.
This functionality is now available as `iterator=True`.

Without this change, the module actually only retrieves the first
20 results, which can lead to non-idempotent behavior, such as
registering a runner again.

* Add changelog entry (#7790)

* gitlab_runner: Check python-gitlab version when listing runners

* gitlab: Add list_all_kwargs variable to module_utils

* refactor(gitlab modules): use list_all_kwargs where it helps (#7790)

I did not change every instance of all=True or all=False, only those
which could obviously benefit from simplifying:

  * Code using `all=True` but then searching for any items that match a
    condition (no need to collect the full list).
  * Code that basically reimplements `all=True` with manual pagination.
    (These could be changed to `all=True`, but `list_all_kwargs` also
    sets per_page to 100, to gather data faster.)

* gitlab_instance_variable: Use list_all_kwargs

* Add new changelog entry for gitlab module changes (#7790)
2024-02-25 19:45:30 +01:00
..
identity/keycloak Add keycloak_realm_rolemapping module to map realm roles to groups (#7663) 2023-12-28 18:11:32 +01:00
mh
net_tools/pritunl Fix more typos (#7439) 2023-10-29 18:04:44 +01:00
oracle Use isinstance() instead of type() (#7501) 2023-11-08 13:20:19 +01:00
remote_management/lxca
source_control
storage
_filelock.py
_mount.py
_stormssh.py
alicloud_ecs.py
btrfs.py
cloud.py
cmd_runner.py
consul.py Add new consul modules and reuse code between them. (#7878) 2024-01-27 10:22:44 +01:00
csv.py
database.py
deps.py
dimensiondata.py Fix more typos (#7439) 2023-10-29 18:04:44 +01:00
gandi_livedns_api.py
gconftool2.py
gio_mime.py
gitlab.py fix(modules/gitlab_runner): Use correct argument to list all runners (#7790) 2024-02-25 19:45:30 +01:00
heroku.py
hwc_utils.py Fix more typos (#7439) 2023-10-29 18:04:44 +01:00
ibm_sa_utils.py
ilo_redfish_utils.py
influxdb.py
ipa.py
jenkins.py
known_hosts.py
ldap.py Simplify regex for identifying order number in DN (#7646) (#7697) 2024-01-29 19:08:34 +01:00
linode.py
locale_gen.py
lxd.py plugins/inventory/lxd: add server_cert option (#7392) 2023-10-25 08:47:48 +02:00
manageiq.py
memset.py Fix more typos (#7439) 2023-10-29 18:04:44 +01:00
module_helper.py
ocapi_utils.py Use isinstance() instead of type() (#7501) 2023-11-08 13:20:19 +01:00
oneandone.py
onepassword.py
oneview.py
online.py
opennebula.py
pipx.py pipx: change parameter formatter for pip_args (#7506) 2023-11-11 11:59:44 +01:00
proxmox.py Proxmox add storage content listing (#7725) 2023-12-31 15:21:20 +01:00
puppet.py
pure.py
rax.py
redfish_utils.py Fix errors in hpe specific get methods (#7952) 2024-02-24 20:32:20 +01:00
redhat.py
redis.py
rundeck.py
saslprep.py
scaleway.py Fix more typos (#7439) 2023-10-29 18:04:44 +01:00
snap.py
ssh.py
univention_umc.py
utm_utils.py
vardict.py Fix more typos (#7439) 2023-10-29 18:04:44 +01:00
version.py
vexata.py
wdc_redfish_utils.py Fix more typos (#7439) 2023-10-29 18:04:44 +01:00
xenserver.py
xfconf.py