1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/changelogs
Mike Wadsten 787fa46217
fix(modules/gitlab_runner): Use correct argument to list all runners (#7790)
* fix(modules/gitlab_runner): Use correct argument to list all runners

python-gitlab 4.0.0 removed support for the `as_list=False` parameter.
This functionality is now available as `iterator=True`.

Without this change, the module actually only retrieves the first
20 results, which can lead to non-idempotent behavior, such as
registering a runner again.

* Add changelog entry (#7790)

* gitlab_runner: Check python-gitlab version when listing runners

* gitlab: Add list_all_kwargs variable to module_utils

* refactor(gitlab modules): use list_all_kwargs where it helps (#7790)

I did not change every instance of all=True or all=False, only those
which could obviously benefit from simplifying:

  * Code using `all=True` but then searching for any items that match a
    condition (no need to collect the full list).
  * Code that basically reimplements `all=True` with manual pagination.
    (These could be changed to `all=True`, but `list_all_kwargs` also
    sets per_page to 100, to gather data faster.)

* gitlab_instance_variable: Use list_all_kwargs

* Add new changelog entry for gitlab module changes (#7790)
2024-02-25 19:45:30 +01:00
..
fragments fix(modules/gitlab_runner): Use correct argument to list all runners (#7790) 2024-02-25 19:45:30 +01:00
.gitignore Add more default license and copyright notices (#5087) 2022-08-08 08:44:19 +02:00
changelog.yaml The main branch is prepared for 9.0.0, and continues to accept features for 8.1.0. 2023-11-01 08:07:41 +01:00
changelog.yaml.license Make reuse conformant (#5138) 2022-08-21 08:27:01 +02:00
config.yaml Add MarkDown changelog and use it by default (#7941) 2024-02-09 13:08:50 +01:00