1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/plugins/modules/system
patchback[bot] 7713202d9b
Adding module_utils/module_helper.py + big revamp in xfconf.py to use it (#1322) (#1336)
* Big revamp in xfconf.py

- added plugin/module_utils/module_helper.py
  - scaffold class for writing modules, beyond standard AnsibleModule
  - automatic capture of exceptions
  - easier dependency testing
  - StateMixin to easily handle different behaviours for 'state' param
  - CmdMixin to easily run external commands
- adapted test_xfconf.py
  - the args for run_command are now lists instead of a string
  - value and previous_value were not being tested before (because xfconf wasn't filling results - see below)
  - added more tests: setting value to previous_value, getting non-existent property
- rewritten xfconf module, keeping the same results
  - original module posted results as ansible_facts, this version still does it for compatibility, but also adds to the module result

* Added suggestions from the PR

* Added russoz as maintainer for the module_utils/module_helper.py file

* Formatting using printf-style requires special treatment

Strings not containing substitution tokens must work as well.

* Tidied up variables in module definition

* Tests with ArgFormat and DependencyCtxMgr

* pytest parameters must be in the same order, it seems

* improved testing for the DependencyCtxMgr

* fixed test for older pythons

* Moved changed property to improve readability

* Added testcase for state: absent and adjusted xfconf after it

* Fixed param name environ_update in run_command()

* added changelog fragment

* fixed tests after run_command param change

(cherry picked from commit e3fcc7de2a)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
2020-11-20 12:43:23 +01:00
..
aix_devices.py
aix_filesystem.py Enabling validation-modules for system modules (#1212) (#1225) 2020-11-04 09:21:51 +01:00
aix_inittab.py Enabling validation-modules for system modules (#1212) (#1225) 2020-11-04 09:21:51 +01:00
aix_lvg.py Enabling validation-modules for system modules (#1212) (#1225) 2020-11-04 09:21:51 +01:00
aix_lvol.py Enabling validation-modules for system modules (#1212) (#1225) 2020-11-04 09:21:51 +01:00
alternatives.py
awall.py Enabling validation-modules for system modules (#1212) (#1225) 2020-11-04 09:21:51 +01:00
beadm.py
capabilities.py
cronvar.py
crypttab.py
dconf.py Enabling validation-modules for system modules (#1212) (#1225) 2020-11-04 09:21:51 +01:00
dpkg_divert.py
facter.py
filesystem.py
gconftool2.py Enabling validation-modules for system modules (#1212) (#1225) 2020-11-04 09:21:51 +01:00
interfaces_file.py Enabling validation-modules for system modules (#1212) (#1225) 2020-11-04 09:21:51 +01:00
iptables_state.py
java_cert.py
java_keystore.py Enabling validation-modules for system modules (#1212) (#1225) 2020-11-04 09:21:51 +01:00
kernel_blacklist.py Enabling validation-modules for system modules (#1212) (#1225) 2020-11-04 09:21:51 +01:00
launchd.py
lbu.py Enabling validation-modules for system modules (#1212) (#1225) 2020-11-04 09:21:51 +01:00
listen_ports_facts.py
locale_gen.py Enabling validation-modules for system modules (#1212) (#1225) 2020-11-04 09:21:51 +01:00
lvg.py Enabling validation-modules for system modules (#1212) (#1225) 2020-11-04 09:21:51 +01:00
lvol.py Fix idempotent issue when using lvol with %VG or %PVS size options and VG is fully allocated (#229) (#1250) 2020-11-09 07:49:37 +00:00
make.py
mksysb.py Enabling validation-modules for system modules (#1212) (#1225) 2020-11-04 09:21:51 +01:00
modprobe.py Enabling validation-modules for system modules (#1212) (#1225) 2020-11-04 09:21:51 +01:00
nosh.py Enabling validation-modules for system modules (#1212) (#1225) 2020-11-04 09:21:51 +01:00
ohai.py
open_iscsi.py Enabling validation-modules for system modules (#1212) (#1225) 2020-11-04 09:21:51 +01:00
openwrt_init.py Enabling validation-modules for system modules (#1212) (#1225) 2020-11-04 09:21:51 +01:00
osx_defaults.py
pam_limits.py Enabling validation-modules for system modules (#1212) (#1225) 2020-11-04 09:21:51 +01:00
pamd.py Enabling validation-modules for system modules (#1212) (#1225) 2020-11-04 09:21:51 +01:00
parted.py Enabling validation-modules for system modules (#1212) (#1225) 2020-11-04 09:21:51 +01:00
pids.py
puppet.py Enabling validation-modules for system modules (#1212) (#1225) 2020-11-04 09:21:51 +01:00
python_requirements_facts.py
python_requirements_info.py Enabling validation-modules for system modules (#1212) (#1225) 2020-11-04 09:21:51 +01:00
runit.py
sefcontext.py Enabling validation-modules for system modules (#1212) (#1225) 2020-11-04 09:21:51 +01:00
selinux_permissive.py
selogin.py Enabling validation-modules for system modules (#1212) (#1225) 2020-11-04 09:21:51 +01:00
seport.py Enabling validation-modules for system modules (#1212) (#1225) 2020-11-04 09:21:51 +01:00
shutdown.py
solaris_zone.py Enabling validation-modules for system modules (#1212) (#1225) 2020-11-04 09:21:51 +01:00
svc.py
syspatch.py Enabling validation-modules for system modules (#1212) (#1225) 2020-11-04 09:21:51 +01:00
sysupgrade.py
timezone.py
ufw.py
vdo.py Enabling validation-modules for system modules (#1212) (#1225) 2020-11-04 09:21:51 +01:00
xfconf.py Adding module_utils/module_helper.py + big revamp in xfconf.py to use it (#1322) (#1336) 2020-11-20 12:43:23 +01:00
xfs_quota.py