mirror of
https://github.com/ansible-collections/community.general.git
synced 2024-09-14 20:13:21 +02:00
768512645d
* with_filetree: use splitext for compatibility with template
The example code given deploys files with their .j2 extensions intact, which is probably not what you want.
* Explain how templates interact with splitext|first
* Update plugins/lookup/filetree.py
Co-authored-by: Felix Fontein <felix@fontein.de>
* Don't encourage setting the mode of symlinks
On ext4, maybe most filesystems, symlinks always have the artificial mode of 0777, and `chmod $mode $symlink` *writes through* the symlink to its target file.
An effect of this is that if you deploy a file and a symlink to it (e.g. this common situation: /etc/nginx/sites-available/default and /etc/nginx/sites-enabled/default -> ../sites-available/default) then `with_filetree` will forever first deploy the file with the right mode, then corrupt its mode to 0777, and every redeploy will see a change to fix, forever in a loop.
Probably `file:` should refuse `mode:` on `state: link`s, but in the meantime, avoid recommending it in `filetree`
* Use `follow: false` instead of just the mode.
This should be more cross-compatible.
https://github.com/ansible-collections/community.general/pull/2285#discussion_r616571873
* Update plugins/lookup/filetree.py
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit
|
||
---|---|---|
.. | ||
__init__.py | ||
cartesian.py | ||
chef_databag.py | ||
consul_kv.py | ||
credstash.py | ||
cyberarkpassword.py | ||
dig.py | ||
dnstxt.py | ||
dsv.py | ||
etcd.py | ||
etcd3.py | ||
filetree.py | ||
flattened.py | ||
hiera.py | ||
keyring.py | ||
lastpass.py | ||
lmdb_kv.py | ||
manifold.py | ||
nios.py | ||
nios_next_ip.py | ||
nios_next_network.py | ||
onepassword.py | ||
onepassword_raw.py | ||
passwordstore.py | ||
redis.py | ||
shelvefile.py | ||
tss.py |