1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/plugins/modules/storage
patchback[bot] afc620fc74
Avoid incorrectly marking zfs tasks as changed (#2454) (#2483)
* Avoid incorrectly marking zfs tasks as changed

The zfs module will incorrectly mark certain tasks as having been
changed. For example, if a dataset has a quota of "1G" and the user
changes it to "1024M", the actual quota vale has not changed, but since
the module is doing a simple string comparison between "1G" and "1024M",
it marks the step as "changed".

Instead of trying to handle all the corner cases of zfs (another example
is when the zpool "altroot" property has been set), this change simply
compares the output of "zfs-get" from before and after "zfs-set" is
called

* update changelog format

* Update changelogs/fragments/2454-detect_zfs_changed.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

* add note about check_mode

* Update plugins/modules/storage/zfs/zfs.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Update plugins/modules/storage/zfs/zfs.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* clarify check mode qualifications

* rephrase to avoid hypothetical

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 8e7aff00b5)

Co-authored-by: sam-lunt <samuel.j.lunt@gmail.com>
2021-05-10 18:16:49 +02:00
..
emc Tidy up validations + bug fixes + deprecations (#1830) (#1841) 2021-02-16 09:10:13 +00:00
glusterfs Deprecate gluster_* modules (#1439) 2020-12-07 10:07:56 +00:00
hpe3par modules: fix examples to use FQCN (#644) 2020-07-13 21:50:31 +02:00
ibm Tidy up validations + bug fixes + deprecations (#1830) (#1841) 2021-02-16 09:10:13 +00:00
netapp Tidy up validate-modules:parameter-list-no-elements (batch 1) (#1795) (#1834) 2021-02-16 07:38:50 +01:00
purestorage modules: fix examples to use FQCN (#644) 2020-07-13 21:50:31 +02:00
vexata modules: fix examples to use FQCN (#644) 2020-07-13 21:50:31 +02:00
zfs Avoid incorrectly marking zfs tasks as changed (#2454) (#2483) 2021-05-10 18:16:49 +02:00