1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
community.general/test
Adam Miller 75127092f2 refactor firewalld module with object abstraction (#26487)
* refactor firewalld module with object abstraction

This change creates a FirewallTransaction object that each
individual transaction type is a sub-class of as they all follow the
same pattern to enable or disable something in the firewall.

Also, there's a few bugfixes here:
    - Fix the "source" type to handle permanent operations
    - Remove ambiguity of required parameters for only specific use
      cases that can lead to transactions effectively being a no-op.
      Instead, pick sane defaults and document them.
    - Change how imports are done so globals are no longer needed

This is based on the original feedback by Toshio from the last
refactor attempt:

    https://github.com/ansible/ansible-modules-extras/pull/3383

Signed-off-by: Adam Miller <maxamillion@fedoraproject.org>

* fix line too long for pep8 for shippable tests

Signed-off-by: Adam Miller <maxamillion@fedoraproject.org>

* remove firewalld from pep8/legacy-files

Signed-off-by: Adam Miller <maxamillion@fedoraproject.org>
2017-09-11 14:10:07 -07:00
..
compile Docs how to test (2nd) (#24094) 2017-04-28 09:08:26 +01:00
integration dnf: add environment upgrade test 2017-09-11 11:45:10 -07:00
results Collect data from integration test runs. (#28650) 2017-08-25 18:14:47 -04:00
runner Fix wheel dependency on python 2.6. (#29388) 2017-09-10 23:52:13 -07:00
sanity refactor firewalld module with object abstraction (#26487) 2017-09-11 14:10:07 -07:00
units Fixes #23680 bug with py3.x due to binary string handling (#23688) 2017-09-09 18:40:07 -07:00
utils Divide Windows integration tests into 2 groups. (#29029) 2017-09-05 15:32:26 -07:00