ansible/community.general
1
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2024-09-14 20:13:21 +02:00
Code Releases Activity
community.general/plugins/modules/cloud/misc
History
Tristan Le Guern 73f8338980
proxmox_kvm: fix idempotency issue with state=absent (#811) 
When the `vmid` parameter is not supplied and the module can only rely on
name look-up an early failure can happen if the targeted VM doesn't exist.
In this case a task execution with the parameter `state` set to `absent`
will actually fail instead of being considered ok.

This patch introduces a deferred error-checking for non-existent VMs
by assigning the value -1 to the `vmid` parameter, allowing the actual
verification to be performed in the right code paths.
Is also help to differentiate between a non-existent `vmid` or non-existent
VM `name`.

Previously:

    TASK [ansible-role-proxmox-instance : Remove instance-test]
    changed: [localhost]
    ...
    TASK [ansible-role-proxmox-instance : Remove instance-test]
    fatal: [localhost]: FAILED! => changed=false
      msg: VM instance-test does not exist in cluster.

Now:

    TASK [ansible-role-proxmox-instance : Remove instance-test]
    ok: [localhost]
    ...
    TASK [ansible-role-proxmox-instance : Remove instance-test]
    ok: [localhost]

Update changelogs/fragments/811-proxmox-kvm-state-absent.yml

With suggestions from Felix Fontein <felix@fontein.de>.
2020-09-05 00:51:54 +02:00
..
cloud_init_data_facts.py Reduce ignored sanity tests in cloud/misc modules (#845) 2020-09-01 13:44:04 +02:00
helm.py Reduce ignored sanity tests in cloud/misc modules (#845) 2020-09-01 13:44:04 +02:00
ovirt.py Reduce ignored sanity tests in cloud/misc modules (#845) 2020-09-01 13:44:04 +02:00
proxmox.py Reduce ignored sanity tests in cloud/misc modules (#845) 2020-09-01 13:44:04 +02:00
proxmox_kvm.py proxmox_kvm: fix idempotency issue with state=absent (#811) 2020-09-05 00:51:54 +02:00
proxmox_template.py Reduce ignored sanity tests in cloud/misc modules (#845) 2020-09-01 13:44:04 +02:00
rhevm.py Reduce ignored sanity tests in cloud/misc modules (#845) 2020-09-01 13:44:04 +02:00
serverless.py Reduce ignored sanity tests in cloud/misc modules (#845) 2020-09-01 13:44:04 +02:00
terraform.py Reduce ignored sanity tests in cloud/misc modules (#845) 2020-09-01 13:44:04 +02:00
xenserver_facts.py